1 2005-01-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Bug fix for the python part use
4 2005-01-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
7 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
8 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
9 a string and should ask the global TS dict what are the propreties of
12 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
13 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
14 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
15 to swap the Swap Code, at parsing time, when we come out of group 0002
16 and Transfer Syntax is Big Endian
17 We should be able to read now 'true DICOM" Big Endian coded images
18 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
19 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
21 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
22 * Hopefully fix the bug on MacOSX and static global initialization.
23 This is the only -minor- patch I found that both please MacOSX and VS6.
24 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
25 but this would require a lot of change. Another approach would be that Global
26 create those string and GDCM_UNFOUND becomes a pointer to a string (which
27 gdcm::Global would destroy at exit).
29 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
30 * Fix bug on MacOSX with static initialization in a multy threaded
31 environment. static const string in a header file used to be ill
32 initialized provoquing the freeze of any tests. patch should solve this
35 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
36 * According to Benoit's suggestion, and without any objection from anybody
37 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
38 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
39 - method gdcmDicomDirObject::GetEntry() renamed as
40 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
42 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
43 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
44 you debug/warning message just as c++ streams which make them very convinient
45 to use. Once this is stabilize I will change the ostringstrem to be
46 redirected to a file (ofstream).
47 * Properly support C99 extension: __FUNCTION__ which allow us to display
48 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
50 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
51 * Removal of useless and dangerous methods :
52 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
53 GetDocEntryByName, GetEntryByName, GetDictEntryByName
54 * Removal of usless methods :
55 Dict::PrintByName, Dict::GetDictEntryByName
56 * Commenting out of probabely useless methods :
57 Dict::GetDictEntryNames()
58 Dict::GetDictEntryNamesByCategory()
59 DictSet::GetPubDictEntryNames()
60 DictSet::GetPubDictEntryNamesByCategory()
61 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
62 * ENH : Use dicomTS.dic as described in 2004 version
63 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
64 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
65 Add Accessors on VM (Value Multiplicity), and VM related methods
66 * ADD : Add a list of 'Dicom Attribute types', as found in
67 http://medical.nema.org/dicom/2004/04_15PU.PDF
69 * ADD : Add dicomGroupNameAbbreviations.dic
70 should be used to write a method to replace the former
71 Dict::GetDictEntryNamesByCategory()
73 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
75 to read in the file... and only it ! Length is the efective length of the
76 data in the DocEntry structure
78 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
79 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
80 And now use a static function call instead, with a global variable. i
81 This is much closer to the VTK approach. Hopefully should be bulletproof
82 and easier to use...hopefully
84 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
85 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
87 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
90 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
91 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
92 ValEntry, BinEntry, SeqEntry creation or replace
94 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
96 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
98 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
99 when specifying the VR
100 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
101 * src/gdcmDocEntry.cxx : amelioration of print
103 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
104 * ADD : Add the method Util::IsCurrentProcessorBigEndian
105 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
106 * ADD Method Document::ComputeGroupLength
107 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
108 in order to allow further VR modification by user
109 * REM : removal of once-called method File::WriteBase
110 integration of its code in formerly one-line method File::Write
112 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
114 replace the different values "??", "Unkn", "Unknown".
115 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
116 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
117 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
118 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
120 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
121 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
123 * Set the gdcm::Base class to some Printable classes
125 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * src/gdcmFile.[h|cxx] : add the Print method
127 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
128 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
129 * src/gdcmDocument.h : remove the PrintLevel informations
130 * Example/PrintFile.cxx : use the new gdcm::File::Print
132 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
133 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
134 problems when compiling with the python wrapping
136 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
138 writting in ImplicitVR
140 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
141 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
142 JPEG decompression, especially when dicom frames are split into several
143 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
144 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
146 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * src/gdcmHeader.cxx : change the initialisation of default header.
148 Now, this header is readable by gdm, e-film, DicomWorks
150 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
152 Rename Decompressed to Raw
153 * Use the API changes in gdcm::File.
154 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
157 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
159 each added entry in the header. Replace the 'Planes' field by the 'Number
162 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
164 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
166 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
168 At this time, this image isn't readable by e-film... waiting JPR help to
171 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
173 DocEntry. Now use methods of the Document !
175 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * Test/ShowDicomSeq.cxx : bug fix
178 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
179 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
180 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
181 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
182 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
184 * Test/TestCopyRescaleDicom.cxx : remove unused variable
185 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
186 containing found sequences
188 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
191 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
192 Some fields in BinEntry must be copied to not seg fault when making the :
193 gdcm::File *copy = new gdcm::File( copyH );
194 and tests are now made on good variables
196 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
197 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
198 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
200 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
201 * Add vtkGdcmWriter example and test
203 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * Test/TestUtil.cxx : reformat the source code
205 * vtk/vtkGdcmReader.cxx : remove and change prints
206 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
208 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
209 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
211 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
213 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
215 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
217 by an eof to prevent all bad read of the file... and in this case, the
220 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * Example/Volume2Dicom.cxx : comment unused variables
222 * Test/PrintDicomDir.cxx : comment unused variables
223 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
224 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
225 method that is redondant with AddEntry.
226 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
229 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * Bug fix due my last commit (compilation under Windows).
231 * Example/Volume2Dicom : bug fix in the file and reformatting source code
232 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
234 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
236 - Remove printf / sprintf
237 - include iostream AFTER gdcm so we don't get warnings
238 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
240 - Also remove tons of include from header files, hopefully this should
241 speeup the compilation time, since it was becoming a dog slow.
242 - Remove gdcm.h as it include way too many files and slow down compilation
243 (plus it is not up to date)
244 - remove 'using namespace std' this is BAD !
246 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
247 * Remove memory leaks on the DicomDir
248 * Remove some useless data in DicomDirObject
249 * Add usefull methods in SQItem, to be complient withe the ElementSet
251 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
252 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
254 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
255 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
256 future, with convertion)
257 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
258 and ImageDataSize values. Remove the method to get the PixelReadConverter
259 from the output of the class
261 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
264 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
265 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
266 and vtkErrorMacro use.
267 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
269 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
272 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
273 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
274 The string leaves only in the fonction. So when we make a .c_str(), we
275 get the pointeur on the first element, element that will be destroyed
276 immediately after thee instruction.
277 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
278 file has been opened : the test must be made on the content of the
279 pointer and not directly on the pointer !
282 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
283 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
284 the python part recompiles
286 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
287 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
288 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
289 X session is killed (for my computer... it seems to not be identic on
292 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
293 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
294 avoid problems (otherwise, the difference test between the visible image
295 and the reference is incorrect. If the reference is greater than the
296 screen resolution, it's produce errors).
297 Can be used for only one image. Can be used with a visible flag.
298 * vtk/vtkGdcmReader.cxx : remove commented codes.
299 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
300 under windows at compilation
301 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
303 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
305 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
306 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
307 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
308 tests on the image size X, Y, Z
310 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
312 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
313 between the class name and the file name
315 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * src/ : fix compilation warnings for the Write method (2 different
317 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
318 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
319 variable... create a static method in gdcm::Document to access to
320 this variable content.
322 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
323 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
324 file, to be accessed by other files (like gdcmFile). Remove commented
325 code. Move the change of the header to the gdcmFile, using the
327 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
328 To be sure of that (and simplify calls), the Write of the header now
329 gets a file name and not a file pointer (std::ifstream).
330 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
331 DocEntryArchive. Remove all open of the written file
333 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
334 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
336 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
337 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
338 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
340 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
341 some corresponding methods. Write correctly the file and check before
343 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
344 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
345 is now on RGB data (as before my last commit
346 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
348 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
350 Add a print information of the type of the entry
351 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
352 It was in the gdcmFile, and all write have been regrouped
353 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
354 Write correctly all dicom files (in decompressed mode only at this time)
355 * Test/ : test on files are now made using Raw data and not color data if
357 * Example/PrintFile.cxx : add more printings
359 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
360 * Amelioration of code, remove some code copy. For the loading of
361 BinEntry (in gdcmDocument), add the test to verify if the file is already
364 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
365 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
366 remove a DocEntry in the header (push an empty DocEntry)
367 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
368 lines. Bug fix in the initialization of the PixelConvert and the
370 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
371 use in TestCopyDicom (now this test can run under windows... but fails)
372 * Test/TestCopyDicom.cxx : amelioration of the test :
373 - test the pixels written
374 - add test points to quickly find where is the error
375 - can set a file name input and output in arguments
376 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
377 amelioration of the test output
379 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
380 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
381 all replaced DocEntry's
382 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
383 Now, each needed DocEntry to modify is duplicated, modified and inserted
384 to the header using DocEntryArchive. Thus, after save, we can restore the
385 header initial state.
387 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
388 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
390 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
391 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
392 correct to copy it. The DictEntry is specified at the DocEntry creation,
393 then, it musn't change in the time.
394 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
395 header correctly. At this time, the change is only made for the first
396 level of the Document. In the future, it might consider sequences.
397 The change is made by replacing a DocEntry by an other that is created
398 outside the class. The old value is kept. When we restore the header
399 status, the added DocEntry is deleted and replaced by the old value.
400 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
401 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
402 set the write type to explicit VR, implicit VR or ACR. Add methods to set
403 the write mode to native, decompressed or RGB (but not used at this time)
405 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
406 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
407 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
409 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
410 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
411 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
413 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
414 set because already copied when copying the BinEntry's of the header
415 * Test/TestAllReadCompareDicom.cxx : remove warnings
417 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
418 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
419 Two problems appear when doing it :
420 - with the gdcmFile : when the GetImageData method is called, the pixels
421 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
422 data (pixels). And each structure destruct the data when it's
423 destructed. So we have two destructions for the same data. To solve it,
424 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
425 data or not. If it doesn't own data, then they will not destroyed by
427 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
428 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
429 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
430 create a double destruction of the same DocEntry's. So, to solve it,
431 the TagHT is simply cleared and the DicomDir* elements are destroyed.
432 * TODO : add an entry concerning memory leaks in the DicomDir
434 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
435 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
436 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
439 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
440 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
441 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
442 after it have been deleted
444 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
445 * FIX: src/* fix the doxygen warnings.
446 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
447 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
448 was erroneously defined with a size of 15 instead of 16. [many thanks
449 to Jean Michel Rouet for pointing out this bug].
451 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
452 1. Finish merging JMR patch for writting DICOM from scratch
453 2. Fix -hopefully- bug with MONOCHROME and space vs null character
454 3. Use const ref when possible
455 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
456 5. A few more comments
457 6. CreateUniqueUID can now be called without parameter"
459 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
460 * ENH: Slightly bigger patch:
461 1. Getting toward full integration of JMR patch for writting dicom from scratch
462 2. Update Test to test part of this patch: CreateUniqueUID
463 3. File was not close properly in gdcmDict
464 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
465 5. Use of const ref instead of copy (speed issue)
466 6. Remove temporary (duplicate) string in TranslateToKey
467 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
468 8. Do not repeat virtual in subclasses
469 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
471 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
472 * Apply first patch toward better string comparison when dealing with broken
473 DICOM files. Essentially the string could be padded with a space instead
474 of a null character as defined by standard
476 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
477 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
478 because never used... and in the same time, that's remove some memory leaks
480 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
481 * src/gdcmFile.cxx : now delete the PixelConvert instance.
482 * In examples and tests : change the type of image data variables from void*
483 to uint8_t*. Remmove all delete on image data variables
485 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
486 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
487 Verify the file pointer value before open the file, and if it's not null,
488 a verbose message is generated.
489 Close correctly the file when the file isn't considered dicom-like. The
490 correctly close is a call to CloseFile.
491 When closing the file pointer, test if its not null to close the file.
492 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
493 file. For an uncompressed image, the copied data correspond in the least
494 case to the image size (calculated) or the image size specified in the
495 header. A verbose is generated if these two size mismatch
497 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
498 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
499 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
500 break under windows (with msvc6 compilation).
502 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
504 compiling with MSVC6)
506 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
507 * Bugs fix for the Windows build with VC6
508 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
509 needed (only for projects required VTK). If the VTK is included in all
510 projects, there is conflicts with the jpeg lib of vtk when compiling the
511 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
512 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
513 when compiling the gdcm_wrap.cxx file (created by the compilation of the
515 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
516 (like it's already made for the cout use). Otherwise, conflict with the
519 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
520 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
522 - comments on the DicomDir::Method related usage added.
523 - now that we use the namespace gdcm, a lot of internal classes do
524 NOT need to be wrapped anymore.
525 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
526 DicomDir::Method) new example added.
528 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
529 * Improve string manipulation. I now inforce the notion of 'DicomString'
530 A DicomString can contain as many \0 as they want
531 and it is *always* of even length.
532 We only support odd length for very rare case.
533 And in the near future this should be removed.
535 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
536 * /binary_write/ gdcm source. Now even on big endian we are writting
537 little endian. This should -heopfully- fix some tests
539 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
540 * Now the dictionary is compiled into gdcm lib. This is a default
541 behavior, thus any dic file specified is picked before failback to
542 the one comiled into lib
544 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
545 * Change internals for gdcmDict. Don't use any 'new' any more.
546 This should definitely solve any leak problem, and we should be
547 as fast as before, as long as don't modify too much the dictionary.
549 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
550 * STYLE: ivars should start with a capital letter.
551 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
552 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
554 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
555 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
556 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
557 new 2004 dictionaries added (thanks to JPR).
558 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
559 * CLEANUP_ROUND (15) for gdcmPixelConvert
560 - RLEFrame::NumberFragments is now of type unsigned int
561 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
562 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
565 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
566 * Initial work in gathering all transfer syntax accessors. clearly
567 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
568 ivars, but only one transfersyntax (class) ivar with equivalent method on
571 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
572 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
573 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
574 discussed (plus I didn't like having a 2000 lines patch not commited)
576 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
577 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
578 * CLEANUP_ROUND (14) for gdcmPixelConvert
579 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
580 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
581 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
583 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
584 anymore and hence avoids storing a copy of PixelConvert::Decompressed
585 into File::Pixel_Data.
587 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
588 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
589 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
590 * CLEANUP_ROUND (13) for gdcmPixelConvert
591 Substituted File::ParsePixelData() with PixelConvert::Print() new
593 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
594 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
595 method to those classes.
596 - src/gdcmFile.[cxx|h]:
597 -- Added a ::Print() method.
598 -- PixelConverter is now a reference instead of a member.
599 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
600 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
602 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
603 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
604 collaboration diagram and inheritance diagram should be generated with
606 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
607 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
608 pointlessly wrapped (see
609 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
610 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
611 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
612 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
613 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
614 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
615 -- File::Initialise: PixelConverter setup moved away to
616 PixelConverter::GrabInformationsFromHeader()
617 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
618 interpretation moved away to PixelConverter::BuildRGBImage()
620 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
621 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
622 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
624 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
625 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
626 displayed on Win32 when a brutal abort() occurs (because of uncatched
627 exception). See TODO new entry of this commit for more on this.
628 * TODO added new entry.
629 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
630 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
631 - HandleColor is no longer called from gdcmFile.cxx
632 - gdcmPixelConvert.cxx clean up on method arguments and internal
633 variable names for semantical coherence.
635 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
636 * Finished lossless transition, not only do we now read all lossless jpeg
637 images, without the need of the Cornwell lib, but we do read them properly now
638 * To reduce code (well to avoid code duplication), I defined a common place
639 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
640 redefine symbols. This is not perfect but this the best solution I found for a
641 compilation time jpeg option.
643 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
644 * Update jpeg ijg lib to support lossless jpeg implementation
645 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
647 * Also added a special copyright for dcmtk since we use their bugfixes.
650 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
651 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
652 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
653 matters, as stated in warning note at begining of %include section).
654 * src/gdcmDicomDir*.[cxx|h]: coding style
655 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
656 * src/gdcmJpeg8.cxx: doxygen fix.
657 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
658 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
659 from File:: to PixelConvert::.
661 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
662 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
663 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
664 - more code moved away from File:: to PixelConvert::
665 - fat setup of PixelConverter set in place in File::Initialise.
667 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
668 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
669 namespace at the file system level. So now you should convert your examples
671 gdcmHeader -> gdcm::Header
672 It would be nice if people keep in mind to no open the namespace, since it
673 allows compilation on broken plateform which were defining common symbol in
674 the standart namespace (like LP, Unknown ...)
676 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
677 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
678 The JPEG fragments are now parsed at the same stage than the RLE
679 information. All code related to JPEG is now in gdcmPixelConvert:
680 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
681 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
682 export a gdcmFile:: method. Those are simply global functions
683 (for the time being this is better than having them attach to
684 either gdcmFile:: or gdcmPixelConvert::).
685 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
686 and stores the result in a gdcmJPEGFragmentsInfo.
687 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
688 code (among other stuff) moved away from gdcmFile:; to
691 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
692 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
693 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
694 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
695 clean up of RLE related code.
696 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
697 - src/gdcmRLE.cxx removed
698 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
699 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
700 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
701 * CLEANUP_ROUND (9) for gdcmPixelConvert
702 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
703 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
704 away from gdcmFile:: to gdcmPixelConvert::.
706 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
707 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
708 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
709 This is because Parse7Fe0 used to parse the pixels to compute the
710 length. This task was passed over to FindDocEntryLengthOB() a long
711 time ago, EXCEPT I had forgotten the OW case...
712 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
713 we just recylce the code for parsing RLE fragments and computing
715 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
716 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
717 with the retired Parse7Fe0().
718 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
719 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
721 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
722 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
723 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
724 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
725 - src/CMakeLists.txt: alphabetic order reodering + new entries.
726 * CLEANUP_ROUND (4) for gdcmPixelConvert
727 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
728 to return an unused length.
730 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
731 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
732 this should be cleanner from the plane view. The iostream are erally a pain
733 to use to do simple stuff.
735 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
736 * Redo the compilation of the ijg jpeg library. Now only one source is
737 necesseray. No need to rename file by hand what so ever. CMake handle the
738 copying of the file within different directory, configure header file to
739 modify some symbol. The only addition made to ijg wasd a mangle table so
740 that symbol are different wether we are within 8bits or 12bits.
742 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
743 * Added documentation of vtkgdcmReader on Website:
744 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
745 with it's binary name).
746 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
747 the Website to be more complete.
748 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
749 doxygenated documentation.
750 - Doc/DoxyVtkGdcmReaderExamples.txt added
751 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
752 DoxyVtkGdmReaderExamples.html )
753 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
754 * CLEANUP_ROUND (3) for gdcmPixelConvert
755 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
757 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
758 * CLEANUP_ROUND (2) for gdcmPixelConvert
759 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
761 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * CLEANUP_ROUND for gdcmPixelConvert:
763 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
764 - src/gdcmPixelStuff[h|cxx] removed
765 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
766 - src/CMakeLists.txt changed accordingly
768 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
769 gdcmVersion.py moved to newly created ATTIC related
770 gdcmPython/SetupOldies/ directory.
771 * Autotools clean up:
772 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
773 - autogen.sh configure.in acinclude.m4 python.m4 removed
775 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
776 * src/*.cxx *.h Reference to License.htm fixed to License.html.
777 * Doc/CMakeLists.txt, doxygen.config.in: fix.
778 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
780 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
781 * TODO updated with Mathieu suggestions. I proposed a template for
782 describing TODO entries and used it for new entries.
783 * Added Doc/Website/CodingStyle.html, Developpers.html,
784 DeveloppersPython.html, GdcmDataCvs.html and
785 DownloadVersion0_1.html, DownloadVersion0_3.html.
786 * Some Doc/*.txt Doxygen files (which do not really concern the
787 documentation itself, but the website) moved to html and
788 placed in directory Doc/Website:
789 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
790 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
791 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
792 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
793 * CMakeLists.txt changed accordingly.
794 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
795 DeveloppersPython.html
796 * INSTALL nows refers to Doc/Website/Installation.html
798 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
799 * Added Doc/Website directory, that contains a first raw version
802 2004-09-23 Jean-Pierre Roux
803 * FIX In order not to be poluted any longer by casting problems,
804 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
805 we can now delete[] it safely
806 * VoidArea is now called BinArea (less confusing name),
807 and all the methods called ...VoidArea... are now ... BinArea...
808 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
810 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
811 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
812 clear) TagHT, which is an inherited member of gdcmElementSet. It is
813 up to the destructor of gdcmElementSet to clean up TagHt and it's
816 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
817 * Test/CMakeLists.txt: update to follow gdcmData renamings.
818 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
820 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
821 * ENH: added some utility method that builds a flat dictionnary
822 holding all the Dicom entries contained in the recursive structure
823 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
825 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
826 BuildFlatHashTable() that build a flat dictionary.
827 - src/gdcmElementSet.h: added a new private GetTag() accessor.
828 gdcmDocument is now a friend of gdcmElementSet.
829 - src/gdcmElementSet.cxx: clean up.
830 - Example/FlatHashTablePrint.cxx added.
831 - Example/CmakeLists.txt changed accordingly
833 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
834 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
835 moved away from gdcmDocEntrySet (since this class is an abstract class
836 acting like an interface). SQDepthLevel and BaseTagKey are now
838 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
839 and associated accessors. Doxygenation of the class.
840 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
842 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
843 Use SQDepthLevel accessor instead. ::Print() adapted.
844 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
845 - src/gdcmDocument.cxx changed accordingly.
847 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
848 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
849 - The following is the doxygen comment of the typedef declaration
850 of gdcmagKey in src/gdcmCommon.h:
851 gdcmTagKey is made to old an "universal" (as in URL, Universal
852 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
853 A dicom tag allways has a group and an element, but a set of tags
854 embeded in various (optionally nested) sequences and sharing
855 the same group and element all share the same (group, element)
856 "identifier". Hence the (group, element) cannot be used as an
857 identifier (in gdcm we shall refer to a "TagKey") of a tag.
858 In order to construct a proper tag identifier (i.e. a key) we
859 consider the following definition of a TagKey:
860 - let Group, Element be the string representation of the
861 group and element dicom tag members,
862 - let ItemNumber be the string representation of the integer
863 index of the considered item number of a sequence,
864 Let the key of a tag embeded in a sequence, noted SeqTag, be
866 /ItemNumber#Group|Element
867 where "/", "#" and "|" are characters acting as separators.
868 Then the general form of a gdcmTagKey is given by:
869 Group|Element<SeqTag>
870 where <SeqTag> means NO or many instances of SeqTag.
871 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
874 but the gdcmTagKey of a tag "embeded" is the first item of
875 a sequence, itself nested in the third item of a sequence is the
877 0004|1220/2#0008|0082/0#0008|0090
878 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
879 order to hold the new sequence compatible key. Previously, the
880 GetKey() method would look in the underlying gdcmDictEntry.
881 - src/gdcmDocEntry.cxx:
882 -- constructor now copies the underlying DictEntry key, in the local
884 -- ::Print: displays the member Key, instead of the (group, element).
885 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
886 - src/gdcmDocEntrySet.h:xi
887 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
888 -- now has a new BaseTagKey member.
890 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
891 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
893 This poses the problem with the semantics of the following lines
894 LoadEntryVoidArea(0x0028,0x1201); // R LUT
895 LoadEntryVoidArea(0x0028,0x1202); // G LUT
896 LoadEntryVoidArea(0x0028,0x1203); // B LUT
897 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
898 to the long FIXME note for what the problem is. Nevertheless in
899 order to get things working the dicom dictionary was altered !
900 Please fix things urgently...
901 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
902 information), see above note on moving the member VoidArea. Nevertheless
903 the following entries previously correctly set as US are now inproperly
905 0028 1201 OW IMG Red Palette Color Lookup Table Data
906 0028 1202 OW IMG Green Palette Color Lookup Table Data
907 0028 1203 OW IMG Blue Palette Color Lookup Table Data
908 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
909 of gdcmDocEntry moved to gdcmSeqEntry.
910 * src/gdcmSeqEntry.cxx: STYLE.
912 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
913 * Test/TestAllEntryVerify.cxx minor fix and added comments.
915 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
916 * gdcmPython/testSuite.py: all the test suite in python is now moved
917 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
918 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
919 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
921 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
922 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
923 to avoid inclusion recursion until STL is reached.
924 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
925 mecanism. errno.h is not included in gdcm anymore.
926 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
927 (gdcmFormatError now inherits from gdcmFormatUnexpected).
929 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
930 gdcmData/TestAllEntryVerifyReference.txt
931 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
932 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
933 exception_on_error parameter.
934 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
935 - vtk/vtkGdcmReader.cxx changed accordingly,
936 - Example/*.cxx and Test/*.cxx changed accordingly.
938 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
939 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
940 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
941 enable_sequences removed from gdcmHeader constructor and dependencies.
942 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
943 * gdcmPython/demo/PrintHeader.py: dummy fix.
944 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
945 skip_shadow removed from gdcmHeader constructor and dependencies.
946 * Example/*.cxx and Test/*.cxx changed accordingly.
948 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
949 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
950 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
952 2004-07-21 Jean-Pierre Roux
953 * FIX Now, Parsing and Printing a DICOMDIR do work!
954 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
956 2004-07-20 Jean-Pierre Roux
957 * FIX Some brain damaged headers have Zero-Lenght fields
958 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
960 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
961 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
962 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
963 variable (instance of gdcmDebug) by a definition macro, and the instance
964 is now in static in the gdcmDebug class
965 * src/gdcmSQItem.h : (FIXME) remove an undefined method
966 * Test/PrintAllDocument.cxx : bug fix in the result of the test
968 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
969 * WARNING: ctest now depends more tightly on gdcmData. You should
970 check out gdcmData properly for things to run smoothly...
971 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
972 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
973 we need the pixels not be loaded in order to use the ValEntry
974 that displays position and size).
975 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
976 This is a C++ based equivalent of gdcmPython/testSuite.py that should
977 be deprecated. If you have any doubts about the advantages of a
978 modern scripting language (read Python) versus grass root C++ (i.e.
979 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
980 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
981 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
982 Anyhow, consider documenting the gdcmData images in
983 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
985 * Test/CMakeLists.txt:
986 - now uses TestAllEntryVerify.cxx
987 - specific comments on oldACR00001.ima (now renamed in gdcmData
988 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
989 gdcmData/TestAllEntryVerifyReference.txt
992 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
993 * src/*.[h|cxx] : typedef clean up
994 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
995 - TagKey renamed to gdcmTagKey (for external usage)
996 - VRKey renamed to gdcmVRKey (for external usage)
997 - removal of typedef duplication.
998 - Removed all unecessary inline keyword from class inline definitions.
999 - Some method|function(void) declarations replaced with method|function().
1000 * src/jpeg/libijg12/jdhuff12.c:
1001 - printf polluting ctest removed.
1002 - TAB removal for comminting
1004 - TestAllReadCompareDicom.cxx: added a test that compares all the
1005 images in gdcmDataImages.h with corresponding images in
1006 gdcmData/BaselineDicom/. When baseline images are not present
1007 this test creates them.
1008 Note: we need to validate each reference image, but before that
1009 I'd like to rename them with a more explicit name...
1010 - CMakeLists.txt: changed accordingly.
1011 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1012 including each header needed).
1014 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1015 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1016 test suite to the Example directory. Are concerned:
1021 - TestWriteSimple.cxx
1022 * Test/CMakeLists.txt: added some comments on reasons for black listing
1023 image gdcmData/oldACR00001.ima
1025 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1026 * Test/CmakeList.txt: removed the following from black list (to be coherent
1027 with removal from gdcmData):
1028 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1029 - gdcm-MR-PHILIPS-16.dcm
1031 Added the following because after last cvs update, they cause
1032 ctest -R TestReadWriteReadCompare
1034 - gdcm-MR-SIEMENS-16-1.acr
1036 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1037 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1038 new comments in this file) we temporarily (sigh) move to a weaker
1040 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1041 we don't need to black list the following images anymore:
1042 - 8BitsUncompressedColor.dcm
1044 - US-PAL-8-10x-echo.dcm
1045 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1046 fixes and the beautified code ;-)
1047 This fixes the bug introduced in version 1.42 (when beautifying)
1048 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1049 Note: ctest was blind to this bug (this means we need to still
1050 improve the test suite). The bug could be detected by using
1051 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1053 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1054 and by displaying the (garbage) produced file temp.XDCM...
1056 2004-06-29 Jean-Pierre Roux
1057 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1058 - replace by uggly but working old code :-(
1059 A lot of things should be OK again.
1060 It's really urgent to have a test suite that *tests*,
1061 to prevent Frog's beautifying sessions to break all the stuff
1062 (twice, withing a fortnigh ...)
1064 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1065 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1066 redundancy) to added Test/TestReadWriteReadCompare.cxx
1067 * Test/CmakeList.txt: because the compare test of
1068 Test/TestReadWriteReadCompare.cxx fails, the following images are
1069 black listed: - 8BitsUncompressedColor.dcm
1071 - US-PAL-8-10x-echo.dcm
1072 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1073 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1074 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1075 and ad-hoc kludge. This kludge is now removed, and on encountering
1076 such an image (OB field brain damaged) we set errno. Then in
1077 ::FindDocLength() we "fix" the length as being ALL what remains
1078 in the file (until EOF). We then proceed, hoping for the best...
1079 This fixes a SegFault in ShowDicom when trying to write such an
1081 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1082 (because TestWriteRead breaks on it, after a non conformal commit?).
1083 ctest now runs properly, except for MakeDicomDir (which was allways
1084 broken) and the Python related stuff (still not fixed).
1086 2004-06-24 Jean-Pierre Roux
1087 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1088 FIX : Test/TestReadWrite now iterates on all the file names
1089 (instead of infinite loop)
1090 ENH : Test/TestWriteRead now iterates on all the file names
1092 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1093 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1095 2004-06-24 Jean-Pierre Roux
1096 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1097 when SamplesPerPixel =3
1098 - now Write is no longer confused by
1099 'BitsAllocated = 12" and 'BitsStored=12"
1100 - "UN" value representation Elements are now written correctly
1101 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1102 ENH : - now gdcmHeader has its own Write methods
1103 (in order to split the job that has not to be done
1106 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1107 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1108 loop on the same image until memory went out.
1109 Note: this means we still have gobs of memory loss in PrintDocument
1110 * src/gdcmDocument.cxx: fixes problem on parsing on file
1111 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1113 2004-06-24 Jean-Pierre Roux
1114 FIX : Write - All the Sequences and Sequence Item are now written
1115 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1116 is added a the end, when necessary.
1117 - A lot of brain-damaged images, that were read correctly are
1118 now written correctly
1119 - length compatible BinEntry are now loaded correctly
1120 (even for odd groups)
1121 Note : only Explicit Value Representation was checked.
1122 (question : is implicit VR really necessary for gdcm ?)
1124 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1125 * DEVELOPPER: added a proposition of coding style.
1126 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1129 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1130 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1131 Use the gdcmDocEntry::Print() and Write() instead.
1132 * src/gdcmDocument.cxx: bug fix.
1134 2004-06-22 Jean-Pierre Roux
1135 FIX : gdcmDocument.cxx
1136 - Now we do recognize the JpegLossLess format (there was a misstyping in
1137 code 'beautyfication' :-(
1138 - Now we automaticaticaly load the Luts, if any
1140 2004-06-22 Jean-Pierre Roux
1141 In order : to write Sequences, whatever their imbrication level,
1142 : to allow user to create his own Sequences
1143 a lot of modif where necessary (adding, moving, or virtualising methods)
1145 WARNING : save your own sources *before* cvs up !
1148 ADD virtual void Write(FILE *fp, FileType filetype);
1151 ADD virtual void Write(FILE *fp, FileType filetype);
1152 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1155 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1156 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1157 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1158 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1159 ADD std::string GetEntryByName(TagName name);
1160 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1162 std::string vr = "unkn",
1163 std::string fourth = "unkn",
1164 std::string name = "unkn");
1165 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1166 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1167 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1168 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1169 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1170 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1171 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1172 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1175 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1176 ADD virtual std::string GetEntryByName (TagName tagName);
1177 ADD virtual std::string GetEntryVRByName (TagName tagName);
1178 REM virtual bool Write(FILE *, FileType);
1179 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1180 FILE *_fp, FileType type);
1181 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1182 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1183 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1184 REM virtual std::string GetEntryByName (std::string tagName);
1185 REM virtual std::string GetEntryVRByName (std::string tagName);
1186 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1187 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1188 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1190 std::string vr = "unkn",
1191 std::string fourth = "unkn",
1192 std::string name = "unkn");
1193 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1194 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1195 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1196 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1199 ADD virtual void Write(FILE *fp, FileType filetype);
1202 ADD virtual void Write(FILE *fp,FileType filetype);
1205 ADD virtual void Write(FILE *fp, FileType filetype);
1206 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1207 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1208 REM std::string GetEntryByName(TagName name);
1211 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1213 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1214 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1215 The default constructor invoked by the line
1216 gdcmHeader *f1 = new gdcmHeader( header );
1217 was gdcmHeader::gdcmHeader(bool) instead of the expected
1218 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1219 Hence the parsing wasn't executed... See also below.
1220 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1221 as explicit constructor didn't do the trick to fix the above problem.
1222 Could anyone explain why ?
1223 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1224 properly calls gdcmValEntry::Print() (that was weed out from
1225 code related to gdcmBinEntry).
1227 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1228 * In order to fix memory leaks:
1229 - Test/TestWriteSimple.cxx: added cleaning of free store through
1231 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1232 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1233 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1234 (through the call to ::AddDicomDirMeta()) or the destructor
1235 would crash when deleting uninitialized ::metaElems].
1236 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1237 - src/gdcmDocument.cxx:
1238 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1239 from dynamic stores.
1240 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1241 was causing memory leaks.
1242 - src/gdcmSQItem.cxx:
1243 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1244 cleanly handled with polymophism: sorry but my milage is low).
1245 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1246 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1247 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1248 This avoids SegFaulting.
1249 - src/gdcmSQItem.h: coding style.
1251 - Test/TestWriteSimple still severely sucks. The output image content
1252 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1253 damaged when displayed with vtkgdcmViewer.
1254 - on memory leaks: TestWriteSimple leaks really less (see entry
1255 of 2004-06-18 in Changelog file for the call to valgrind).
1256 - on segfaults: ctest now passes all the tests but one (no more
1258 * Erroneous leading white fix:
1259 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1260 white[s] (as opposed to from >> xxx, that removes it [them].
1261 - src/gdcmTS.cxx: ditto.
1262 - gdcmPython/testSuite.py: dirty related kludge removed.
1263 * src/*: remaining references to gdcmParser removed.
1264 * src/*[cxx|h]: added copy[way]left header.
1267 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1268 * In order to fix writing of dicom files:
1269 - Test/TestWriteSimple.cxx: a simpler example of writing.
1270 - Test/CMakeLists.txt changed accordingly.
1271 - src/gdcmDocument.cxx:
1272 -- The destructor now recursilvely removes potential sequences.
1273 -- Bug fix in ::IsJPEG2000()
1274 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1275 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1277 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1278 to only declared) and build on top of
1279 ::GetDocEntryByNumber(guint16, guint16).
1280 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1281 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1282 for usage in destructor and treatement of promotion in
1283 ::ReplaceOrCreateByNumber().
1284 - src/gdcmSQItem.cxx: destructor should better handle his job.
1285 Test/TestWriteSimple now runs (or at least it DOES something).
1286 * We can now start hutting memory links. A good starting point is:
1287 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1288 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1289 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1291 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1292 * Valgrind note: after Mathieu Malaterre teached me how to read
1293 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1295 Using gcc, you can force the STL to use malloc and to free memory as
1296 soon as possible by globally disabling memory caching.
1297 With 3.2.2 and later, you should export the environment variable
1298 GLIBCPP_FORCE_NEW before running your program.
1299 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1300 simply vanish (it is still not clear to me, whether this means that
1301 STL std::string leaks or if valgrind believes it leaks...).
1302 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1303 running bin/gdcmTests makeDicomDir):
1304 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1305 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1307 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1308 SegFaulting (I drowned in DicomDir related code when trying to
1309 understand why the list is empty...).
1310 * src/gdcmDocument.h: first BSD license header try.
1311 * Doc/License.txt added.
1313 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1314 * src/gdcmDocument.[h|cxx]:
1315 - Clean up of the Transfer related predicates. They are now all based
1316 on new method isGivenTransferSyntax, that (should) handle properly
1317 the padding problem.
1318 - general clean up, simplification, and coding style.
1319 - Specific clean up of Parse7FE0() (umproperly named actually).
1320 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1322 2004-06-14 Jean-Pierre Roux
1324 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1325 - fix the display of SQItem ordinal number
1326 - add the GetSQItemByOrdinalNumber method
1327 - remove some useless never written private methods
1329 2004-06-14 Jean-Pierre Roux
1331 - adding a constructor taking a gdcmDocEntry as an input param
1332 - ReplaceOrCreateByNumber now returns :
1333 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1334 a gdcmValEntry * if a string value is passed as a param
1336 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1337 according to the param type (no longer sets a gdcmDocEntry)
1338 - GetValEntryByNumber, GetBinEntryByNumber added
1339 - NewValEntryByNumber and NewBinEntryByNumber added
1341 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1343 - GetSQItemNumber and SetSQItemNumber added, to provide
1344 a (relative) Item identier inside a given Sequence
1345 \warning : some pb remaining around this number
1347 - AddEntry now takes the Item Number as a param
1349 - adding a constructor taking a gdcmDocEntry as an input param
1351 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1352 * Memory leak hunt with the following command:
1353 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1354 --show-reachable=yes gdcmTests PrintDocument
1355 It looks like many (all?) leaks are due to the STL (or a bad usage
1356 of the STL. The lines producing the leaks now have a comment with
1357 a "MEMORY LEAK" tag: you can retrieve them with
1358 grep "MEMORY LEAK" src/*
1359 Here are two typical examples which I can't help fixing:
1364 char * test = "babo";
1365 name = test; //// <--- valgrind detects 960 bytes lost in
1366 //// call to std::string::operator=(char const*)
1367 name.clear(); //// Doesn't help !
1375 std::cout << "Type a bunch of characters followed by RETURN: ";
1376 getline(std::cin, line); //// <--- valgrind dectects a loss
1377 //// of 1320 bytes in call to
1378 /// std::basic_istream<>& std::getline<>
1384 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1385 * src/gdcmHeader.[cxx|h]:
1386 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1387 and related, moved away to gdcmDocument.
1388 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1389 the corresponding protected accessors of inherited class
1390 gdcmDocument, removed ! As a consequence gdcmFile had to be
1391 declared friend of class gdcmDocument (see below).
1392 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1393 - Clean up of undefined or unused methods.
1394 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1395 account the changes to gdcmHeader.h).
1396 * src/gdcmDocument.h:
1397 - gdcmFile is now a friend class (in order to take into account the
1398 changes to gdcmHeader.h).
1399 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1400 (see changes to gdcmHeader.h).
1401 - Accessors (reading on the form GetEntry*) are now public.
1402 - Clean up of undefined or unused methods.
1403 * src/gdcmDocument.cxx:
1404 - adaptation to changes to gdcmDocument.h
1405 - ::OpenFile now writes a verbose message when file cannot be opened.
1406 - some std::string properly set to VRKey
1407 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1408 references to gdcmDocument.
1409 * Test/TestFindTags.cxx: changed accordingly to above changes.
1410 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1411 cvs repository gdcmData.
1413 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1414 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1415 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1416 conflicts with gdcmValEntry::voidArea.
1417 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1418 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1419 Value representation between StringRepresentable and BinaryRepresentable.
1420 * src/gdcmDocument.cxx:
1421 - method ParseDES: proper indentation restored and usage of
1422 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1423 - method LoadDocEntry: the fingerprint left in the SetValue() of
1424 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1425 removed. Reverting to previous code segment with the proper
1426 dynamic_cast< gdcmValEntry* >.
1427 Note: this was (partially) breaking the python test suite
1428 (gdcmPython/testSuite.py) that made usage of the above
1429 fingerprint to check presence of "Pixel Data".
1430 * src/gdcmDocEntry.h: coding style.
1431 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1432 now taken into account.
1433 * gdcmPython/gdcm.i: adaptation to the new internal representation
1434 of gdcm (exit gdcmParser, hello gdcmDocument).
1435 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1437 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1438 anymore, but instead prints the loaded Python dictionary.
1439 * .... alas, the python testSuite is still broken.
1441 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1442 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1444 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1445 * src/gdcmUtil.h : export methods
1447 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1448 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1450 * Initial addition of automatic python testing
1451 * Initial addition of automatic image comparison
1453 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1454 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1455 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1457 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1458 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1459 * Test/ShowDicom.cxx : bug fix for msvc compilation
1460 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1462 2004-05-04 Jean-Pierre Roux
1463 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1464 new concepts (and new classes) :
1465 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1466 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1467 - Sequence Doc Entries (gdcmSeqEntries)
1468 a Sequence is composed of Items.
1469 Each item is a set of Doc Entries (this is recursive)
1470 The non uniqueness of the 'Dicom tag' is due to this recursivity
1471 (never taken into account)
1472 Our unability to add a new 'entry' in the header
1473 at the proper location (neither in the H-Table (map or multimap),
1474 nor in the Chained List is also due to this recursivity.
1475 Don't try, right now, to use/modify/compile these new sources :
1476 nothing is finished.
1477 We just commit all the stuff, 'as is', in order not to loose it.
1479 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1480 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1482 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1483 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1484 file prefix (SetFilePrefix)
1486 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1487 * Add a new test: ShowDicom, for now this is just the c++ version of
1488 checkRead.sh, later it will be able to compare the image read against a
1490 * Replace the DEBUG on the stack with a global entry in cmake interface:
1491 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1493 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1494 * Add an example subdir, with a real example on how to read + write a
1497 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1498 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1499 * Doc/CMakeLists.txt: the main page is now properly differentiated
1500 between the developper and user version.
1501 * Doc/doxygen.config.in: dropped search related obsolete flags
1502 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1504 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1505 * DEVELOPPER: added some helpfull comments for compile/test/install
1508 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1509 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1510 src directory, now generated in the build dir.
1511 2. Tests as mentionned smarter
1513 4. Add a new method in gdcmDict that return the PubDict by name
1514 this is interesting for 3rd party lib like ITK,
1515 where we could set the institution name / patient name...
1517 * ENH: 1. Now the test suite is working for real
1518 2. All binaries are now output in the gdcm-bin directory
1519 (this was not true before)
1521 2004-04-28 Jean-Pierre Roux
1522 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1523 SeQuence indented printing of Dicom Header.
1524 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1525 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1526 Computation of SQDepthLevel is now part of gdcmHeader constructor
1527 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1528 tree-like structure of a Dicom Header.
1529 * FIX Test code cleaning
1531 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1532 * ENH: Adding automatic testing
1533 1. Need a DartConfig.cmake to submit to public
1534 2. Add a test driver gdcmTest.cxx
1535 3. gdcmTestMain, an helper for the main test driver gdcmTest
1536 4. Files in Test don't have a main anymore, this becomes interesting
1537 when we add more and more tests, thus dsw don't have to load
1539 * ENH: Adding a GDCM_DATA_ROOT for testing
1540 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1541 one file instead of seven + some small cleanup
1543 2004-04-22 Jean-Pierre Roux
1544 * ENH Minor changes to the Print() methods.
1545 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1546 Header printing. Example given with :
1547 > PrintHeader fileName 2 new
1548 (SQ based tree-like structure still to be done for the Header ...)
1550 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1551 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1552 1. I have added some unsigned where needed
1553 2. Some function parameter not used -> (void)
1554 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1555 4. g++ don't like character '\' in comment
1556 5. #define jpeg_create_decompress jCreaDecompress
1557 this really need to be fixed
1558 6. virtualize destructor of gdcmObject ... leakage
1559 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1560 this also really need to be fixed
1561 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1562 remove compression file
1563 (as we only do decompression, right ?)
1564 * ENH: Change malloc/calloc/free with c++ equivalent
1566 2004-04-21 Jean-Pierre Roux
1567 * FIX gdcmHeaderHelper::GetXSpacing
1568 when a single value is found (bug ?), xpacing is now
1569 defaulted to yspacing
1571 2004-04-19 Jean-Pierre Roux
1572 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1573 * ENH add parameters :
1574 bool exception_on_error = false,
1575 bool enable_sequences = false,
1576 bool ignore_shadow = false
1577 to the gdcmFile constructors to be full gdcmParser compliant
1578 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1579 to allow reading of PAPYRUS 3.0 files
1581 2004-04-06 Jean-Pierre Roux
1582 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1584 2004-04-02 Jean-Pierre Roux
1585 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1586 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1587 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1589 2004-03-30 Jean-Pierre Roux
1590 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1591 for ACR file, written out as DICOM files (hope so...)
1593 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1594 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1595 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1596 moved to base class gdcmParser and only the specialisation is kept
1598 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1599 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1600 already does the job.
1601 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1602 (to be consistent with gdcmParser::WriteEntries).
1604 2004-03-30 Benoit Regrain
1605 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1606 upate of the object's instance. It's passed to 2 in the unfavorable
1607 case : one in the ExecuteInformation, one in the ExecuteData
1609 2004-03-29 Jean-Pierre Roux
1610 * ENH : Check on file type to be written moved
1611 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1612 * FIX : gdcmObject::ResetBoundaries now stops properly
1613 when end-of-list is reached
1614 : gdcmVersion modified (as Benoit Regrain asked)
1616 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1617 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1618 * src/gdcmUtil.cxx: added forgotten iostream include.
1619 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1620 equivalent to ExplicitVR in existing code).
1622 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1623 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1624 now contains all the gdcmGlobal related code.
1625 * minor coding style and doxygenation changes.
1627 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1628 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1629 now contains all the Debug related code.
1630 * minor clean-up of includes in src/*.cxx
1631 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1632 CreateCleanString) removed.
1633 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1634 * Doc/DoxyMainPageUser.txt added.
1635 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1636 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1637 src/gdcmDirList.cxx)
1639 2004-03-24 Jean-Pierre Roux
1640 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1642 2004-03-23 Jean-Pierre Roux
1643 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1644 big endian made volumes
1645 * ENH Now gdcmParser constructor and destructor are protected to forbid
1646 end user to instanciate class gdcmParser
1647 (only gdcmHeader and gdcmDicomDir are meaningfull)
1649 2004-03-22 Benoit Regrain
1650 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1651 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1652 gdcmSerie to gdcmDicomDirSerie
1654 2004-03-19 Jean-Pierre Roux
1655 * ENH Now the tree-like structure describing a DICOMDIR comming from
1656 an already existing DICOMDIR file is consistent with
1657 the home-made tree-like structure build ex-nihilo
1658 or build from the files held (recursively) in a Directory
1659 functions gdcmDicomDir::CheckBoundaries()
1660 gdcmObject::SetBoundaries() added
1662 2004-03-17 Jean-Pierre Roux
1663 * REM (Eric Boix bug) : removal of meaningless
1664 gdcmDicomDirImage::NewImage function.
1665 * FIX now file names and directory name are written properly in the
1667 * FIX now gdcmDicomDir constructor may be call without any trick
1670 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1671 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1672 of gdcmDicomDirImage::NewImage as empty function.
1674 2004-02-28 Jean-Pierre Roux
1675 * ENH add gdcmDicomDir:NewPatient
1676 add gdcmDicomDirPatient:NewStudy
1677 add gdcmDicomDirStudy:NewSerie
1678 add gdcmDicomDirSerie:NewImage
1679 to allow making gdcDicomDir object.
1680 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1681 (as opposite to the gdcmHeader chained list)
1683 2004-02-11 Benoit Regrain
1684 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1685 when using from python
1687 2004-02-10 Benoit Regrain
1688 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1689 * FIX : in gdcmDicomDir when the directory is empty
1690 * ENH : add callback and methods to get the progression of dicomDir
1693 2004-02-06 Jean-Pierre Roux
1694 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1695 - GDCM_META added to gdcmDicomDirType
1696 - class gdcmMeta created
1697 * ENH : - A brief summary is now displayed at the beginning of
1698 'testDicomDir' to help disaster magnitude estimation
1699 * REM : Now useless Test/explDICOMDIR.cxx
1701 2004-02-05 Benoit Regrain
1702 * ENH : add methods in gdcmObject to get the hash table or the list of
1704 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1705 * FIX : wrapping python for TagHeaderEntryHT
1707 2004-02-04 Benoit Regrain
1708 * FIX : even length for some strings when writting the dicom dir
1709 * FIX : sort the images in the dicom dir
1710 * FIX : Bug fix for python use of dicom dir
1711 * ADD : a python demo
1713 2004-02-04 Jean-Pierre Roux
1714 * FIX : Final solution (?) for icone embedded images
1715 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1716 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1717 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1718 gdcmData/gdcm-MR-SIEMENS-16.acr1
1719 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1720 to make full checking easier
1722 2004-02-04 Benoit Regrain
1723 * FIX : WriteEntries : coding style & logic in parameters
1724 * FIX : Set the elements to create the DicomDir in a dictionary file
1726 2004-02-03 Benoit Regrain
1727 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1728 * gdcmDicomDir : add the load of directory
1729 * Bug fix and print add-on
1731 2004-02-03 Jean-Pierre Roux
1732 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1733 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1734 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1735 * FIX gdcmParser.cxx : 'group length' elements are now considered
1736 as integers, even for shadow groups, when file is Implicit VR
1738 2004-02-02 Jean-Pierre Roux
1739 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1741 of the last synonym :-(
1742 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1744 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1745 * FIX taking into account the possible 7fe0,0010 multiplicity
1746 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1747 to allow removal of references to 7fe0,0010, to deal with
1748 ACR-NEMA images, when 0028,0200 is meaningfull
1750 2004-01-31 Jean-Pierre Roux
1751 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1752 no longer writes 'Un' on disk
1753 * FIX SQ elements with actual length are now dealt with corectly
1754 * FIX gdcmFile::WriteBase make the difference, for color images, between
1755 the length (for Palette expanded images)
1756 and Raw Length (non expanded image + Palette)
1757 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1758 (that broke Write). Replaced by UL.
1759 Aware user will reload the field if he
1760 thinks it's necesssary
1762 2004-01-30 Jean-Pierre Roux
1763 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1764 when 'dirty Acr' is found, to be compliant with the new
1765 IsReadable() methods.
1767 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1768 (no DOUBLE images in kosher DICOM,
1769 but so usefull for people that miss them ;-)
1771 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1772 DICOMDIR related utilities (not checked as Windoze compliant)
1774 2004-01-28 Jean-Pierre Roux
1775 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1777 2004-01-27 Jean-Pierre Roux
1778 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1779 to allow skipping the shadow elements, to save memory space.
1780 The TRUE value for this param has to be used
1781 with a FALSE value for the 'enable_sequence' param.
1782 ('public elements' may be embedded in 'shadow Sequences')
1783 * gdcmHeader methods now deal with 'embedded icones images' in the header
1784 (even when an 'icone image sequence' is announced by the
1785 element (0x0088,0x0200), but there is NO icone at all ...
1787 * gdcmHeader sometimes Image Location value doesn't follow
1788 the supposed processor endianity (see gdcmData/cr172241.dcm).
1791 * gdcmHeader add the method
1792 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1793 to get *all* the Header Entries with the same tag.
1794 GetHeaderEntrySameName is probabely *useless*
1795 (no meaning : Name is *not* an identifier within the Dictionnary)
1797 2004-01-26 Benoit Regrain
1798 * Bug fix in the print of hexadecimal representations. Remove long fields
1799 in the print and add a third level of print to print them
1801 2004-01-23 Benoit Regrain
1802 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1803 * Bug fix on test suite after remove the strip made on not string fields
1804 * Split the IsReadable method between gdcmParser which test that the file
1805 is dicom and gdcmHeader which test that it's an image file
1807 2004-01-22 Benoit Regrain
1808 * DicomDir : clean code, add methods, set variables in protected or private
1809 * gdcmUtil : bug fix for the clean string method
1811 2004-01-19 Benoit Regrain
1812 * Add the use of shadow dictionaries
1813 * bug fix and coding style
1815 2004-01-19 Benoit Regrain
1816 * src/gdcmFile.cxx : bug fix concerning the close of file
1817 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1818 * Add the update of header entries using the shadow library
1820 2004-01-19 Benoit Regrain
1821 * removal of file gdcmHeader2.cxx
1822 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1823 inheriting from gdcmParser. This split is to prepare the integration
1824 of dicom dir parsing
1825 * bug fix under python
1827 2004-01-16 Jean-Pierre Roux
1828 * REM removal of class gdcmHeaderEntrySet
1829 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1830 * ADD add file gdcmHeader2.cxx
1831 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1833 2004-01-15 Benoit Regrain
1834 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1835 entries created while parsing the header. Thus, they will be destroyed
1836 when the gdcmDictSet will be destroyed
1837 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1840 2004-01-15 Benoit Regrain
1841 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1842 made a fatal error because of the memory release at the end of program.
1843 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1844 some memory and vtk seems to have some problems with that.
1845 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1847 2004-01-14 Benoit Regrain
1848 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1849 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1850 * src/*.[h|cxx] : make changes due to class name changes
1851 * gdcmPython/demo/*.py : bug fix due to method names
1853 2004-01-13 Benoit Regrain
1854 * src/*.[h|cxx] : coding style
1855 * vtk/*.[h|cxx] : coding style
1857 2004-01-13 Benoit Regrain
1858 * gdcmPython/testSuite.py : test the readable flag of file for tests
1859 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1860 It's lied to the stl compilation by MSVC (windows, always windows...)
1861 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1863 2004-01-12 Benoit Regrain
1864 * src/*.h : add comments
1865 * src/gdcmDictSet.h : set the method BuildDictPath in public
1866 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1867 directly setted in the source code
1868 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1871 2004-01-09 Benoit Regrain
1872 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1873 * setup.py : use a reference to gdcmVERSION
1875 2004-01-07 Benoit Regrain
1876 * Modification to compile with the distutils.
1879 2003-12-10 Benoit Regrain
1880 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1881 can use a gdcmHeaderHelper to load data
1882 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1883 made in the source code
1885 2003-12-10 Benoit Regrain
1886 * Update Windows projects and .cvsignore files
1888 2003-11-12 Jean-Pierre Roux
1889 * ENH gdcmHeader constructor has one more parameter (default value : false)
1890 that allows the user to 'go inside' the SeQuences only
1892 gdcmElValSet:Print takes it into account
1894 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1895 * ENH: Update gdcmPython/CMakeLists
1896 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1897 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1899 2003-11-10 Jean-Pierre Roux
1900 * FIX : gdcmHeader::LoadElements is now based
1901 on the ListTag listElem member,
1902 not longer on the TagElValueHT tagHt member
1903 * ENH : PrintPubElVal shows (temporarily) both results,
1904 with the tagHt member and the listElem member.
1905 (it's easier to 'see' the problems when using Printheader)
1907 * FIX : old private member LgrElem is now splitted into
1908 ReadLength : Length actually found on disk (updated only
1909 if bug fixing is necessary), for internal
1911 UsableLength : Updated by FixFoundLength, to fix a bug
1912 or to allow Parser going on.
1913 Will allow to re-write a kosher header when a SeQuence
1914 with a length (not 0000) is found
1915 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1916 because gdcmElValSet::Add does not update ListElem
1919 2003-11-07 Jean-Pierre Roux
1920 * FIX misstyping in Transfert Syntax name table
1921 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1922 when they have an actual length (not 0000 nor FFFFF)
1923 (Nobody should care of it, but DICOMDIR explorers)
1925 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1926 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1928 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1929 * ENH: vtkGdcmReader now supports LUT !
1930 (vtkgdcmViewer for now is not able to use them though)
1932 2003-11-05 Jean-Pierre Roux
1933 * in testSuite.py : new files names for checking the package
1934 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1935 that returns the pixel area size to the *aware* (vtk) user
1936 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1938 2003-11-05 Benoit Regrain
1939 * in testSuite.py : Modify the rules for checking the paths
1940 : Explicit error messages
1941 * in __init__.py : Related modif
1943 2003-11-03 Jean-Pierre Roux
1944 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1945 to be used by aware (vtk) users that want to manage
1946 LUT (and no to turn the PALETTE image into an RGB pixels one)
1947 * GetPixelType now returns 8U for 24 Bits images
1948 (vtkGdcmReader compliant)
1950 2003-10-31 Jean-Pierre Roux
1951 * Removal of *all* gdcmData images and add them again
1952 in order to loose the 'history' of un-anonymised images
1954 2003-10-31 Jean-Pierre Roux
1955 * RMV : removal of useless jBitsInJsample.h
1956 for both 8 and 12 Bits JPEG Lossy Libraries
1958 2003-10-31 Jean-Pierre Roux
1959 * ENH : Add the functions gdcmFile::GetImageDataRaw
1960 gdcmFile::GetImageDataIntoVectorRaw
1961 that act as GetImageData and GetImageDataIntoVector
1962 except the making of an RGB Plane from Gray Plane + LUT
1963 Intended to aware (vtk) users who know how to manage
1966 GetLUTRGBA return a R,G,B,A LUT if any
1967 lgrTotaleRaw gives the 'Raw' length
1968 GetImageDataRaw returns the gray Plane
1969 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1970 (They stay Grey, just like with other Dicom viewers :-(
1972 2003-10-30 Jean-Pierre Roux
1973 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1975 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1976 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1977 being coherents dicom files.
1979 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1980 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1982 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1983 * ENH: Two steps is necessary to please VC++ compiler...
1984 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1985 * ENH: Add include dir to medcon lib
1986 * FIX: only one function is being exported for now !
1987 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1989 2003-10-29 Jean-Pierre Roux
1990 * adding gdcmHeader::GetLUTRGBA
1991 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1992 --> Mathieu, the modif u're waiting for is not yet committed
1993 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1995 2003-10-27 Jean-Pierre Roux
1996 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1997 00191113.dcm DermaColorLossLess.dcm
1998 MxTwinLossLess.dcm RadBWLossLess.dcm
1999 * ENH: For version prior to vtkImageViewer2 -r 1.19
2000 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2002 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2003 * Removal of ido stuff in CMakeLists.txt
2005 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2006 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2007 * FIX: remove a call to ->Modified ... see comments
2008 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2010 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2011 * FIX: Problem with path for libvtkgdcmPython
2012 * ENH: Try adding a search script for python site-package
2013 * RMV: Remove some file from medcon lib that are not necessary
2014 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2015 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2016 * FIX: More pragma disable fro VC++,
2017 I don't think I break something as it is also disable in VTK/ITK.
2018 But it fasten debug compilation time.
2020 2003-10-23 Jean-Pierre Roux
2021 * gdcm now deals with 16 Bits Run Length Encoded images
2022 (they are compressed as 2 planes images,
2023 one for the high Bytes, the other for low Bytes)
2025 2003-10-22 Jean-Pierre Roux
2026 * Now CheckRead takes into account :
2027 - the bugged 'Leonardo' Siemens images
2028 - the XA images, sent thru the burning VPRO station
2029 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2032 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2033 * FIX: When copying a Makefile.am to CMakeLists.txt
2034 one should remove the '\'
2036 2003-10-22 Jean-Pierre Roux
2037 * in gdcmData adding a bugged 'Leonardo' Siemens image
2038 (wrong lengths in header)
2039 OK with gdcm, KO with the other viewers :-)
2040 * add a GE dlx XA image, thru the VEPRO burning station
2043 2003-10-21 Jean-Pierre Roux
2044 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2045 for a brutal checking of vtkgdcmViewer compliance
2047 2003-10-21 Jean-Pierre Roux
2048 * add the files for 'xmedcon' Jpeg Lossless library
2049 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2051 2003-10-21 Jean-Pierre Roux
2052 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2054 2003-10-21 Jean-Pierre Roux
2055 * garbage Siemens 'Leonardo' images dealt with
2056 (the patch is easy to remove)
2057 * cosmetic changes to avoid warnings
2059 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2060 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2061 no need to press 'r' now.
2063 2003-10-20 Jean-Pierre Roux
2064 * upgrade of checkRead.sh checkWrite.sh according
2065 to new Jpeg Lossless decompressor
2066 * add US.3405.1.dcm, a genuine RGB medical file ...
2067 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2068 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2070 2003-10-15 Jean-Pierre Roux
2071 * general anonymisation in gdcmData
2072 * adding the 'color files' from
2073 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2074 * adding some well knowed bugged-header images
2075 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2076 waiting for their inclusion in Python testsuite
2078 2003-10-15 Jean-Pierre Roux
2079 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2080 no longer seg faults when file is not found
2082 2003-10-14 Jean-Pierre Roux
2083 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2086 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2087 * TODO: *.in file to genereate a UseGDCM later
2089 2003-10-14 Jean-Pierre Roux
2090 * Some supposed-to-be Dicom Images have no preamble.
2091 OpenFile takes it into account
2092 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2093 * Missing elements added in dicomV3.dic
2094 (just to be affraid : have a look at
2095 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2096 and do it again next year ;->
2098 2003-10-13 Jean-Pierre Roux
2099 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2100 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2101 But there are NOT. It's fixed !
2103 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2104 * FIX: "jpeglib.h" was not found on VC++
2105 * FIX: vtkgdcm was not being installed
2107 2003-10-10 Jean-Pierre Roux
2108 * ENH : OpenFile closes the file if it *really* doesn't look like
2109 an ACR-NEMA / DICOM one.
2110 * FIX : testWrite no longer writes an empty file if the source file
2111 is not gdcm Readable
2112 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2115 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2116 * FIX: CMake generate now documentation
2117 * ENH: out of source doc build !
2118 * ENH: Generate both user and dev documentation
2119 * ENH: Should work on windows too
2120 * ENH: Only one doxygen config.in file is needed
2121 * FIX: make install should be ok now on ùnix plateform
2122 * FIX: PATH to dictionary was wrong (missing /)
2123 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2125 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2126 * vtkGdcmReader is now able to read rgb dicom file.
2127 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2128 * added a gdcmViewer to vtk test, use mouse to control
2129 window level & window width
2131 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2132 * CMake-ification of gdcm, we have now two build system
2133 * FIX: on cygwin Wsock32 doesn't exist
2134 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2136 2003-10-06 Emanuel Ollart
2137 * FIX : compilation process wad broken.
2138 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2140 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2141 * change gdcmViewer -> vtkgdcmViewer
2142 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2144 2003-10-06 Jean-Pierre Roux
2145 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2146 ( e.g : well known GE images with a wrong elem length,
2147 : Philips MRI Images with a wrong Huffman table)
2148 * still to be done : allow the reading of bugged LEONARDO Siemens images
2150 2003-10-03 Jean-Pierre Roux
2151 * Odd length strings are padded with '\0' (not with spaces,
2152 to remain compliant with already defined strings,
2153 like Transfert Syntax UID and others)
2155 2003-10-03 Jean-Pierre Roux
2156 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2157 to allow displaying RGB images (not only by affim ;-)
2159 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2160 * vtkGdcmReader is now able to read rgb dicom file.
2161 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2163 2003-10-03 Jean-Pierre Roux
2164 * A few nasty patches to allow the reading of a lot of nasty images
2165 ( e.g : well known GE images with a wrong elem length,
2166 : Philips MRI Images with a wrong Huffman table)
2167 * still to be done : allow the reading of bugged LEONARDO Siemens images
2169 2003-10-03 Jean-Pierre Roux
2170 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2172 2003-10-03 Jean-Pierre Roux
2173 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2174 to allow displaying RGB images (not only by affim ;-)
2176 2003-10-03 Jean-Pierre Roux
2177 * gdcmFile::GetImageDataIntoVector now
2178 - deals with MultiFrames MultiFragments Run Length Encoded files
2179 - deals with YcBcR (YBR_FULL) files
2180 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2181 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2183 (no sample found :-(
2185 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2186 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2187 Two reasons: - clear things
2188 - third parties acces gdcm through header files, so won't
2189 suffer anymore VC++ complains
2191 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2192 * add argv[1] in testvtkGdcmReader.cxx
2195 2003-09-24 Jean-Pierre Roux
2196 * The lines are now eigthy characters long.for
2197 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2199 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2200 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2201 char* to std::string. Thus, the use of strdup becomes useless. (see
2202 previous commis of Malaterre)
2203 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2204 before the last Malaterre's commit.
2206 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2207 * This commit should fix the Debug building under VC++, the problem
2208 was mainly a mixture of debug and release lib being loaded at startup.
2209 * I also remove a depency to a specific C function: strdup. Because I had
2210 to force the link to msvcrtd (whereas strdup is in libc).
2212 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2213 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2214 located in the gdcmCommon.h file. All use of reference of tha has been
2215 changed to now use the variable GDCM_UNFOUND.
2217 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2219 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2220 Dicom dictionary. The test suite can now be run again. Note:
2221 I'm note very happy with the " (RET)" changes. I believe this
2222 RETAINED comment should be dropped when parsing the dictionary.
2223 - PACKAGER corrected
2225 - AUTHORS updated and now in alphabetical order
2226 * Makefile.am now exports gdcm.dsw for Windoze users.
2228 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2229 * cygwin complains about missing std:: in subdir Test/
2231 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2232 * remove some methods that are now in gdcmHeaderHelper
2234 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2235 * vtkGdcmReader set spacing and origin correctly
2237 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2238 * Fix a few delete/delete[] mismatch
2240 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2241 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2242 interpretation to data given by gdcmHeader. For instance there are
2243 heuristics to get informations (look at different places).
2244 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2245 sorting DICOM images based on different strategies.
2246 * modified Makefiles accordingly.
2248 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2249 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2250 when building in debug mode
2251 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2252 src/win32/gdcmdll.dsp
2253 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2255 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2256 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2259 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2260 * src/win32/libgdcmjpeg12.dsp was not dos format
2261 * src/win32/libgdcmjpeg12.dsp :
2262 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2263 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2265 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2266 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2268 * src/gdcmFile.cxx : bug fix in affectation type
2269 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2270 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2271 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2272 symbols... future problem ?
2274 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2275 * src/win32/libgdcmijpeg12.dsp was missing
2276 * modified gdcm.dsw accordingly
2278 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2279 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2281 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2282 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2283 commit of JPR (before his hollidays to facilitate our work).
2284 * setup.py : bug fix in code. Modifications made while the last commit
2285 of JPR. The code hasn't been tested before the commit... it's so
2286 useless to make that (for best programmer that is JPR) !!!
2288 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2289 * tagged the current version as Version0_3 (i.e. version 0.3)
2291 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2292 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2293 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2294 * *.dsp : modifications to use new libgdcmijpeg8 library
2295 * setup.py : bug fix on VTKPATH variable
2296 * PACKAGER : adding all concerning windows
2298 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2299 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2301 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2302 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2303 test suite reported error.
2304 * PACKAGER file added (describes what a packager must do when
2305 packaging a new release).
2306 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2307 * configure.in: upgraded version number to 0.3.0
2308 * fixing build of rpm (through rpm -ta):
2309 - Doc/Makefile.am exports proper doxygen files
2310 - src/jpeg/libijg8/Makefile.am exports the include files.
2312 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2313 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2314 * src/gdcmHeader.h : formatting code
2316 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2317 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2318 We were obtaining error message from vtk. Now, creation of file list
2319 is made in an internal list to prevent this problem.
2320 Bug fix when output is empty.
2321 Bug fix in update of progress value. Previous commit for this was a bad
2323 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2325 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2326 * src/gdcmHeader.h : added method to get the file name
2327 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2328 files. Added method to remove all files on the input
2329 Added FIXME comment concerning the bad parsing of header made by
2330 ExecuteInformation method (in ExecuteData method)
2332 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2333 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2334 when using make instal.
2335 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2336 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2338 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2339 * setup.py : adding include dir of jpeg lib to compile all sources
2340 * */Win32/*.dsp : JPR fix for windows compilation
2342 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2343 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2345 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2346 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2348 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2349 * setup.py is again effective on un*x (takes into account the
2350 addon of the jpeg library)
2351 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2352 * Doc/Doxy* updated (includes above enhancements)
2353 * INSTALL now points to web documentation
2355 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2356 * src/gdcmHeader.h doesn't make unnecessary reference to
2358 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2360 * src/gdcm*.[cxx|h] :
2361 - to allow compilation with gcc 3.x
2362 -- clean up of STL usage (added explicit usage of std::)
2363 -- small fixes on exceptions.
2364 Note: linking not tested !
2365 - clean of doxygen comments to avoid warnings at documentation
2367 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2368 dependent convertion).
2370 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2371 * Clean up of previous JPR garbage commit (not even commented in the
2373 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2374 - moved all jpeg related files from src to src/jpeg/libijg8, with
2375 addition/modification of Makefile.am and configure.in.
2376 - the testSuite is still brain damage (not guilty).
2378 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2379 * WrapVTK.py : modifications to get correctly vtk source files to
2381 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2382 (FileName -> Filename)
2384 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2385 * vtk/vtkGdcmReader.[cxx/h]:
2386 - UpdateProgress method should now be effective
2387 - removed the limitation on having only images loaded (as opposed
2389 - when building a stack of images/volume, a lesser number of
2390 gdcmHeader and gdcmFile instances should be used (hopefully
2391 accelerating things).
2392 - when building a stack of images/volumes, files which are not
2393 loadable (wrong path-filename, wrong permissions on existing file,
2394 or file not parsable by gdcm) are replaced with a black image
2395 in the stack (for the caller to notice the problem).
2397 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2398 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2400 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2401 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2402 between standard library (std) and vtk library (problems are found
2403 under Windows... thanks Windows !)
2405 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2406 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2408 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2410 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2411 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2413 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2414 * When compiling with distutils (see setup.py) the C++ compiler is
2415 called with different flags than the default ones (with automake).
2416 In order to fix all those warning, I compiled gdcm with the command
2417 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2418 and went for warning fixes:
2419 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2420 up from unused variables.
2421 - vtk/vtkGdcmReader.cxx: potential bug fix.
2422 * src/gdcmHeader.h: Doxygen warning cleanup
2424 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2425 * gdcmPython/gdcm.i:
2426 - typemaps correction to take into account the systematic replacement
2427 of "using namespace std" with std:: prefix e.g. std::list,
2428 std::string... (cf changes of 2003-05-21).
2429 - gdcmGlob global variable of type gdcmGlobal (defined in
2430 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2431 exported to Python a as cvar.
2432 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2433 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2434 gdcmDictSet.GetPubDictTagNames() and
2435 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2436 C++ static methods).
2437 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2438 with the above changes.
2440 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2441 * setup.py, manifest.in : bug fix under linux
2443 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2444 * Modification of setup.py to compile vtk part too. Then, we have 2
2445 wrappers which must work with same distutils. For that, we have a
2446 generic distutils in distusiltsWrapping.py ; with :
2447 - build_extWrap class to wrap generically all extensions,
2448 - ExtensionWrap base class for all wrapping extension that contains
2450 - Wrapper interface which wrap sources
2451 + In WrapSwig.py we have extension and wrapper for Swig
2452 + In WrapVTK.py we have extension and wrapper for VTK
2453 * MANIFEST.in : modifications to consider vtk directory and new python
2454 files for compilation
2456 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2457 * Added python wrappers of vtkGdcmReader vtk class (see the
2458 source in vtk/vtkGdcmReader.cxx) :
2459 - vtk/Makefile.am now builds a library
2460 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2461 python library (as opposed to _gdcm.so wich are the python
2462 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2463 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2465 - configure.in has an additional flag --enable-vtk that needs
2466 to be set to enable compilation of vtk related code, that is:
2467 + vtk/vtkGdcmReader.so and
2468 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2469 + gdcmPython/vtkgdcmPython.so (see above)
2470 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2471 be read when compressed or when HighBit + 1 != BitsStored),
2472 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2473 the usage of the python wrapper of vtkGdcmReader vtk class.
2474 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2475 * src/*.[h] all occurences of stl classes are now prefixed with
2476 std::, and all occurences of "using namespace std;" where removed.
2477 This is to avoid pollution of global namespace in included files.
2478 Apparently vtk does not avoid this pitfall: when using both
2479 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2480 collision of various stl members (principally cout...).
2481 * gdcmPython/testSuite.py now cleanly removes temprory generated
2483 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2484 comply with above changes)
2486 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2487 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2488 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2489 vtk data structure (an image Flip was required).
2490 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2491 * cosmetic changes in documentation.
2493 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2494 * src/gdcmHeader.cxx: the constructor no longer exits when an
2495 unexisting file is given as argument.
2496 * The subdirectory Data (containing all the images used for the
2497 test suite) is not part of this repository anymore. A new module
2498 containing those images is now available at
2499 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2500 with the name gdcmData.
2501 All the python scripts (including the package initialisation file
2502 gdcmPython/__init__.py) were adapated to take this change into
2503 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2505 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2506 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2507 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2508 demo of the usage of this class.
2509 Compilation of this vtk part is only done when using the --enable-vtk
2510 at configure (or autogen.sh) stage.
2512 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2513 * More memory link related corrections and documentation fixes.
2515 - maximum info is obtained with a command of the form:
2516 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2517 --show-reachable=yes PrintHeader
2518 - the remaining reachable blocks seem to come from the STL
2519 allocation scheme through the usage of map and list. It looks
2520 like this memory cannot be freed but it is not a memory leak
2521 (in fact further invocation to the STL would recollect the
2522 unused memory allthough it cannot explicitely be freed).
2523 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2524 of displaying an image parsed with gdcm and displayed with VTK.
2525 Note: some images don't seem to work e.g.
2526 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2527 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2528 Allthough this weakens the semantics, it is a ditch attempt to
2529 make gdcm more thread friendly.
2531 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2532 * Memory link hunt (by using valgrind through the command
2533 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2534 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2535 gdcmHeader::_dicom_vr.
2536 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2537 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2539 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2541 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2542 * src/Makefile.am now exports all the necessary include files at
2546 * UpdateGroupLength replaced by new one
2549 * UpdateGroupLength re-written using H-Table
2550 (named UpdateGroupLengthNew untill checks are over)
2552 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2553 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2554 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2556 - gdcmHeader::GetPubElValSet removed.
2557 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2558 UpdateGroupLength, WriteElements, Write.
2559 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2560 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2561 carried the same semantics.
2562 - src/gdcmHeaderIdo.cxx changed accordingly.
2563 - gdcmFile::WriteBase now regroups all the codes from previous
2564 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2565 - enum FileType moved to gdcmCommon.h
2566 * src/gdcmHeader.cxx AddDefault trashed
2567 * gdcmGetXSize added
2568 * getimageDataSize now calls gdcmGetXSize
2569 * Test/*.cxx changed to agree with above changes
2571 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2572 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2573 (to avoid double call by end user).
2574 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2575 by end user, since gdcmHeader::gdcmHeader now handles it.
2577 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2578 * gdcm/Doc many doxygen changes:
2579 - Doxyfile now has two different versions, DoxyfileUsers that generates
2580 the html.users end users oriented documentation and
2581 DoxyfileDeveloppers that generates the html.developper developper
2582 oriented documentation.
2583 - README changed accordingly
2584 - requirement.txt removed (old design info moved to TODO).
2585 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2586 DoxyMainPage.txt, DoxyPython.txt provide more information.
2587 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2588 be updated by simply regenerating the docs with doxygen and copying
2589 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2590 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2591 all the tests in the form "if (<map>.count() >1)" were removed.
2592 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2593 ill-formed documentation sections.
2594 * src/gdcmHeader.cxx: ditto
2596 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2597 * setup.py fixed for un*x (needed macro for stdint.h)
2598 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2599 un*ces with sh-utils test utility.
2600 * gdcmPython/demo/test.py renamed to PrintHeader.py
2601 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2602 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2603 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2604 * src/gdcm*.cxx JPR's bad inclusion fixed.
2606 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2607 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2608 * gdcmPython/demo/test.py changed accordingly.
2610 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2611 * gdcmPython/Makefile.am fixed linking against libstdc++
2612 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2613 * Swig subdir (historical tests of swig version 1.3.17++) removed
2614 * Test/testChangeEntete.cxx some lines commented out in order to make
2616 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2617 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2619 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2620 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2621 hence the user doesn't need this explicit call.
2622 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2623 i.e. LoadElements() call removed.
2624 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2625 - src/Makefile.am declares the proper flag for g++.
2626 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2627 for adding user defined new tags.
2628 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2629 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2630 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2632 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2633 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2634 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2635 src/Makefile.am : the project should properly compile and install
2636 with the autotools, included the python wrappers part.
2637 * gdcm.spec.in : added a spec file for RPM packaging.
2639 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2640 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2642 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2643 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2644 to exported to the environement (see gdcmPython/testSuite.py
2646 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2647 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2648 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2649 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2650 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2652 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2653 * gdcmPython/__init__.py doesn't crash anymore when running in
2654 in InstallMode or PreInstallMode but with an environement given
2655 value of GDCM_DICT_PATH.
2656 * src/gdcmDictSet.[cxx/h] coding style.
2658 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2659 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2660 * src/gdcm.h general comments moved to TODO, and README
2661 * src/gdcm.h should now be seen as a user commodity (including it
2662 should suffice to fully use gdcm). It is nowhere including within
2663 any of the kernel files src/*.cxx and src/*.h.
2665 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2666 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2667 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2669 * src/gdcm*.cxx only include their corresponding include file
2670 (as opposed to gdcm.h)
2671 * gdcmPython/gdcm.i changed accordingly
2672 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2673 the autogen.sh generated "make snapshot" command to work.
2674 * autogen.sh removed history related references to crea package.
2676 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2677 * distutilsSwigCPlusPlus.py work around some swig portability
2680 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2681 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2682 was done in a last ditch attempt to get setup.py _really_
2683 operationnal. The python/gdcmPython layaout add the advantage
2684 of hidding away the python related distutils specific files
2685 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2686 Alas, the src directory was out of scope (i.e. it's relative
2687 position to setup.py was ../src) which made things impossible to
2688 handle (see previous version of python/setup.py). Crossing fingers...
2690 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2691 * python/setup.py now works on Un*x. (harder than I thougth)
2692 * python/distutilsSwigCPlusPlus.py can now have include files
2693 among the list of sources.
2695 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2696 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2697 * modifications in MSVC projects
2699 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * As stated by the first lines of Test/ExceptionAndPython/README, it
2701 looks like we can move back to original usage of exception within
2702 src/gdcm* and hence remove the errno stuff that was introduced
2703 as a quick and dirty fixture of this problem (added to the TODO).
2704 * Doc/Doxyfile configuration file for Doxygen and corresponding
2705 README file for usage added.
2706 * Test/testWrite.cxx added. This new test comes from a split of
2707 test.cxx that is now reverted to its original purpous i.e.
2708 testing the proper parsing of a Dicom related file.
2709 testWrite.cxx concentrates on testing the IO part of gdcm.
2710 * Test/bug1.cxx (containing a bug on WIn32) added.
2711 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2712 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2713 whose purpose is to publish the content of the TagNames of the
2714 Dicom public dictionnary were not accessible without an
2715 instance of class gdcmHeader.
2716 - those methods are now static methods of gdcmDictSet and hence
2717 require no instances at all to be invocated.
2718 - within gdcmDictSet this change required to change some method
2719 to class methods (i.e. are now static) among which SetDictPath
2720 (renamed to BuildDictPath) and LoadDefaultPubDict.
2721 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2722 the above changes by calling the new method classes of gdcmDictSet.
2723 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2724 the above to be effective.
2725 * python/gdcmPython: in order to wrap properly the above changes
2726 for Python, swig version now needs to be > 1.3.17.
2727 * python/gdcmPython/Makefile fixed to adapt itself to new
2728 configure/make shema introduced by Johan Montagnat (thanks for the
2729 contribution). Alas this Makefile cannot be turned into a proper
2730 Makefile.am without some heavy changes in the configure.in
2731 (for python dectection).
2732 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2733 now avoids publishing the empty entries.
2735 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2736 * python/setup.py : bug fix concerning install under windows
2737 ExtraPath reused :-P
2738 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2740 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2741 * Dicts/dicomV3.dic : remove double spaces !!!
2742 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2743 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2746 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2747 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2748 method. Doxygenation.
2749 * src/gdcm.h clean up of JPR spurious comments.
2751 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2752 * python/distutilsSwigCPlusPlus.py now properly collects the
2753 shadow classes generated by "swig -c++" (gdcm.py in our case)
2754 when using "python setup.py install".
2755 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2756 reexports the working classes.
2757 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2758 by the classical C errno scheme. This is to prevent an obscure
2759 behavior of the python wrappers when importing wxPython.wx prior
2760 to gdcmPython (which ended up in an abort call). An illustration
2761 of this oddity can be found in the Test/ExceptionAndPython
2762 subdir (see the README file). This problem probably due to
2763 an combination of g++ and dynamic loading.
2764 * added Test/ExceptionAndPython (see above)
2766 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2767 * Changed the layout of the python part to avoid bloating main
2768 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2769 i.e. the distutils arsenal. All the python related stuff is
2770 again in a python subdir, but the package itself is now in
2772 * setup.py was cleaned up:
2773 - pythonIncludePath removed
2774 - python setup.py bdist target is now functional.
2775 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2776 collision with other packages). gdcmPython/demo/*.py changed
2779 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2780 * python subdir moved to gdcmPython (preparation of distutils packaging).
2781 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2782 distutils installer is operational.
2783 * - gdcmPython/__init__.py now properly loads the swig generated
2784 shadow classes (from gdcm.py).
2785 - gdcmPython/demo/*.py changed to import the package gdcmPython
2786 instead of gdcmPython/demo/load.py.
2787 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2789 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2790 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2791 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2792 entries within the associated public Dicom dictionary resp. the same
2793 information but sorted by the fourth field (PAT, IMG, DIR) of the
2795 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2796 are now in the "???" group.
2797 - python/gdcm.i changed accordingly,
2798 - python/demo/printGroupedPublicDict.py added, that gives an example
2799 of the above new functionalities in Python.
2801 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2802 * src/gdcm.h, gdcmHeader.cxx:
2803 - historic references to glib's g_malloc and g_free (#defined)
2804 were definitively removed.
2805 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2806 * src/gdcmElValSet.cxx:
2807 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2808 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2809 - GetElValue(string) renamed to GetElValueByName.
2810 - Added GetElementByName(string).
2811 * src/gdcmHeader.cxx: added
2812 - GetPubElValRepByNumber(guint16, guint16)
2813 - GetPubElValRepByName(string)
2814 - GetShaElValRepByNumber(guint16, guint16)
2815 - GetShaElValRepByName(string)
2816 - GetShaElValByNumber(guint16, guint16)
2817 - GetShaElValRepByName(string)
2818 - GetElValRepByNumber(guint16, guint16)
2819 - GetElValRepByName(string)
2820 - GetElValByNumber(guint16, guint16)
2821 - GetElValRepByName(string)
2822 * Doc/requirements.txt added.
2824 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2825 * Test/Makefile building now depends on the one of libgdcm.so
2826 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2827 pixel data) aware which enables finding the address (offset) of
2828 the pixel data of JPEG encoded DICOM files. This leaves only a single
2829 file in the testSuite whose pixel data address (offset) is unknown.
2830 * python/testSuite.py changed accordingly.
2832 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2833 * VC++ has some strong limitations when working with the STL, as stated
2834 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2835 "Also note that some STL containers (map, set, queue, list, deque)
2836 cannot be exported. [...]
2837 Some STL classes contain nested classes. These classes can not
2839 This is caused by a designed limitation that once a template
2840 class is instantiated, it can not be re-instantiated and
2842 Since our usage of map<> is ubiquitous in gdcm, this "designed
2843 limitation" of VC++ is a pitfall.
2844 Hence the Python wrappers of gdcm cannot be incrementally linked
2845 against the c++ dynamic library. The dirty but only workaround is
2846 to forget about incremental link of dynamic libraries and to generate
2847 the Python wrappers library with the inclusions of the underlying C++
2849 The following modifications concern this matter on Win32/VC++:
2850 - wrapping python correct with standalone wrapped dll (don't use separate
2851 dll under windows !!!!)
2852 - python21_d debug mode enabled (ask Frog how to use it :-)
2853 - NO problem with having an STL member of class for example string in C++
2854 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2855 - Python test of dcmlib in Python is ok under windows on a large set
2857 * removed glib references
2858 * typedef's inserted in gdcm.i for correct swig type management
2860 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2861 * python/demo/*.py load.py extracted from test.py. Added explore.py
2862 that only displays required tags and testAll.py that parses all
2863 the files of the testsuite without using unittest.
2864 * python/testSuite.py other additional test on new files added.
2865 * Data/* new test files added accordingly to the testSuite.
2866 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2867 the vr in the file differs from the one of the dictionary.
2869 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2870 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2871 values, but limits itself to values which are below a user specified
2872 size (by default 1024 bytes).
2873 * python/gdcm.i : elements not loaded (because their size is above the
2874 user specified treshold) are exported with their TagKey as key of the
2875 python dictionary. This enables the testsuite to make some checks
2876 on the unloaded elements (since we have their offset and size).
2877 * python/testSuite.py
2878 - now tests for the existence and proper value of the pixel data
2879 - two new examples added.
2880 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2882 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2883 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2884 aware. See the strategy comments in gdcmHeader::FindeLength().
2885 * Test/test.cxx now accepts a filename as first argument.
2886 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2887 * python/testSuite.py changed to integrate test on above files.
2889 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2890 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2891 the vr was also RET.
2892 * python/testSuite.py more tests added.
2894 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2895 * python/testSuite.py unittest test suite added (uses Data)
2896 * Data/* dcm and acr files for the test suite.
2897 * glib dependance removed from un*x version. We now use ISO C99
2898 7.18 Integer types (see stdint.h)
2899 - python/Makefile, src/Makefile src/gdcm.h
2900 * src/ when an explicit vr (like dicom files) suddenly poped an
2901 implicit element we use to mark the underlying DictEntry of the
2902 concerned ElValue with "Implicit". This strategy was damageable
2903 too the public or provite dictionaries, since some of their vr
2904 would be changed. Since Header::FindLength heavily relies on the
2905 detection by Header::FindVR of falsely explicit elements, I
2906 added an extra ImplicitVr member to ElValue (boolean).
2907 The rest of the changes we the necessary adaptations.
2909 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2910 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2912 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2914 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2915 * Adaptation for porting to VC++:
2917 o forced to use std namespace (for string to be known)
2918 o all class use __declspec export style on WIN32
2919 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2920 (in stdlib.h on Win32 but in std:: for gcc)
2921 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2922 variable GDCM_DICT_PATH.
2923 * src/gdcmHeader.cxx verbose comments made discrete.
2925 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2926 * python/gdcm.i: added a typemap that converts a C++ hashing table
2927 to native Python dictionary.
2928 * python/demo/test.py:
2929 - now uses the native dictionary for exploration of gdcmHeader.
2930 - takes an optional filename argument (the file to parse).
2931 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2932 PubElVals hashing table.
2933 * Dicts/dicomV3.dic removed error prone trailing spaces.
2935 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2936 * Python wrapping process moved away from src/Makefile to
2937 newly created python/Makefile (as well as gdcm.i)
2938 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2939 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2940 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2941 from the environement variable GDCM_DICT_PATH (when existing).
2942 * src/gdcmDict::GetTag bug fix.
2944 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2945 * Straightforward temporary fixes for swig to build the python wrappers.
2946 src/Makefile now has a python working entry [by working we mean
2947 that we can import de shadow classes without errors].
2949 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2950 * hashtest.cxx removed (since allready in Test)
2951 * src/gdcmlib.h renamed to src/gdcm.h
2952 * src/dcm.i renamed to src/gdcm.i
2953 * src/Makefile prepared for python wrapping
2955 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2956 * src/gdcmHeader.cxx :
2957 - Parsing of header is now separated from loading of element values
2958 (see gdcmHeader::LoadElements).
2959 - general clean up of hopefully all file access (creation of
2960 ReadInt16 and ReadInt32)
2962 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2963 * src/gdcmHeader.cxx :
2964 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2966 - SetLgrElem renamed to SetLength
2967 - GetLgrElem renamed to GetLength
2968 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2969 * src/gdcmElValSet.cxx fixed both GetElValue methods
2970 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2971 due to IdoDude was cleaned out.
2973 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2974 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2975 concentrates on finding the value representation (when it exists).
2976 RecupLgr now only finds the element value length, and it avoids
2977 returning the unecessary skL (skipped length).
2978 Also, offsetCourant was simply removed (with taille_fich) since
2979 it was redundant with the File position internals (by using
2980 ftell and fseek). This also made skL (see above in RecupLgr) usage
2982 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2983 on the libido specificities which are handled through class
2985 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2988 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2989 * Truckload of changes. Parsing of header is barely functional
2990 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2992 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2993 * src/gdcmHeader.cxx many addons of low level methods
2995 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2996 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2997 and _IdDcmSWAP_LONG.
2999 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3000 * This corresponds to all the changes decided at the meeting of
3001 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob