1 2005-01-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
4 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
5 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
6 a string and should ask the global TS dict what are the propreties of
9 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
10 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
11 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
12 to swap the Swap Code, at parsing time, when we come out of group 0002
13 and Transfer Syntax is Big Endian
14 We should be able to read now 'true DICOM" Big Endian coded images
15 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
16 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
18 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
19 * Hopefully fix the bug on MacOSX and static global initialization.
20 This is the only -minor- patch I found that both please MacOSX and VS6.
21 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
22 but this would require a lot of change. Another approach would be that Global
23 create those string and GDCM_UNFOUND becomes a pointer to a string (which
24 gdcm::Global would destroy at exit).
26 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
27 * Fix bug on MacOSX with static initialization in a multy threaded
28 environment. static const string in a header file used to be ill
29 initialized provoquing the freeze of any tests. patch should solve this
32 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
33 * According to Benoit's suggestion, and without any objection from anybody
34 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
35 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
36 - method gdcmDicomDirObject::GetEntry() renamed as
37 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
39 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
40 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
41 you debug/warning message just as c++ streams which make them very convinient
42 to use. Once this is stabilize I will change the ostringstrem to be
43 redirected to a file (ofstream).
44 * Properly support C99 extension: __FUNCTION__ which allow us to display
45 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
47 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
48 * Removal of useless and dangerous methods :
49 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
50 GetDocEntryByName, GetEntryByName, GetDictEntryByName
51 * Removal of usless methods :
52 Dict::PrintByName, Dict::GetDictEntryByName
53 * Commenting out of probabely useless methods :
54 Dict::GetDictEntryNames()
55 Dict::GetDictEntryNamesByCategory()
56 DictSet::GetPubDictEntryNames()
57 DictSet::GetPubDictEntryNamesByCategory()
58 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
59 * ENH : Use dicomTS.dic as described in 2004 version
60 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
61 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
62 Add Accessors on VM (Value Multiplicity), and VM related methods
63 * ADD : Add a list of 'Dicom Attribute types', as found in
64 http://medical.nema.org/dicom/2004/04_15PU.PDF
66 * ADD : Add dicomGroupNameAbbreviations.dic
67 should be used to write a method to replace the former
68 Dict::GetDictEntryNamesByCategory()
70 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
72 to read in the file... and only it ! Length is the efective length of the
73 data in the DocEntry structure
75 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
76 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
77 And now use a static function call instead, with a global variable. i
78 This is much closer to the VTK approach. Hopefully should be bulletproof
79 and easier to use...hopefully
81 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
82 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
84 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
87 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
89 ValEntry, BinEntry, SeqEntry creation or replace
91 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
93 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
95 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
96 when specifying the VR
97 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
98 * src/gdcmDocEntry.cxx : amelioration of print
100 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
101 * ADD : Add the method Util::IsCurrentProcessorBigEndian
102 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
103 * ADD Method Document::ComputeGroupLength
104 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
105 in order to allow further VR modification by user
106 * REM : removal of once-called method File::WriteBase
107 integration of its code in formerly one-line method File::Write
109 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
111 replace the different values "??", "Unkn", "Unknown".
112 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
113 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
114 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
115 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
117 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
120 * Set the gdcm::Base class to some Printable classes
122 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * src/gdcmFile.[h|cxx] : add the Print method
124 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
125 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
126 * src/gdcmDocument.h : remove the PrintLevel informations
127 * Example/PrintFile.cxx : use the new gdcm::File::Print
129 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
131 problems when compiling with the python wrapping
133 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
135 writting in ImplicitVR
137 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
138 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
139 JPEG decompression, especially when dicom frames are split into several
140 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
141 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
143 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * src/gdcmHeader.cxx : change the initialisation of default header.
145 Now, this header is readable by gdm, e-film, DicomWorks
147 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
149 Rename Decompressed to Raw
150 * Use the API changes in gdcm::File.
151 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
154 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
156 each added entry in the header. Replace the 'Planes' field by the 'Number
159 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
161 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
163 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
165 At this time, this image isn't readable by e-film... waiting JPR help to
168 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
170 DocEntry. Now use methods of the Document !
172 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * Test/ShowDicomSeq.cxx : bug fix
175 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
177 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
178 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
179 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
181 * Test/TestCopyRescaleDicom.cxx : remove unused variable
182 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
183 containing found sequences
185 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
188 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
189 Some fields in BinEntry must be copied to not seg fault when making the :
190 gdcm::File *copy = new gdcm::File( copyH );
191 and tests are now made on good variables
193 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
194 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
195 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
197 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
198 * Add vtkGdcmWriter example and test
200 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
201 * Test/TestUtil.cxx : reformat the source code
202 * vtk/vtkGdcmReader.cxx : remove and change prints
203 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
205 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
206 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
208 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
210 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
212 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
214 by an eof to prevent all bad read of the file... and in this case, the
217 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
218 * Example/Volume2Dicom.cxx : comment unused variables
219 * Test/PrintDicomDir.cxx : comment unused variables
220 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
221 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
222 method that is redondant with AddEntry.
223 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
226 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * Bug fix due my last commit (compilation under Windows).
228 * Example/Volume2Dicom : bug fix in the file and reformatting source code
229 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
231 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
233 - Remove printf / sprintf
234 - include iostream AFTER gdcm so we don't get warnings
235 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
237 - Also remove tons of include from header files, hopefully this should
238 speeup the compilation time, since it was becoming a dog slow.
239 - Remove gdcm.h as it include way too many files and slow down compilation
240 (plus it is not up to date)
241 - remove 'using namespace std' this is BAD !
243 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * Remove memory leaks on the DicomDir
245 * Remove some useless data in DicomDirObject
246 * Add usefull methods in SQItem, to be complient withe the ElementSet
248 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
251 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
252 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
253 future, with convertion)
254 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
255 and ImageDataSize values. Remove the method to get the PixelReadConverter
256 from the output of the class
258 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
261 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
263 and vtkErrorMacro use.
264 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
266 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
269 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
270 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
271 The string leaves only in the fonction. So when we make a .c_str(), we
272 get the pointeur on the first element, element that will be destroyed
273 immediately after thee instruction.
274 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
275 file has been opened : the test must be made on the content of the
276 pointer and not directly on the pointer !
279 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
280 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
281 the python part recompiles
283 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
285 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
286 X session is killed (for my computer... it seems to not be identic on
289 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
290 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
291 avoid problems (otherwise, the difference test between the visible image
292 and the reference is incorrect. If the reference is greater than the
293 screen resolution, it's produce errors).
294 Can be used for only one image. Can be used with a visible flag.
295 * vtk/vtkGdcmReader.cxx : remove commented codes.
296 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
297 under windows at compilation
298 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
300 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
302 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
303 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
304 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
305 tests on the image size X, Y, Z
307 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
309 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
310 between the class name and the file name
312 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
313 * src/ : fix compilation warnings for the Write method (2 different
314 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
315 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
316 variable... create a static method in gdcm::Document to access to
317 this variable content.
319 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
320 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
321 file, to be accessed by other files (like gdcmFile). Remove commented
322 code. Move the change of the header to the gdcmFile, using the
324 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
325 To be sure of that (and simplify calls), the Write of the header now
326 gets a file name and not a file pointer (std::ifstream).
327 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
328 DocEntryArchive. Remove all open of the written file
330 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
333 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
334 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
335 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
337 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
338 some corresponding methods. Write correctly the file and check before
340 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
341 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
342 is now on RGB data (as before my last commit
343 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
345 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
347 Add a print information of the type of the entry
348 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
349 It was in the gdcmFile, and all write have been regrouped
350 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
351 Write correctly all dicom files (in decompressed mode only at this time)
352 * Test/ : test on files are now made using Raw data and not color data if
354 * Example/PrintFile.cxx : add more printings
356 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
357 * Amelioration of code, remove some code copy. For the loading of
358 BinEntry (in gdcmDocument), add the test to verify if the file is already
361 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
362 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
363 remove a DocEntry in the header (push an empty DocEntry)
364 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
365 lines. Bug fix in the initialization of the PixelConvert and the
367 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
368 use in TestCopyDicom (now this test can run under windows... but fails)
369 * Test/TestCopyDicom.cxx : amelioration of the test :
370 - test the pixels written
371 - add test points to quickly find where is the error
372 - can set a file name input and output in arguments
373 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
374 amelioration of the test output
376 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
377 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
378 all replaced DocEntry's
379 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
380 Now, each needed DocEntry to modify is duplicated, modified and inserted
381 to the header using DocEntryArchive. Thus, after save, we can restore the
382 header initial state.
384 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
385 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
387 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
388 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
389 correct to copy it. The DictEntry is specified at the DocEntry creation,
390 then, it musn't change in the time.
391 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
392 header correctly. At this time, the change is only made for the first
393 level of the Document. In the future, it might consider sequences.
394 The change is made by replacing a DocEntry by an other that is created
395 outside the class. The old value is kept. When we restore the header
396 status, the added DocEntry is deleted and replaced by the old value.
397 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
398 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
399 set the write type to explicit VR, implicit VR or ACR. Add methods to set
400 the write mode to native, decompressed or RGB (but not used at this time)
402 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
403 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
404 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
406 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
407 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
408 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
410 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
411 set because already copied when copying the BinEntry's of the header
412 * Test/TestAllReadCompareDicom.cxx : remove warnings
414 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
415 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
416 Two problems appear when doing it :
417 - with the gdcmFile : when the GetImageData method is called, the pixels
418 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
419 data (pixels). And each structure destruct the data when it's
420 destructed. So we have two destructions for the same data. To solve it,
421 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
422 data or not. If it doesn't own data, then they will not destroyed by
424 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
425 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
426 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
427 create a double destruction of the same DocEntry's. So, to solve it,
428 the TagHT is simply cleared and the DicomDir* elements are destroyed.
429 * TODO : add an entry concerning memory leaks in the DicomDir
431 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
432 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
433 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
436 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
437 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
438 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
439 after it have been deleted
441 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
442 * FIX: src/* fix the doxygen warnings.
443 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
444 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
445 was erroneously defined with a size of 15 instead of 16. [many thanks
446 to Jean Michel Rouet for pointing out this bug].
448 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
449 1. Finish merging JMR patch for writting DICOM from scratch
450 2. Fix -hopefully- bug with MONOCHROME and space vs null character
451 3. Use const ref when possible
452 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
453 5. A few more comments
454 6. CreateUniqueUID can now be called without parameter"
456 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
457 * ENH: Slightly bigger patch:
458 1. Getting toward full integration of JMR patch for writting dicom from scratch
459 2. Update Test to test part of this patch: CreateUniqueUID
460 3. File was not close properly in gdcmDict
461 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
462 5. Use of const ref instead of copy (speed issue)
463 6. Remove temporary (duplicate) string in TranslateToKey
464 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
465 8. Do not repeat virtual in subclasses
466 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
468 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
469 * Apply first patch toward better string comparison when dealing with broken
470 DICOM files. Essentially the string could be padded with a space instead
471 of a null character as defined by standard
473 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
474 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
475 because never used... and in the same time, that's remove some memory leaks
477 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
478 * src/gdcmFile.cxx : now delete the PixelConvert instance.
479 * In examples and tests : change the type of image data variables from void*
480 to uint8_t*. Remmove all delete on image data variables
482 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
483 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
484 Verify the file pointer value before open the file, and if it's not null,
485 a verbose message is generated.
486 Close correctly the file when the file isn't considered dicom-like. The
487 correctly close is a call to CloseFile.
488 When closing the file pointer, test if its not null to close the file.
489 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
490 file. For an uncompressed image, the copied data correspond in the least
491 case to the image size (calculated) or the image size specified in the
492 header. A verbose is generated if these two size mismatch
494 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
495 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
496 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
497 break under windows (with msvc6 compilation).
499 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
500 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
501 compiling with MSVC6)
503 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
504 * Bugs fix for the Windows build with VC6
505 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
506 needed (only for projects required VTK). If the VTK is included in all
507 projects, there is conflicts with the jpeg lib of vtk when compiling the
508 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
509 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
510 when compiling the gdcm_wrap.cxx file (created by the compilation of the
512 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
513 (like it's already made for the cout use). Otherwise, conflict with the
516 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
517 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
519 - comments on the DicomDir::Method related usage added.
520 - now that we use the namespace gdcm, a lot of internal classes do
521 NOT need to be wrapped anymore.
522 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
523 DicomDir::Method) new example added.
525 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
526 * Improve string manipulation. I now inforce the notion of 'DicomString'
527 A DicomString can contain as many \0 as they want
528 and it is *always* of even length.
529 We only support odd length for very rare case.
530 And in the near future this should be removed.
532 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
533 * /binary_write/ gdcm source. Now even on big endian we are writting
534 little endian. This should -heopfully- fix some tests
536 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
537 * Now the dictionary is compiled into gdcm lib. This is a default
538 behavior, thus any dic file specified is picked before failback to
539 the one comiled into lib
541 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
542 * Change internals for gdcmDict. Don't use any 'new' any more.
543 This should definitely solve any leak problem, and we should be
544 as fast as before, as long as don't modify too much the dictionary.
546 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
547 * STYLE: ivars should start with a capital letter.
548 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
549 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
551 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
552 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
553 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
554 new 2004 dictionaries added (thanks to JPR).
555 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
556 * CLEANUP_ROUND (15) for gdcmPixelConvert
557 - RLEFrame::NumberFragments is now of type unsigned int
558 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
559 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
562 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
563 * Initial work in gathering all transfer syntax accessors. clearly
564 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
565 ivars, but only one transfersyntax (class) ivar with equivalent method on
568 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
569 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
570 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
571 discussed (plus I didn't like having a 2000 lines patch not commited)
573 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
574 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
575 * CLEANUP_ROUND (14) for gdcmPixelConvert
576 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
577 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
578 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
580 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
581 anymore and hence avoids storing a copy of PixelConvert::Decompressed
582 into File::Pixel_Data.
584 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
585 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
586 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
587 * CLEANUP_ROUND (13) for gdcmPixelConvert
588 Substituted File::ParsePixelData() with PixelConvert::Print() new
590 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
591 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
592 method to those classes.
593 - src/gdcmFile.[cxx|h]:
594 -- Added a ::Print() method.
595 -- PixelConverter is now a reference instead of a member.
596 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
597 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
599 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
600 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
601 collaboration diagram and inheritance diagram should be generated with
603 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
604 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
605 pointlessly wrapped (see
606 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
607 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
608 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
609 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
610 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
611 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
612 -- File::Initialise: PixelConverter setup moved away to
613 PixelConverter::GrabInformationsFromHeader()
614 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
615 interpretation moved away to PixelConverter::BuildRGBImage()
617 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
618 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
619 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
621 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
622 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
623 displayed on Win32 when a brutal abort() occurs (because of uncatched
624 exception). See TODO new entry of this commit for more on this.
625 * TODO added new entry.
626 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
627 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
628 - HandleColor is no longer called from gdcmFile.cxx
629 - gdcmPixelConvert.cxx clean up on method arguments and internal
630 variable names for semantical coherence.
632 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
633 * Finished lossless transition, not only do we now read all lossless jpeg
634 images, without the need of the Cornwell lib, but we do read them properly now
635 * To reduce code (well to avoid code duplication), I defined a common place
636 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
637 redefine symbols. This is not perfect but this the best solution I found for a
638 compilation time jpeg option.
640 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
641 * Update jpeg ijg lib to support lossless jpeg implementation
642 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
644 * Also added a special copyright for dcmtk since we use their bugfixes.
647 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
648 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
649 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
650 matters, as stated in warning note at begining of %include section).
651 * src/gdcmDicomDir*.[cxx|h]: coding style
652 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
653 * src/gdcmJpeg8.cxx: doxygen fix.
654 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
655 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
656 from File:: to PixelConvert::.
658 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
659 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
660 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
661 - more code moved away from File:: to PixelConvert::
662 - fat setup of PixelConverter set in place in File::Initialise.
664 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
665 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
666 namespace at the file system level. So now you should convert your examples
668 gdcmHeader -> gdcm::Header
669 It would be nice if people keep in mind to no open the namespace, since it
670 allows compilation on broken plateform which were defining common symbol in
671 the standart namespace (like LP, Unknown ...)
673 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
674 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
675 The JPEG fragments are now parsed at the same stage than the RLE
676 information. All code related to JPEG is now in gdcmPixelConvert:
677 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
678 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
679 export a gdcmFile:: method. Those are simply global functions
680 (for the time being this is better than having them attach to
681 either gdcmFile:: or gdcmPixelConvert::).
682 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
683 and stores the result in a gdcmJPEGFragmentsInfo.
684 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
685 code (among other stuff) moved away from gdcmFile:; to
688 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
689 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
690 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
691 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
692 clean up of RLE related code.
693 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
694 - src/gdcmRLE.cxx removed
695 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
696 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
697 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
698 * CLEANUP_ROUND (9) for gdcmPixelConvert
699 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
700 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
701 away from gdcmFile:: to gdcmPixelConvert::.
703 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
704 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
705 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
706 This is because Parse7Fe0 used to parse the pixels to compute the
707 length. This task was passed over to FindDocEntryLengthOB() a long
708 time ago, EXCEPT I had forgotten the OW case...
709 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
710 we just recylce the code for parsing RLE fragments and computing
712 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
713 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
714 with the retired Parse7Fe0().
715 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
716 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
718 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
719 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
720 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
721 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
722 - src/CMakeLists.txt: alphabetic order reodering + new entries.
723 * CLEANUP_ROUND (4) for gdcmPixelConvert
724 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
725 to return an unused length.
727 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
728 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
729 this should be cleanner from the plane view. The iostream are erally a pain
730 to use to do simple stuff.
732 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
733 * Redo the compilation of the ijg jpeg library. Now only one source is
734 necesseray. No need to rename file by hand what so ever. CMake handle the
735 copying of the file within different directory, configure header file to
736 modify some symbol. The only addition made to ijg wasd a mangle table so
737 that symbol are different wether we are within 8bits or 12bits.
739 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
740 * Added documentation of vtkgdcmReader on Website:
741 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
742 with it's binary name).
743 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
744 the Website to be more complete.
745 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
746 doxygenated documentation.
747 - Doc/DoxyVtkGdcmReaderExamples.txt added
748 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
749 DoxyVtkGdmReaderExamples.html )
750 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
751 * CLEANUP_ROUND (3) for gdcmPixelConvert
752 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
754 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
755 * CLEANUP_ROUND (2) for gdcmPixelConvert
756 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
758 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
759 * CLEANUP_ROUND for gdcmPixelConvert:
760 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
761 - src/gdcmPixelStuff[h|cxx] removed
762 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
763 - src/CMakeLists.txt changed accordingly
765 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
766 gdcmVersion.py moved to newly created ATTIC related
767 gdcmPython/SetupOldies/ directory.
768 * Autotools clean up:
769 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
770 - autogen.sh configure.in acinclude.m4 python.m4 removed
772 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
773 * src/*.cxx *.h Reference to License.htm fixed to License.html.
774 * Doc/CMakeLists.txt, doxygen.config.in: fix.
775 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
777 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
778 * TODO updated with Mathieu suggestions. I proposed a template for
779 describing TODO entries and used it for new entries.
780 * Added Doc/Website/CodingStyle.html, Developpers.html,
781 DeveloppersPython.html, GdcmDataCvs.html and
782 DownloadVersion0_1.html, DownloadVersion0_3.html.
783 * Some Doc/*.txt Doxygen files (which do not really concern the
784 documentation itself, but the website) moved to html and
785 placed in directory Doc/Website:
786 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
787 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
788 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
789 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
790 * CMakeLists.txt changed accordingly.
791 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
792 DeveloppersPython.html
793 * INSTALL nows refers to Doc/Website/Installation.html
795 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
796 * Added Doc/Website directory, that contains a first raw version
799 2004-09-23 Jean-Pierre Roux
800 * FIX In order not to be poluted any longer by casting problems,
801 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
802 we can now delete[] it safely
803 * VoidArea is now called BinArea (less confusing name),
804 and all the methods called ...VoidArea... are now ... BinArea...
805 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
807 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
808 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
809 clear) TagHT, which is an inherited member of gdcmElementSet. It is
810 up to the destructor of gdcmElementSet to clean up TagHt and it's
813 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
814 * Test/CMakeLists.txt: update to follow gdcmData renamings.
815 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
817 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
818 * ENH: added some utility method that builds a flat dictionnary
819 holding all the Dicom entries contained in the recursive structure
820 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
822 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
823 BuildFlatHashTable() that build a flat dictionary.
824 - src/gdcmElementSet.h: added a new private GetTag() accessor.
825 gdcmDocument is now a friend of gdcmElementSet.
826 - src/gdcmElementSet.cxx: clean up.
827 - Example/FlatHashTablePrint.cxx added.
828 - Example/CmakeLists.txt changed accordingly
830 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
831 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
832 moved away from gdcmDocEntrySet (since this class is an abstract class
833 acting like an interface). SQDepthLevel and BaseTagKey are now
835 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
836 and associated accessors. Doxygenation of the class.
837 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
839 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
840 Use SQDepthLevel accessor instead. ::Print() adapted.
841 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
842 - src/gdcmDocument.cxx changed accordingly.
844 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
845 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
846 - The following is the doxygen comment of the typedef declaration
847 of gdcmagKey in src/gdcmCommon.h:
848 gdcmTagKey is made to old an "universal" (as in URL, Universal
849 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
850 A dicom tag allways has a group and an element, but a set of tags
851 embeded in various (optionally nested) sequences and sharing
852 the same group and element all share the same (group, element)
853 "identifier". Hence the (group, element) cannot be used as an
854 identifier (in gdcm we shall refer to a "TagKey") of a tag.
855 In order to construct a proper tag identifier (i.e. a key) we
856 consider the following definition of a TagKey:
857 - let Group, Element be the string representation of the
858 group and element dicom tag members,
859 - let ItemNumber be the string representation of the integer
860 index of the considered item number of a sequence,
861 Let the key of a tag embeded in a sequence, noted SeqTag, be
863 /ItemNumber#Group|Element
864 where "/", "#" and "|" are characters acting as separators.
865 Then the general form of a gdcmTagKey is given by:
866 Group|Element<SeqTag>
867 where <SeqTag> means NO or many instances of SeqTag.
868 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
871 but the gdcmTagKey of a tag "embeded" is the first item of
872 a sequence, itself nested in the third item of a sequence is the
874 0004|1220/2#0008|0082/0#0008|0090
875 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
876 order to hold the new sequence compatible key. Previously, the
877 GetKey() method would look in the underlying gdcmDictEntry.
878 - src/gdcmDocEntry.cxx:
879 -- constructor now copies the underlying DictEntry key, in the local
881 -- ::Print: displays the member Key, instead of the (group, element).
882 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
883 - src/gdcmDocEntrySet.h:xi
884 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
885 -- now has a new BaseTagKey member.
887 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
888 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
890 This poses the problem with the semantics of the following lines
891 LoadEntryVoidArea(0x0028,0x1201); // R LUT
892 LoadEntryVoidArea(0x0028,0x1202); // G LUT
893 LoadEntryVoidArea(0x0028,0x1203); // B LUT
894 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
895 to the long FIXME note for what the problem is. Nevertheless in
896 order to get things working the dicom dictionary was altered !
897 Please fix things urgently...
898 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
899 information), see above note on moving the member VoidArea. Nevertheless
900 the following entries previously correctly set as US are now inproperly
902 0028 1201 OW IMG Red Palette Color Lookup Table Data
903 0028 1202 OW IMG Green Palette Color Lookup Table Data
904 0028 1203 OW IMG Blue Palette Color Lookup Table Data
905 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
906 of gdcmDocEntry moved to gdcmSeqEntry.
907 * src/gdcmSeqEntry.cxx: STYLE.
909 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
910 * Test/TestAllEntryVerify.cxx minor fix and added comments.
912 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
913 * gdcmPython/testSuite.py: all the test suite in python is now moved
914 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
915 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
916 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
918 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
919 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
920 to avoid inclusion recursion until STL is reached.
921 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
922 mecanism. errno.h is not included in gdcm anymore.
923 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
924 (gdcmFormatError now inherits from gdcmFormatUnexpected).
926 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
927 gdcmData/TestAllEntryVerifyReference.txt
928 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
929 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
930 exception_on_error parameter.
931 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
932 - vtk/vtkGdcmReader.cxx changed accordingly,
933 - Example/*.cxx and Test/*.cxx changed accordingly.
935 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
936 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
937 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
938 enable_sequences removed from gdcmHeader constructor and dependencies.
939 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
940 * gdcmPython/demo/PrintHeader.py: dummy fix.
941 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
942 skip_shadow removed from gdcmHeader constructor and dependencies.
943 * Example/*.cxx and Test/*.cxx changed accordingly.
945 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
946 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
947 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
949 2004-07-21 Jean-Pierre Roux
950 * FIX Now, Parsing and Printing a DICOMDIR do work!
951 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
953 2004-07-20 Jean-Pierre Roux
954 * FIX Some brain damaged headers have Zero-Lenght fields
955 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
957 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
958 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
959 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
960 variable (instance of gdcmDebug) by a definition macro, and the instance
961 is now in static in the gdcmDebug class
962 * src/gdcmSQItem.h : (FIXME) remove an undefined method
963 * Test/PrintAllDocument.cxx : bug fix in the result of the test
965 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
966 * WARNING: ctest now depends more tightly on gdcmData. You should
967 check out gdcmData properly for things to run smoothly...
968 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
969 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
970 we need the pixels not be loaded in order to use the ValEntry
971 that displays position and size).
972 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
973 This is a C++ based equivalent of gdcmPython/testSuite.py that should
974 be deprecated. If you have any doubts about the advantages of a
975 modern scripting language (read Python) versus grass root C++ (i.e.
976 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
977 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
978 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
979 Anyhow, consider documenting the gdcmData images in
980 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
982 * Test/CMakeLists.txt:
983 - now uses TestAllEntryVerify.cxx
984 - specific comments on oldACR00001.ima (now renamed in gdcmData
985 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
986 gdcmData/TestAllEntryVerifyReference.txt
989 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
990 * src/*.[h|cxx] : typedef clean up
991 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
992 - TagKey renamed to gdcmTagKey (for external usage)
993 - VRKey renamed to gdcmVRKey (for external usage)
994 - removal of typedef duplication.
995 - Removed all unecessary inline keyword from class inline definitions.
996 - Some method|function(void) declarations replaced with method|function().
997 * src/jpeg/libijg12/jdhuff12.c:
998 - printf polluting ctest removed.
999 - TAB removal for comminting
1001 - TestAllReadCompareDicom.cxx: added a test that compares all the
1002 images in gdcmDataImages.h with corresponding images in
1003 gdcmData/BaselineDicom/. When baseline images are not present
1004 this test creates them.
1005 Note: we need to validate each reference image, but before that
1006 I'd like to rename them with a more explicit name...
1007 - CMakeLists.txt: changed accordingly.
1008 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1009 including each header needed).
1011 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1012 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1013 test suite to the Example directory. Are concerned:
1018 - TestWriteSimple.cxx
1019 * Test/CMakeLists.txt: added some comments on reasons for black listing
1020 image gdcmData/oldACR00001.ima
1022 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1023 * Test/CmakeList.txt: removed the following from black list (to be coherent
1024 with removal from gdcmData):
1025 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1026 - gdcm-MR-PHILIPS-16.dcm
1028 Added the following because after last cvs update, they cause
1029 ctest -R TestReadWriteReadCompare
1031 - gdcm-MR-SIEMENS-16-1.acr
1033 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1034 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1035 new comments in this file) we temporarily (sigh) move to a weaker
1037 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1038 we don't need to black list the following images anymore:
1039 - 8BitsUncompressedColor.dcm
1041 - US-PAL-8-10x-echo.dcm
1042 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1043 fixes and the beautified code ;-)
1044 This fixes the bug introduced in version 1.42 (when beautifying)
1045 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1046 Note: ctest was blind to this bug (this means we need to still
1047 improve the test suite). The bug could be detected by using
1048 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1050 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1051 and by displaying the (garbage) produced file temp.XDCM...
1053 2004-06-29 Jean-Pierre Roux
1054 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1055 - replace by uggly but working old code :-(
1056 A lot of things should be OK again.
1057 It's really urgent to have a test suite that *tests*,
1058 to prevent Frog's beautifying sessions to break all the stuff
1059 (twice, withing a fortnigh ...)
1061 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1062 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1063 redundancy) to added Test/TestReadWriteReadCompare.cxx
1064 * Test/CmakeList.txt: because the compare test of
1065 Test/TestReadWriteReadCompare.cxx fails, the following images are
1066 black listed: - 8BitsUncompressedColor.dcm
1068 - US-PAL-8-10x-echo.dcm
1069 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1070 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1071 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1072 and ad-hoc kludge. This kludge is now removed, and on encountering
1073 such an image (OB field brain damaged) we set errno. Then in
1074 ::FindDocLength() we "fix" the length as being ALL what remains
1075 in the file (until EOF). We then proceed, hoping for the best...
1076 This fixes a SegFault in ShowDicom when trying to write such an
1078 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1079 (because TestWriteRead breaks on it, after a non conformal commit?).
1080 ctest now runs properly, except for MakeDicomDir (which was allways
1081 broken) and the Python related stuff (still not fixed).
1083 2004-06-24 Jean-Pierre Roux
1084 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1085 FIX : Test/TestReadWrite now iterates on all the file names
1086 (instead of infinite loop)
1087 ENH : Test/TestWriteRead now iterates on all the file names
1089 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1090 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1092 2004-06-24 Jean-Pierre Roux
1093 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1094 when SamplesPerPixel =3
1095 - now Write is no longer confused by
1096 'BitsAllocated = 12" and 'BitsStored=12"
1097 - "UN" value representation Elements are now written correctly
1098 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1099 ENH : - now gdcmHeader has its own Write methods
1100 (in order to split the job that has not to be done
1103 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1104 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1105 loop on the same image until memory went out.
1106 Note: this means we still have gobs of memory loss in PrintDocument
1107 * src/gdcmDocument.cxx: fixes problem on parsing on file
1108 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1110 2004-06-24 Jean-Pierre Roux
1111 FIX : Write - All the Sequences and Sequence Item are now written
1112 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1113 is added a the end, when necessary.
1114 - A lot of brain-damaged images, that were read correctly are
1115 now written correctly
1116 - length compatible BinEntry are now loaded correctly
1117 (even for odd groups)
1118 Note : only Explicit Value Representation was checked.
1119 (question : is implicit VR really necessary for gdcm ?)
1121 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1122 * DEVELOPPER: added a proposition of coding style.
1123 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1126 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1127 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1128 Use the gdcmDocEntry::Print() and Write() instead.
1129 * src/gdcmDocument.cxx: bug fix.
1131 2004-06-22 Jean-Pierre Roux
1132 FIX : gdcmDocument.cxx
1133 - Now we do recognize the JpegLossLess format (there was a misstyping in
1134 code 'beautyfication' :-(
1135 - Now we automaticaticaly load the Luts, if any
1137 2004-06-22 Jean-Pierre Roux
1138 In order : to write Sequences, whatever their imbrication level,
1139 : to allow user to create his own Sequences
1140 a lot of modif where necessary (adding, moving, or virtualising methods)
1142 WARNING : save your own sources *before* cvs up !
1145 ADD virtual void Write(FILE *fp, FileType filetype);
1148 ADD virtual void Write(FILE *fp, FileType filetype);
1149 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1152 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1153 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1154 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1155 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1156 ADD std::string GetEntryByName(TagName name);
1157 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1159 std::string vr = "unkn",
1160 std::string fourth = "unkn",
1161 std::string name = "unkn");
1162 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1163 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1164 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1165 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1166 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1167 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1168 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1169 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1172 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1173 ADD virtual std::string GetEntryByName (TagName tagName);
1174 ADD virtual std::string GetEntryVRByName (TagName tagName);
1175 REM virtual bool Write(FILE *, FileType);
1176 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1177 FILE *_fp, FileType type);
1178 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1179 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1180 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1181 REM virtual std::string GetEntryByName (std::string tagName);
1182 REM virtual std::string GetEntryVRByName (std::string tagName);
1183 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1184 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1185 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1187 std::string vr = "unkn",
1188 std::string fourth = "unkn",
1189 std::string name = "unkn");
1190 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1191 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1192 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1193 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1196 ADD virtual void Write(FILE *fp, FileType filetype);
1199 ADD virtual void Write(FILE *fp,FileType filetype);
1202 ADD virtual void Write(FILE *fp, FileType filetype);
1203 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1204 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1205 REM std::string GetEntryByName(TagName name);
1208 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1210 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1211 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1212 The default constructor invoked by the line
1213 gdcmHeader *f1 = new gdcmHeader( header );
1214 was gdcmHeader::gdcmHeader(bool) instead of the expected
1215 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1216 Hence the parsing wasn't executed... See also below.
1217 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1218 as explicit constructor didn't do the trick to fix the above problem.
1219 Could anyone explain why ?
1220 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1221 properly calls gdcmValEntry::Print() (that was weed out from
1222 code related to gdcmBinEntry).
1224 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1225 * In order to fix memory leaks:
1226 - Test/TestWriteSimple.cxx: added cleaning of free store through
1228 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1229 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1230 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1231 (through the call to ::AddDicomDirMeta()) or the destructor
1232 would crash when deleting uninitialized ::metaElems].
1233 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1234 - src/gdcmDocument.cxx:
1235 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1236 from dynamic stores.
1237 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1238 was causing memory leaks.
1239 - src/gdcmSQItem.cxx:
1240 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1241 cleanly handled with polymophism: sorry but my milage is low).
1242 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1243 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1244 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1245 This avoids SegFaulting.
1246 - src/gdcmSQItem.h: coding style.
1248 - Test/TestWriteSimple still severely sucks. The output image content
1249 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1250 damaged when displayed with vtkgdcmViewer.
1251 - on memory leaks: TestWriteSimple leaks really less (see entry
1252 of 2004-06-18 in Changelog file for the call to valgrind).
1253 - on segfaults: ctest now passes all the tests but one (no more
1255 * Erroneous leading white fix:
1256 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1257 white[s] (as opposed to from >> xxx, that removes it [them].
1258 - src/gdcmTS.cxx: ditto.
1259 - gdcmPython/testSuite.py: dirty related kludge removed.
1260 * src/*: remaining references to gdcmParser removed.
1261 * src/*[cxx|h]: added copy[way]left header.
1264 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1265 * In order to fix writing of dicom files:
1266 - Test/TestWriteSimple.cxx: a simpler example of writing.
1267 - Test/CMakeLists.txt changed accordingly.
1268 - src/gdcmDocument.cxx:
1269 -- The destructor now recursilvely removes potential sequences.
1270 -- Bug fix in ::IsJPEG2000()
1271 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1272 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1274 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1275 to only declared) and build on top of
1276 ::GetDocEntryByNumber(guint16, guint16).
1277 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1278 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1279 for usage in destructor and treatement of promotion in
1280 ::ReplaceOrCreateByNumber().
1281 - src/gdcmSQItem.cxx: destructor should better handle his job.
1282 Test/TestWriteSimple now runs (or at least it DOES something).
1283 * We can now start hutting memory links. A good starting point is:
1284 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1285 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1286 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1288 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1289 * Valgrind note: after Mathieu Malaterre teached me how to read
1290 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1292 Using gcc, you can force the STL to use malloc and to free memory as
1293 soon as possible by globally disabling memory caching.
1294 With 3.2.2 and later, you should export the environment variable
1295 GLIBCPP_FORCE_NEW before running your program.
1296 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1297 simply vanish (it is still not clear to me, whether this means that
1298 STL std::string leaks or if valgrind believes it leaks...).
1299 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1300 running bin/gdcmTests makeDicomDir):
1301 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1302 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1304 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1305 SegFaulting (I drowned in DicomDir related code when trying to
1306 understand why the list is empty...).
1307 * src/gdcmDocument.h: first BSD license header try.
1308 * Doc/License.txt added.
1310 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1311 * src/gdcmDocument.[h|cxx]:
1312 - Clean up of the Transfer related predicates. They are now all based
1313 on new method isGivenTransferSyntax, that (should) handle properly
1314 the padding problem.
1315 - general clean up, simplification, and coding style.
1316 - Specific clean up of Parse7FE0() (umproperly named actually).
1317 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1319 2004-06-14 Jean-Pierre Roux
1321 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1322 - fix the display of SQItem ordinal number
1323 - add the GetSQItemByOrdinalNumber method
1324 - remove some useless never written private methods
1326 2004-06-14 Jean-Pierre Roux
1328 - adding a constructor taking a gdcmDocEntry as an input param
1329 - ReplaceOrCreateByNumber now returns :
1330 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1331 a gdcmValEntry * if a string value is passed as a param
1333 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1334 according to the param type (no longer sets a gdcmDocEntry)
1335 - GetValEntryByNumber, GetBinEntryByNumber added
1336 - NewValEntryByNumber and NewBinEntryByNumber added
1338 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1340 - GetSQItemNumber and SetSQItemNumber added, to provide
1341 a (relative) Item identier inside a given Sequence
1342 \warning : some pb remaining around this number
1344 - AddEntry now takes the Item Number as a param
1346 - adding a constructor taking a gdcmDocEntry as an input param
1348 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1349 * Memory leak hunt with the following command:
1350 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1351 --show-reachable=yes gdcmTests PrintDocument
1352 It looks like many (all?) leaks are due to the STL (or a bad usage
1353 of the STL. The lines producing the leaks now have a comment with
1354 a "MEMORY LEAK" tag: you can retrieve them with
1355 grep "MEMORY LEAK" src/*
1356 Here are two typical examples which I can't help fixing:
1361 char * test = "babo";
1362 name = test; //// <--- valgrind detects 960 bytes lost in
1363 //// call to std::string::operator=(char const*)
1364 name.clear(); //// Doesn't help !
1372 std::cout << "Type a bunch of characters followed by RETURN: ";
1373 getline(std::cin, line); //// <--- valgrind dectects a loss
1374 //// of 1320 bytes in call to
1375 /// std::basic_istream<>& std::getline<>
1381 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1382 * src/gdcmHeader.[cxx|h]:
1383 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1384 and related, moved away to gdcmDocument.
1385 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1386 the corresponding protected accessors of inherited class
1387 gdcmDocument, removed ! As a consequence gdcmFile had to be
1388 declared friend of class gdcmDocument (see below).
1389 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1390 - Clean up of undefined or unused methods.
1391 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1392 account the changes to gdcmHeader.h).
1393 * src/gdcmDocument.h:
1394 - gdcmFile is now a friend class (in order to take into account the
1395 changes to gdcmHeader.h).
1396 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1397 (see changes to gdcmHeader.h).
1398 - Accessors (reading on the form GetEntry*) are now public.
1399 - Clean up of undefined or unused methods.
1400 * src/gdcmDocument.cxx:
1401 - adaptation to changes to gdcmDocument.h
1402 - ::OpenFile now writes a verbose message when file cannot be opened.
1403 - some std::string properly set to VRKey
1404 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1405 references to gdcmDocument.
1406 * Test/TestFindTags.cxx: changed accordingly to above changes.
1407 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1408 cvs repository gdcmData.
1410 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1411 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1412 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1413 conflicts with gdcmValEntry::voidArea.
1414 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1415 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1416 Value representation between StringRepresentable and BinaryRepresentable.
1417 * src/gdcmDocument.cxx:
1418 - method ParseDES: proper indentation restored and usage of
1419 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1420 - method LoadDocEntry: the fingerprint left in the SetValue() of
1421 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1422 removed. Reverting to previous code segment with the proper
1423 dynamic_cast< gdcmValEntry* >.
1424 Note: this was (partially) breaking the python test suite
1425 (gdcmPython/testSuite.py) that made usage of the above
1426 fingerprint to check presence of "Pixel Data".
1427 * src/gdcmDocEntry.h: coding style.
1428 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1429 now taken into account.
1430 * gdcmPython/gdcm.i: adaptation to the new internal representation
1431 of gdcm (exit gdcmParser, hello gdcmDocument).
1432 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1434 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1435 anymore, but instead prints the loaded Python dictionary.
1436 * .... alas, the python testSuite is still broken.
1438 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1439 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1441 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1442 * src/gdcmUtil.h : export methods
1444 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1445 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1447 * Initial addition of automatic python testing
1448 * Initial addition of automatic image comparison
1450 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1451 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1452 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1454 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1455 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1456 * Test/ShowDicom.cxx : bug fix for msvc compilation
1457 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1459 2004-05-04 Jean-Pierre Roux
1460 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1461 new concepts (and new classes) :
1462 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1463 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1464 - Sequence Doc Entries (gdcmSeqEntries)
1465 a Sequence is composed of Items.
1466 Each item is a set of Doc Entries (this is recursive)
1467 The non uniqueness of the 'Dicom tag' is due to this recursivity
1468 (never taken into account)
1469 Our unability to add a new 'entry' in the header
1470 at the proper location (neither in the H-Table (map or multimap),
1471 nor in the Chained List is also due to this recursivity.
1472 Don't try, right now, to use/modify/compile these new sources :
1473 nothing is finished.
1474 We just commit all the stuff, 'as is', in order not to loose it.
1476 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1477 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1479 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1480 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1481 file prefix (SetFilePrefix)
1483 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1484 * Add a new test: ShowDicom, for now this is just the c++ version of
1485 checkRead.sh, later it will be able to compare the image read against a
1487 * Replace the DEBUG on the stack with a global entry in cmake interface:
1488 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1490 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1491 * Add an example subdir, with a real example on how to read + write a
1494 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1495 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1496 * Doc/CMakeLists.txt: the main page is now properly differentiated
1497 between the developper and user version.
1498 * Doc/doxygen.config.in: dropped search related obsolete flags
1499 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1501 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1502 * DEVELOPPER: added some helpfull comments for compile/test/install
1505 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1506 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1507 src directory, now generated in the build dir.
1508 2. Tests as mentionned smarter
1510 4. Add a new method in gdcmDict that return the PubDict by name
1511 this is interesting for 3rd party lib like ITK,
1512 where we could set the institution name / patient name...
1514 * ENH: 1. Now the test suite is working for real
1515 2. All binaries are now output in the gdcm-bin directory
1516 (this was not true before)
1518 2004-04-28 Jean-Pierre Roux
1519 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1520 SeQuence indented printing of Dicom Header.
1521 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1522 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1523 Computation of SQDepthLevel is now part of gdcmHeader constructor
1524 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1525 tree-like structure of a Dicom Header.
1526 * FIX Test code cleaning
1528 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1529 * ENH: Adding automatic testing
1530 1. Need a DartConfig.cmake to submit to public
1531 2. Add a test driver gdcmTest.cxx
1532 3. gdcmTestMain, an helper for the main test driver gdcmTest
1533 4. Files in Test don't have a main anymore, this becomes interesting
1534 when we add more and more tests, thus dsw don't have to load
1536 * ENH: Adding a GDCM_DATA_ROOT for testing
1537 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1538 one file instead of seven + some small cleanup
1540 2004-04-22 Jean-Pierre Roux
1541 * ENH Minor changes to the Print() methods.
1542 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1543 Header printing. Example given with :
1544 > PrintHeader fileName 2 new
1545 (SQ based tree-like structure still to be done for the Header ...)
1547 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1548 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1549 1. I have added some unsigned where needed
1550 2. Some function parameter not used -> (void)
1551 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1552 4. g++ don't like character '\' in comment
1553 5. #define jpeg_create_decompress jCreaDecompress
1554 this really need to be fixed
1555 6. virtualize destructor of gdcmObject ... leakage
1556 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1557 this also really need to be fixed
1558 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1559 remove compression file
1560 (as we only do decompression, right ?)
1561 * ENH: Change malloc/calloc/free with c++ equivalent
1563 2004-04-21 Jean-Pierre Roux
1564 * FIX gdcmHeaderHelper::GetXSpacing
1565 when a single value is found (bug ?), xpacing is now
1566 defaulted to yspacing
1568 2004-04-19 Jean-Pierre Roux
1569 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1570 * ENH add parameters :
1571 bool exception_on_error = false,
1572 bool enable_sequences = false,
1573 bool ignore_shadow = false
1574 to the gdcmFile constructors to be full gdcmParser compliant
1575 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1576 to allow reading of PAPYRUS 3.0 files
1578 2004-04-06 Jean-Pierre Roux
1579 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1581 2004-04-02 Jean-Pierre Roux
1582 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1583 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1584 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1586 2004-03-30 Jean-Pierre Roux
1587 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1588 for ACR file, written out as DICOM files (hope so...)
1590 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1591 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1592 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1593 moved to base class gdcmParser and only the specialisation is kept
1595 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1596 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1597 already does the job.
1598 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1599 (to be consistent with gdcmParser::WriteEntries).
1601 2004-03-30 Benoit Regrain
1602 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1603 upate of the object's instance. It's passed to 2 in the unfavorable
1604 case : one in the ExecuteInformation, one in the ExecuteData
1606 2004-03-29 Jean-Pierre Roux
1607 * ENH : Check on file type to be written moved
1608 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1609 * FIX : gdcmObject::ResetBoundaries now stops properly
1610 when end-of-list is reached
1611 : gdcmVersion modified (as Benoit Regrain asked)
1613 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1614 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1615 * src/gdcmUtil.cxx: added forgotten iostream include.
1616 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1617 equivalent to ExplicitVR in existing code).
1619 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1620 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1621 now contains all the gdcmGlobal related code.
1622 * minor coding style and doxygenation changes.
1624 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1625 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1626 now contains all the Debug related code.
1627 * minor clean-up of includes in src/*.cxx
1628 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1629 CreateCleanString) removed.
1630 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1631 * Doc/DoxyMainPageUser.txt added.
1632 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1633 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1634 src/gdcmDirList.cxx)
1636 2004-03-24 Jean-Pierre Roux
1637 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1639 2004-03-23 Jean-Pierre Roux
1640 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1641 big endian made volumes
1642 * ENH Now gdcmParser constructor and destructor are protected to forbid
1643 end user to instanciate class gdcmParser
1644 (only gdcmHeader and gdcmDicomDir are meaningfull)
1646 2004-03-22 Benoit Regrain
1647 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1648 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1649 gdcmSerie to gdcmDicomDirSerie
1651 2004-03-19 Jean-Pierre Roux
1652 * ENH Now the tree-like structure describing a DICOMDIR comming from
1653 an already existing DICOMDIR file is consistent with
1654 the home-made tree-like structure build ex-nihilo
1655 or build from the files held (recursively) in a Directory
1656 functions gdcmDicomDir::CheckBoundaries()
1657 gdcmObject::SetBoundaries() added
1659 2004-03-17 Jean-Pierre Roux
1660 * REM (Eric Boix bug) : removal of meaningless
1661 gdcmDicomDirImage::NewImage function.
1662 * FIX now file names and directory name are written properly in the
1664 * FIX now gdcmDicomDir constructor may be call without any trick
1667 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1668 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1669 of gdcmDicomDirImage::NewImage as empty function.
1671 2004-02-28 Jean-Pierre Roux
1672 * ENH add gdcmDicomDir:NewPatient
1673 add gdcmDicomDirPatient:NewStudy
1674 add gdcmDicomDirStudy:NewSerie
1675 add gdcmDicomDirSerie:NewImage
1676 to allow making gdcDicomDir object.
1677 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1678 (as opposite to the gdcmHeader chained list)
1680 2004-02-11 Benoit Regrain
1681 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1682 when using from python
1684 2004-02-10 Benoit Regrain
1685 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1686 * FIX : in gdcmDicomDir when the directory is empty
1687 * ENH : add callback and methods to get the progression of dicomDir
1690 2004-02-06 Jean-Pierre Roux
1691 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1692 - GDCM_META added to gdcmDicomDirType
1693 - class gdcmMeta created
1694 * ENH : - A brief summary is now displayed at the beginning of
1695 'testDicomDir' to help disaster magnitude estimation
1696 * REM : Now useless Test/explDICOMDIR.cxx
1698 2004-02-05 Benoit Regrain
1699 * ENH : add methods in gdcmObject to get the hash table or the list of
1701 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1702 * FIX : wrapping python for TagHeaderEntryHT
1704 2004-02-04 Benoit Regrain
1705 * FIX : even length for some strings when writting the dicom dir
1706 * FIX : sort the images in the dicom dir
1707 * FIX : Bug fix for python use of dicom dir
1708 * ADD : a python demo
1710 2004-02-04 Jean-Pierre Roux
1711 * FIX : Final solution (?) for icone embedded images
1712 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1713 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1714 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1715 gdcmData/gdcm-MR-SIEMENS-16.acr1
1716 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1717 to make full checking easier
1719 2004-02-04 Benoit Regrain
1720 * FIX : WriteEntries : coding style & logic in parameters
1721 * FIX : Set the elements to create the DicomDir in a dictionary file
1723 2004-02-03 Benoit Regrain
1724 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1725 * gdcmDicomDir : add the load of directory
1726 * Bug fix and print add-on
1728 2004-02-03 Jean-Pierre Roux
1729 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1730 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1731 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1732 * FIX gdcmParser.cxx : 'group length' elements are now considered
1733 as integers, even for shadow groups, when file is Implicit VR
1735 2004-02-02 Jean-Pierre Roux
1736 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1738 of the last synonym :-(
1739 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1741 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1742 * FIX taking into account the possible 7fe0,0010 multiplicity
1743 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1744 to allow removal of references to 7fe0,0010, to deal with
1745 ACR-NEMA images, when 0028,0200 is meaningfull
1747 2004-01-31 Jean-Pierre Roux
1748 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1749 no longer writes 'Un' on disk
1750 * FIX SQ elements with actual length are now dealt with corectly
1751 * FIX gdcmFile::WriteBase make the difference, for color images, between
1752 the length (for Palette expanded images)
1753 and Raw Length (non expanded image + Palette)
1754 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1755 (that broke Write). Replaced by UL.
1756 Aware user will reload the field if he
1757 thinks it's necesssary
1759 2004-01-30 Jean-Pierre Roux
1760 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1761 when 'dirty Acr' is found, to be compliant with the new
1762 IsReadable() methods.
1764 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1765 (no DOUBLE images in kosher DICOM,
1766 but so usefull for people that miss them ;-)
1768 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1769 DICOMDIR related utilities (not checked as Windoze compliant)
1771 2004-01-28 Jean-Pierre Roux
1772 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1774 2004-01-27 Jean-Pierre Roux
1775 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1776 to allow skipping the shadow elements, to save memory space.
1777 The TRUE value for this param has to be used
1778 with a FALSE value for the 'enable_sequence' param.
1779 ('public elements' may be embedded in 'shadow Sequences')
1780 * gdcmHeader methods now deal with 'embedded icones images' in the header
1781 (even when an 'icone image sequence' is announced by the
1782 element (0x0088,0x0200), but there is NO icone at all ...
1784 * gdcmHeader sometimes Image Location value doesn't follow
1785 the supposed processor endianity (see gdcmData/cr172241.dcm).
1788 * gdcmHeader add the method
1789 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1790 to get *all* the Header Entries with the same tag.
1791 GetHeaderEntrySameName is probabely *useless*
1792 (no meaning : Name is *not* an identifier within the Dictionnary)
1794 2004-01-26 Benoit Regrain
1795 * Bug fix in the print of hexadecimal representations. Remove long fields
1796 in the print and add a third level of print to print them
1798 2004-01-23 Benoit Regrain
1799 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1800 * Bug fix on test suite after remove the strip made on not string fields
1801 * Split the IsReadable method between gdcmParser which test that the file
1802 is dicom and gdcmHeader which test that it's an image file
1804 2004-01-22 Benoit Regrain
1805 * DicomDir : clean code, add methods, set variables in protected or private
1806 * gdcmUtil : bug fix for the clean string method
1808 2004-01-19 Benoit Regrain
1809 * Add the use of shadow dictionaries
1810 * bug fix and coding style
1812 2004-01-19 Benoit Regrain
1813 * src/gdcmFile.cxx : bug fix concerning the close of file
1814 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1815 * Add the update of header entries using the shadow library
1817 2004-01-19 Benoit Regrain
1818 * removal of file gdcmHeader2.cxx
1819 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1820 inheriting from gdcmParser. This split is to prepare the integration
1821 of dicom dir parsing
1822 * bug fix under python
1824 2004-01-16 Jean-Pierre Roux
1825 * REM removal of class gdcmHeaderEntrySet
1826 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1827 * ADD add file gdcmHeader2.cxx
1828 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1830 2004-01-15 Benoit Regrain
1831 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1832 entries created while parsing the header. Thus, they will be destroyed
1833 when the gdcmDictSet will be destroyed
1834 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1837 2004-01-15 Benoit Regrain
1838 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1839 made a fatal error because of the memory release at the end of program.
1840 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1841 some memory and vtk seems to have some problems with that.
1842 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1844 2004-01-14 Benoit Regrain
1845 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1846 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1847 * src/*.[h|cxx] : make changes due to class name changes
1848 * gdcmPython/demo/*.py : bug fix due to method names
1850 2004-01-13 Benoit Regrain
1851 * src/*.[h|cxx] : coding style
1852 * vtk/*.[h|cxx] : coding style
1854 2004-01-13 Benoit Regrain
1855 * gdcmPython/testSuite.py : test the readable flag of file for tests
1856 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1857 It's lied to the stl compilation by MSVC (windows, always windows...)
1858 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1860 2004-01-12 Benoit Regrain
1861 * src/*.h : add comments
1862 * src/gdcmDictSet.h : set the method BuildDictPath in public
1863 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1864 directly setted in the source code
1865 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1868 2004-01-09 Benoit Regrain
1869 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1870 * setup.py : use a reference to gdcmVERSION
1872 2004-01-07 Benoit Regrain
1873 * Modification to compile with the distutils.
1876 2003-12-10 Benoit Regrain
1877 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1878 can use a gdcmHeaderHelper to load data
1879 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1880 made in the source code
1882 2003-12-10 Benoit Regrain
1883 * Update Windows projects and .cvsignore files
1885 2003-11-12 Jean-Pierre Roux
1886 * ENH gdcmHeader constructor has one more parameter (default value : false)
1887 that allows the user to 'go inside' the SeQuences only
1889 gdcmElValSet:Print takes it into account
1891 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1892 * ENH: Update gdcmPython/CMakeLists
1893 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1894 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1896 2003-11-10 Jean-Pierre Roux
1897 * FIX : gdcmHeader::LoadElements is now based
1898 on the ListTag listElem member,
1899 not longer on the TagElValueHT tagHt member
1900 * ENH : PrintPubElVal shows (temporarily) both results,
1901 with the tagHt member and the listElem member.
1902 (it's easier to 'see' the problems when using Printheader)
1904 * FIX : old private member LgrElem is now splitted into
1905 ReadLength : Length actually found on disk (updated only
1906 if bug fixing is necessary), for internal
1908 UsableLength : Updated by FixFoundLength, to fix a bug
1909 or to allow Parser going on.
1910 Will allow to re-write a kosher header when a SeQuence
1911 with a length (not 0000) is found
1912 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1913 because gdcmElValSet::Add does not update ListElem
1916 2003-11-07 Jean-Pierre Roux
1917 * FIX misstyping in Transfert Syntax name table
1918 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1919 when they have an actual length (not 0000 nor FFFFF)
1920 (Nobody should care of it, but DICOMDIR explorers)
1922 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1923 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1925 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1926 * ENH: vtkGdcmReader now supports LUT !
1927 (vtkgdcmViewer for now is not able to use them though)
1929 2003-11-05 Jean-Pierre Roux
1930 * in testSuite.py : new files names for checking the package
1931 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1932 that returns the pixel area size to the *aware* (vtk) user
1933 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1935 2003-11-05 Benoit Regrain
1936 * in testSuite.py : Modify the rules for checking the paths
1937 : Explicit error messages
1938 * in __init__.py : Related modif
1940 2003-11-03 Jean-Pierre Roux
1941 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1942 to be used by aware (vtk) users that want to manage
1943 LUT (and no to turn the PALETTE image into an RGB pixels one)
1944 * GetPixelType now returns 8U for 24 Bits images
1945 (vtkGdcmReader compliant)
1947 2003-10-31 Jean-Pierre Roux
1948 * Removal of *all* gdcmData images and add them again
1949 in order to loose the 'history' of un-anonymised images
1951 2003-10-31 Jean-Pierre Roux
1952 * RMV : removal of useless jBitsInJsample.h
1953 for both 8 and 12 Bits JPEG Lossy Libraries
1955 2003-10-31 Jean-Pierre Roux
1956 * ENH : Add the functions gdcmFile::GetImageDataRaw
1957 gdcmFile::GetImageDataIntoVectorRaw
1958 that act as GetImageData and GetImageDataIntoVector
1959 except the making of an RGB Plane from Gray Plane + LUT
1960 Intended to aware (vtk) users who know how to manage
1963 GetLUTRGBA return a R,G,B,A LUT if any
1964 lgrTotaleRaw gives the 'Raw' length
1965 GetImageDataRaw returns the gray Plane
1966 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1967 (They stay Grey, just like with other Dicom viewers :-(
1969 2003-10-30 Jean-Pierre Roux
1970 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1972 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1973 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1974 being coherents dicom files.
1976 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1977 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1979 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1980 * ENH: Two steps is necessary to please VC++ compiler...
1981 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1982 * ENH: Add include dir to medcon lib
1983 * FIX: only one function is being exported for now !
1984 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1986 2003-10-29 Jean-Pierre Roux
1987 * adding gdcmHeader::GetLUTRGBA
1988 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1989 --> Mathieu, the modif u're waiting for is not yet committed
1990 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1992 2003-10-27 Jean-Pierre Roux
1993 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1994 00191113.dcm DermaColorLossLess.dcm
1995 MxTwinLossLess.dcm RadBWLossLess.dcm
1996 * ENH: For version prior to vtkImageViewer2 -r 1.19
1997 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1999 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2000 * Removal of ido stuff in CMakeLists.txt
2002 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2003 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2004 * FIX: remove a call to ->Modified ... see comments
2005 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2007 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2008 * FIX: Problem with path for libvtkgdcmPython
2009 * ENH: Try adding a search script for python site-package
2010 * RMV: Remove some file from medcon lib that are not necessary
2011 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2012 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2013 * FIX: More pragma disable fro VC++,
2014 I don't think I break something as it is also disable in VTK/ITK.
2015 But it fasten debug compilation time.
2017 2003-10-23 Jean-Pierre Roux
2018 * gdcm now deals with 16 Bits Run Length Encoded images
2019 (they are compressed as 2 planes images,
2020 one for the high Bytes, the other for low Bytes)
2022 2003-10-22 Jean-Pierre Roux
2023 * Now CheckRead takes into account :
2024 - the bugged 'Leonardo' Siemens images
2025 - the XA images, sent thru the burning VPRO station
2026 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2029 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2030 * FIX: When copying a Makefile.am to CMakeLists.txt
2031 one should remove the '\'
2033 2003-10-22 Jean-Pierre Roux
2034 * in gdcmData adding a bugged 'Leonardo' Siemens image
2035 (wrong lengths in header)
2036 OK with gdcm, KO with the other viewers :-)
2037 * add a GE dlx XA image, thru the VEPRO burning station
2040 2003-10-21 Jean-Pierre Roux
2041 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2042 for a brutal checking of vtkgdcmViewer compliance
2044 2003-10-21 Jean-Pierre Roux
2045 * add the files for 'xmedcon' Jpeg Lossless library
2046 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2048 2003-10-21 Jean-Pierre Roux
2049 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2051 2003-10-21 Jean-Pierre Roux
2052 * garbage Siemens 'Leonardo' images dealt with
2053 (the patch is easy to remove)
2054 * cosmetic changes to avoid warnings
2056 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2057 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2058 no need to press 'r' now.
2060 2003-10-20 Jean-Pierre Roux
2061 * upgrade of checkRead.sh checkWrite.sh according
2062 to new Jpeg Lossless decompressor
2063 * add US.3405.1.dcm, a genuine RGB medical file ...
2064 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2065 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2067 2003-10-15 Jean-Pierre Roux
2068 * general anonymisation in gdcmData
2069 * adding the 'color files' from
2070 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2071 * adding some well knowed bugged-header images
2072 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2073 waiting for their inclusion in Python testsuite
2075 2003-10-15 Jean-Pierre Roux
2076 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2077 no longer seg faults when file is not found
2079 2003-10-14 Jean-Pierre Roux
2080 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2083 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2084 * TODO: *.in file to genereate a UseGDCM later
2086 2003-10-14 Jean-Pierre Roux
2087 * Some supposed-to-be Dicom Images have no preamble.
2088 OpenFile takes it into account
2089 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2090 * Missing elements added in dicomV3.dic
2091 (just to be affraid : have a look at
2092 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2093 and do it again next year ;->
2095 2003-10-13 Jean-Pierre Roux
2096 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2097 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2098 But there are NOT. It's fixed !
2100 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2101 * FIX: "jpeglib.h" was not found on VC++
2102 * FIX: vtkgdcm was not being installed
2104 2003-10-10 Jean-Pierre Roux
2105 * ENH : OpenFile closes the file if it *really* doesn't look like
2106 an ACR-NEMA / DICOM one.
2107 * FIX : testWrite no longer writes an empty file if the source file
2108 is not gdcm Readable
2109 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2112 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2113 * FIX: CMake generate now documentation
2114 * ENH: out of source doc build !
2115 * ENH: Generate both user and dev documentation
2116 * ENH: Should work on windows too
2117 * ENH: Only one doxygen config.in file is needed
2118 * FIX: make install should be ok now on ùnix plateform
2119 * FIX: PATH to dictionary was wrong (missing /)
2120 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2122 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2123 * vtkGdcmReader is now able to read rgb dicom file.
2124 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2125 * added a gdcmViewer to vtk test, use mouse to control
2126 window level & window width
2128 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2129 * CMake-ification of gdcm, we have now two build system
2130 * FIX: on cygwin Wsock32 doesn't exist
2131 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2133 2003-10-06 Emanuel Ollart
2134 * FIX : compilation process wad broken.
2135 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2137 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2138 * change gdcmViewer -> vtkgdcmViewer
2139 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2141 2003-10-06 Jean-Pierre Roux
2142 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2143 ( e.g : well known GE images with a wrong elem length,
2144 : Philips MRI Images with a wrong Huffman table)
2145 * still to be done : allow the reading of bugged LEONARDO Siemens images
2147 2003-10-03 Jean-Pierre Roux
2148 * Odd length strings are padded with '\0' (not with spaces,
2149 to remain compliant with already defined strings,
2150 like Transfert Syntax UID and others)
2152 2003-10-03 Jean-Pierre Roux
2153 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2154 to allow displaying RGB images (not only by affim ;-)
2156 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2157 * vtkGdcmReader is now able to read rgb dicom file.
2158 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2160 2003-10-03 Jean-Pierre Roux
2161 * A few nasty patches to allow the reading of a lot of nasty images
2162 ( e.g : well known GE images with a wrong elem length,
2163 : Philips MRI Images with a wrong Huffman table)
2164 * still to be done : allow the reading of bugged LEONARDO Siemens images
2166 2003-10-03 Jean-Pierre Roux
2167 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2169 2003-10-03 Jean-Pierre Roux
2170 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2171 to allow displaying RGB images (not only by affim ;-)
2173 2003-10-03 Jean-Pierre Roux
2174 * gdcmFile::GetImageDataIntoVector now
2175 - deals with MultiFrames MultiFragments Run Length Encoded files
2176 - deals with YcBcR (YBR_FULL) files
2177 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2178 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2180 (no sample found :-(
2182 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2183 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2184 Two reasons: - clear things
2185 - third parties acces gdcm through header files, so won't
2186 suffer anymore VC++ complains
2188 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2189 * add argv[1] in testvtkGdcmReader.cxx
2192 2003-09-24 Jean-Pierre Roux
2193 * The lines are now eigthy characters long.for
2194 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2196 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2197 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2198 char* to std::string. Thus, the use of strdup becomes useless. (see
2199 previous commis of Malaterre)
2200 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2201 before the last Malaterre's commit.
2203 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2204 * This commit should fix the Debug building under VC++, the problem
2205 was mainly a mixture of debug and release lib being loaded at startup.
2206 * I also remove a depency to a specific C function: strdup. Because I had
2207 to force the link to msvcrtd (whereas strdup is in libc).
2209 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2210 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2211 located in the gdcmCommon.h file. All use of reference of tha has been
2212 changed to now use the variable GDCM_UNFOUND.
2214 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2216 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2217 Dicom dictionary. The test suite can now be run again. Note:
2218 I'm note very happy with the " (RET)" changes. I believe this
2219 RETAINED comment should be dropped when parsing the dictionary.
2220 - PACKAGER corrected
2222 - AUTHORS updated and now in alphabetical order
2223 * Makefile.am now exports gdcm.dsw for Windoze users.
2225 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2226 * cygwin complains about missing std:: in subdir Test/
2228 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2229 * remove some methods that are now in gdcmHeaderHelper
2231 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2232 * vtkGdcmReader set spacing and origin correctly
2234 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2235 * Fix a few delete/delete[] mismatch
2237 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2238 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2239 interpretation to data given by gdcmHeader. For instance there are
2240 heuristics to get informations (look at different places).
2241 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2242 sorting DICOM images based on different strategies.
2243 * modified Makefiles accordingly.
2245 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2246 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2247 when building in debug mode
2248 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2249 src/win32/gdcmdll.dsp
2250 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2252 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2253 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2256 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2257 * src/win32/libgdcmjpeg12.dsp was not dos format
2258 * src/win32/libgdcmjpeg12.dsp :
2259 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2260 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2262 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2263 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2265 * src/gdcmFile.cxx : bug fix in affectation type
2266 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2267 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2268 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2269 symbols... future problem ?
2271 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2272 * src/win32/libgdcmijpeg12.dsp was missing
2273 * modified gdcm.dsw accordingly
2275 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2276 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2278 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2279 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2280 commit of JPR (before his hollidays to facilitate our work).
2281 * setup.py : bug fix in code. Modifications made while the last commit
2282 of JPR. The code hasn't been tested before the commit... it's so
2283 useless to make that (for best programmer that is JPR) !!!
2285 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2286 * tagged the current version as Version0_3 (i.e. version 0.3)
2288 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2289 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2290 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2291 * *.dsp : modifications to use new libgdcmijpeg8 library
2292 * setup.py : bug fix on VTKPATH variable
2293 * PACKAGER : adding all concerning windows
2295 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2296 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2298 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2299 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2300 test suite reported error.
2301 * PACKAGER file added (describes what a packager must do when
2302 packaging a new release).
2303 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2304 * configure.in: upgraded version number to 0.3.0
2305 * fixing build of rpm (through rpm -ta):
2306 - Doc/Makefile.am exports proper doxygen files
2307 - src/jpeg/libijg8/Makefile.am exports the include files.
2309 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2310 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2311 * src/gdcmHeader.h : formatting code
2313 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2314 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2315 We were obtaining error message from vtk. Now, creation of file list
2316 is made in an internal list to prevent this problem.
2317 Bug fix when output is empty.
2318 Bug fix in update of progress value. Previous commit for this was a bad
2320 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2322 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2323 * src/gdcmHeader.h : added method to get the file name
2324 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2325 files. Added method to remove all files on the input
2326 Added FIXME comment concerning the bad parsing of header made by
2327 ExecuteInformation method (in ExecuteData method)
2329 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2330 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2331 when using make instal.
2332 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2333 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2335 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2336 * setup.py : adding include dir of jpeg lib to compile all sources
2337 * */Win32/*.dsp : JPR fix for windows compilation
2339 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2340 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2342 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2343 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2345 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2346 * setup.py is again effective on un*x (takes into account the
2347 addon of the jpeg library)
2348 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2349 * Doc/Doxy* updated (includes above enhancements)
2350 * INSTALL now points to web documentation
2352 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2353 * src/gdcmHeader.h doesn't make unnecessary reference to
2355 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2357 * src/gdcm*.[cxx|h] :
2358 - to allow compilation with gcc 3.x
2359 -- clean up of STL usage (added explicit usage of std::)
2360 -- small fixes on exceptions.
2361 Note: linking not tested !
2362 - clean of doxygen comments to avoid warnings at documentation
2364 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2365 dependent convertion).
2367 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2368 * Clean up of previous JPR garbage commit (not even commented in the
2370 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2371 - moved all jpeg related files from src to src/jpeg/libijg8, with
2372 addition/modification of Makefile.am and configure.in.
2373 - the testSuite is still brain damage (not guilty).
2375 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2376 * WrapVTK.py : modifications to get correctly vtk source files to
2378 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2379 (FileName -> Filename)
2381 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2382 * vtk/vtkGdcmReader.[cxx/h]:
2383 - UpdateProgress method should now be effective
2384 - removed the limitation on having only images loaded (as opposed
2386 - when building a stack of images/volume, a lesser number of
2387 gdcmHeader and gdcmFile instances should be used (hopefully
2388 accelerating things).
2389 - when building a stack of images/volumes, files which are not
2390 loadable (wrong path-filename, wrong permissions on existing file,
2391 or file not parsable by gdcm) are replaced with a black image
2392 in the stack (for the caller to notice the problem).
2394 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2395 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2397 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2398 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2399 between standard library (std) and vtk library (problems are found
2400 under Windows... thanks Windows !)
2402 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2403 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2405 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2407 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2408 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2410 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2411 * When compiling with distutils (see setup.py) the C++ compiler is
2412 called with different flags than the default ones (with automake).
2413 In order to fix all those warning, I compiled gdcm with the command
2414 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2415 and went for warning fixes:
2416 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2417 up from unused variables.
2418 - vtk/vtkGdcmReader.cxx: potential bug fix.
2419 * src/gdcmHeader.h: Doxygen warning cleanup
2421 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2422 * gdcmPython/gdcm.i:
2423 - typemaps correction to take into account the systematic replacement
2424 of "using namespace std" with std:: prefix e.g. std::list,
2425 std::string... (cf changes of 2003-05-21).
2426 - gdcmGlob global variable of type gdcmGlobal (defined in
2427 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2428 exported to Python a as cvar.
2429 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2430 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2431 gdcmDictSet.GetPubDictTagNames() and
2432 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2433 C++ static methods).
2434 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2435 with the above changes.
2437 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2438 * setup.py, manifest.in : bug fix under linux
2440 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2441 * Modification of setup.py to compile vtk part too. Then, we have 2
2442 wrappers which must work with same distutils. For that, we have a
2443 generic distutils in distusiltsWrapping.py ; with :
2444 - build_extWrap class to wrap generically all extensions,
2445 - ExtensionWrap base class for all wrapping extension that contains
2447 - Wrapper interface which wrap sources
2448 + In WrapSwig.py we have extension and wrapper for Swig
2449 + In WrapVTK.py we have extension and wrapper for VTK
2450 * MANIFEST.in : modifications to consider vtk directory and new python
2451 files for compilation
2453 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2454 * Added python wrappers of vtkGdcmReader vtk class (see the
2455 source in vtk/vtkGdcmReader.cxx) :
2456 - vtk/Makefile.am now builds a library
2457 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2458 python library (as opposed to _gdcm.so wich are the python
2459 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2460 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2462 - configure.in has an additional flag --enable-vtk that needs
2463 to be set to enable compilation of vtk related code, that is:
2464 + vtk/vtkGdcmReader.so and
2465 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2466 + gdcmPython/vtkgdcmPython.so (see above)
2467 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2468 be read when compressed or when HighBit + 1 != BitsStored),
2469 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2470 the usage of the python wrapper of vtkGdcmReader vtk class.
2471 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2472 * src/*.[h] all occurences of stl classes are now prefixed with
2473 std::, and all occurences of "using namespace std;" where removed.
2474 This is to avoid pollution of global namespace in included files.
2475 Apparently vtk does not avoid this pitfall: when using both
2476 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2477 collision of various stl members (principally cout...).
2478 * gdcmPython/testSuite.py now cleanly removes temprory generated
2480 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2481 comply with above changes)
2483 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2484 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2485 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2486 vtk data structure (an image Flip was required).
2487 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2488 * cosmetic changes in documentation.
2490 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2491 * src/gdcmHeader.cxx: the constructor no longer exits when an
2492 unexisting file is given as argument.
2493 * The subdirectory Data (containing all the images used for the
2494 test suite) is not part of this repository anymore. A new module
2495 containing those images is now available at
2496 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2497 with the name gdcmData.
2498 All the python scripts (including the package initialisation file
2499 gdcmPython/__init__.py) were adapated to take this change into
2500 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2502 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2503 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2504 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2505 demo of the usage of this class.
2506 Compilation of this vtk part is only done when using the --enable-vtk
2507 at configure (or autogen.sh) stage.
2509 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2510 * More memory link related corrections and documentation fixes.
2512 - maximum info is obtained with a command of the form:
2513 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2514 --show-reachable=yes PrintHeader
2515 - the remaining reachable blocks seem to come from the STL
2516 allocation scheme through the usage of map and list. It looks
2517 like this memory cannot be freed but it is not a memory leak
2518 (in fact further invocation to the STL would recollect the
2519 unused memory allthough it cannot explicitely be freed).
2520 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2521 of displaying an image parsed with gdcm and displayed with VTK.
2522 Note: some images don't seem to work e.g.
2523 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2524 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2525 Allthough this weakens the semantics, it is a ditch attempt to
2526 make gdcm more thread friendly.
2528 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2529 * Memory link hunt (by using valgrind through the command
2530 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2531 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2532 gdcmHeader::_dicom_vr.
2533 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2534 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2536 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2538 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2539 * src/Makefile.am now exports all the necessary include files at
2543 * UpdateGroupLength replaced by new one
2546 * UpdateGroupLength re-written using H-Table
2547 (named UpdateGroupLengthNew untill checks are over)
2549 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2550 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2551 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2553 - gdcmHeader::GetPubElValSet removed.
2554 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2555 UpdateGroupLength, WriteElements, Write.
2556 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2557 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2558 carried the same semantics.
2559 - src/gdcmHeaderIdo.cxx changed accordingly.
2560 - gdcmFile::WriteBase now regroups all the codes from previous
2561 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2562 - enum FileType moved to gdcmCommon.h
2563 * src/gdcmHeader.cxx AddDefault trashed
2564 * gdcmGetXSize added
2565 * getimageDataSize now calls gdcmGetXSize
2566 * Test/*.cxx changed to agree with above changes
2568 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2569 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2570 (to avoid double call by end user).
2571 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2572 by end user, since gdcmHeader::gdcmHeader now handles it.
2574 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2575 * gdcm/Doc many doxygen changes:
2576 - Doxyfile now has two different versions, DoxyfileUsers that generates
2577 the html.users end users oriented documentation and
2578 DoxyfileDeveloppers that generates the html.developper developper
2579 oriented documentation.
2580 - README changed accordingly
2581 - requirement.txt removed (old design info moved to TODO).
2582 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2583 DoxyMainPage.txt, DoxyPython.txt provide more information.
2584 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2585 be updated by simply regenerating the docs with doxygen and copying
2586 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2587 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2588 all the tests in the form "if (<map>.count() >1)" were removed.
2589 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2590 ill-formed documentation sections.
2591 * src/gdcmHeader.cxx: ditto
2593 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2594 * setup.py fixed for un*x (needed macro for stdint.h)
2595 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2596 un*ces with sh-utils test utility.
2597 * gdcmPython/demo/test.py renamed to PrintHeader.py
2598 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2599 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2600 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2601 * src/gdcm*.cxx JPR's bad inclusion fixed.
2603 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2604 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2605 * gdcmPython/demo/test.py changed accordingly.
2607 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2608 * gdcmPython/Makefile.am fixed linking against libstdc++
2609 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2610 * Swig subdir (historical tests of swig version 1.3.17++) removed
2611 * Test/testChangeEntete.cxx some lines commented out in order to make
2613 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2614 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2616 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2617 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2618 hence the user doesn't need this explicit call.
2619 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2620 i.e. LoadElements() call removed.
2621 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2622 - src/Makefile.am declares the proper flag for g++.
2623 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2624 for adding user defined new tags.
2625 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2626 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2627 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2629 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2630 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2631 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2632 src/Makefile.am : the project should properly compile and install
2633 with the autotools, included the python wrappers part.
2634 * gdcm.spec.in : added a spec file for RPM packaging.
2636 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2637 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2639 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2640 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2641 to exported to the environement (see gdcmPython/testSuite.py
2643 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2644 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2645 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2646 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2647 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2649 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2650 * gdcmPython/__init__.py doesn't crash anymore when running in
2651 in InstallMode or PreInstallMode but with an environement given
2652 value of GDCM_DICT_PATH.
2653 * src/gdcmDictSet.[cxx/h] coding style.
2655 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2656 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2657 * src/gdcm.h general comments moved to TODO, and README
2658 * src/gdcm.h should now be seen as a user commodity (including it
2659 should suffice to fully use gdcm). It is nowhere including within
2660 any of the kernel files src/*.cxx and src/*.h.
2662 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2663 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2664 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2666 * src/gdcm*.cxx only include their corresponding include file
2667 (as opposed to gdcm.h)
2668 * gdcmPython/gdcm.i changed accordingly
2669 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2670 the autogen.sh generated "make snapshot" command to work.
2671 * autogen.sh removed history related references to crea package.
2673 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2674 * distutilsSwigCPlusPlus.py work around some swig portability
2677 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2678 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2679 was done in a last ditch attempt to get setup.py _really_
2680 operationnal. The python/gdcmPython layaout add the advantage
2681 of hidding away the python related distutils specific files
2682 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2683 Alas, the src directory was out of scope (i.e. it's relative
2684 position to setup.py was ../src) which made things impossible to
2685 handle (see previous version of python/setup.py). Crossing fingers...
2687 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2688 * python/setup.py now works on Un*x. (harder than I thougth)
2689 * python/distutilsSwigCPlusPlus.py can now have include files
2690 among the list of sources.
2692 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2693 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2694 * modifications in MSVC projects
2696 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2697 * As stated by the first lines of Test/ExceptionAndPython/README, it
2698 looks like we can move back to original usage of exception within
2699 src/gdcm* and hence remove the errno stuff that was introduced
2700 as a quick and dirty fixture of this problem (added to the TODO).
2701 * Doc/Doxyfile configuration file for Doxygen and corresponding
2702 README file for usage added.
2703 * Test/testWrite.cxx added. This new test comes from a split of
2704 test.cxx that is now reverted to its original purpous i.e.
2705 testing the proper parsing of a Dicom related file.
2706 testWrite.cxx concentrates on testing the IO part of gdcm.
2707 * Test/bug1.cxx (containing a bug on WIn32) added.
2708 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2709 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2710 whose purpose is to publish the content of the TagNames of the
2711 Dicom public dictionnary were not accessible without an
2712 instance of class gdcmHeader.
2713 - those methods are now static methods of gdcmDictSet and hence
2714 require no instances at all to be invocated.
2715 - within gdcmDictSet this change required to change some method
2716 to class methods (i.e. are now static) among which SetDictPath
2717 (renamed to BuildDictPath) and LoadDefaultPubDict.
2718 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2719 the above changes by calling the new method classes of gdcmDictSet.
2720 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2721 the above to be effective.
2722 * python/gdcmPython: in order to wrap properly the above changes
2723 for Python, swig version now needs to be > 1.3.17.
2724 * python/gdcmPython/Makefile fixed to adapt itself to new
2725 configure/make shema introduced by Johan Montagnat (thanks for the
2726 contribution). Alas this Makefile cannot be turned into a proper
2727 Makefile.am without some heavy changes in the configure.in
2728 (for python dectection).
2729 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2730 now avoids publishing the empty entries.
2732 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2733 * python/setup.py : bug fix concerning install under windows
2734 ExtraPath reused :-P
2735 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2737 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2738 * Dicts/dicomV3.dic : remove double spaces !!!
2739 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2740 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2743 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2744 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2745 method. Doxygenation.
2746 * src/gdcm.h clean up of JPR spurious comments.
2748 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2749 * python/distutilsSwigCPlusPlus.py now properly collects the
2750 shadow classes generated by "swig -c++" (gdcm.py in our case)
2751 when using "python setup.py install".
2752 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2753 reexports the working classes.
2754 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2755 by the classical C errno scheme. This is to prevent an obscure
2756 behavior of the python wrappers when importing wxPython.wx prior
2757 to gdcmPython (which ended up in an abort call). An illustration
2758 of this oddity can be found in the Test/ExceptionAndPython
2759 subdir (see the README file). This problem probably due to
2760 an combination of g++ and dynamic loading.
2761 * added Test/ExceptionAndPython (see above)
2763 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2764 * Changed the layout of the python part to avoid bloating main
2765 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2766 i.e. the distutils arsenal. All the python related stuff is
2767 again in a python subdir, but the package itself is now in
2769 * setup.py was cleaned up:
2770 - pythonIncludePath removed
2771 - python setup.py bdist target is now functional.
2772 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2773 collision with other packages). gdcmPython/demo/*.py changed
2776 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2777 * python subdir moved to gdcmPython (preparation of distutils packaging).
2778 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2779 distutils installer is operational.
2780 * - gdcmPython/__init__.py now properly loads the swig generated
2781 shadow classes (from gdcm.py).
2782 - gdcmPython/demo/*.py changed to import the package gdcmPython
2783 instead of gdcmPython/demo/load.py.
2784 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2786 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2787 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2788 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2789 entries within the associated public Dicom dictionary resp. the same
2790 information but sorted by the fourth field (PAT, IMG, DIR) of the
2792 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2793 are now in the "???" group.
2794 - python/gdcm.i changed accordingly,
2795 - python/demo/printGroupedPublicDict.py added, that gives an example
2796 of the above new functionalities in Python.
2798 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2799 * src/gdcm.h, gdcmHeader.cxx:
2800 - historic references to glib's g_malloc and g_free (#defined)
2801 were definitively removed.
2802 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2803 * src/gdcmElValSet.cxx:
2804 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2805 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2806 - GetElValue(string) renamed to GetElValueByName.
2807 - Added GetElementByName(string).
2808 * src/gdcmHeader.cxx: added
2809 - GetPubElValRepByNumber(guint16, guint16)
2810 - GetPubElValRepByName(string)
2811 - GetShaElValRepByNumber(guint16, guint16)
2812 - GetShaElValRepByName(string)
2813 - GetShaElValByNumber(guint16, guint16)
2814 - GetShaElValRepByName(string)
2815 - GetElValRepByNumber(guint16, guint16)
2816 - GetElValRepByName(string)
2817 - GetElValByNumber(guint16, guint16)
2818 - GetElValRepByName(string)
2819 * Doc/requirements.txt added.
2821 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2822 * Test/Makefile building now depends on the one of libgdcm.so
2823 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2824 pixel data) aware which enables finding the address (offset) of
2825 the pixel data of JPEG encoded DICOM files. This leaves only a single
2826 file in the testSuite whose pixel data address (offset) is unknown.
2827 * python/testSuite.py changed accordingly.
2829 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2830 * VC++ has some strong limitations when working with the STL, as stated
2831 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2832 "Also note that some STL containers (map, set, queue, list, deque)
2833 cannot be exported. [...]
2834 Some STL classes contain nested classes. These classes can not
2836 This is caused by a designed limitation that once a template
2837 class is instantiated, it can not be re-instantiated and
2839 Since our usage of map<> is ubiquitous in gdcm, this "designed
2840 limitation" of VC++ is a pitfall.
2841 Hence the Python wrappers of gdcm cannot be incrementally linked
2842 against the c++ dynamic library. The dirty but only workaround is
2843 to forget about incremental link of dynamic libraries and to generate
2844 the Python wrappers library with the inclusions of the underlying C++
2846 The following modifications concern this matter on Win32/VC++:
2847 - wrapping python correct with standalone wrapped dll (don't use separate
2848 dll under windows !!!!)
2849 - python21_d debug mode enabled (ask Frog how to use it :-)
2850 - NO problem with having an STL member of class for example string in C++
2851 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2852 - Python test of dcmlib in Python is ok under windows on a large set
2854 * removed glib references
2855 * typedef's inserted in gdcm.i for correct swig type management
2857 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2858 * python/demo/*.py load.py extracted from test.py. Added explore.py
2859 that only displays required tags and testAll.py that parses all
2860 the files of the testsuite without using unittest.
2861 * python/testSuite.py other additional test on new files added.
2862 * Data/* new test files added accordingly to the testSuite.
2863 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2864 the vr in the file differs from the one of the dictionary.
2866 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2867 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2868 values, but limits itself to values which are below a user specified
2869 size (by default 1024 bytes).
2870 * python/gdcm.i : elements not loaded (because their size is above the
2871 user specified treshold) are exported with their TagKey as key of the
2872 python dictionary. This enables the testsuite to make some checks
2873 on the unloaded elements (since we have their offset and size).
2874 * python/testSuite.py
2875 - now tests for the existence and proper value of the pixel data
2876 - two new examples added.
2877 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2879 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2880 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2881 aware. See the strategy comments in gdcmHeader::FindeLength().
2882 * Test/test.cxx now accepts a filename as first argument.
2883 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2884 * python/testSuite.py changed to integrate test on above files.
2886 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2887 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2888 the vr was also RET.
2889 * python/testSuite.py more tests added.
2891 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2892 * python/testSuite.py unittest test suite added (uses Data)
2893 * Data/* dcm and acr files for the test suite.
2894 * glib dependance removed from un*x version. We now use ISO C99
2895 7.18 Integer types (see stdint.h)
2896 - python/Makefile, src/Makefile src/gdcm.h
2897 * src/ when an explicit vr (like dicom files) suddenly poped an
2898 implicit element we use to mark the underlying DictEntry of the
2899 concerned ElValue with "Implicit". This strategy was damageable
2900 too the public or provite dictionaries, since some of their vr
2901 would be changed. Since Header::FindLength heavily relies on the
2902 detection by Header::FindVR of falsely explicit elements, I
2903 added an extra ImplicitVr member to ElValue (boolean).
2904 The rest of the changes we the necessary adaptations.
2906 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2907 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2909 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2911 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2912 * Adaptation for porting to VC++:
2914 o forced to use std namespace (for string to be known)
2915 o all class use __declspec export style on WIN32
2916 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2917 (in stdlib.h on Win32 but in std:: for gcc)
2918 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2919 variable GDCM_DICT_PATH.
2920 * src/gdcmHeader.cxx verbose comments made discrete.
2922 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2923 * python/gdcm.i: added a typemap that converts a C++ hashing table
2924 to native Python dictionary.
2925 * python/demo/test.py:
2926 - now uses the native dictionary for exploration of gdcmHeader.
2927 - takes an optional filename argument (the file to parse).
2928 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2929 PubElVals hashing table.
2930 * Dicts/dicomV3.dic removed error prone trailing spaces.
2932 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2933 * Python wrapping process moved away from src/Makefile to
2934 newly created python/Makefile (as well as gdcm.i)
2935 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2936 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2937 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2938 from the environement variable GDCM_DICT_PATH (when existing).
2939 * src/gdcmDict::GetTag bug fix.
2941 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2942 * Straightforward temporary fixes for swig to build the python wrappers.
2943 src/Makefile now has a python working entry [by working we mean
2944 that we can import de shadow classes without errors].
2946 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2947 * hashtest.cxx removed (since allready in Test)
2948 * src/gdcmlib.h renamed to src/gdcm.h
2949 * src/dcm.i renamed to src/gdcm.i
2950 * src/Makefile prepared for python wrapping
2952 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2953 * src/gdcmHeader.cxx :
2954 - Parsing of header is now separated from loading of element values
2955 (see gdcmHeader::LoadElements).
2956 - general clean up of hopefully all file access (creation of
2957 ReadInt16 and ReadInt32)
2959 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2960 * src/gdcmHeader.cxx :
2961 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2963 - SetLgrElem renamed to SetLength
2964 - GetLgrElem renamed to GetLength
2965 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2966 * src/gdcmElValSet.cxx fixed both GetElValue methods
2967 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2968 due to IdoDude was cleaned out.
2970 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2971 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2972 concentrates on finding the value representation (when it exists).
2973 RecupLgr now only finds the element value length, and it avoids
2974 returning the unecessary skL (skipped length).
2975 Also, offsetCourant was simply removed (with taille_fich) since
2976 it was redundant with the File position internals (by using
2977 ftell and fseek). This also made skL (see above in RecupLgr) usage
2979 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2980 on the libido specificities which are handled through class
2982 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2985 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2986 * Truckload of changes. Parsing of header is barely functional
2987 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2989 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2990 * src/gdcmHeader.cxx many addons of low level methods
2992 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2993 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2994 and _IdDcmSWAP_LONG.
2996 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2997 * This corresponds to all the changes decided at the meeting of
2998 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob