1 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
4 * Fix compilation on gcc 2.96 (which does not have ios::failure)
6 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
8 and it's representation name (for the NIH)
10 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
12 conversion of YBR to RGB pixels. So, now, the conversion is made using
15 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
17 format) to replace 'at-run' dicom files generated by the
18 TestAllReadCompareDicom test
20 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
23 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
26 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * Testing/TestMAkeIcon.cxx : complete the test
29 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
32 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
36 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
39 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * Test/ : accelerate tests (it's not very significant accelerations).
41 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
43 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * Testing/TestSequence.cxx : add test for sequences of images... test that
45 we have the same serie or the same study UID
47 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
50 * src/gdcmDict.h : remove commented code
51 * src/gdcmDocument.cxx : initialize values
52 * src/gdcmFile.cxx : bug fix when reading values
53 * gdcmPython/demo/ : change file names. Remove useless files
55 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * src/gdcmFile.cxx : remove the default array of initialization.
57 The static array contained pointers to non-static values (comming from
58 strings). To have coherences, when creating files, these values can't be
59 static. So, the array can't be static, too ! To simplify, the array have
60 been replaced by repeted lines to insert values in the File
62 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
64 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
66 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
67 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
68 (Dicom Element) into the Sequence Item
70 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * src/*.cxx : first parss to normalize file organisation
73 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * src/gdcmDirList.[h|cxx] : add method to find a directory
75 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
77 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
78 * Finish cleaning up my JPEG mess. Should be ok now.
79 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
80 contained within the RLE* class(doh!)
82 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
83 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
84 * SerieHeader::AddFileName() creates as many Coherent Files lists
85 (same Serie UID) as it founds different Serie UID
86 amongst the files instead of discarting any file
87 that doesn't match with the first one he found.
88 * SerieHeader::OrderGdcmFileList has now one parameter :
89 the Coherent Files list the user wants to sort
90 * SerieHeader::GetFirstCoherentFileList() |
91 * SerieHeader::GetLastCoherentFileList() | allow to parse
92 the set of Coherent Files lists
93 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
94 compatibility (it returns the *first* Coherent Files list,
95 since there was only one before)
96 * Test/TestSerieHeader gets gdcmData as a default root directory
98 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * Remove friend between DocEntry and File classes
100 * Remove friend between PixelReadConverter and RLEFramesInfo,
103 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
105 0002|0000. The value was incorrect.
107 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
108 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
110 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
111 * src/gdcmUtil.cxx : compilation fix on Win32
112 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
113 variable, to be easy found. Add methods to change the default UID.
114 Amelioration of the CreateUniqueUID to use the correct default UID.
115 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
118 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * Test/TestVR.cxx : fix memory leaks
121 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
122 * Rewrite the base 256 to base 10 conversion, using string operation only.
123 This allows us to get rid of the problematic 64bits integer type (does not
124 always exist on target platform).
126 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
127 * Add construct and destructor to class gdcm::Debug to close the debug file
129 * Don't let uset to open twice the same file
130 * gdcm has now an official UID prefix,
131 supplied by http://www.medicalconnections.co.uk
132 1.2.826.0.1.3680043.2.1143
133 (Thx to Mathieu for providing URL)
134 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
135 to be able to perform some more tests
136 * gdcm::ContentEntry : Contructors and Destructor are now protected,
137 in order to be sure no user will try to use them.
138 (at user level, only the children classes are meaningfull)
140 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * move RLEInfo & JPEGInfo from Document to File
143 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * FIX : remove so many friend between classes
146 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
148 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
150 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
151 In order to avoid missbehaviour :
152 . gdcm::DocEntry is now specialized in
153 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
154 - gdcm::ContentEntry (Dicom entry with a 'content')
155 . gdcm::ContentEntry is specialized in
156 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
157 characters value, or integers)
158 - gdcm::BinEntry (Dicom entry with a non strig representable value
159 (user hasn't any longer to thing about the precedence of his dynamic_casts)
161 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * Test/VTKTest*.cxx : bug fix under linux
164 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
166 use with python. Some methods are moved from Document to ElementSet or
167 DocEntrySet. The equivalent methods to ElementSet have been added to
168 SQItem and are virtual in DocEntrySet. Methods that may have the same code
169 in SQItem and ElementSet is directly placed in DocEntrySet
171 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * Test/VTKTest*.cxx : remove the show variable in each test method because
173 it's useless (the viewer variable replace this variable)
175 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * src/gdcmDocument.cxx : bug fix on potential memory leak
177 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
178 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
179 Add ClearXxx methods to remove all the content of the list or map
180 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
182 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
183 * methods ReplaceOrCreate renamed as Insert
184 (nobody will be any longer confused by 'CreateOrReplace')
186 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
187 * Grealty simplify the JPEg decompression, no need to differenciate based on
188 the JPEG possible type (with/without fragment, with/without multiple frame).
189 Everything is done throught the JPEG IO Suspension mechanism in IJG
191 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
192 * Stage 3 of normalization :
193 in order to avoid any missunderstanding while reading method names :
194 - All the methods xxxEntry now deal with dicom Entries
195 - Methods GetEntry splitted into
198 - Method SetEntry renamed as SetEntryValue
199 - Method SetEntryBinArea let as it was
201 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
202 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
203 - Position correctly the entry points for JPEG2000 and JPEG-LS
204 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
206 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
207 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
208 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
209 with other method names
210 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
211 * Test/TestDicomDirElement.cxx : add new test
213 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
214 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
215 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
216 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
217 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
218 So can't you use __int64 in ostream at all.
220 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * bug fix for compilation on MSVC6
222 * gdcmPython/gdcm.i : rename of classes missed
224 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
225 * Stage 2 of names normalization :
226 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
227 (easy to understand ...)
228 - gdcm::FileHelper replaces old class gdcm::File
230 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
232 type and not a string. So, there remove problems on the format of the
235 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
236 * Add Example/TestPapyrus.cxx
237 - reads a Papyrus file (gdcm::Header compliant),
238 - gets the pixels of all the images, using low level iterators
239 - writes an multiframes Dicom image.
240 (Just to show it's *possible* to do that)
241 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
244 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
246 Thus, DicomDirXXX are created with a flad that indicates if the created
247 object is empty or not (when not empty, the DicomDirElement is used to
250 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
251 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
252 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
254 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
255 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
257 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
258 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
259 Remove all access to the hash-tables or lists in the objects.
261 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
263 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
264 be complient with all the gdcm source code
266 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
270 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
271 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
274 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * Test/ : rename VTK tests to have a best name for the tests
276 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
277 GetFirstEntry/GetNextEntry use
279 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
280 * In SerieHeader::ImagePositionPatientOrdering()
281 // a Dicom 'Serie' may contain scout views
282 // and images may have differents directions.
283 // -> More than one may have the same 'pos'
284 // Sorting has then NO meaning !
285 Thx to Eduardo Davila for reporting bug.
287 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
289 test. Now it's on image content and not on the resulting visualisation...
290 might solve the problem on linux when using the OpenGL drivers
292 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
293 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
294 DicomDirSerie, DicomDirImage
295 Dict, DictSet classes :
296 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
297 -remove InitTraversal method.
298 * UPD Test programs + Example programs
300 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
301 * remove useless and never updated keyword \ingroup
302 * Solve pb when structure (list, map, ...) is empty.
303 Thx to Benoit for reporting bug
305 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
306 * Taking into account of 'Transfer Syntax' value
307 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
310 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
312 is no memory access violation
313 * gdcmPython/demo : add python demos using VTK
315 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
316 * FIX 'Dictionnary' is now spelt 'Dictionary'
317 'wether' is now spelt 'whether'
318 'archieve' is now spelt 'archive' ;-)
320 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
321 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
322 related methods, in order not to expose internal mechanisms
325 * REM methods that exposed internal mechanisms :
326 DicomDir::GetDicomDirPatients()
327 DicomDirPatient::GetDicomDirStudies()
328 DicomDirStudy::GetDicomDirSeries()
329 DicomDirSerie::GetDicomDirImages()
330 * UPD Test programs :
334 * UPD Example program
336 * ADD DictSet methods
340 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
341 * Removed the Print/indent/default parameter mess. There is absolutely no
342 reason to have to methods, moreover with the second taking the ostream as
343 *SECOND* parameter. This was clearly a bad hack to get things compile.
345 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
346 * Complete rewrite of the GetMacAddress code. Now the code is *much*
347 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
348 Unfortunately the main code does not work on SunOS, thus provide a specific
349 code for this platform only (and Win32 of course). Since this seems to be
350 working, change CreateUniqueUID to use GetMACAddress instead of the
351 problematic GctestetIPAddress
353 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
354 * Unfortunately to be able to test gdcmDirList I had to break the API
355 a little. Now the class is not a std::list anymore but has a member
356 std::vector (more ITK compatible). Allow unit testing on Win32 and
359 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
360 * Update SerieHeader to take into account a Serie Instance UID to properly
363 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
364 * ENH - Comment out Mathieu's (dangerous) Super Hack
365 for dealing with BIGENDIAN processors
366 - Move equivalent stuff to BinEntry::WriteContent
367 When necessary, 16 Bits Pixels are swapped in a small buffer
368 and then written. This avoid allocating a huge buffer, in
369 PixelWriteConvertor, and avoid modifying the Pixel Area.
371 Probabely, the same operation will have to be done when we want
372 to write image with Big Endian Transfert Syntax,
373 and we are working on Little Endian Processor
375 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
376 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
378 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
379 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
380 all the dict content.
381 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
383 * Test/TestDict.cxx : add a new test for the dict classes
385 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
386 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
387 file. Debug is yanked if compiled with NDEBUG
389 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
390 * src/gdcmDictSet.h : set the default output to the os variable
391 * src/gdcmDictEntry.[h|cxx] : add the Print method
392 * gdcmPython/demo/ : add a new test
394 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
395 * merging of Test/PrintDicomDir and Test/TestDicomDir
396 * removal of now redundant Test/PrintDicomDir
397 * enhancement of Example/PrintDicomDir
399 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
400 * Now, python test might work on systems
401 * Add the PrintDicomDir test
403 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
404 * FIX : First entry following group 0002 was lost for
405 Explicit Big Endian Transfer Syntax files
406 (group and elem not swaped)
408 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
409 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
410 Big Endian Transfer Syntax supposed the group following 0002
411 begins always by element 0000 (element 0000 is *optional*)
412 To avoid further troubles, let's be pessimistic, and use
413 Document::HandleOutOfGroup0002() method
414 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
415 (related pb not yet solved)
417 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
418 * Bug fix for the python part use
419 * Now, PrintHeader.py pass... but outside the ctest use. shit !
421 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
422 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
424 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
425 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
426 a string and should ask the global TS dict what are the propreties of
429 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
430 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
431 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
432 to swap the Swap Code, at parsing time, when we come out of group 0002
433 and Transfer Syntax is Big Endian
434 We should be able to read now 'true DICOM" Big Endian coded images
435 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
436 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
438 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
439 * Hopefully fix the bug on MacOSX and static global initialization.
440 This is the only -minor- patch I found that both please MacOSX and VS6.
441 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
442 but this would require a lot of change. Another approach would be that Global
443 create those string and GDCM_UNFOUND becomes a pointer to a string (which
444 gdcm::Global would destroy at exit).
446 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
447 * Fix bug on MacOSX with static initialization in a multy threaded
448 environment. static const string in a header file used to be ill
449 initialized provoquing the freeze of any tests. patch should solve this
452 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
453 * According to Benoit's suggestion, and without any objection from anybody
454 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
455 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
456 - method gdcmDicomDirObject::GetEntry() renamed as
457 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
459 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
460 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
461 you debug/warning message just as c++ streams which make them very convinient
462 to use. Once this is stabilize I will change the ostringstrem to be
463 redirected to a file (ofstream).
464 * Properly support C99 extension: __FUNCTION__ which allow us to display
465 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
467 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
468 * Removal of useless and dangerous methods :
469 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
470 GetDocEntryByName, GetEntryByName, GetDictEntryByName
471 * Removal of usless methods :
472 Dict::PrintByName, Dict::GetDictEntryByName
473 * Commenting out of probabely useless methods :
474 Dict::GetDictEntryNames()
475 Dict::GetDictEntryNamesByCategory()
476 DictSet::GetPubDictEntryNames()
477 DictSet::GetPubDictEntryNamesByCategory()
478 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
479 * ENH : Use dicomTS.dic as described in 2004 version
480 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
481 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
482 Add Accessors on VM (Value Multiplicity), and VM related methods
483 * ADD : Add a list of 'Dicom Attribute types', as found in
484 http://medical.nema.org/dicom/2004/04_15PU.PDF
486 * ADD : Add dicomGroupNameAbbreviations.dic
487 should be used to write a method to replace the former
488 Dict::GetDictEntryNamesByCategory()
490 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
492 to read in the file... and only it ! Length is the efective length of the
493 data in the DocEntry structure
495 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
496 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
497 And now use a static function call instead, with a global variable. i
498 This is much closer to the VTK approach. Hopefully should be bulletproof
499 and easier to use...hopefully
501 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
502 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
504 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
505 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
507 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
509 ValEntry, BinEntry, SeqEntry creation or replace
511 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
512 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
513 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
515 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
516 when specifying the VR
517 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
518 * src/gdcmDocEntry.cxx : amelioration of print
520 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
521 * ADD : Add the method Util::IsCurrentProcessorBigEndian
522 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
523 * ADD Method Document::ComputeGroupLength
524 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
525 in order to allow further VR modification by user
526 * REM : removal of once-called method File::WriteBase
527 integration of its code in formerly one-line method File::Write
529 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
530 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
531 replace the different values "??", "Unkn", "Unknown".
532 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
533 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
534 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
535 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
537 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
538 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
540 * Set the gdcm::Base class to some Printable classes
542 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * src/gdcmFile.[h|cxx] : add the Print method
544 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
545 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
546 * src/gdcmDocument.h : remove the PrintLevel informations
547 * Example/PrintFile.cxx : use the new gdcm::File::Print
549 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
550 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
551 problems when compiling with the python wrapping
553 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
554 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
555 writting in ImplicitVR
557 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
558 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
559 JPEG decompression, especially when dicom frames are split into several
560 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
561 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
563 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
564 * src/gdcmHeader.cxx : change the initialisation of default header.
565 Now, this header is readable by gdm, e-film, DicomWorks
567 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
568 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
569 Rename Decompressed to Raw
570 * Use the API changes in gdcm::File.
571 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
574 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
576 each added entry in the header. Replace the 'Planes' field by the 'Number
579 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
580 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
581 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
583 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
584 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
585 At this time, this image isn't readable by e-film... waiting JPR help to
588 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
589 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
590 DocEntry. Now use methods of the Document !
592 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
593 * Test/ShowDicomSeq.cxx : bug fix
595 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
596 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
597 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
598 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
599 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
601 * Test/TestCopyRescaleDicom.cxx : remove unused variable
602 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
603 containing found sequences
605 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
606 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
608 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
609 Some fields in BinEntry must be copied to not seg fault when making the :
610 gdcm::File *copy = new gdcm::File( copyH );
611 and tests are now made on good variables
613 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
614 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
615 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
617 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
618 * Add vtkGdcmWriter example and test
620 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
621 * Test/TestUtil.cxx : reformat the source code
622 * vtk/vtkGdcmReader.cxx : remove and change prints
623 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
625 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
626 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
628 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
629 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
630 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
632 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
634 by an eof to prevent all bad read of the file... and in this case, the
637 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
638 * Example/Volume2Dicom.cxx : comment unused variables
639 * Test/PrintDicomDir.cxx : comment unused variables
640 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
641 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
642 method that is redondant with AddEntry.
643 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
646 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
647 * Bug fix due my last commit (compilation under Windows).
648 * Example/Volume2Dicom : bug fix in the file and reformatting source code
649 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
651 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
653 - Remove printf / sprintf
654 - include iostream AFTER gdcm so we don't get warnings
655 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
657 - Also remove tons of include from header files, hopefully this should
658 speeup the compilation time, since it was becoming a dog slow.
659 - Remove gdcm.h as it include way too many files and slow down compilation
660 (plus it is not up to date)
661 - remove 'using namespace std' this is BAD !
663 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
664 * Remove memory leaks on the DicomDir
665 * Remove some useless data in DicomDirObject
666 * Add usefull methods in SQItem, to be complient withe the ElementSet
668 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
669 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
671 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
672 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
673 future, with convertion)
674 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
675 and ImageDataSize values. Remove the method to get the PixelReadConverter
676 from the output of the class
678 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
679 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
681 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
683 and vtkErrorMacro use.
684 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
686 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
687 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
689 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
690 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
691 The string leaves only in the fonction. So when we make a .c_str(), we
692 get the pointeur on the first element, element that will be destroyed
693 immediately after thee instruction.
694 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
695 file has been opened : the test must be made on the content of the
696 pointer and not directly on the pointer !
699 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
700 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
701 the python part recompiles
703 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
704 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
705 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
706 X session is killed (for my computer... it seems to not be identic on
709 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
710 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
711 avoid problems (otherwise, the difference test between the visible image
712 and the reference is incorrect. If the reference is greater than the
713 screen resolution, it's produce errors).
714 Can be used for only one image. Can be used with a visible flag.
715 * vtk/vtkGdcmReader.cxx : remove commented codes.
716 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
717 under windows at compilation
718 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
720 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
722 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
723 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
724 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
725 tests on the image size X, Y, Z
727 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
728 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
729 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
730 between the class name and the file name
732 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
733 * src/ : fix compilation warnings for the Write method (2 different
734 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
735 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
736 variable... create a static method in gdcm::Document to access to
737 this variable content.
739 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
740 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
741 file, to be accessed by other files (like gdcmFile). Remove commented
742 code. Move the change of the header to the gdcmFile, using the
744 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
745 To be sure of that (and simplify calls), the Write of the header now
746 gets a file name and not a file pointer (std::ifstream).
747 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
748 DocEntryArchive. Remove all open of the written file
750 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
751 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
753 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
754 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
755 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
757 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
758 some corresponding methods. Write correctly the file and check before
760 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
761 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
762 is now on RGB data (as before my last commit
763 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
765 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
766 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
767 Add a print information of the type of the entry
768 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
769 It was in the gdcmFile, and all write have been regrouped
770 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
771 Write correctly all dicom files (in decompressed mode only at this time)
772 * Test/ : test on files are now made using Raw data and not color data if
774 * Example/PrintFile.cxx : add more printings
776 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
777 * Amelioration of code, remove some code copy. For the loading of
778 BinEntry (in gdcmDocument), add the test to verify if the file is already
781 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
782 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
783 remove a DocEntry in the header (push an empty DocEntry)
784 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
785 lines. Bug fix in the initialization of the PixelConvert and the
787 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
788 use in TestCopyDicom (now this test can run under windows... but fails)
789 * Test/TestCopyDicom.cxx : amelioration of the test :
790 - test the pixels written
791 - add test points to quickly find where is the error
792 - can set a file name input and output in arguments
793 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
794 amelioration of the test output
796 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
797 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
798 all replaced DocEntry's
799 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
800 Now, each needed DocEntry to modify is duplicated, modified and inserted
801 to the header using DocEntryArchive. Thus, after save, we can restore the
802 header initial state.
804 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
805 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
807 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
808 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
809 correct to copy it. The DictEntry is specified at the DocEntry creation,
810 then, it musn't change in the time.
811 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
812 header correctly. At this time, the change is only made for the first
813 level of the Document. In the future, it might consider sequences.
814 The change is made by replacing a DocEntry by an other that is created
815 outside the class. The old value is kept. When we restore the header
816 status, the added DocEntry is deleted and replaced by the old value.
817 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
818 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
819 set the write type to explicit VR, implicit VR or ACR. Add methods to set
820 the write mode to native, decompressed or RGB (but not used at this time)
822 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
823 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
824 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
826 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
827 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
828 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
830 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
831 set because already copied when copying the BinEntry's of the header
832 * Test/TestAllReadCompareDicom.cxx : remove warnings
834 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
835 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
836 Two problems appear when doing it :
837 - with the gdcmFile : when the GetImageData method is called, the pixels
838 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
839 data (pixels). And each structure destruct the data when it's
840 destructed. So we have two destructions for the same data. To solve it,
841 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
842 data or not. If it doesn't own data, then they will not destroyed by
844 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
845 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
846 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
847 create a double destruction of the same DocEntry's. So, to solve it,
848 the TagHT is simply cleared and the DicomDir* elements are destroyed.
849 * TODO : add an entry concerning memory leaks in the DicomDir
851 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
852 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
853 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
856 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
857 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
858 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
859 after it have been deleted
861 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
862 * FIX: src/* fix the doxygen warnings.
863 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
864 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
865 was erroneously defined with a size of 15 instead of 16. [many thanks
866 to Jean Michel Rouet for pointing out this bug].
868 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
869 1. Finish merging JMR patch for writting DICOM from scratch
870 2. Fix -hopefully- bug with MONOCHROME and space vs null character
871 3. Use const ref when possible
872 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
873 5. A few more comments
874 6. CreateUniqueUID can now be called without parameter"
876 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
877 * ENH: Slightly bigger patch:
878 1. Getting toward full integration of JMR patch for writting dicom from scratch
879 2. Update Test to test part of this patch: CreateUniqueUID
880 3. File was not close properly in gdcmDict
881 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
882 5. Use of const ref instead of copy (speed issue)
883 6. Remove temporary (duplicate) string in TranslateToKey
884 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
885 8. Do not repeat virtual in subclasses
886 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
888 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
889 * Apply first patch toward better string comparison when dealing with broken
890 DICOM files. Essentially the string could be padded with a space instead
891 of a null character as defined by standard
893 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
894 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
895 because never used... and in the same time, that's remove some memory leaks
897 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
898 * src/gdcmFile.cxx : now delete the PixelConvert instance.
899 * In examples and tests : change the type of image data variables from void*
900 to uint8_t*. Remmove all delete on image data variables
902 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
903 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
904 Verify the file pointer value before open the file, and if it's not null,
905 a verbose message is generated.
906 Close correctly the file when the file isn't considered dicom-like. The
907 correctly close is a call to CloseFile.
908 When closing the file pointer, test if its not null to close the file.
909 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
910 file. For an uncompressed image, the copied data correspond in the least
911 case to the image size (calculated) or the image size specified in the
912 header. A verbose is generated if these two size mismatch
914 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
915 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
916 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
917 break under windows (with msvc6 compilation).
919 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
920 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
921 compiling with MSVC6)
923 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
924 * Bugs fix for the Windows build with VC6
925 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
926 needed (only for projects required VTK). If the VTK is included in all
927 projects, there is conflicts with the jpeg lib of vtk when compiling the
928 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
929 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
930 when compiling the gdcm_wrap.cxx file (created by the compilation of the
932 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
933 (like it's already made for the cout use). Otherwise, conflict with the
936 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
937 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
939 - comments on the DicomDir::Method related usage added.
940 - now that we use the namespace gdcm, a lot of internal classes do
941 NOT need to be wrapped anymore.
942 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
943 DicomDir::Method) new example added.
945 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
946 * Improve string manipulation. I now inforce the notion of 'DicomString'
947 A DicomString can contain as many \0 as they want
948 and it is *always* of even length.
949 We only support odd length for very rare case.
950 And in the near future this should be removed.
952 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
953 * /binary_write/ gdcm source. Now even on big endian we are writting
954 little endian. This should -heopfully- fix some tests
956 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
957 * Now the dictionary is compiled into gdcm lib. This is a default
958 behavior, thus any dic file specified is picked before failback to
959 the one comiled into lib
961 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
962 * Change internals for gdcmDict. Don't use any 'new' any more.
963 This should definitely solve any leak problem, and we should be
964 as fast as before, as long as don't modify too much the dictionary.
966 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
967 * STYLE: ivars should start with a capital letter.
968 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
969 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
971 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
972 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
973 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
974 new 2004 dictionaries added (thanks to JPR).
975 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
976 * CLEANUP_ROUND (15) for gdcmPixelConvert
977 - RLEFrame::NumberFragments is now of type unsigned int
978 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
979 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
982 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
983 * Initial work in gathering all transfer syntax accessors. clearly
984 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
985 ivars, but only one transfersyntax (class) ivar with equivalent method on
988 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
989 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
990 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
991 discussed (plus I didn't like having a 2000 lines patch not commited)
993 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
994 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
995 * CLEANUP_ROUND (14) for gdcmPixelConvert
996 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
997 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
998 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1000 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1001 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1002 into File::Pixel_Data.
1004 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1005 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1006 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1007 * CLEANUP_ROUND (13) for gdcmPixelConvert
1008 Substituted File::ParsePixelData() with PixelConvert::Print() new
1010 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1011 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1012 method to those classes.
1013 - src/gdcmFile.[cxx|h]:
1014 -- Added a ::Print() method.
1015 -- PixelConverter is now a reference instead of a member.
1016 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1017 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1019 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1020 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1021 collaboration diagram and inheritance diagram should be generated with
1023 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1024 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1025 pointlessly wrapped (see
1026 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1027 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1028 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1029 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1030 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1031 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1032 -- File::Initialise: PixelConverter setup moved away to
1033 PixelConverter::GrabInformationsFromHeader()
1034 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1035 interpretation moved away to PixelConverter::BuildRGBImage()
1037 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1038 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1039 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1041 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1042 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1043 displayed on Win32 when a brutal abort() occurs (because of uncatched
1044 exception). See TODO new entry of this commit for more on this.
1045 * TODO added new entry.
1046 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1047 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1048 - HandleColor is no longer called from gdcmFile.cxx
1049 - gdcmPixelConvert.cxx clean up on method arguments and internal
1050 variable names for semantical coherence.
1052 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1053 * Finished lossless transition, not only do we now read all lossless jpeg
1054 images, without the need of the Cornwell lib, but we do read them properly now
1055 * To reduce code (well to avoid code duplication), I defined a common place
1056 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1057 redefine symbols. This is not perfect but this the best solution I found for a
1058 compilation time jpeg option.
1060 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1061 * Update jpeg ijg lib to support lossless jpeg implementation
1062 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1064 * Also added a special copyright for dcmtk since we use their bugfixes.
1067 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1068 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1069 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1070 matters, as stated in warning note at beginning of %include section).
1071 * src/gdcmDicomDir*.[cxx|h]: coding style
1072 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1073 * src/gdcmJpeg8.cxx: doxygen fix.
1074 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1075 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1076 from File:: to PixelConvert::.
1078 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1079 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1080 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1081 - more code moved away from File:: to PixelConvert::
1082 - fat setup of PixelConverter set in place in File::Initialise.
1084 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1085 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1086 namespace at the file system level. So now you should convert your examples
1088 gdcmHeader -> gdcm::Header
1089 It would be nice if people keep in mind to no open the namespace, since it
1090 allows compilation on broken plateform which were defining common symbol in
1091 the standart namespace (like LP, Unknown ...)
1093 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1094 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1095 The JPEG fragments are now parsed at the same stage than the RLE
1096 information. All code related to JPEG is now in gdcmPixelConvert:
1097 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1098 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1099 export a gdcmFile:: method. Those are simply global functions
1100 (for the time being this is better than having them attach to
1101 either gdcmFile:: or gdcmPixelConvert::).
1102 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1103 and stores the result in a gdcmJPEGFragmentsInfo.
1104 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1105 code (among other stuff) moved away from gdcmFile:; to
1108 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1109 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1110 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1111 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1112 clean up of RLE related code.
1113 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1114 - src/gdcmRLE.cxx removed
1115 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1116 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1117 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1118 * CLEANUP_ROUND (9) for gdcmPixelConvert
1119 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1120 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1121 away from gdcmFile:: to gdcmPixelConvert::.
1123 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1124 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1125 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1126 This is because Parse7Fe0 used to parse the pixels to compute the
1127 length. This task was passed over to FindDocEntryLengthOB() a long
1128 time ago, EXCEPT I had forgotten the OW case...
1129 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1130 we just recylce the code for parsing RLE fragments and computing
1132 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1133 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1134 with the retired Parse7Fe0().
1135 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1136 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1138 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1139 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1140 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1141 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1142 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1143 * CLEANUP_ROUND (4) for gdcmPixelConvert
1144 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1145 to return an unused length.
1147 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1148 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1149 this should be cleanner from the plane view. The iostream are erally a pain
1150 to use to do simple stuff.
1152 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1153 * Redo the compilation of the ijg jpeg library. Now only one source is
1154 necesseray. No need to rename file by hand what so ever. CMake handle the
1155 copying of the file within different directory, configure header file to
1156 modify some symbol. The only addition made to ijg wasd a mangle table so
1157 that symbol are different whether we are within 8bits or 12bits.
1159 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1160 * Added documentation of vtkgdcmReader on Website:
1161 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1162 with it's binary name).
1163 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1164 the Website to be more complete.
1165 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1166 doxygenated documentation.
1167 - Doc/DoxyVtkGdcmReaderExamples.txt added
1168 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1169 DoxyVtkGdmReaderExamples.html )
1170 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1171 * CLEANUP_ROUND (3) for gdcmPixelConvert
1172 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1174 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1175 * CLEANUP_ROUND (2) for gdcmPixelConvert
1176 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1178 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1179 * CLEANUP_ROUND for gdcmPixelConvert:
1180 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1181 - src/gdcmPixelStuff[h|cxx] removed
1182 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1183 - src/CMakeLists.txt changed accordingly
1184 * GDCMHOME clean up:
1185 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1186 gdcmVersion.py moved to newly created ATTIC related
1187 gdcmPython/SetupOldies/ directory.
1188 * Autotools clean up:
1189 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1190 - autogen.sh configure.in acinclude.m4 python.m4 removed
1192 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1193 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1194 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1195 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1197 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1198 * TODO updated with Mathieu suggestions. I proposed a template for
1199 describing TODO entries and used it for new entries.
1200 * Added Doc/Website/CodingStyle.html, Developpers.html,
1201 DeveloppersPython.html, GdcmDataCvs.html and
1202 DownloadVersion0_1.html, DownloadVersion0_3.html.
1203 * Some Doc/*.txt Doxygen files (which do not really concern the
1204 documentation itself, but the website) moved to html and
1205 placed in directory Doc/Website:
1206 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1207 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1208 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1209 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1210 * CMakeLists.txt changed accordingly.
1211 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1212 DeveloppersPython.html
1213 * INSTALL nows refers to Doc/Website/Installation.html
1215 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1216 * Added Doc/Website directory, that contains a first raw version
1219 2004-09-23 Jean-Pierre Roux
1220 * FIX In order not to be poluted any longer by casting problems,
1221 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1222 we can now delete[] it safely
1223 * VoidArea is now called BinArea (less confusing name),
1224 and all the methods called ...VoidArea... are now ... BinArea...
1225 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1227 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1228 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1229 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1230 up to the destructor of gdcmElementSet to clean up TagHt and it's
1233 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1234 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1235 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1237 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1238 * ENH: added some utility method that builds a flat dictionary
1239 holding all the Dicom entries contained in the recursive structure
1240 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1241 an example of usage.
1242 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1243 BuildFlatHashTable() that build a flat dictionary.
1244 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1245 gdcmDocument is now a friend of gdcmElementSet.
1246 - src/gdcmElementSet.cxx: clean up.
1247 - Example/FlatHashTablePrint.cxx added.
1248 - Example/CmakeLists.txt changed accordingly
1250 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1251 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1252 moved away from gdcmDocEntrySet (since this class is an abstract class
1253 acting like an interface). SQDepthLevel and BaseTagKey are now
1255 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1256 and associated accessors. Doxygenation of the class.
1257 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1259 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1260 Use SQDepthLevel accessor instead. ::Print() adapted.
1261 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1262 - src/gdcmDocument.cxx changed accordingly.
1264 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1265 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1266 - The following is the doxygen comment of the typedef declaration
1267 of gdcmTagKey in src/gdcmCommon.h:
1268 gdcmTagKey is made to old an "universal" (as in URL, Universal
1269 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1270 A dicom tag always has a group and an element, but a set of tags
1271 embeded in various (optionally nested) sequences and sharing
1272 the same group and element all share the same (group, element)
1273 "identifier". Hence the (group, element) cannot be used as an
1274 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1275 In order to construct a proper tag identifier (i.e. a key) we
1276 consider the following definition of a TagKey:
1277 - let Group, Element be the string representation of the
1278 group and element dicom tag members,
1279 - let ItemNumber be the string representation of the integer
1280 index of the considered item number of a sequence,
1281 Let the key of a tag embeded in a sequence, noted SeqTag, be
1283 /ItemNumber#Group|Element
1284 where "/", "#" and "|" are characters acting as separators.
1285 Then the general form of a gdcmTagKey is given by:
1286 Group|Element<SeqTag>
1287 where <SeqTag> means NO or many instances of SeqTag.
1288 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1291 but the gdcmTagKey of a tag "embeded" is the first item of
1292 a sequence, itself nested in the third item of a sequence is the
1294 0004|1220/2#0008|0082/0#0008|0090
1295 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1296 order to hold the new sequence compatible key. Previously, the
1297 GetKey() method would look in the underlying gdcmDictEntry.
1298 - src/gdcmDocEntry.cxx:
1299 -- constructor now copies the underlying DictEntry key, in the local
1301 -- ::Print: displays the member Key, instead of the (group, element).
1302 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1303 - src/gdcmDocEntrySet.h:xi
1304 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1305 -- now has a new BaseTagKey member.
1307 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1308 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1310 This poses the problem with the semantics of the following lines
1311 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1312 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1313 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1314 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1315 to the long FIXME note for what the problem is. Nevertheless in
1316 order to get things working the dicom dictionary was altered !
1317 Please fix things urgently...
1318 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1319 information), see above note on moving the member VoidArea. Nevertheless
1320 the following entries previously correctly set as US are now inproperly
1322 0028 1201 OW IMG Red Palette Color Lookup Table Data
1323 0028 1202 OW IMG Green Palette Color Lookup Table Data
1324 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1325 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1326 of gdcmDocEntry moved to gdcmSeqEntry.
1327 * src/gdcmSeqEntry.cxx: STYLE.
1329 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1330 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1332 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1333 * gdcmPython/testSuite.py: all the test suite in python is now moved
1334 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1335 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1336 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1338 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1339 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1340 to avoid inclusion recursion until STL is reached.
1341 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1342 mecanism. errno.h is not included in gdcm anymore.
1343 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1344 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1346 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1347 gdcmData/TestAllEntryVerifyReference.txt
1348 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1349 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1350 exception_on_error parameter.
1351 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1352 - vtk/vtkGdcmReader.cxx changed accordingly,
1353 - Example/*.cxx and Test/*.cxx changed accordingly.
1355 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1356 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1357 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1358 enable_sequences removed from gdcmHeader constructor and dependencies.
1359 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1360 * gdcmPython/demo/PrintHeader.py: dummy fix.
1361 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1362 skip_shadow removed from gdcmHeader constructor and dependencies.
1363 * Example/*.cxx and Test/*.cxx changed accordingly.
1365 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1366 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1367 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1369 2004-07-21 Jean-Pierre Roux
1370 * FIX Now, Parsing and Printing a DICOMDIR do work!
1371 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1373 2004-07-20 Jean-Pierre Roux
1374 * FIX Some brain damaged headers have Zero-Lenght fields
1375 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1377 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1378 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1379 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1380 variable (instance of gdcmDebug) by a definition macro, and the instance
1381 is now in static in the gdcmDebug class
1382 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1383 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1385 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1386 * WARNING: ctest now depends more tightly on gdcmData. You should
1387 check out gdcmData properly for things to run smoothly...
1388 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1389 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1390 we need the pixels not be loaded in order to use the ValEntry
1391 that displays position and size).
1392 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1393 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1394 be deprecated. If you have any doubts about the advantages of a
1395 modern scripting language (read Python) versus grass root C++ (i.e.
1396 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1397 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1398 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1399 Anyhow, consider documenting the gdcmData images in
1400 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1402 * Test/CMakeLists.txt:
1403 - now uses TestAllEntryVerify.cxx
1404 - specific comments on oldACR00001.ima (now renamed in gdcmData
1405 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1406 gdcmData/TestAllEntryVerifyReference.txt
1409 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1410 * src/*.[h|cxx] : typedef clean up
1411 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1412 - TagKey renamed to gdcmTagKey (for external usage)
1413 - VRKey renamed to gdcmVRKey (for external usage)
1414 - removal of typedef duplication.
1415 - Removed all unecessary inline keyword from class inline definitions.
1416 - Some method|function(void) declarations replaced with method|function().
1417 * src/jpeg/libijg12/jdhuff12.c:
1418 - printf polluting ctest removed.
1419 - TAB removal for comminting
1421 - TestAllReadCompareDicom.cxx: added a test that compares all the
1422 images in gdcmDataImages.h with corresponding images in
1423 gdcmData/BaselineDicom/. When baseline images are not present
1424 this test creates them.
1425 Note: we need to validate each reference image, but before that
1426 I'd like to rename them with a more explicit name...
1427 - CMakeLists.txt: changed accordingly.
1428 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1429 including each header needed).
1431 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1432 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1433 test suite to the Example directory. Are concerned:
1438 - TestWriteSimple.cxx
1439 * Test/CMakeLists.txt: added some comments on reasons for black listing
1440 image gdcmData/oldACR00001.ima
1442 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1443 * Test/CmakeList.txt: removed the following from black list (to be coherent
1444 with removal from gdcmData):
1445 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1446 - gdcm-MR-PHILIPS-16.dcm
1448 Added the following because after last cvs update, they cause
1449 ctest -R TestReadWriteReadCompare
1451 - gdcm-MR-SIEMENS-16-1.acr
1453 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1454 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1455 new comments in this file) we temporarily (sigh) move to a weaker
1457 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1458 we don't need to black list the following images anymore:
1459 - 8BitsUncompressedColor.dcm
1461 - US-PAL-8-10x-echo.dcm
1462 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1463 fixes and the beautified code ;-)
1464 This fixes the bug introduced in version 1.42 (when beautifying)
1465 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1466 Note: ctest was blind to this bug (this means we need to still
1467 improve the test suite). The bug could be detected by using
1468 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1470 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1471 and by displaying the (garbage) produced file temp.XDCM...
1473 2004-06-29 Jean-Pierre Roux
1474 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1475 - replace by uggly but working old code :-(
1476 A lot of things should be OK again.
1477 It's really urgent to have a test suite that *tests*,
1478 to prevent Frog's beautifying sessions to break all the stuff
1479 (twice, withing a fortnigh ...)
1481 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1482 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1483 redundancy) to added Test/TestReadWriteReadCompare.cxx
1484 * Test/CmakeList.txt: because the compare test of
1485 Test/TestReadWriteReadCompare.cxx fails, the following images are
1486 black listed: - 8BitsUncompressedColor.dcm
1488 - US-PAL-8-10x-echo.dcm
1489 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1490 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1491 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1492 and ad-hoc kludge. This kludge is now removed, and on encountering
1493 such an image (OB field brain damaged) we set errno. Then in
1494 ::FindDocLength() we "fix" the length as being ALL what remains
1495 in the file (until EOF). We then proceed, hoping for the best...
1496 This fixes a SegFault in ShowDicom when trying to write such an
1498 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1499 (because TestWriteRead breaks on it, after a non conformal commit?).
1500 ctest now runs properly, except for MakeDicomDir (which was always
1501 broken) and the Python related stuff (still not fixed).
1503 2004-06-24 Jean-Pierre Roux
1504 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1505 FIX : Test/TestReadWrite now iterates on all the file names
1506 (instead of infinite loop)
1507 ENH : Test/TestWriteRead now iterates on all the file names
1509 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1510 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1512 2004-06-24 Jean-Pierre Roux
1513 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1514 when SamplesPerPixel =3
1515 - now Write is no longer confused by
1516 'BitsAllocated = 12" and 'BitsStored=12"
1517 - "UN" value representation Elements are now written correctly
1518 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1519 ENH : - now gdcmHeader has its own Write methods
1520 (in order to split the job that has not to be done
1523 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1524 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1525 loop on the same image until memory went out.
1526 Note: this means we still have gobs of memory loss in PrintDocument
1527 * src/gdcmDocument.cxx: fixes problem on parsing on file
1528 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1530 2004-06-24 Jean-Pierre Roux
1531 FIX : Write - All the Sequences and Sequence Item are now written
1532 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1533 is added a the end, when necessary.
1534 - A lot of brain-damaged images, that were read correctly are
1535 now written correctly
1536 - length compatible BinEntry are now loaded correctly
1537 (even for odd groups)
1538 Note : only Explicit Value Representation was checked.
1539 (question : is implicit VR really necessary for gdcm ?)
1541 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1542 * DEVELOPPER: added a proposition of coding style.
1543 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1546 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1547 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1548 Use the gdcmDocEntry::Print() and Write() instead.
1549 * src/gdcmDocument.cxx: bug fix.
1551 2004-06-22 Jean-Pierre Roux
1552 FIX : gdcmDocument.cxx
1553 - Now we do recognize the JpegLossLess format (there was a misstyping in
1554 code 'beautyfication' :-(
1555 - Now we automaticaticaly load the Luts, if any
1557 2004-06-22 Jean-Pierre Roux
1558 In order : to write Sequences, whatever their imbrication level,
1559 : to allow user to create his own Sequences
1560 a lot of modif where necessary (adding, moving, or virtualising methods)
1562 WARNING : save your own sources *before* cvs up !
1565 ADD virtual void Write(FILE *fp, FileType filetype);
1568 ADD virtual void Write(FILE *fp, FileType filetype);
1569 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1572 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1573 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1574 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1575 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1576 ADD std::string GetEntryByName(TagName name);
1577 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1579 std::string vr = "unkn",
1580 std::string fourth = "unkn",
1581 std::string name = "unkn");
1582 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1583 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1584 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1585 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1586 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1587 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1588 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1589 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1592 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1593 ADD virtual std::string GetEntryByName (TagName tagName);
1594 ADD virtual std::string GetEntryVRByName (TagName tagName);
1595 REM virtual bool Write(FILE *, FileType);
1596 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1597 FILE *_fp, FileType type);
1598 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1599 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1600 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1601 REM virtual std::string GetEntryByName (std::string tagName);
1602 REM virtual std::string GetEntryVRByName (std::string tagName);
1603 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1604 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1605 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1607 std::string vr = "unkn",
1608 std::string fourth = "unkn",
1609 std::string name = "unkn");
1610 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1611 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1612 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1613 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1616 ADD virtual void Write(FILE *fp, FileType filetype);
1619 ADD virtual void Write(FILE *fp,FileType filetype);
1622 ADD virtual void Write(FILE *fp, FileType filetype);
1623 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1624 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1625 REM std::string GetEntryByName(TagName name);
1628 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1630 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1631 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1632 The default constructor invoked by the line
1633 gdcmHeader *f1 = new gdcmHeader( header );
1634 was gdcmHeader::gdcmHeader(bool) instead of the expected
1635 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1636 Hence the parsing wasn't executed... See also below.
1637 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1638 as explicit constructor didn't do the trick to fix the above problem.
1639 Could anyone explain why ?
1640 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1641 properly calls gdcmValEntry::Print() (that was weed out from
1642 code related to gdcmBinEntry).
1644 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1645 * In order to fix memory leaks:
1646 - Test/TestWriteSimple.cxx: added cleaning of free store through
1648 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1649 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1650 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1651 (through the call to ::AddDicomDirMeta()) or the destructor
1652 would crash when deleting uninitialized ::metaElems].
1653 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1654 - src/gdcmDocument.cxx:
1655 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1656 from dynamic stores.
1657 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1658 was causing memory leaks.
1659 - src/gdcmSQItem.cxx:
1660 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1661 cleanly handled with polymophism: sorry but my milage is low).
1662 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1663 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1664 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1665 This avoids SegFaulting.
1666 - src/gdcmSQItem.h: coding style.
1668 - Test/TestWriteSimple still severely sucks. The output image content
1669 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1670 damaged when displayed with vtkgdcmViewer.
1671 - on memory leaks: TestWriteSimple leaks really less (see entry
1672 of 2004-06-18 in Changelog file for the call to valgrind).
1673 - on segfaults: ctest now passes all the tests but one (no more
1675 * Erroneous leading white fix:
1676 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1677 white[s] (as opposed to from >> xxx, that removes it [them].
1678 - src/gdcmTS.cxx: ditto.
1679 - gdcmPython/testSuite.py: dirty related kludge removed.
1680 * src/*: remaining references to gdcmParser removed.
1681 * src/*[cxx|h]: added copy[way]left header.
1684 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1685 * In order to fix writing of dicom files:
1686 - Test/TestWriteSimple.cxx: a simpler example of writing.
1687 - Test/CMakeLists.txt changed accordingly.
1688 - src/gdcmDocument.cxx:
1689 -- The destructor now recursilvely removes potential sequences.
1690 -- Bug fix in ::IsJPEG2000()
1691 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1692 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1694 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1695 to only declared) and build on top of
1696 ::GetDocEntryByNumber(guint16, guint16).
1697 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1698 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1699 for usage in destructor and treatement of promotion in
1700 ::ReplaceOrCreateByNumber().
1701 - src/gdcmSQItem.cxx: destructor should better handle his job.
1702 Test/TestWriteSimple now runs (or at least it DOES something).
1703 * We can now start hutting memory links. A good starting point is:
1704 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1705 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1706 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1708 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1709 * Valgrind note: after Mathieu Malaterre teached me how to read
1710 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1712 Using gcc, you can force the STL to use malloc and to free memory as
1713 soon as possible by globally disabling memory caching.
1714 With 3.2.2 and later, you should export the environment variable
1715 GLIBCPP_FORCE_NEW before running your program.
1716 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1717 simply vanish (it is still not clear to me, whether this means that
1718 STL std::string leaks or if valgrind believes it leaks...).
1719 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1720 running bin/gdcmTests makeDicomDir):
1721 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1722 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1724 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1725 SegFaulting (I drowned in DicomDir related code when trying to
1726 understand why the list is empty...).
1727 * src/gdcmDocument.h: first BSD license header try.
1728 * Doc/License.txt added.
1730 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1731 * src/gdcmDocument.[h|cxx]:
1732 - Clean up of the Transfer related predicates. They are now all based
1733 on new method isGivenTransferSyntax, that (should) handle properly
1734 the padding problem.
1735 - general clean up, simplification, and coding style.
1736 - Specific clean up of Parse7FE0() (umproperly named actually).
1737 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1739 2004-06-14 Jean-Pierre Roux
1741 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1742 - fix the display of SQItem ordinal number
1743 - add the GetSQItemByOrdinalNumber method
1744 - remove some useless never written private methods
1746 2004-06-14 Jean-Pierre Roux
1748 - adding a constructor taking a gdcmDocEntry as an input param
1749 - ReplaceOrCreateByNumber now returns :
1750 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1751 a gdcmValEntry * if a string value is passed as a param
1753 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1754 according to the param type (no longer sets a gdcmDocEntry)
1755 - GetValEntryByNumber, GetBinEntryByNumber added
1756 - NewValEntryByNumber and NewBinEntryByNumber added
1758 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1760 - GetSQItemNumber and SetSQItemNumber added, to provide
1761 a (relative) Item identier inside a given Sequence
1762 \warning : some pb remaining around this number
1764 - AddEntry now takes the Item Number as a param
1766 - adding a constructor taking a gdcmDocEntry as an input param
1768 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1769 * Memory leak hunt with the following command:
1770 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1771 --show-reachable=yes gdcmTests PrintDocument
1772 It looks like many (all?) leaks are due to the STL (or a bad usage
1773 of the STL. The lines producing the leaks now have a comment with
1774 a "MEMORY LEAK" tag: you can retrieve them with
1775 grep "MEMORY LEAK" src/*
1776 Here are two typical examples which I can't help fixing:
1781 char * test = "babo";
1782 name = test; //// <--- valgrind detects 960 bytes lost in
1783 //// call to std::string::operator=(char const*)
1784 name.clear(); //// Doesn't help !
1792 std::cout << "Type a bunch of characters followed by RETURN: ";
1793 getline(std::cin, line); //// <--- valgrind dectects a loss
1794 //// of 1320 bytes in call to
1795 /// std::basic_istream<>& std::getline<>
1801 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1802 * src/gdcmHeader.[cxx|h]:
1803 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1804 and related, moved away to gdcmDocument.
1805 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1806 the corresponding protected accessors of inherited class
1807 gdcmDocument, removed ! As a consequence gdcmFile had to be
1808 declared friend of class gdcmDocument (see below).
1809 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1810 - Clean up of undefined or unused methods.
1811 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1812 account the changes to gdcmHeader.h).
1813 * src/gdcmDocument.h:
1814 - gdcmFile is now a friend class (in order to take into account the
1815 changes to gdcmHeader.h).
1816 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1817 (see changes to gdcmHeader.h).
1818 - Accessors (reading on the form GetEntry*) are now public.
1819 - Clean up of undefined or unused methods.
1820 * src/gdcmDocument.cxx:
1821 - adaptation to changes to gdcmDocument.h
1822 - ::OpenFile now writes a verbose message when file cannot be opened.
1823 - some std::string properly set to VRKey
1824 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1825 references to gdcmDocument.
1826 * Test/TestFindTags.cxx: changed accordingly to above changes.
1827 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1828 cvs repository gdcmData.
1830 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1831 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1832 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1833 conflicts with gdcmValEntry::voidArea.
1834 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1835 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1836 Value representation between StringRepresentable and BinaryRepresentable.
1837 * src/gdcmDocument.cxx:
1838 - method ParseDES: proper indentation restored and usage of
1839 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1840 - method LoadDocEntry: the fingerprint left in the SetValue() of
1841 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1842 removed. Reverting to previous code segment with the proper
1843 dynamic_cast< gdcmValEntry* >.
1844 Note: this was (partially) breaking the python test suite
1845 (gdcmPython/testSuite.py) that made usage of the above
1846 fingerprint to check presence of "Pixel Data".
1847 * src/gdcmDocEntry.h: coding style.
1848 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1849 now taken into account.
1850 * gdcmPython/gdcm.i: adaptation to the new internal representation
1851 of gdcm (exit gdcmParser, hello gdcmDocument).
1852 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1854 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1855 anymore, but instead prints the loaded Python dictionary.
1856 * .... alas, the python testSuite is still broken.
1858 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1859 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1861 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1862 * src/gdcmUtil.h : export methods
1864 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1865 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1867 * Initial addition of automatic python testing
1868 * Initial addition of automatic image comparison
1870 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1871 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1872 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1874 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1875 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1876 * Test/ShowDicom.cxx : bug fix for msvc compilation
1877 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1879 2004-05-04 Jean-Pierre Roux
1880 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1881 new concepts (and new classes) :
1882 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1883 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1884 - Sequence Doc Entries (gdcmSeqEntries)
1885 a Sequence is composed of Items.
1886 Each item is a set of Doc Entries (this is recursive)
1887 The non uniqueness of the 'Dicom tag' is due to this recursivity
1888 (never taken into account)
1889 Our unability to add a new 'entry' in the header
1890 at the proper location (neither in the H-Table (map or multimap),
1891 nor in the Chained List is also due to this recursivity.
1892 Don't try, right now, to use/modify/compile these new sources :
1893 nothing is finished.
1894 We just commit all the stuff, 'as is', in order not to loose it.
1896 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1897 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1899 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1900 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1901 file prefix (SetFilePrefix)
1903 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1904 * Add a new test: ShowDicom, for now this is just the c++ version of
1905 checkRead.sh, later it will be able to compare the image read against a
1907 * Replace the DEBUG on the stack with a global entry in cmake interface:
1908 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1910 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1911 * Add an example subdir, with a real example on how to read + write a
1914 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1915 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1916 * Doc/CMakeLists.txt: the main page is now properly differentiated
1917 between the developper and user version.
1918 * Doc/doxygen.config.in: dropped search related obsolete flags
1919 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1921 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1922 * DEVELOPPER: added some helpfull comments for compile/test/install
1925 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1926 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1927 src directory, now generated in the build dir.
1928 2. Tests as mentionned smarter
1930 4. Add a new method in gdcmDict that return the PubDict by name
1931 this is interesting for 3rd party lib like ITK,
1932 where we could set the institution name / patient name...
1934 * ENH: 1. Now the test suite is working for real
1935 2. All binaries are now output in the gdcm-bin directory
1936 (this was not true before)
1938 2004-04-28 Jean-Pierre Roux
1939 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1940 SeQuence indented printing of Dicom Header.
1941 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1942 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1943 Computation of SQDepthLevel is now part of gdcmHeader constructor
1944 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1945 tree-like structure of a Dicom Header.
1946 * FIX Test code cleaning
1948 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1949 * ENH: Adding automatic testing
1950 1. Need a DartConfig.cmake to submit to public
1951 2. Add a test driver gdcmTest.cxx
1952 3. gdcmTestMain, an helper for the main test driver gdcmTest
1953 4. Files in Test don't have a main anymore, this becomes interesting
1954 when we add more and more tests, thus dsw don't have to load
1956 * ENH: Adding a GDCM_DATA_ROOT for testing
1957 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1958 one file instead of seven + some small cleanup
1960 2004-04-22 Jean-Pierre Roux
1961 * ENH Minor changes to the Print() methods.
1962 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1963 Header printing. Example given with :
1964 > PrintHeader fileName 2 new
1965 (SQ based tree-like structure still to be done for the Header ...)
1967 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1968 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1969 1. I have added some unsigned where needed
1970 2. Some function parameter not used -> (void)
1971 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1972 4. g++ don't like character '\' in comment
1973 5. #define jpeg_create_decompress jCreaDecompress
1974 this really need to be fixed
1975 6. virtualize destructor of gdcmObject ... leakage
1976 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1977 this also really need to be fixed
1978 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1979 remove compression file
1980 (as we only do decompression, right ?)
1981 * ENH: Change malloc/calloc/free with c++ equivalent
1983 2004-04-21 Jean-Pierre Roux
1984 * FIX gdcmHeaderHelper::GetXSpacing
1985 when a single value is found (bug ?), xpacing is now
1986 defaulted to yspacing
1988 2004-04-19 Jean-Pierre Roux
1989 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1990 * ENH add parameters :
1991 bool exception_on_error = false,
1992 bool enable_sequences = false,
1993 bool ignore_shadow = false
1994 to the gdcmFile constructors to be full gdcmParser compliant
1995 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1996 to allow reading of PAPYRUS 3.0 files
1998 2004-04-06 Jean-Pierre Roux
1999 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2001 2004-04-02 Jean-Pierre Roux
2002 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2003 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2004 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2006 2004-03-30 Jean-Pierre Roux
2007 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2008 for ACR file, written out as DICOM files (hope so...)
2010 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2011 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2012 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2013 moved to base class gdcmParser and only the specialisation is kept
2015 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2016 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2017 already does the job.
2018 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2019 (to be consistent with gdcmParser::WriteEntries).
2021 2004-03-30 Benoit Regrain
2022 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2023 upate of the object's instance. It's passed to 2 in the unfavorable
2024 case : one in the ExecuteInformation, one in the ExecuteData
2026 2004-03-29 Jean-Pierre Roux
2027 * ENH : Check on file type to be written moved
2028 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2029 * FIX : gdcmObject::ResetBoundaries now stops properly
2030 when end-of-list is reached
2031 : gdcmVersion modified (as Benoit Regrain asked)
2033 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2034 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2035 * src/gdcmUtil.cxx: added forgotten iostream include.
2036 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2037 equivalent to ExplicitVR in existing code).
2039 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2040 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2041 now contains all the gdcmGlobal related code.
2042 * minor coding style and doxygenation changes.
2044 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2045 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2046 now contains all the Debug related code.
2047 * minor clean-up of includes in src/*.cxx
2048 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2049 CreateCleanString) removed.
2050 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2051 * Doc/DoxyMainPageUser.txt added.
2052 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2053 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2054 src/gdcmDirList.cxx)
2056 2004-03-24 Jean-Pierre Roux
2057 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2059 2004-03-23 Jean-Pierre Roux
2060 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2061 big endian made volumes
2062 * ENH Now gdcmParser constructor and destructor are protected to forbid
2063 end user to instanciate class gdcmParser
2064 (only gdcmHeader and gdcmDicomDir are meaningfull)
2066 2004-03-22 Benoit Regrain
2067 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2068 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2069 gdcmSerie to gdcmDicomDirSerie
2071 2004-03-19 Jean-Pierre Roux
2072 * ENH Now the tree-like structure describing a DICOMDIR comming from
2073 an already existing DICOMDIR file is consistent with
2074 the home-made tree-like structure build ex-nihilo
2075 or build from the files held (recursively) in a Directory
2076 functions gdcmDicomDir::CheckBoundaries()
2077 gdcmObject::SetBoundaries() added
2079 2004-03-17 Jean-Pierre Roux
2080 * REM (Eric Boix bug) : removal of meaningless
2081 gdcmDicomDirImage::NewImage function.
2082 * FIX now file names and directory name are written properly in the
2084 * FIX now gdcmDicomDir constructor may be call without any trick
2087 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2088 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2089 of gdcmDicomDirImage::NewImage as empty function.
2091 2004-02-28 Jean-Pierre Roux
2092 * ENH add gdcmDicomDir:NewPatient
2093 add gdcmDicomDirPatient:NewStudy
2094 add gdcmDicomDirStudy:NewSerie
2095 add gdcmDicomDirSerie:NewImage
2096 to allow making gdcDicomDir object.
2097 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2098 (as opposite to the gdcmHeader chained list)
2100 2004-02-11 Benoit Regrain
2101 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2102 when using from python
2104 2004-02-10 Benoit Regrain
2105 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2106 * FIX : in gdcmDicomDir when the directory is empty
2107 * ENH : add callback and methods to get the progression of dicomDir
2110 2004-02-06 Jean-Pierre Roux
2111 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2112 - GDCM_META added to gdcmDicomDirType
2113 - class gdcmMeta created
2114 * ENH : - A brief summary is now displayed at the beginning of
2115 'testDicomDir' to help disaster magnitude estimation
2116 * REM : Now useless Test/explDICOMDIR.cxx
2118 2004-02-05 Benoit Regrain
2119 * ENH : add methods in gdcmObject to get the hash table or the list of
2121 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2122 * FIX : wrapping python for TagHeaderEntryHT
2124 2004-02-04 Benoit Regrain
2125 * FIX : even length for some strings when writting the dicom dir
2126 * FIX : sort the images in the dicom dir
2127 * FIX : Bug fix for python use of dicom dir
2128 * ADD : a python demo
2130 2004-02-04 Jean-Pierre Roux
2131 * FIX : Final solution (?) for icone embedded images
2132 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2133 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2134 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2135 gdcmData/gdcm-MR-SIEMENS-16.acr1
2136 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2137 to make full checking easier
2139 2004-02-04 Benoit Regrain
2140 * FIX : WriteEntries : coding style & logic in parameters
2141 * FIX : Set the elements to create the DicomDir in a dictionary file
2143 2004-02-03 Benoit Regrain
2144 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2145 * gdcmDicomDir : add the load of directory
2146 * Bug fix and print add-on
2148 2004-02-03 Jean-Pierre Roux
2149 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2150 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2151 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2152 * FIX gdcmParser.cxx : 'group length' elements are now considered
2153 as integers, even for shadow groups, when file is Implicit VR
2155 2004-02-02 Jean-Pierre Roux
2156 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2158 of the last synonym :-(
2159 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2161 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2162 * FIX taking into account the possible 7fe0,0010 multiplicity
2163 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2164 to allow removal of references to 7fe0,0010, to deal with
2165 ACR-NEMA images, when 0028,0200 is meaningfull
2167 2004-01-31 Jean-Pierre Roux
2168 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2169 no longer writes 'Un' on disk
2170 * FIX SQ elements with actual length are now dealt with corectly
2171 * FIX gdcmFile::WriteBase make the difference, for color images, between
2172 the length (for Palette expanded images)
2173 and Raw Length (non expanded image + Palette)
2174 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2175 (that broke Write). Replaced by UL.
2176 Aware user will reload the field if he
2177 thinks it's necesssary
2179 2004-01-30 Jean-Pierre Roux
2180 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2181 when 'dirty Acr' is found, to be compliant with the new
2182 IsReadable() methods.
2184 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2185 (no DOUBLE images in kosher DICOM,
2186 but so usefull for people that miss them ;-)
2188 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2189 DICOMDIR related utilities (not checked as Windoze compliant)
2191 2004-01-28 Jean-Pierre Roux
2192 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2194 2004-01-27 Jean-Pierre Roux
2195 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2196 to allow skipping the shadow elements, to save memory space.
2197 The TRUE value for this param has to be used
2198 with a FALSE value for the 'enable_sequence' param.
2199 ('public elements' may be embedded in 'shadow Sequences')
2200 * gdcmHeader methods now deal with 'embedded icones images' in the header
2201 (even when an 'icone image sequence' is announced by the
2202 element (0x0088,0x0200), but there is NO icone at all ...
2204 * gdcmHeader sometimes Image Location value doesn't follow
2205 the supposed processor endianity (see gdcmData/cr172241.dcm).
2208 * gdcmHeader add the method
2209 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2210 to get *all* the Header Entries with the same tag.
2211 GetHeaderEntrySameName is probabely *useless*
2212 (no meaning : Name is *not* an identifier within the Dictionary)
2214 2004-01-26 Benoit Regrain
2215 * Bug fix in the print of hexadecimal representations. Remove long fields
2216 in the print and add a third level of print to print them
2218 2004-01-23 Benoit Regrain
2219 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2220 * Bug fix on test suite after remove the strip made on not string fields
2221 * Split the IsReadable method between gdcmParser which test that the file
2222 is dicom and gdcmHeader which test that it's an image file
2224 2004-01-22 Benoit Regrain
2225 * DicomDir : clean code, add methods, set variables in protected or private
2226 * gdcmUtil : bug fix for the clean string method
2228 2004-01-19 Benoit Regrain
2229 * Add the use of shadow dictionaries
2230 * bug fix and coding style
2232 2004-01-19 Benoit Regrain
2233 * src/gdcmFile.cxx : bug fix concerning the close of file
2234 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2235 * Add the update of header entries using the shadow library
2237 2004-01-19 Benoit Regrain
2238 * removal of file gdcmHeader2.cxx
2239 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2240 inheriting from gdcmParser. This split is to prepare the integration
2241 of dicom dir parsing
2242 * bug fix under python
2244 2004-01-16 Jean-Pierre Roux
2245 * REM removal of class gdcmHeaderEntrySet
2246 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2247 * ADD add file gdcmHeader2.cxx
2248 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2250 2004-01-15 Benoit Regrain
2251 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2252 entries created while parsing the header. Thus, they will be destroyed
2253 when the gdcmDictSet will be destroyed
2254 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2257 2004-01-15 Benoit Regrain
2258 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2259 made a fatal error because of the memory release at the end of program.
2260 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2261 some memory and vtk seems to have some problems with that.
2262 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2264 2004-01-14 Benoit Regrain
2265 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2266 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2267 * src/*.[h|cxx] : make changes due to class name changes
2268 * gdcmPython/demo/*.py : bug fix due to method names
2270 2004-01-13 Benoit Regrain
2271 * src/*.[h|cxx] : coding style
2272 * vtk/*.[h|cxx] : coding style
2274 2004-01-13 Benoit Regrain
2275 * gdcmPython/testSuite.py : test the readable flag of file for tests
2276 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2277 It's lied to the stl compilation by MSVC (windows, always windows...)
2278 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2280 2004-01-12 Benoit Regrain
2281 * src/*.h : add comments
2282 * src/gdcmDictSet.h : set the method BuildDictPath in public
2283 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2284 directly setted in the source code
2285 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2288 2004-01-09 Benoit Regrain
2289 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2290 * setup.py : use a reference to gdcmVERSION
2292 2004-01-07 Benoit Regrain
2293 * Modification to compile with the distutils.
2296 2003-12-10 Benoit Regrain
2297 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2298 can use a gdcmHeaderHelper to load data
2299 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2300 made in the source code
2302 2003-12-10 Benoit Regrain
2303 * Update Windows projects and .cvsignore files
2305 2003-11-12 Jean-Pierre Roux
2306 * ENH gdcmHeader constructor has one more parameter (default value : false)
2307 that allows the user to 'go inside' the SeQuences only
2309 gdcmElValSet:Print takes it into account
2311 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2312 * ENH: Update gdcmPython/CMakeLists
2313 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2314 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2316 2003-11-10 Jean-Pierre Roux
2317 * FIX : gdcmHeader::LoadElements is now based
2318 on the ListTag listElem member,
2319 not longer on the TagElValueHT tagHt member
2320 * ENH : PrintPubElVal shows (temporarily) both results,
2321 with the tagHt member and the listElem member.
2322 (it's easier to 'see' the problems when using Printheader)
2324 * FIX : old private member LgrElem is now splitted into
2325 ReadLength : Length actually found on disk (updated only
2326 if bug fixing is necessary), for internal
2328 UsableLength : Updated by FixFoundLength, to fix a bug
2329 or to allow Parser going on.
2330 Will allow to re-write a kosher header when a SeQuence
2331 with a length (not 0000) is found
2332 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2333 because gdcmElValSet::Add does not update ListElem
2336 2003-11-07 Jean-Pierre Roux
2337 * FIX misstyping in Transfert Syntax name table
2338 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2339 when they have an actual length (not 0000 nor FFFFF)
2340 (Nobody should care of it, but DICOMDIR explorers)
2342 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2343 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2345 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2346 * ENH: vtkGdcmReader now supports LUT !
2347 (vtkgdcmViewer for now is not able to use them though)
2349 2003-11-05 Jean-Pierre Roux
2350 * in testSuite.py : new files names for checking the package
2351 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2352 that returns the pixel area size to the *aware* (vtk) user
2353 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2355 2003-11-05 Benoit Regrain
2356 * in testSuite.py : Modify the rules for checking the paths
2357 : Explicit error messages
2358 * in __init__.py : Related modif
2360 2003-11-03 Jean-Pierre Roux
2361 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2362 to be used by aware (vtk) users that want to manage
2363 LUT (and no to turn the PALETTE image into an RGB pixels one)
2364 * GetPixelType now returns 8U for 24 Bits images
2365 (vtkGdcmReader compliant)
2367 2003-10-31 Jean-Pierre Roux
2368 * Removal of *all* gdcmData images and add them again
2369 in order to loose the 'history' of un-anonymised images
2371 2003-10-31 Jean-Pierre Roux
2372 * RMV : removal of useless jBitsInJsample.h
2373 for both 8 and 12 Bits JPEG Lossy Libraries
2375 2003-10-31 Jean-Pierre Roux
2376 * ENH : Add the functions gdcmFile::GetImageDataRaw
2377 gdcmFile::GetImageDataIntoVectorRaw
2378 that act as GetImageData and GetImageDataIntoVector
2379 except the making of an RGB Plane from Gray Plane + LUT
2380 Intended to aware (vtk) users who know how to manage
2383 GetLUTRGBA return a R,G,B,A LUT if any
2384 lgrTotaleRaw gives the 'Raw' length
2385 GetImageDataRaw returns the gray Plane
2386 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2387 (They stay Grey, just like with other Dicom viewers :-(
2389 2003-10-30 Jean-Pierre Roux
2390 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2392 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2393 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2394 being coherents dicom files.
2396 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2397 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2399 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2400 * ENH: Two steps is necessary to please VC++ compiler...
2401 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2402 * ENH: Add include dir to medcon lib
2403 * FIX: only one function is being exported for now !
2404 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2406 2003-10-29 Jean-Pierre Roux
2407 * adding gdcmHeader::GetLUTRGBA
2408 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2409 --> Mathieu, the modif u're waiting for is not yet committed
2410 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2412 2003-10-27 Jean-Pierre Roux
2413 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2414 00191113.dcm DermaColorLossLess.dcm
2415 MxTwinLossLess.dcm RadBWLossLess.dcm
2416 * ENH: For version prior to vtkImageViewer2 -r 1.19
2417 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2419 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2420 * Removal of ido stuff in CMakeLists.txt
2422 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2423 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2424 * FIX: remove a call to ->Modified ... see comments
2425 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2427 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2428 * FIX: Problem with path for libvtkgdcmPython
2429 * ENH: Try adding a search script for python site-package
2430 * RMV: Remove some file from medcon lib that are not necessary
2431 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2432 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2433 * FIX: More pragma disable fro VC++,
2434 I don't think I break something as it is also disable in VTK/ITK.
2435 But it fasten debug compilation time.
2437 2003-10-23 Jean-Pierre Roux
2438 * gdcm now deals with 16 Bits Run Length Encoded images
2439 (they are compressed as 2 planes images,
2440 one for the high Bytes, the other for low Bytes)
2442 2003-10-22 Jean-Pierre Roux
2443 * Now CheckRead takes into account :
2444 - the bugged 'Leonardo' Siemens images
2445 - the XA images, sent thru the burning VPRO station
2446 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2449 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2450 * FIX: When copying a Makefile.am to CMakeLists.txt
2451 one should remove the '\'
2453 2003-10-22 Jean-Pierre Roux
2454 * in gdcmData adding a bugged 'Leonardo' Siemens image
2455 (wrong lengths in header)
2456 OK with gdcm, KO with the other viewers :-)
2457 * add a GE dlx XA image, thru the VEPRO burning station
2460 2003-10-21 Jean-Pierre Roux
2461 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2462 for a brutal checking of vtkgdcmViewer compliance
2464 2003-10-21 Jean-Pierre Roux
2465 * add the files for 'xmedcon' Jpeg Lossless library
2466 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2468 2003-10-21 Jean-Pierre Roux
2469 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2471 2003-10-21 Jean-Pierre Roux
2472 * garbage Siemens 'Leonardo' images dealt with
2473 (the patch is easy to remove)
2474 * cosmetic changes to avoid warnings
2476 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2477 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2478 no need to press 'r' now.
2480 2003-10-20 Jean-Pierre Roux
2481 * upgrade of checkRead.sh checkWrite.sh according
2482 to new Jpeg Lossless decompressor
2483 * add US.3405.1.dcm, a genuine RGB medical file ...
2484 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2485 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2487 2003-10-15 Jean-Pierre Roux
2488 * general anonymisation in gdcmData
2489 * adding the 'color files' from
2490 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2491 * adding some well knowed bugged-header images
2492 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2493 waiting for their inclusion in Python testsuite
2495 2003-10-15 Jean-Pierre Roux
2496 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2497 no longer seg faults when file is not found
2499 2003-10-14 Jean-Pierre Roux
2500 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2503 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2504 * TODO: *.in file to genereate a UseGDCM later
2506 2003-10-14 Jean-Pierre Roux
2507 * Some supposed-to-be Dicom Images have no preamble.
2508 OpenFile takes it into account
2509 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2510 * Missing elements added in dicomV3.dic
2511 (just to be affraid : have a look at
2512 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2513 and do it again next year ;->
2515 2003-10-13 Jean-Pierre Roux
2516 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2517 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2518 But there are NOT. It's fixed !
2520 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2521 * FIX: "jpeglib.h" was not found on VC++
2522 * FIX: vtkgdcm was not being installed
2524 2003-10-10 Jean-Pierre Roux
2525 * ENH : OpenFile closes the file if it *really* doesn't look like
2526 an ACR-NEMA / DICOM one.
2527 * FIX : testWrite no longer writes an empty file if the source file
2528 is not gdcm Readable
2529 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2532 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2533 * FIX: CMake generate now documentation
2534 * ENH: out of source doc build !
2535 * ENH: Generate both user and dev documentation
2536 * ENH: Should work on windows too
2537 * ENH: Only one doxygen config.in file is needed
2538 * FIX: make install should be ok now on ùnix plateform
2539 * FIX: PATH to dictionary was wrong (missing /)
2540 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2542 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2543 * vtkGdcmReader is now able to read rgb dicom file.
2544 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2545 * added a gdcmViewer to vtk test, use mouse to control
2546 window level & window width
2548 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2549 * CMake-ification of gdcm, we have now two build system
2550 * FIX: on cygwin Wsock32 doesn't exist
2551 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2553 2003-10-06 Emanuel Ollart
2554 * FIX : compilation process wad broken.
2555 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2557 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2558 * change gdcmViewer -> vtkgdcmViewer
2559 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2561 2003-10-06 Jean-Pierre Roux
2562 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2563 ( e.g : well known GE images with a wrong elem length,
2564 : Philips MRI Images with a wrong Huffman table)
2565 * still to be done : allow the reading of bugged LEONARDO Siemens images
2567 2003-10-03 Jean-Pierre Roux
2568 * Odd length strings are padded with '\0' (not with spaces,
2569 to remain compliant with already defined strings,
2570 like Transfert Syntax UID and others)
2572 2003-10-03 Jean-Pierre Roux
2573 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2574 to allow displaying RGB images (not only by affim ;-)
2576 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2577 * vtkGdcmReader is now able to read rgb dicom file.
2578 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2580 2003-10-03 Jean-Pierre Roux
2581 * A few nasty patches to allow the reading of a lot of nasty images
2582 ( e.g : well known GE images with a wrong elem length,
2583 : Philips MRI Images with a wrong Huffman table)
2584 * still to be done : allow the reading of bugged LEONARDO Siemens images
2586 2003-10-03 Jean-Pierre Roux
2587 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2589 2003-10-03 Jean-Pierre Roux
2590 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2591 to allow displaying RGB images (not only by affim ;-)
2593 2003-10-03 Jean-Pierre Roux
2594 * gdcmFile::GetImageDataIntoVector now
2595 - deals with MultiFrames MultiFragments Run Length Encoded files
2596 - deals with YcBcR (YBR_FULL) files
2597 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2598 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2600 (no sample found :-(
2602 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2603 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2604 Two reasons: - clear things
2605 - third parties acces gdcm through header files, so won't
2606 suffer anymore VC++ complains
2608 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2609 * add argv[1] in testvtkGdcmReader.cxx
2612 2003-09-24 Jean-Pierre Roux
2613 * The lines are now eigthy characters long.for
2614 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2616 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2617 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2618 char* to std::string. Thus, the use of strdup becomes useless. (see
2619 previous commis of Malaterre)
2620 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2621 before the last Malaterre's commit.
2623 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2624 * This commit should fix the Debug building under VC++, the problem
2625 was mainly a mixture of debug and release lib being loaded at startup.
2626 * I also remove a depency to a specific C function: strdup. Because I had
2627 to force the link to msvcrtd (whereas strdup is in libc).
2629 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2630 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2631 located in the gdcmCommon.h file. All use of reference of tha has been
2632 changed to now use the variable GDCM_UNFOUND.
2634 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2636 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2637 Dicom dictionary. The test suite can now be run again. Note:
2638 I'm note very happy with the " (RET)" changes. I believe this
2639 RETAINED comment should be dropped when parsing the dictionary.
2640 - PACKAGER corrected
2642 - AUTHORS updated and now in alphabetical order
2643 * Makefile.am now exports gdcm.dsw for Windoze users.
2645 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2646 * cygwin complains about missing std:: in subdir Test/
2648 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2649 * remove some methods that are now in gdcmHeaderHelper
2651 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2652 * vtkGdcmReader set spacing and origin correctly
2654 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2655 * Fix a few delete/delete[] mismatch
2657 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2658 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2659 interpretation to data given by gdcmHeader. For instance there are
2660 heuristics to get informations (look at different places).
2661 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2662 sorting DICOM images based on different strategies.
2663 * modified Makefiles accordingly.
2665 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2666 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2667 when building in debug mode
2668 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2669 src/win32/gdcmdll.dsp
2670 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2672 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2673 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2676 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2677 * src/win32/libgdcmjpeg12.dsp was not dos format
2678 * src/win32/libgdcmjpeg12.dsp :
2679 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2680 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2682 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2683 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2685 * src/gdcmFile.cxx : bug fix in affectation type
2686 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2687 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2688 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2689 symbols... future problem ?
2691 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2692 * src/win32/libgdcmijpeg12.dsp was missing
2693 * modified gdcm.dsw accordingly
2695 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2696 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2698 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2699 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2700 commit of JPR (before his hollidays to facilitate our work).
2701 * setup.py : bug fix in code. Modifications made while the last commit
2702 of JPR. The code hasn't been tested before the commit... it's so
2703 useless to make that (for best programmer that is JPR) !!!
2705 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2706 * tagged the current version as Version0_3 (i.e. version 0.3)
2708 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2709 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2710 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2711 * *.dsp : modifications to use new libgdcmijpeg8 library
2712 * setup.py : bug fix on VTKPATH variable
2713 * PACKAGER : adding all concerning windows
2715 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2716 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2718 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2719 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2720 test suite reported error.
2721 * PACKAGER file added (describes what a packager must do when
2722 packaging a new release).
2723 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2724 * configure.in: upgraded version number to 0.3.0
2725 * fixing build of rpm (through rpm -ta):
2726 - Doc/Makefile.am exports proper doxygen files
2727 - src/jpeg/libijg8/Makefile.am exports the include files.
2729 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2730 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2731 * src/gdcmHeader.h : formatting code
2733 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2734 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2735 We were obtaining error message from vtk. Now, creation of file list
2736 is made in an internal list to prevent this problem.
2737 Bug fix when output is empty.
2738 Bug fix in update of progress value. Previous commit for this was a bad
2740 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2742 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2743 * src/gdcmHeader.h : added method to get the file name
2744 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2745 files. Added method to remove all files on the input
2746 Added FIXME comment concerning the bad parsing of header made by
2747 ExecuteInformation method (in ExecuteData method)
2749 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2750 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2751 when using make instal.
2752 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2753 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2755 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2756 * setup.py : adding include dir of jpeg lib to compile all sources
2757 * */Win32/*.dsp : JPR fix for windows compilation
2759 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2760 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2762 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2763 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2765 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2766 * setup.py is again effective on un*x (takes into account the
2767 addon of the jpeg library)
2768 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2769 * Doc/Doxy* updated (includes above enhancements)
2770 * INSTALL now points to web documentation
2772 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2773 * src/gdcmHeader.h doesn't make unnecessary reference to
2775 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2777 * src/gdcm*.[cxx|h] :
2778 - to allow compilation with gcc 3.x
2779 -- clean up of STL usage (added explicit usage of std::)
2780 -- small fixes on exceptions.
2781 Note: linking not tested !
2782 - clean of doxygen comments to avoid warnings at documentation
2784 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2785 dependent convertion).
2787 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2788 * Clean up of previous JPR garbage commit (not even commented in the
2790 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2791 - moved all jpeg related files from src to src/jpeg/libijg8, with
2792 addition/modification of Makefile.am and configure.in.
2793 - the testSuite is still brain damage (not guilty).
2795 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2796 * WrapVTK.py : modifications to get correctly vtk source files to
2798 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2799 (FileName -> Filename)
2801 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2802 * vtk/vtkGdcmReader.[cxx/h]:
2803 - UpdateProgress method should now be effective
2804 - removed the limitation on having only images loaded (as opposed
2806 - when building a stack of images/volume, a lesser number of
2807 gdcmHeader and gdcmFile instances should be used (hopefully
2808 accelerating things).
2809 - when building a stack of images/volumes, files which are not
2810 loadable (wrong path-filename, wrong permissions on existing file,
2811 or file not parsable by gdcm) are replaced with a black image
2812 in the stack (for the caller to notice the problem).
2814 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2815 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2817 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2818 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2819 between standard library (std) and vtk library (problems are found
2820 under Windows... thanks Windows !)
2822 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2825 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2827 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2828 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2830 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2831 * When compiling with distutils (see setup.py) the C++ compiler is
2832 called with different flags than the default ones (with automake).
2833 In order to fix all those warning, I compiled gdcm with the command
2834 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2835 and went for warning fixes:
2836 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2837 up from unused variables.
2838 - vtk/vtkGdcmReader.cxx: potential bug fix.
2839 * src/gdcmHeader.h: Doxygen warning cleanup
2841 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2842 * gdcmPython/gdcm.i:
2843 - typemaps correction to take into account the systematic replacement
2844 of "using namespace std" with std:: prefix e.g. std::list,
2845 std::string... (cf changes of 2003-05-21).
2846 - gdcmGlob global variable of type gdcmGlobal (defined in
2847 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2848 exported to Python a as cvar.
2849 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2850 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2851 gdcmDictSet.GetPubDictTagNames() and
2852 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2853 C++ static methods).
2854 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2855 with the above changes.
2857 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2858 * setup.py, manifest.in : bug fix under linux
2860 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2861 * Modification of setup.py to compile vtk part too. Then, we have 2
2862 wrappers which must work with same distutils. For that, we have a
2863 generic distutils in distusiltsWrapping.py ; with :
2864 - build_extWrap class to wrap generically all extensions,
2865 - ExtensionWrap base class for all wrapping extension that contains
2867 - Wrapper interface which wrap sources
2868 + In WrapSwig.py we have extension and wrapper for Swig
2869 + In WrapVTK.py we have extension and wrapper for VTK
2870 * MANIFEST.in : modifications to consider vtk directory and new python
2871 files for compilation
2873 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2874 * Added python wrappers of vtkGdcmReader vtk class (see the
2875 source in vtk/vtkGdcmReader.cxx) :
2876 - vtk/Makefile.am now builds a library
2877 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2878 python library (as opposed to _gdcm.so wich are the python
2879 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2880 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2882 - configure.in has an additional flag --enable-vtk that needs
2883 to be set to enable compilation of vtk related code, that is:
2884 + vtk/vtkGdcmReader.so and
2885 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2886 + gdcmPython/vtkgdcmPython.so (see above)
2887 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2888 be read when compressed or when HighBit + 1 != BitsStored),
2889 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2890 the usage of the python wrapper of vtkGdcmReader vtk class.
2891 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2892 * src/*.[h] all occurences of stl classes are now prefixed with
2893 std::, and all occurences of "using namespace std;" where removed.
2894 This is to avoid pollution of global namespace in included files.
2895 Apparently vtk does not avoid this pitfall: when using both
2896 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2897 collision of various stl members (principally cout...).
2898 * gdcmPython/testSuite.py now cleanly removes temprory generated
2900 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2901 comply with above changes)
2903 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2904 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2905 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2906 vtk data structure (an image Flip was required).
2907 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2908 * cosmetic changes in documentation.
2910 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2911 * src/gdcmHeader.cxx: the constructor no longer exits when an
2912 unexisting file is given as argument.
2913 * The subdirectory Data (containing all the images used for the
2914 test suite) is not part of this repository anymore. A new module
2915 containing those images is now available at
2916 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2917 with the name gdcmData.
2918 All the python scripts (including the package initialisation file
2919 gdcmPython/__init__.py) were adapated to take this change into
2920 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2922 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2923 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2924 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2925 demo of the usage of this class.
2926 Compilation of this vtk part is only done when using the --enable-vtk
2927 at configure (or autogen.sh) stage.
2929 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2930 * More memory link related corrections and documentation fixes.
2932 - maximum info is obtained with a command of the form:
2933 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2934 --show-reachable=yes PrintHeader
2935 - the remaining reachable blocks seem to come from the STL
2936 allocation scheme through the usage of map and list. It looks
2937 like this memory cannot be freed but it is not a memory leak
2938 (in fact further invocation to the STL would recollect the
2939 unused memory allthough it cannot explicitely be freed).
2940 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2941 of displaying an image parsed with gdcm and displayed with VTK.
2942 Note: some images don't seem to work e.g.
2943 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2944 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2945 Allthough this weakens the semantics, it is a ditch attempt to
2946 make gdcm more thread friendly.
2948 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2949 * Memory link hunt (by using valgrind through the command
2950 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2951 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2952 gdcmHeader::_dicom_vr.
2953 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2954 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2956 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2958 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2959 * src/Makefile.am now exports all the necessary include files at
2963 * UpdateGroupLength replaced by new one
2966 * UpdateGroupLength re-written using H-Table
2967 (named UpdateGroupLengthNew untill checks are over)
2969 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2970 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2971 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2973 - gdcmHeader::GetPubElValSet removed.
2974 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2975 UpdateGroupLength, WriteElements, Write.
2976 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2977 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2978 carried the same semantics.
2979 - src/gdcmHeaderIdo.cxx changed accordingly.
2980 - gdcmFile::WriteBase now regroups all the codes from previous
2981 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2982 - enum FileType moved to gdcmCommon.h
2983 * src/gdcmHeader.cxx AddDefault trashed
2984 * gdcmGetXSize added
2985 * getimageDataSize now calls gdcmGetXSize
2986 * Test/*.cxx changed to agree with above changes
2988 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2989 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2990 (to avoid double call by end user).
2991 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2992 by end user, since gdcmHeader::gdcmHeader now handles it.
2994 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2995 * gdcm/Doc many doxygen changes:
2996 - Doxyfile now has two different versions, DoxyfileUsers that generates
2997 the html.users end users oriented documentation and
2998 DoxyfileDeveloppers that generates the html.developper developper
2999 oriented documentation.
3000 - README changed accordingly
3001 - requirement.txt removed (old design info moved to TODO).
3002 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3003 DoxyMainPage.txt, DoxyPython.txt provide more information.
3004 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3005 be updated by simply regenerating the docs with doxygen and copying
3006 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3007 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3008 all the tests in the form "if (<map>.count() >1)" were removed.
3009 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3010 ill-formed documentation sections.
3011 * src/gdcmHeader.cxx: ditto
3013 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3014 * setup.py fixed for un*x (needed macro for stdint.h)
3015 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3016 un*ces with sh-utils test utility.
3017 * gdcmPython/demo/test.py renamed to PrintHeader.py
3018 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3019 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3020 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3021 * src/gdcm*.cxx JPR's bad inclusion fixed.
3023 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3024 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3025 * gdcmPython/demo/test.py changed accordingly.
3027 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3028 * gdcmPython/Makefile.am fixed linking against libstdc++
3029 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3030 * Swig subdir (historical tests of swig version 1.3.17++) removed
3031 * Test/testChangeEntete.cxx some lines commented out in order to make
3033 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3034 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3036 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3037 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3038 hence the user doesn't need this explicit call.
3039 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3040 i.e. LoadElements() call removed.
3041 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3042 - src/Makefile.am declares the proper flag for g++.
3043 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3044 for adding user defined new tags.
3045 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3046 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3047 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3049 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3050 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3051 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3052 src/Makefile.am : the project should properly compile and install
3053 with the autotools, included the python wrappers part.
3054 * gdcm.spec.in : added a spec file for RPM packaging.
3056 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3057 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3059 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3060 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3061 to exported to the environement (see gdcmPython/testSuite.py
3063 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3064 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3065 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3066 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3067 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3069 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3070 * gdcmPython/__init__.py doesn't crash anymore when running in
3071 in InstallMode or PreInstallMode but with an environment given
3072 value of GDCM_DICT_PATH.
3073 * src/gdcmDictSet.[cxx/h] coding style.
3075 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3076 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3077 * src/gdcm.h general comments moved to TODO, and README
3078 * src/gdcm.h should now be seen as a user commodity (including it
3079 should suffice to fully use gdcm). It is nowhere including within
3080 any of the kernel files src/*.cxx and src/*.h.
3082 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3083 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3084 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3086 * src/gdcm*.cxx only include their corresponding include file
3087 (as opposed to gdcm.h)
3088 * gdcmPython/gdcm.i changed accordingly
3089 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3090 the autogen.sh generated "make snapshot" command to work.
3091 * autogen.sh removed history related references to crea package.
3093 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3094 * distutilsSwigCPlusPlus.py work around some swig portability
3097 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3098 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3099 was done in a last ditch attempt to get setup.py _really_
3100 operationnal. The python/gdcmPython layaout add the advantage
3101 of hidding away the python related distutils specific files
3102 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3103 Alas, the src directory was out of scope (i.e. it's relative
3104 position to setup.py was ../src) which made things impossible to
3105 handle (see previous version of python/setup.py). Crossing fingers...
3107 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3108 * python/setup.py now works on Un*x. (harder than I thougth)
3109 * python/distutilsSwigCPlusPlus.py can now have include files
3110 among the list of sources.
3112 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3113 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3114 * modifications in MSVC projects
3116 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3117 * As stated by the first lines of Test/ExceptionAndPython/README, it
3118 looks like we can move back to original usage of exception within
3119 src/gdcm* and hence remove the errno stuff that was introduced
3120 as a quick and dirty fixture of this problem (added to the TODO).
3121 * Doc/Doxyfile configuration file for Doxygen and corresponding
3122 README file for usage added.
3123 * Test/testWrite.cxx added. This new test comes from a split of
3124 test.cxx that is now reverted to its original purpous i.e.
3125 testing the proper parsing of a Dicom related file.
3126 testWrite.cxx concentrates on testing the IO part of gdcm.
3127 * Test/bug1.cxx (containing a bug on WIn32) added.
3128 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3129 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3130 whose purpose is to publish the content of the TagNames of the
3131 Dicom public dictionary were not accessible without an
3132 instance of class gdcmHeader.
3133 - those methods are now static methods of gdcmDictSet and hence
3134 require no instances at all to be invocated.
3135 - within gdcmDictSet this change required to change some method
3136 to class methods (i.e. are now static) among which SetDictPath
3137 (renamed to BuildDictPath) and LoadDefaultPubDict.
3138 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3139 the above changes by calling the new method classes of gdcmDictSet.
3140 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3141 the above to be effective.
3142 * python/gdcmPython: in order to wrap properly the above changes
3143 for Python, swig version now needs to be > 1.3.17.
3144 * python/gdcmPython/Makefile fixed to adapt itself to new
3145 configure/make shema introduced by Johan Montagnat (thanks for the
3146 contribution). Alas this Makefile cannot be turned into a proper
3147 Makefile.am without some heavy changes in the configure.in
3148 (for python dectection).
3149 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3150 now avoids publishing the empty entries.
3152 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3153 * python/setup.py : bug fix concerning install under windows
3154 ExtraPath reused :-P
3155 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3157 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3158 * Dicts/dicomV3.dic : remove double spaces !!!
3159 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3160 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3163 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3164 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3165 method. Doxygenation.
3166 * src/gdcm.h clean up of JPR spurious comments.
3168 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3169 * python/distutilsSwigCPlusPlus.py now properly collects the
3170 shadow classes generated by "swig -c++" (gdcm.py in our case)
3171 when using "python setup.py install".
3172 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3173 reexports the working classes.
3174 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3175 by the classical C errno scheme. This is to prevent an obscure
3176 behavior of the python wrappers when importing wxPython.wx prior
3177 to gdcmPython (which ended up in an abort call). An illustration
3178 of this oddity can be found in the Test/ExceptionAndPython
3179 subdir (see the README file). This problem probably due to
3180 an combination of g++ and dynamic loading.
3181 * added Test/ExceptionAndPython (see above)
3183 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3184 * Changed the layout of the python part to avoid bloating main
3185 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3186 i.e. the distutils arsenal. All the python related stuff is
3187 again in a python subdir, but the package itself is now in
3189 * setup.py was cleaned up:
3190 - pythonIncludePath removed
3191 - python setup.py bdist target is now functional.
3192 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3193 collision with other packages). gdcmPython/demo/*.py changed
3196 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3197 * python subdir moved to gdcmPython (preparation of distutils packaging).
3198 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3199 distutils installer is operational.
3200 * - gdcmPython/__init__.py now properly loads the swig generated
3201 shadow classes (from gdcm.py).
3202 - gdcmPython/demo/*.py changed to import the package gdcmPython
3203 instead of gdcmPython/demo/load.py.
3204 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3206 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3207 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3208 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3209 entries within the associated public Dicom dictionary resp. the same
3210 information but sorted by the fourth field (PAT, IMG, DIR) of the
3212 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3213 are now in the "???" group.
3214 - python/gdcm.i changed accordingly,
3215 - python/demo/printGroupedPublicDict.py added, that gives an example
3216 of the above new functionalities in Python.
3218 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3219 * src/gdcm.h, gdcmHeader.cxx:
3220 - historic references to glib's g_malloc and g_free (#defined)
3221 were definitively removed.
3222 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3223 * src/gdcmElValSet.cxx:
3224 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3225 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3226 - GetElValue(string) renamed to GetElValueByName.
3227 - Added GetElementByName(string).
3228 * src/gdcmHeader.cxx: added
3229 - GetPubElValRepByNumber(guint16, guint16)
3230 - GetPubElValRepByName(string)
3231 - GetShaElValRepByNumber(guint16, guint16)
3232 - GetShaElValRepByName(string)
3233 - GetShaElValByNumber(guint16, guint16)
3234 - GetShaElValRepByName(string)
3235 - GetElValRepByNumber(guint16, guint16)
3236 - GetElValRepByName(string)
3237 - GetElValByNumber(guint16, guint16)
3238 - GetElValRepByName(string)
3239 * Doc/requirements.txt added.
3241 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3242 * Test/Makefile building now depends on the one of libgdcm.so
3243 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3244 pixel data) aware which enables finding the address (offset) of
3245 the pixel data of JPEG encoded DICOM files. This leaves only a single
3246 file in the testSuite whose pixel data address (offset) is unknown.
3247 * python/testSuite.py changed accordingly.
3249 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3250 * VC++ has some strong limitations when working with the STL, as stated
3251 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3252 "Also note that some STL containers (map, set, queue, list, deque)
3253 cannot be exported. [...]
3254 Some STL classes contain nested classes. These classes can not
3256 This is caused by a designed limitation that once a template
3257 class is instantiated, it can not be re-instantiated and
3259 Since our usage of map<> is ubiquitous in gdcm, this "designed
3260 limitation" of VC++ is a pitfall.
3261 Hence the Python wrappers of gdcm cannot be incrementally linked
3262 against the c++ dynamic library. The dirty but only workaround is
3263 to forget about incremental link of dynamic libraries and to generate
3264 the Python wrappers library with the inclusions of the underlying C++
3266 The following modifications concern this matter on Win32/VC++:
3267 - wrapping python correct with standalone wrapped dll (don't use separate
3268 dll under windows !!!!)
3269 - python21_d debug mode enabled (ask Frog how to use it :-)
3270 - NO problem with having an STL member of class for example string in C++
3271 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3272 - Python test of dcmlib in Python is ok under windows on a large set
3274 * removed glib references
3275 * typedef's inserted in gdcm.i for correct swig type management
3277 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3278 * python/demo/*.py load.py extracted from test.py. Added explore.py
3279 that only displays required tags and testAll.py that parses all
3280 the files of the testsuite without using unittest.
3281 * python/testSuite.py other additional test on new files added.
3282 * Data/* new test files added accordingly to the testSuite.
3283 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3284 the vr in the file differs from the one of the dictionary.
3286 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3287 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3288 values, but limits itself to values which are below a user specified
3289 size (by default 1024 bytes).
3290 * python/gdcm.i : elements not loaded (because their size is above the
3291 user specified treshold) are exported with their TagKey as key of the
3292 python dictionary. This enables the testsuite to make some checks
3293 on the unloaded elements (since we have their offset and size).
3294 * python/testSuite.py
3295 - now tests for the existence and proper value of the pixel data
3296 - two new examples added.
3297 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3299 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3300 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3301 aware. See the strategy comments in gdcmHeader::FindLength().
3302 * Test/test.cxx now accepts a filename as first argument.
3303 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3304 * python/testSuite.py changed to integrate test on above files.
3306 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3307 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3308 the vr was also RET.
3309 * python/testSuite.py more tests added.
3311 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3312 * python/testSuite.py unittest test suite added (uses Data)
3313 * Data/* dcm and acr files for the test suite.
3314 * glib dependance removed from un*x version. We now use ISO C99
3315 7.18 Integer types (see stdint.h)
3316 - python/Makefile, src/Makefile src/gdcm.h
3317 * src/ when an explicit vr (like dicom files) suddenly poped an
3318 implicit element we use to mark the underlying DictEntry of the
3319 concerned ElValue with "Implicit". This strategy was damageable
3320 too the public or provite dictionaries, since some of their vr
3321 would be changed. Since Header::FindLength heavily relies on the
3322 detection by Header::FindVR of falsely explicit elements, I
3323 added an extra ImplicitVr member to ElValue (boolean).
3324 The rest of the changes we the necessary adaptations.
3326 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3327 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3329 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3331 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3332 * Adaptation for porting to VC++:
3334 o forced to use std namespace (for string to be known)
3335 o all class use __declspec export style on WIN32
3336 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3337 (in stdlib.h on Win32 but in std:: for gcc)
3338 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3339 variable GDCM_DICT_PATH.
3340 * src/gdcmHeader.cxx verbose comments made discrete.
3342 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3343 * python/gdcm.i: added a typemap that converts a C++ hashing table
3344 to native Python dictionary.
3345 * python/demo/test.py:
3346 - now uses the native dictionary for exploration of gdcmHeader.
3347 - takes an optional filename argument (the file to parse).
3348 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3349 PubElVals hashing table.
3350 * Dicts/dicomV3.dic removed error prone trailing spaces.
3352 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3353 * Python wrapping process moved away from src/Makefile to
3354 newly created python/Makefile (as well as gdcm.i)
3355 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3356 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3357 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3358 from the environement variable GDCM_DICT_PATH (when existing).
3359 * src/gdcmDict::GetTag bug fix.
3361 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3362 * Straightforward temporary fixes for swig to build the python wrappers.
3363 src/Makefile now has a python working entry [by working we mean
3364 that we can import the shadow classes without errors].
3366 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3367 * hashtest.cxx removed (since already in Test)
3368 * src/gdcmlib.h renamed to src/gdcm.h
3369 * src/dcm.i renamed to src/gdcm.i
3370 * src/Makefile prepared for python wrapping
3372 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3373 * src/gdcmHeader.cxx :
3374 - Parsing of header is now separated from loading of element values
3375 (see gdcmHeader::LoadElements).
3376 - general clean up of hopefully all file access (creation of
3377 ReadInt16 and ReadInt32)
3379 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3380 * src/gdcmHeader.cxx :
3381 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3383 - SetLgrElem renamed to SetLength
3384 - GetLgrElem renamed to GetLength
3385 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3386 * src/gdcmElValSet.cxx fixed both GetElValue methods
3387 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3388 due to IdoDude was cleaned out.
3390 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3391 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3392 concentrates on finding the value representation (when it exists).
3393 RecupLgr now only finds the element value length, and it avoids
3394 returning the unecessary skL (skipped length).
3395 Also, offsetCourant was simply removed (with taille_fich) since
3396 it was redundant with the File position internals (by using
3397 ftell and fseek). This also made skL (see above in RecupLgr) usage
3399 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3400 on the libido specificities which are handled through class
3402 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3405 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3406 * Truckload of changes. Parsing of header is barely functional
3407 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3409 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3410 * src/gdcmHeader.cxx many addons of low level methods
3412 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3413 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3414 and _IdDcmSWAP_LONG.
3416 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3417 * This corresponds to all the changes decided at the meeting of
3418 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob