1 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
4 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * Test/ : accelerate tests (it's not very significant accelerations).
6 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
8 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * Testing/TestSequence.cxx : add test for sequences of images... test that
10 we have the same serie or the same study UID
12 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
15 * src/gdcmDict.h : remove commented code
16 * src/gdcmDocument.cxx : initialize values
17 * src/gdcmFile.cxx : bug fix when reading values
18 * gdcmPython/demo/ : change file names. Remove useless files
20 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * src/gdcmFile.cxx : remove the default array of initialization.
22 The static array contained pointers to non-static values (comming from
23 strings). To have coherences, when creating files, these values can't be
24 static. So, the array can't be static, too ! To simplify, the array have
25 been replaced by repeted lines to insert values in the File
27 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
29 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
31 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
32 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
33 (Dicom Element) into the Sequence Item
35 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * src/*.cxx : first parss to normalize file organisation
38 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * src/gdcmDirList.[h|cxx] : add method to find a directory
40 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
42 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
43 * Finish cleaning up my JPEG mess. Should be ok now.
44 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
45 contained within the RLE* class(doh!)
47 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
48 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
49 * SerieHeader::AddFileName() creates as many Coherent Files lists
50 (same Serie UID) as it founds different Serie UID
51 amongst the files instead of discarting any file
52 that doesn't match with the first one he found.
53 * SerieHeader::OrderGdcmFileList has now one parameter :
54 the Coherent Files list the user wants to sort
55 * SerieHeader::GetFirstCoherentFileList() |
56 * SerieHeader::GetLastCoherentFileList() | allow to parse
57 the set of Coherent Files lists
58 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
59 compatibility (it returns the *first* Coherent Files list,
60 since there was only one before)
61 * Test/TestSerieHeader gets gdcmData as a default root directory
63 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
64 * Remove friend between DocEntry and File classes
65 * Remove friend between PixelReadConverter and RLEFramesInfo,
68 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
70 0002|0000. The value was incorrect.
72 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
75 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
76 * src/gdcmUtil.cxx : compilation fix on Win32
77 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
78 variable, to be easy found. Add methods to change the default UID.
79 Amelioration of the CreateUniqueUID to use the correct default UID.
80 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
83 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
84 * Test/TestVR.cxx : fix memory leaks
86 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
87 * Rewrite the base 256 to base 10 conversion, using string operation only.
88 This allows us to get rid of the problematic 64bits integer type (does not
89 always exist on target platform).
91 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
92 * Add construct and destructor to class gdcm::Debug to close the debug file
94 * Don't let uset to open twice the same file
95 * gdcm has now an official UID prefix,
96 supplied by http://www.medicalconnections.co.uk
97 1.2.826.0.1.3680043.2.1143
98 (Thx to Mathieu for providing URL)
99 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
100 to be able to perform some more tests
101 * gdcm::ContentEntry : Contructors and Destructor are now protected,
102 in order to be sure no user will try to use them.
103 (at user level, only the children classes are meaningfull)
105 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * move RLEInfo & JPEGInfo from Document to File
108 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * FIX : remove so many friend between classes
111 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
112 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
113 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
115 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
116 In order to avoid missbehaviour :
117 . gdcm::DocEntry is now specialized in
118 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
119 - gdcm::ContentEntry (Dicom entry with a 'content')
120 . gdcm::ContentEntry is specialized in
121 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
122 characters value, or integers)
123 - gdcm::BinEntry (Dicom entry with a non strig representable value
124 (user hasn't any longer to thing about the precedence of his dynamic_casts)
126 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * Test/VTKTest*.cxx : bug fix under linux
129 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
131 use with python. Some methods are moved from Document to ElementSet or
132 DocEntrySet. The equivalent methods to ElementSet have been added to
133 SQItem and are virtual in DocEntrySet. Methods that may have the same code
134 in SQItem and ElementSet is directly placed in DocEntrySet
136 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * Test/VTKTest*.cxx : remove the show variable in each test method because
138 it's useless (the viewer variable replace this variable)
140 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * src/gdcmDocument.cxx : bug fix on potential memory leak
142 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
143 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
144 Add ClearXxx methods to remove all the content of the list or map
145 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
147 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
148 * methods ReplaceOrCreate renamed as Insert
149 (nobody will be any longer confused by 'CreateOrReplace')
151 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
152 * Grealty simplify the JPEg decompression, no need to differenciate based on
153 the JPEG possible type (with/without fragment, with/without multiple frame).
154 Everything is done throught the JPEG IO Suspension mechanism in IJG
156 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
157 * Stage 3 of normalization :
158 in order to avoid any missunderstanding while reading method names :
159 - All the methods xxxEntry now deal with dicom Entries
160 - Methods GetEntry splitted into
163 - Method SetEntry renamed as SetEntryValue
164 - Method SetEntryBinArea let as it was
166 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
167 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
168 - Position correctly the entry points for JPEG2000 and JPEG-LS
169 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
171 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
173 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
174 with other method names
175 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
176 * Test/TestDicomDirElement.cxx : add new test
178 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
179 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
180 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
181 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
182 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
183 So can't you use __int64 in ostream at all.
185 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * bug fix for compilation on MSVC6
187 * gdcmPython/gdcm.i : rename of classes missed
189 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
190 * Stage 2 of names normalization :
191 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
192 (easy to understand ...)
193 - gdcm::FileHelper replaces old class gdcm::File
195 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
196 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
197 type and not a string. So, there remove problems on the format of the
200 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
201 * Add Example/TestPapyrus.cxx
202 - reads a Papyrus file (gdcm::Header compliant),
203 - gets the pixels of all the images, using low level iterators
204 - writes an multiframes Dicom image.
205 (Just to show it's *possible* to do that)
206 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
209 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
211 Thus, DicomDirXXX are created with a flad that indicates if the created
212 object is empty or not (when not empty, the DicomDirElement is used to
215 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
217 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
219 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
220 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
222 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
224 Remove all access to the hash-tables or lists in the objects.
226 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
228 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
229 be complient with all the gdcm source code
231 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
232 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
235 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
239 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * Test/ : rename VTK tests to have a best name for the tests
241 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
242 GetFirstEntry/GetNextEntry use
244 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
245 * In SerieHeader::ImagePositionPatientOrdering()
246 // a Dicom 'Serie' may contain scout views
247 // and images may have differents directions.
248 // -> More than one may have the same 'pos'
249 // Sorting has then NO meaning !
250 Thx to Eduardo Davila for reporting bug.
252 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
254 test. Now it's on image content and not on the resulting visualisation...
255 might solve the problem on linux when using the OpenGL drivers
257 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
258 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
259 DicomDirSerie, DicomDirImage
260 Dict, DictSet classes :
261 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
262 -remove InitTraversal method.
263 * UPD Test programs + Example programs
265 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
266 * remove useless and never updated keyword \ingroup
267 * Solve pb when structure (list, map, ...) is empty.
268 Thx to Benoit for reporting bug
270 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
271 * Taking into account of 'Transfer Syntax' value
272 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
275 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
276 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
277 is no memory access violation
278 * gdcmPython/demo : add python demos using VTK
280 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
281 * FIX 'Dictionnary' is now spelt 'Dictionary'
282 'wether' is now spelt 'whether'
283 'archieve' is now spelt 'archive' ;-)
285 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
286 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
287 related methods, in order not to expose internal mechanisms
290 * REM methods that exposed internal mechanisms :
291 DicomDir::GetDicomDirPatients()
292 DicomDirPatient::GetDicomDirStudies()
293 DicomDirStudy::GetDicomDirSeries()
294 DicomDirSerie::GetDicomDirImages()
295 * UPD Test programs :
299 * UPD Example program
301 * ADD DictSet methods
305 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
306 * Removed the Print/indent/default parameter mess. There is absolutely no
307 reason to have to methods, moreover with the second taking the ostream as
308 *SECOND* parameter. This was clearly a bad hack to get things compile.
310 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
311 * Complete rewrite of the GetMacAddress code. Now the code is *much*
312 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
313 Unfortunately the main code does not work on SunOS, thus provide a specific
314 code for this platform only (and Win32 of course). Since this seems to be
315 working, change CreateUniqueUID to use GetMACAddress instead of the
316 problematic GctestetIPAddress
318 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
319 * Unfortunately to be able to test gdcmDirList I had to break the API
320 a little. Now the class is not a std::list anymore but has a member
321 std::vector (more ITK compatible). Allow unit testing on Win32 and
324 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
325 * Update SerieHeader to take into account a Serie Instance UID to properly
328 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
329 * ENH - Comment out Mathieu's (dangerous) Super Hack
330 for dealing with BIGENDIAN processors
331 - Move equivalent stuff to BinEntry::WriteContent
332 When necessary, 16 Bits Pixels are swapped in a small buffer
333 and then written. This avoid allocating a huge buffer, in
334 PixelWriteConvertor, and avoid modifying the Pixel Area.
336 Probabely, the same operation will have to be done when we want
337 to write image with Big Endian Transfert Syntax,
338 and we are working on Little Endian Processor
340 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
341 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
343 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
344 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
345 all the dict content.
346 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
348 * Test/TestDict.cxx : add a new test for the dict classes
350 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
351 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
352 file. Debug is yanked if compiled with NDEBUG
354 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
355 * src/gdcmDictSet.h : set the default output to the os variable
356 * src/gdcmDictEntry.[h|cxx] : add the Print method
357 * gdcmPython/demo/ : add a new test
359 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
360 * merging of Test/PrintDicomDir and Test/TestDicomDir
361 * removal of now redundant Test/PrintDicomDir
362 * enhancement of Example/PrintDicomDir
364 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
365 * Now, python test might work on systems
366 * Add the PrintDicomDir test
368 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
369 * FIX : First entry following group 0002 was lost for
370 Explicit Big Endian Transfer Syntax files
371 (group and elem not swaped)
373 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
374 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
375 Big Endian Transfer Syntax supposed the group following 0002
376 begins always by element 0000 (element 0000 is *optional*)
377 To avoid further troubles, let's be pessimistic, and use
378 Document::HandleOutOfGroup0002() method
379 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
380 (related pb not yet solved)
382 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
383 * Bug fix for the python part use
384 * Now, PrintHeader.py pass... but outside the ctest use. shit !
386 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
387 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
389 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
390 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
391 a string and should ask the global TS dict what are the propreties of
394 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
395 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
396 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
397 to swap the Swap Code, at parsing time, when we come out of group 0002
398 and Transfer Syntax is Big Endian
399 We should be able to read now 'true DICOM" Big Endian coded images
400 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
401 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
403 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
404 * Hopefully fix the bug on MacOSX and static global initialization.
405 This is the only -minor- patch I found that both please MacOSX and VS6.
406 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
407 but this would require a lot of change. Another approach would be that Global
408 create those string and GDCM_UNFOUND becomes a pointer to a string (which
409 gdcm::Global would destroy at exit).
411 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
412 * Fix bug on MacOSX with static initialization in a multy threaded
413 environment. static const string in a header file used to be ill
414 initialized provoquing the freeze of any tests. patch should solve this
417 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
418 * According to Benoit's suggestion, and without any objection from anybody
419 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
420 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
421 - method gdcmDicomDirObject::GetEntry() renamed as
422 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
424 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
425 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
426 you debug/warning message just as c++ streams which make them very convinient
427 to use. Once this is stabilize I will change the ostringstrem to be
428 redirected to a file (ofstream).
429 * Properly support C99 extension: __FUNCTION__ which allow us to display
430 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
432 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
433 * Removal of useless and dangerous methods :
434 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
435 GetDocEntryByName, GetEntryByName, GetDictEntryByName
436 * Removal of usless methods :
437 Dict::PrintByName, Dict::GetDictEntryByName
438 * Commenting out of probabely useless methods :
439 Dict::GetDictEntryNames()
440 Dict::GetDictEntryNamesByCategory()
441 DictSet::GetPubDictEntryNames()
442 DictSet::GetPubDictEntryNamesByCategory()
443 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
444 * ENH : Use dicomTS.dic as described in 2004 version
445 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
446 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
447 Add Accessors on VM (Value Multiplicity), and VM related methods
448 * ADD : Add a list of 'Dicom Attribute types', as found in
449 http://medical.nema.org/dicom/2004/04_15PU.PDF
451 * ADD : Add dicomGroupNameAbbreviations.dic
452 should be used to write a method to replace the former
453 Dict::GetDictEntryNamesByCategory()
455 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
456 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
457 to read in the file... and only it ! Length is the efective length of the
458 data in the DocEntry structure
460 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
461 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
462 And now use a static function call instead, with a global variable. i
463 This is much closer to the VTK approach. Hopefully should be bulletproof
464 and easier to use...hopefully
466 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
467 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
469 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
470 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
472 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
473 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
474 ValEntry, BinEntry, SeqEntry creation or replace
476 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
477 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
478 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
480 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
481 when specifying the VR
482 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
483 * src/gdcmDocEntry.cxx : amelioration of print
485 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
486 * ADD : Add the method Util::IsCurrentProcessorBigEndian
487 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
488 * ADD Method Document::ComputeGroupLength
489 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
490 in order to allow further VR modification by user
491 * REM : removal of once-called method File::WriteBase
492 integration of its code in formerly one-line method File::Write
494 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
495 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
496 replace the different values "??", "Unkn", "Unknown".
497 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
498 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
499 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
500 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
502 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
505 * Set the gdcm::Base class to some Printable classes
507 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * src/gdcmFile.[h|cxx] : add the Print method
509 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
510 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
511 * src/gdcmDocument.h : remove the PrintLevel informations
512 * Example/PrintFile.cxx : use the new gdcm::File::Print
514 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
515 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
516 problems when compiling with the python wrapping
518 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
519 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
520 writting in ImplicitVR
522 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
523 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
524 JPEG decompression, especially when dicom frames are split into several
525 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
526 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
528 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
529 * src/gdcmHeader.cxx : change the initialisation of default header.
530 Now, this header is readable by gdm, e-film, DicomWorks
532 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
534 Rename Decompressed to Raw
535 * Use the API changes in gdcm::File.
536 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
539 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
540 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
541 each added entry in the header. Replace the 'Planes' field by the 'Number
544 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
546 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
548 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
549 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
550 At this time, this image isn't readable by e-film... waiting JPR help to
553 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
554 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
555 DocEntry. Now use methods of the Document !
557 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
558 * Test/ShowDicomSeq.cxx : bug fix
560 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
561 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
562 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
563 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
564 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
566 * Test/TestCopyRescaleDicom.cxx : remove unused variable
567 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
568 containing found sequences
570 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
571 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
573 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
574 Some fields in BinEntry must be copied to not seg fault when making the :
575 gdcm::File *copy = new gdcm::File( copyH );
576 and tests are now made on good variables
578 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
579 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
580 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
582 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
583 * Add vtkGdcmWriter example and test
585 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
586 * Test/TestUtil.cxx : reformat the source code
587 * vtk/vtkGdcmReader.cxx : remove and change prints
588 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
590 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
591 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
593 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
594 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
595 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
597 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
598 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
599 by an eof to prevent all bad read of the file... and in this case, the
602 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
603 * Example/Volume2Dicom.cxx : comment unused variables
604 * Test/PrintDicomDir.cxx : comment unused variables
605 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
606 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
607 method that is redondant with AddEntry.
608 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
611 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
612 * Bug fix due my last commit (compilation under Windows).
613 * Example/Volume2Dicom : bug fix in the file and reformatting source code
614 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
616 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
618 - Remove printf / sprintf
619 - include iostream AFTER gdcm so we don't get warnings
620 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
622 - Also remove tons of include from header files, hopefully this should
623 speeup the compilation time, since it was becoming a dog slow.
624 - Remove gdcm.h as it include way too many files and slow down compilation
625 (plus it is not up to date)
626 - remove 'using namespace std' this is BAD !
628 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
629 * Remove memory leaks on the DicomDir
630 * Remove some useless data in DicomDirObject
631 * Add usefull methods in SQItem, to be complient withe the ElementSet
633 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
634 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
636 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
637 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
638 future, with convertion)
639 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
640 and ImageDataSize values. Remove the method to get the PixelReadConverter
641 from the output of the class
643 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
644 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
646 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
647 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
648 and vtkErrorMacro use.
649 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
651 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
652 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
654 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
655 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
656 The string leaves only in the fonction. So when we make a .c_str(), we
657 get the pointeur on the first element, element that will be destroyed
658 immediately after thee instruction.
659 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
660 file has been opened : the test must be made on the content of the
661 pointer and not directly on the pointer !
664 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
665 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
666 the python part recompiles
668 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
669 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
670 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
671 X session is killed (for my computer... it seems to not be identic on
674 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
675 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
676 avoid problems (otherwise, the difference test between the visible image
677 and the reference is incorrect. If the reference is greater than the
678 screen resolution, it's produce errors).
679 Can be used for only one image. Can be used with a visible flag.
680 * vtk/vtkGdcmReader.cxx : remove commented codes.
681 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
682 under windows at compilation
683 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
685 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
687 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
688 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
689 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
690 tests on the image size X, Y, Z
692 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
693 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
694 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
695 between the class name and the file name
697 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
698 * src/ : fix compilation warnings for the Write method (2 different
699 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
700 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
701 variable... create a static method in gdcm::Document to access to
702 this variable content.
704 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
705 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
706 file, to be accessed by other files (like gdcmFile). Remove commented
707 code. Move the change of the header to the gdcmFile, using the
709 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
710 To be sure of that (and simplify calls), the Write of the header now
711 gets a file name and not a file pointer (std::ifstream).
712 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
713 DocEntryArchive. Remove all open of the written file
715 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
716 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
718 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
719 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
720 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
722 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
723 some corresponding methods. Write correctly the file and check before
725 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
726 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
727 is now on RGB data (as before my last commit
728 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
730 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
731 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
732 Add a print information of the type of the entry
733 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
734 It was in the gdcmFile, and all write have been regrouped
735 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
736 Write correctly all dicom files (in decompressed mode only at this time)
737 * Test/ : test on files are now made using Raw data and not color data if
739 * Example/PrintFile.cxx : add more printings
741 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
742 * Amelioration of code, remove some code copy. For the loading of
743 BinEntry (in gdcmDocument), add the test to verify if the file is already
746 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
747 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
748 remove a DocEntry in the header (push an empty DocEntry)
749 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
750 lines. Bug fix in the initialization of the PixelConvert and the
752 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
753 use in TestCopyDicom (now this test can run under windows... but fails)
754 * Test/TestCopyDicom.cxx : amelioration of the test :
755 - test the pixels written
756 - add test points to quickly find where is the error
757 - can set a file name input and output in arguments
758 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
759 amelioration of the test output
761 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
762 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
763 all replaced DocEntry's
764 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
765 Now, each needed DocEntry to modify is duplicated, modified and inserted
766 to the header using DocEntryArchive. Thus, after save, we can restore the
767 header initial state.
769 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
770 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
772 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
773 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
774 correct to copy it. The DictEntry is specified at the DocEntry creation,
775 then, it musn't change in the time.
776 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
777 header correctly. At this time, the change is only made for the first
778 level of the Document. In the future, it might consider sequences.
779 The change is made by replacing a DocEntry by an other that is created
780 outside the class. The old value is kept. When we restore the header
781 status, the added DocEntry is deleted and replaced by the old value.
782 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
783 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
784 set the write type to explicit VR, implicit VR or ACR. Add methods to set
785 the write mode to native, decompressed or RGB (but not used at this time)
787 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
788 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
789 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
791 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
792 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
793 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
795 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
796 set because already copied when copying the BinEntry's of the header
797 * Test/TestAllReadCompareDicom.cxx : remove warnings
799 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
800 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
801 Two problems appear when doing it :
802 - with the gdcmFile : when the GetImageData method is called, the pixels
803 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
804 data (pixels). And each structure destruct the data when it's
805 destructed. So we have two destructions for the same data. To solve it,
806 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
807 data or not. If it doesn't own data, then they will not destroyed by
809 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
810 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
811 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
812 create a double destruction of the same DocEntry's. So, to solve it,
813 the TagHT is simply cleared and the DicomDir* elements are destroyed.
814 * TODO : add an entry concerning memory leaks in the DicomDir
816 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
817 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
818 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
821 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
822 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
823 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
824 after it have been deleted
826 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
827 * FIX: src/* fix the doxygen warnings.
828 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
829 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
830 was erroneously defined with a size of 15 instead of 16. [many thanks
831 to Jean Michel Rouet for pointing out this bug].
833 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
834 1. Finish merging JMR patch for writting DICOM from scratch
835 2. Fix -hopefully- bug with MONOCHROME and space vs null character
836 3. Use const ref when possible
837 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
838 5. A few more comments
839 6. CreateUniqueUID can now be called without parameter"
841 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
842 * ENH: Slightly bigger patch:
843 1. Getting toward full integration of JMR patch for writting dicom from scratch
844 2. Update Test to test part of this patch: CreateUniqueUID
845 3. File was not close properly in gdcmDict
846 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
847 5. Use of const ref instead of copy (speed issue)
848 6. Remove temporary (duplicate) string in TranslateToKey
849 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
850 8. Do not repeat virtual in subclasses
851 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
853 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
854 * Apply first patch toward better string comparison when dealing with broken
855 DICOM files. Essentially the string could be padded with a space instead
856 of a null character as defined by standard
858 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
859 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
860 because never used... and in the same time, that's remove some memory leaks
862 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
863 * src/gdcmFile.cxx : now delete the PixelConvert instance.
864 * In examples and tests : change the type of image data variables from void*
865 to uint8_t*. Remmove all delete on image data variables
867 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
868 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
869 Verify the file pointer value before open the file, and if it's not null,
870 a verbose message is generated.
871 Close correctly the file when the file isn't considered dicom-like. The
872 correctly close is a call to CloseFile.
873 When closing the file pointer, test if its not null to close the file.
874 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
875 file. For an uncompressed image, the copied data correspond in the least
876 case to the image size (calculated) or the image size specified in the
877 header. A verbose is generated if these two size mismatch
879 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
880 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
881 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
882 break under windows (with msvc6 compilation).
884 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
885 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
886 compiling with MSVC6)
888 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
889 * Bugs fix for the Windows build with VC6
890 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
891 needed (only for projects required VTK). If the VTK is included in all
892 projects, there is conflicts with the jpeg lib of vtk when compiling the
893 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
894 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
895 when compiling the gdcm_wrap.cxx file (created by the compilation of the
897 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
898 (like it's already made for the cout use). Otherwise, conflict with the
901 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
902 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
904 - comments on the DicomDir::Method related usage added.
905 - now that we use the namespace gdcm, a lot of internal classes do
906 NOT need to be wrapped anymore.
907 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
908 DicomDir::Method) new example added.
910 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
911 * Improve string manipulation. I now inforce the notion of 'DicomString'
912 A DicomString can contain as many \0 as they want
913 and it is *always* of even length.
914 We only support odd length for very rare case.
915 And in the near future this should be removed.
917 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
918 * /binary_write/ gdcm source. Now even on big endian we are writting
919 little endian. This should -heopfully- fix some tests
921 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
922 * Now the dictionary is compiled into gdcm lib. This is a default
923 behavior, thus any dic file specified is picked before failback to
924 the one comiled into lib
926 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
927 * Change internals for gdcmDict. Don't use any 'new' any more.
928 This should definitely solve any leak problem, and we should be
929 as fast as before, as long as don't modify too much the dictionary.
931 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
932 * STYLE: ivars should start with a capital letter.
933 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
934 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
936 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
937 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
938 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
939 new 2004 dictionaries added (thanks to JPR).
940 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
941 * CLEANUP_ROUND (15) for gdcmPixelConvert
942 - RLEFrame::NumberFragments is now of type unsigned int
943 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
944 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
947 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
948 * Initial work in gathering all transfer syntax accessors. clearly
949 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
950 ivars, but only one transfersyntax (class) ivar with equivalent method on
953 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
954 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
955 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
956 discussed (plus I didn't like having a 2000 lines patch not commited)
958 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
959 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
960 * CLEANUP_ROUND (14) for gdcmPixelConvert
961 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
962 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
963 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
965 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
966 anymore and hence avoids storing a copy of PixelConvert::Decompressed
967 into File::Pixel_Data.
969 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
970 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
971 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
972 * CLEANUP_ROUND (13) for gdcmPixelConvert
973 Substituted File::ParsePixelData() with PixelConvert::Print() new
975 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
976 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
977 method to those classes.
978 - src/gdcmFile.[cxx|h]:
979 -- Added a ::Print() method.
980 -- PixelConverter is now a reference instead of a member.
981 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
982 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
984 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
985 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
986 collaboration diagram and inheritance diagram should be generated with
988 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
989 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
990 pointlessly wrapped (see
991 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
992 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
993 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
994 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
995 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
996 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
997 -- File::Initialise: PixelConverter setup moved away to
998 PixelConverter::GrabInformationsFromHeader()
999 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1000 interpretation moved away to PixelConverter::BuildRGBImage()
1002 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1003 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1004 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1006 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1007 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1008 displayed on Win32 when a brutal abort() occurs (because of uncatched
1009 exception). See TODO new entry of this commit for more on this.
1010 * TODO added new entry.
1011 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1012 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1013 - HandleColor is no longer called from gdcmFile.cxx
1014 - gdcmPixelConvert.cxx clean up on method arguments and internal
1015 variable names for semantical coherence.
1017 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1018 * Finished lossless transition, not only do we now read all lossless jpeg
1019 images, without the need of the Cornwell lib, but we do read them properly now
1020 * To reduce code (well to avoid code duplication), I defined a common place
1021 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1022 redefine symbols. This is not perfect but this the best solution I found for a
1023 compilation time jpeg option.
1025 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1026 * Update jpeg ijg lib to support lossless jpeg implementation
1027 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1029 * Also added a special copyright for dcmtk since we use their bugfixes.
1032 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1033 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1034 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1035 matters, as stated in warning note at beginning of %include section).
1036 * src/gdcmDicomDir*.[cxx|h]: coding style
1037 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1038 * src/gdcmJpeg8.cxx: doxygen fix.
1039 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1040 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1041 from File:: to PixelConvert::.
1043 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1044 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1045 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1046 - more code moved away from File:: to PixelConvert::
1047 - fat setup of PixelConverter set in place in File::Initialise.
1049 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1050 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1051 namespace at the file system level. So now you should convert your examples
1053 gdcmHeader -> gdcm::Header
1054 It would be nice if people keep in mind to no open the namespace, since it
1055 allows compilation on broken plateform which were defining common symbol in
1056 the standart namespace (like LP, Unknown ...)
1058 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1059 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1060 The JPEG fragments are now parsed at the same stage than the RLE
1061 information. All code related to JPEG is now in gdcmPixelConvert:
1062 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1063 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1064 export a gdcmFile:: method. Those are simply global functions
1065 (for the time being this is better than having them attach to
1066 either gdcmFile:: or gdcmPixelConvert::).
1067 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1068 and stores the result in a gdcmJPEGFragmentsInfo.
1069 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1070 code (among other stuff) moved away from gdcmFile:; to
1073 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1074 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1075 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1076 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1077 clean up of RLE related code.
1078 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1079 - src/gdcmRLE.cxx removed
1080 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1081 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1082 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1083 * CLEANUP_ROUND (9) for gdcmPixelConvert
1084 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1085 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1086 away from gdcmFile:: to gdcmPixelConvert::.
1088 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1090 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1091 This is because Parse7Fe0 used to parse the pixels to compute the
1092 length. This task was passed over to FindDocEntryLengthOB() a long
1093 time ago, EXCEPT I had forgotten the OW case...
1094 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1095 we just recylce the code for parsing RLE fragments and computing
1097 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1098 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1099 with the retired Parse7Fe0().
1100 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1101 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1103 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1104 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1105 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1106 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1107 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1108 * CLEANUP_ROUND (4) for gdcmPixelConvert
1109 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1110 to return an unused length.
1112 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1113 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1114 this should be cleanner from the plane view. The iostream are erally a pain
1115 to use to do simple stuff.
1117 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1118 * Redo the compilation of the ijg jpeg library. Now only one source is
1119 necesseray. No need to rename file by hand what so ever. CMake handle the
1120 copying of the file within different directory, configure header file to
1121 modify some symbol. The only addition made to ijg wasd a mangle table so
1122 that symbol are different whether we are within 8bits or 12bits.
1124 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1125 * Added documentation of vtkgdcmReader on Website:
1126 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1127 with it's binary name).
1128 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1129 the Website to be more complete.
1130 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1131 doxygenated documentation.
1132 - Doc/DoxyVtkGdcmReaderExamples.txt added
1133 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1134 DoxyVtkGdmReaderExamples.html )
1135 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1136 * CLEANUP_ROUND (3) for gdcmPixelConvert
1137 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1139 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1140 * CLEANUP_ROUND (2) for gdcmPixelConvert
1141 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1143 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * CLEANUP_ROUND for gdcmPixelConvert:
1145 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1146 - src/gdcmPixelStuff[h|cxx] removed
1147 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1148 - src/CMakeLists.txt changed accordingly
1149 * GDCMHOME clean up:
1150 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1151 gdcmVersion.py moved to newly created ATTIC related
1152 gdcmPython/SetupOldies/ directory.
1153 * Autotools clean up:
1154 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1155 - autogen.sh configure.in acinclude.m4 python.m4 removed
1157 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1158 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1159 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1160 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1162 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1163 * TODO updated with Mathieu suggestions. I proposed a template for
1164 describing TODO entries and used it for new entries.
1165 * Added Doc/Website/CodingStyle.html, Developpers.html,
1166 DeveloppersPython.html, GdcmDataCvs.html and
1167 DownloadVersion0_1.html, DownloadVersion0_3.html.
1168 * Some Doc/*.txt Doxygen files (which do not really concern the
1169 documentation itself, but the website) moved to html and
1170 placed in directory Doc/Website:
1171 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1172 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1173 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1174 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1175 * CMakeLists.txt changed accordingly.
1176 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1177 DeveloppersPython.html
1178 * INSTALL nows refers to Doc/Website/Installation.html
1180 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1181 * Added Doc/Website directory, that contains a first raw version
1184 2004-09-23 Jean-Pierre Roux
1185 * FIX In order not to be poluted any longer by casting problems,
1186 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1187 we can now delete[] it safely
1188 * VoidArea is now called BinArea (less confusing name),
1189 and all the methods called ...VoidArea... are now ... BinArea...
1190 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1192 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1193 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1194 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1195 up to the destructor of gdcmElementSet to clean up TagHt and it's
1198 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1199 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1200 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1202 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1203 * ENH: added some utility method that builds a flat dictionary
1204 holding all the Dicom entries contained in the recursive structure
1205 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1206 an example of usage.
1207 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1208 BuildFlatHashTable() that build a flat dictionary.
1209 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1210 gdcmDocument is now a friend of gdcmElementSet.
1211 - src/gdcmElementSet.cxx: clean up.
1212 - Example/FlatHashTablePrint.cxx added.
1213 - Example/CmakeLists.txt changed accordingly
1215 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1216 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1217 moved away from gdcmDocEntrySet (since this class is an abstract class
1218 acting like an interface). SQDepthLevel and BaseTagKey are now
1220 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1221 and associated accessors. Doxygenation of the class.
1222 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1224 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1225 Use SQDepthLevel accessor instead. ::Print() adapted.
1226 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1227 - src/gdcmDocument.cxx changed accordingly.
1229 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1230 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1231 - The following is the doxygen comment of the typedef declaration
1232 of gdcmTagKey in src/gdcmCommon.h:
1233 gdcmTagKey is made to old an "universal" (as in URL, Universal
1234 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1235 A dicom tag always has a group and an element, but a set of tags
1236 embeded in various (optionally nested) sequences and sharing
1237 the same group and element all share the same (group, element)
1238 "identifier". Hence the (group, element) cannot be used as an
1239 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1240 In order to construct a proper tag identifier (i.e. a key) we
1241 consider the following definition of a TagKey:
1242 - let Group, Element be the string representation of the
1243 group and element dicom tag members,
1244 - let ItemNumber be the string representation of the integer
1245 index of the considered item number of a sequence,
1246 Let the key of a tag embeded in a sequence, noted SeqTag, be
1248 /ItemNumber#Group|Element
1249 where "/", "#" and "|" are characters acting as separators.
1250 Then the general form of a gdcmTagKey is given by:
1251 Group|Element<SeqTag>
1252 where <SeqTag> means NO or many instances of SeqTag.
1253 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1256 but the gdcmTagKey of a tag "embeded" is the first item of
1257 a sequence, itself nested in the third item of a sequence is the
1259 0004|1220/2#0008|0082/0#0008|0090
1260 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1261 order to hold the new sequence compatible key. Previously, the
1262 GetKey() method would look in the underlying gdcmDictEntry.
1263 - src/gdcmDocEntry.cxx:
1264 -- constructor now copies the underlying DictEntry key, in the local
1266 -- ::Print: displays the member Key, instead of the (group, element).
1267 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1268 - src/gdcmDocEntrySet.h:xi
1269 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1270 -- now has a new BaseTagKey member.
1272 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1273 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1275 This poses the problem with the semantics of the following lines
1276 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1277 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1278 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1279 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1280 to the long FIXME note for what the problem is. Nevertheless in
1281 order to get things working the dicom dictionary was altered !
1282 Please fix things urgently...
1283 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1284 information), see above note on moving the member VoidArea. Nevertheless
1285 the following entries previously correctly set as US are now inproperly
1287 0028 1201 OW IMG Red Palette Color Lookup Table Data
1288 0028 1202 OW IMG Green Palette Color Lookup Table Data
1289 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1290 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1291 of gdcmDocEntry moved to gdcmSeqEntry.
1292 * src/gdcmSeqEntry.cxx: STYLE.
1294 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1295 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1297 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1298 * gdcmPython/testSuite.py: all the test suite in python is now moved
1299 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1300 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1301 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1303 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1304 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1305 to avoid inclusion recursion until STL is reached.
1306 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1307 mecanism. errno.h is not included in gdcm anymore.
1308 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1309 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1311 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1312 gdcmData/TestAllEntryVerifyReference.txt
1313 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1314 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1315 exception_on_error parameter.
1316 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1317 - vtk/vtkGdcmReader.cxx changed accordingly,
1318 - Example/*.cxx and Test/*.cxx changed accordingly.
1320 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1321 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1322 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1323 enable_sequences removed from gdcmHeader constructor and dependencies.
1324 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1325 * gdcmPython/demo/PrintHeader.py: dummy fix.
1326 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1327 skip_shadow removed from gdcmHeader constructor and dependencies.
1328 * Example/*.cxx and Test/*.cxx changed accordingly.
1330 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1331 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1332 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1334 2004-07-21 Jean-Pierre Roux
1335 * FIX Now, Parsing and Printing a DICOMDIR do work!
1336 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1338 2004-07-20 Jean-Pierre Roux
1339 * FIX Some brain damaged headers have Zero-Lenght fields
1340 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1342 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1343 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1344 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1345 variable (instance of gdcmDebug) by a definition macro, and the instance
1346 is now in static in the gdcmDebug class
1347 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1348 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1350 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1351 * WARNING: ctest now depends more tightly on gdcmData. You should
1352 check out gdcmData properly for things to run smoothly...
1353 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1354 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1355 we need the pixels not be loaded in order to use the ValEntry
1356 that displays position and size).
1357 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1358 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1359 be deprecated. If you have any doubts about the advantages of a
1360 modern scripting language (read Python) versus grass root C++ (i.e.
1361 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1362 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1363 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1364 Anyhow, consider documenting the gdcmData images in
1365 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1367 * Test/CMakeLists.txt:
1368 - now uses TestAllEntryVerify.cxx
1369 - specific comments on oldACR00001.ima (now renamed in gdcmData
1370 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1371 gdcmData/TestAllEntryVerifyReference.txt
1374 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1375 * src/*.[h|cxx] : typedef clean up
1376 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1377 - TagKey renamed to gdcmTagKey (for external usage)
1378 - VRKey renamed to gdcmVRKey (for external usage)
1379 - removal of typedef duplication.
1380 - Removed all unecessary inline keyword from class inline definitions.
1381 - Some method|function(void) declarations replaced with method|function().
1382 * src/jpeg/libijg12/jdhuff12.c:
1383 - printf polluting ctest removed.
1384 - TAB removal for comminting
1386 - TestAllReadCompareDicom.cxx: added a test that compares all the
1387 images in gdcmDataImages.h with corresponding images in
1388 gdcmData/BaselineDicom/. When baseline images are not present
1389 this test creates them.
1390 Note: we need to validate each reference image, but before that
1391 I'd like to rename them with a more explicit name...
1392 - CMakeLists.txt: changed accordingly.
1393 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1394 including each header needed).
1396 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1397 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1398 test suite to the Example directory. Are concerned:
1403 - TestWriteSimple.cxx
1404 * Test/CMakeLists.txt: added some comments on reasons for black listing
1405 image gdcmData/oldACR00001.ima
1407 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1408 * Test/CmakeList.txt: removed the following from black list (to be coherent
1409 with removal from gdcmData):
1410 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1411 - gdcm-MR-PHILIPS-16.dcm
1413 Added the following because after last cvs update, they cause
1414 ctest -R TestReadWriteReadCompare
1416 - gdcm-MR-SIEMENS-16-1.acr
1418 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1419 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1420 new comments in this file) we temporarily (sigh) move to a weaker
1422 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1423 we don't need to black list the following images anymore:
1424 - 8BitsUncompressedColor.dcm
1426 - US-PAL-8-10x-echo.dcm
1427 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1428 fixes and the beautified code ;-)
1429 This fixes the bug introduced in version 1.42 (when beautifying)
1430 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1431 Note: ctest was blind to this bug (this means we need to still
1432 improve the test suite). The bug could be detected by using
1433 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1435 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1436 and by displaying the (garbage) produced file temp.XDCM...
1438 2004-06-29 Jean-Pierre Roux
1439 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1440 - replace by uggly but working old code :-(
1441 A lot of things should be OK again.
1442 It's really urgent to have a test suite that *tests*,
1443 to prevent Frog's beautifying sessions to break all the stuff
1444 (twice, withing a fortnigh ...)
1446 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1447 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1448 redundancy) to added Test/TestReadWriteReadCompare.cxx
1449 * Test/CmakeList.txt: because the compare test of
1450 Test/TestReadWriteReadCompare.cxx fails, the following images are
1451 black listed: - 8BitsUncompressedColor.dcm
1453 - US-PAL-8-10x-echo.dcm
1454 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1455 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1456 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1457 and ad-hoc kludge. This kludge is now removed, and on encountering
1458 such an image (OB field brain damaged) we set errno. Then in
1459 ::FindDocLength() we "fix" the length as being ALL what remains
1460 in the file (until EOF). We then proceed, hoping for the best...
1461 This fixes a SegFault in ShowDicom when trying to write such an
1463 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1464 (because TestWriteRead breaks on it, after a non conformal commit?).
1465 ctest now runs properly, except for MakeDicomDir (which was always
1466 broken) and the Python related stuff (still not fixed).
1468 2004-06-24 Jean-Pierre Roux
1469 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1470 FIX : Test/TestReadWrite now iterates on all the file names
1471 (instead of infinite loop)
1472 ENH : Test/TestWriteRead now iterates on all the file names
1474 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1475 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1477 2004-06-24 Jean-Pierre Roux
1478 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1479 when SamplesPerPixel =3
1480 - now Write is no longer confused by
1481 'BitsAllocated = 12" and 'BitsStored=12"
1482 - "UN" value representation Elements are now written correctly
1483 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1484 ENH : - now gdcmHeader has its own Write methods
1485 (in order to split the job that has not to be done
1488 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1489 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1490 loop on the same image until memory went out.
1491 Note: this means we still have gobs of memory loss in PrintDocument
1492 * src/gdcmDocument.cxx: fixes problem on parsing on file
1493 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1495 2004-06-24 Jean-Pierre Roux
1496 FIX : Write - All the Sequences and Sequence Item are now written
1497 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1498 is added a the end, when necessary.
1499 - A lot of brain-damaged images, that were read correctly are
1500 now written correctly
1501 - length compatible BinEntry are now loaded correctly
1502 (even for odd groups)
1503 Note : only Explicit Value Representation was checked.
1504 (question : is implicit VR really necessary for gdcm ?)
1506 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1507 * DEVELOPPER: added a proposition of coding style.
1508 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1511 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1512 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1513 Use the gdcmDocEntry::Print() and Write() instead.
1514 * src/gdcmDocument.cxx: bug fix.
1516 2004-06-22 Jean-Pierre Roux
1517 FIX : gdcmDocument.cxx
1518 - Now we do recognize the JpegLossLess format (there was a misstyping in
1519 code 'beautyfication' :-(
1520 - Now we automaticaticaly load the Luts, if any
1522 2004-06-22 Jean-Pierre Roux
1523 In order : to write Sequences, whatever their imbrication level,
1524 : to allow user to create his own Sequences
1525 a lot of modif where necessary (adding, moving, or virtualising methods)
1527 WARNING : save your own sources *before* cvs up !
1530 ADD virtual void Write(FILE *fp, FileType filetype);
1533 ADD virtual void Write(FILE *fp, FileType filetype);
1534 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1537 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1538 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1539 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1540 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1541 ADD std::string GetEntryByName(TagName name);
1542 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1544 std::string vr = "unkn",
1545 std::string fourth = "unkn",
1546 std::string name = "unkn");
1547 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1548 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1549 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1550 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1551 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1552 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1553 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1554 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1557 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1558 ADD virtual std::string GetEntryByName (TagName tagName);
1559 ADD virtual std::string GetEntryVRByName (TagName tagName);
1560 REM virtual bool Write(FILE *, FileType);
1561 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1562 FILE *_fp, FileType type);
1563 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1564 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1565 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1566 REM virtual std::string GetEntryByName (std::string tagName);
1567 REM virtual std::string GetEntryVRByName (std::string tagName);
1568 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1569 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1570 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1572 std::string vr = "unkn",
1573 std::string fourth = "unkn",
1574 std::string name = "unkn");
1575 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1576 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1577 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1578 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1581 ADD virtual void Write(FILE *fp, FileType filetype);
1584 ADD virtual void Write(FILE *fp,FileType filetype);
1587 ADD virtual void Write(FILE *fp, FileType filetype);
1588 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1589 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1590 REM std::string GetEntryByName(TagName name);
1593 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1595 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1596 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1597 The default constructor invoked by the line
1598 gdcmHeader *f1 = new gdcmHeader( header );
1599 was gdcmHeader::gdcmHeader(bool) instead of the expected
1600 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1601 Hence the parsing wasn't executed... See also below.
1602 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1603 as explicit constructor didn't do the trick to fix the above problem.
1604 Could anyone explain why ?
1605 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1606 properly calls gdcmValEntry::Print() (that was weed out from
1607 code related to gdcmBinEntry).
1609 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1610 * In order to fix memory leaks:
1611 - Test/TestWriteSimple.cxx: added cleaning of free store through
1613 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1614 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1615 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1616 (through the call to ::AddDicomDirMeta()) or the destructor
1617 would crash when deleting uninitialized ::metaElems].
1618 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1619 - src/gdcmDocument.cxx:
1620 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1621 from dynamic stores.
1622 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1623 was causing memory leaks.
1624 - src/gdcmSQItem.cxx:
1625 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1626 cleanly handled with polymophism: sorry but my milage is low).
1627 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1628 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1629 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1630 This avoids SegFaulting.
1631 - src/gdcmSQItem.h: coding style.
1633 - Test/TestWriteSimple still severely sucks. The output image content
1634 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1635 damaged when displayed with vtkgdcmViewer.
1636 - on memory leaks: TestWriteSimple leaks really less (see entry
1637 of 2004-06-18 in Changelog file for the call to valgrind).
1638 - on segfaults: ctest now passes all the tests but one (no more
1640 * Erroneous leading white fix:
1641 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1642 white[s] (as opposed to from >> xxx, that removes it [them].
1643 - src/gdcmTS.cxx: ditto.
1644 - gdcmPython/testSuite.py: dirty related kludge removed.
1645 * src/*: remaining references to gdcmParser removed.
1646 * src/*[cxx|h]: added copy[way]left header.
1649 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1650 * In order to fix writing of dicom files:
1651 - Test/TestWriteSimple.cxx: a simpler example of writing.
1652 - Test/CMakeLists.txt changed accordingly.
1653 - src/gdcmDocument.cxx:
1654 -- The destructor now recursilvely removes potential sequences.
1655 -- Bug fix in ::IsJPEG2000()
1656 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1657 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1659 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1660 to only declared) and build on top of
1661 ::GetDocEntryByNumber(guint16, guint16).
1662 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1663 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1664 for usage in destructor and treatement of promotion in
1665 ::ReplaceOrCreateByNumber().
1666 - src/gdcmSQItem.cxx: destructor should better handle his job.
1667 Test/TestWriteSimple now runs (or at least it DOES something).
1668 * We can now start hutting memory links. A good starting point is:
1669 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1670 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1671 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1673 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1674 * Valgrind note: after Mathieu Malaterre teached me how to read
1675 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1677 Using gcc, you can force the STL to use malloc and to free memory as
1678 soon as possible by globally disabling memory caching.
1679 With 3.2.2 and later, you should export the environment variable
1680 GLIBCPP_FORCE_NEW before running your program.
1681 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1682 simply vanish (it is still not clear to me, whether this means that
1683 STL std::string leaks or if valgrind believes it leaks...).
1684 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1685 running bin/gdcmTests makeDicomDir):
1686 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1687 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1689 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1690 SegFaulting (I drowned in DicomDir related code when trying to
1691 understand why the list is empty...).
1692 * src/gdcmDocument.h: first BSD license header try.
1693 * Doc/License.txt added.
1695 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1696 * src/gdcmDocument.[h|cxx]:
1697 - Clean up of the Transfer related predicates. They are now all based
1698 on new method isGivenTransferSyntax, that (should) handle properly
1699 the padding problem.
1700 - general clean up, simplification, and coding style.
1701 - Specific clean up of Parse7FE0() (umproperly named actually).
1702 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1704 2004-06-14 Jean-Pierre Roux
1706 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1707 - fix the display of SQItem ordinal number
1708 - add the GetSQItemByOrdinalNumber method
1709 - remove some useless never written private methods
1711 2004-06-14 Jean-Pierre Roux
1713 - adding a constructor taking a gdcmDocEntry as an input param
1714 - ReplaceOrCreateByNumber now returns :
1715 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1716 a gdcmValEntry * if a string value is passed as a param
1718 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1719 according to the param type (no longer sets a gdcmDocEntry)
1720 - GetValEntryByNumber, GetBinEntryByNumber added
1721 - NewValEntryByNumber and NewBinEntryByNumber added
1723 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1725 - GetSQItemNumber and SetSQItemNumber added, to provide
1726 a (relative) Item identier inside a given Sequence
1727 \warning : some pb remaining around this number
1729 - AddEntry now takes the Item Number as a param
1731 - adding a constructor taking a gdcmDocEntry as an input param
1733 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1734 * Memory leak hunt with the following command:
1735 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1736 --show-reachable=yes gdcmTests PrintDocument
1737 It looks like many (all?) leaks are due to the STL (or a bad usage
1738 of the STL. The lines producing the leaks now have a comment with
1739 a "MEMORY LEAK" tag: you can retrieve them with
1740 grep "MEMORY LEAK" src/*
1741 Here are two typical examples which I can't help fixing:
1746 char * test = "babo";
1747 name = test; //// <--- valgrind detects 960 bytes lost in
1748 //// call to std::string::operator=(char const*)
1749 name.clear(); //// Doesn't help !
1757 std::cout << "Type a bunch of characters followed by RETURN: ";
1758 getline(std::cin, line); //// <--- valgrind dectects a loss
1759 //// of 1320 bytes in call to
1760 /// std::basic_istream<>& std::getline<>
1766 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1767 * src/gdcmHeader.[cxx|h]:
1768 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1769 and related, moved away to gdcmDocument.
1770 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1771 the corresponding protected accessors of inherited class
1772 gdcmDocument, removed ! As a consequence gdcmFile had to be
1773 declared friend of class gdcmDocument (see below).
1774 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1775 - Clean up of undefined or unused methods.
1776 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1777 account the changes to gdcmHeader.h).
1778 * src/gdcmDocument.h:
1779 - gdcmFile is now a friend class (in order to take into account the
1780 changes to gdcmHeader.h).
1781 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1782 (see changes to gdcmHeader.h).
1783 - Accessors (reading on the form GetEntry*) are now public.
1784 - Clean up of undefined or unused methods.
1785 * src/gdcmDocument.cxx:
1786 - adaptation to changes to gdcmDocument.h
1787 - ::OpenFile now writes a verbose message when file cannot be opened.
1788 - some std::string properly set to VRKey
1789 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1790 references to gdcmDocument.
1791 * Test/TestFindTags.cxx: changed accordingly to above changes.
1792 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1793 cvs repository gdcmData.
1795 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1796 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1797 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1798 conflicts with gdcmValEntry::voidArea.
1799 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1800 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1801 Value representation between StringRepresentable and BinaryRepresentable.
1802 * src/gdcmDocument.cxx:
1803 - method ParseDES: proper indentation restored and usage of
1804 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1805 - method LoadDocEntry: the fingerprint left in the SetValue() of
1806 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1807 removed. Reverting to previous code segment with the proper
1808 dynamic_cast< gdcmValEntry* >.
1809 Note: this was (partially) breaking the python test suite
1810 (gdcmPython/testSuite.py) that made usage of the above
1811 fingerprint to check presence of "Pixel Data".
1812 * src/gdcmDocEntry.h: coding style.
1813 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1814 now taken into account.
1815 * gdcmPython/gdcm.i: adaptation to the new internal representation
1816 of gdcm (exit gdcmParser, hello gdcmDocument).
1817 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1819 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1820 anymore, but instead prints the loaded Python dictionary.
1821 * .... alas, the python testSuite is still broken.
1823 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1824 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1826 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1827 * src/gdcmUtil.h : export methods
1829 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1830 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1832 * Initial addition of automatic python testing
1833 * Initial addition of automatic image comparison
1835 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1836 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1837 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1839 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1840 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1841 * Test/ShowDicom.cxx : bug fix for msvc compilation
1842 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1844 2004-05-04 Jean-Pierre Roux
1845 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1846 new concepts (and new classes) :
1847 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1848 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1849 - Sequence Doc Entries (gdcmSeqEntries)
1850 a Sequence is composed of Items.
1851 Each item is a set of Doc Entries (this is recursive)
1852 The non uniqueness of the 'Dicom tag' is due to this recursivity
1853 (never taken into account)
1854 Our unability to add a new 'entry' in the header
1855 at the proper location (neither in the H-Table (map or multimap),
1856 nor in the Chained List is also due to this recursivity.
1857 Don't try, right now, to use/modify/compile these new sources :
1858 nothing is finished.
1859 We just commit all the stuff, 'as is', in order not to loose it.
1861 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1862 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1864 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1865 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1866 file prefix (SetFilePrefix)
1868 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1869 * Add a new test: ShowDicom, for now this is just the c++ version of
1870 checkRead.sh, later it will be able to compare the image read against a
1872 * Replace the DEBUG on the stack with a global entry in cmake interface:
1873 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1875 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1876 * Add an example subdir, with a real example on how to read + write a
1879 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1880 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1881 * Doc/CMakeLists.txt: the main page is now properly differentiated
1882 between the developper and user version.
1883 * Doc/doxygen.config.in: dropped search related obsolete flags
1884 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1886 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1887 * DEVELOPPER: added some helpfull comments for compile/test/install
1890 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1891 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1892 src directory, now generated in the build dir.
1893 2. Tests as mentionned smarter
1895 4. Add a new method in gdcmDict that return the PubDict by name
1896 this is interesting for 3rd party lib like ITK,
1897 where we could set the institution name / patient name...
1899 * ENH: 1. Now the test suite is working for real
1900 2. All binaries are now output in the gdcm-bin directory
1901 (this was not true before)
1903 2004-04-28 Jean-Pierre Roux
1904 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1905 SeQuence indented printing of Dicom Header.
1906 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1907 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1908 Computation of SQDepthLevel is now part of gdcmHeader constructor
1909 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1910 tree-like structure of a Dicom Header.
1911 * FIX Test code cleaning
1913 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1914 * ENH: Adding automatic testing
1915 1. Need a DartConfig.cmake to submit to public
1916 2. Add a test driver gdcmTest.cxx
1917 3. gdcmTestMain, an helper for the main test driver gdcmTest
1918 4. Files in Test don't have a main anymore, this becomes interesting
1919 when we add more and more tests, thus dsw don't have to load
1921 * ENH: Adding a GDCM_DATA_ROOT for testing
1922 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1923 one file instead of seven + some small cleanup
1925 2004-04-22 Jean-Pierre Roux
1926 * ENH Minor changes to the Print() methods.
1927 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1928 Header printing. Example given with :
1929 > PrintHeader fileName 2 new
1930 (SQ based tree-like structure still to be done for the Header ...)
1932 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1933 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1934 1. I have added some unsigned where needed
1935 2. Some function parameter not used -> (void)
1936 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1937 4. g++ don't like character '\' in comment
1938 5. #define jpeg_create_decompress jCreaDecompress
1939 this really need to be fixed
1940 6. virtualize destructor of gdcmObject ... leakage
1941 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1942 this also really need to be fixed
1943 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1944 remove compression file
1945 (as we only do decompression, right ?)
1946 * ENH: Change malloc/calloc/free with c++ equivalent
1948 2004-04-21 Jean-Pierre Roux
1949 * FIX gdcmHeaderHelper::GetXSpacing
1950 when a single value is found (bug ?), xpacing is now
1951 defaulted to yspacing
1953 2004-04-19 Jean-Pierre Roux
1954 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1955 * ENH add parameters :
1956 bool exception_on_error = false,
1957 bool enable_sequences = false,
1958 bool ignore_shadow = false
1959 to the gdcmFile constructors to be full gdcmParser compliant
1960 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1961 to allow reading of PAPYRUS 3.0 files
1963 2004-04-06 Jean-Pierre Roux
1964 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1966 2004-04-02 Jean-Pierre Roux
1967 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1968 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1969 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1971 2004-03-30 Jean-Pierre Roux
1972 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1973 for ACR file, written out as DICOM files (hope so...)
1975 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1976 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1977 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1978 moved to base class gdcmParser and only the specialisation is kept
1980 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1981 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1982 already does the job.
1983 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1984 (to be consistent with gdcmParser::WriteEntries).
1986 2004-03-30 Benoit Regrain
1987 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1988 upate of the object's instance. It's passed to 2 in the unfavorable
1989 case : one in the ExecuteInformation, one in the ExecuteData
1991 2004-03-29 Jean-Pierre Roux
1992 * ENH : Check on file type to be written moved
1993 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1994 * FIX : gdcmObject::ResetBoundaries now stops properly
1995 when end-of-list is reached
1996 : gdcmVersion modified (as Benoit Regrain asked)
1998 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1999 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2000 * src/gdcmUtil.cxx: added forgotten iostream include.
2001 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2002 equivalent to ExplicitVR in existing code).
2004 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2005 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2006 now contains all the gdcmGlobal related code.
2007 * minor coding style and doxygenation changes.
2009 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2010 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2011 now contains all the Debug related code.
2012 * minor clean-up of includes in src/*.cxx
2013 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2014 CreateCleanString) removed.
2015 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2016 * Doc/DoxyMainPageUser.txt added.
2017 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2018 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2019 src/gdcmDirList.cxx)
2021 2004-03-24 Jean-Pierre Roux
2022 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2024 2004-03-23 Jean-Pierre Roux
2025 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2026 big endian made volumes
2027 * ENH Now gdcmParser constructor and destructor are protected to forbid
2028 end user to instanciate class gdcmParser
2029 (only gdcmHeader and gdcmDicomDir are meaningfull)
2031 2004-03-22 Benoit Regrain
2032 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2033 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2034 gdcmSerie to gdcmDicomDirSerie
2036 2004-03-19 Jean-Pierre Roux
2037 * ENH Now the tree-like structure describing a DICOMDIR comming from
2038 an already existing DICOMDIR file is consistent with
2039 the home-made tree-like structure build ex-nihilo
2040 or build from the files held (recursively) in a Directory
2041 functions gdcmDicomDir::CheckBoundaries()
2042 gdcmObject::SetBoundaries() added
2044 2004-03-17 Jean-Pierre Roux
2045 * REM (Eric Boix bug) : removal of meaningless
2046 gdcmDicomDirImage::NewImage function.
2047 * FIX now file names and directory name are written properly in the
2049 * FIX now gdcmDicomDir constructor may be call without any trick
2052 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2053 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2054 of gdcmDicomDirImage::NewImage as empty function.
2056 2004-02-28 Jean-Pierre Roux
2057 * ENH add gdcmDicomDir:NewPatient
2058 add gdcmDicomDirPatient:NewStudy
2059 add gdcmDicomDirStudy:NewSerie
2060 add gdcmDicomDirSerie:NewImage
2061 to allow making gdcDicomDir object.
2062 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2063 (as opposite to the gdcmHeader chained list)
2065 2004-02-11 Benoit Regrain
2066 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2067 when using from python
2069 2004-02-10 Benoit Regrain
2070 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2071 * FIX : in gdcmDicomDir when the directory is empty
2072 * ENH : add callback and methods to get the progression of dicomDir
2075 2004-02-06 Jean-Pierre Roux
2076 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2077 - GDCM_META added to gdcmDicomDirType
2078 - class gdcmMeta created
2079 * ENH : - A brief summary is now displayed at the beginning of
2080 'testDicomDir' to help disaster magnitude estimation
2081 * REM : Now useless Test/explDICOMDIR.cxx
2083 2004-02-05 Benoit Regrain
2084 * ENH : add methods in gdcmObject to get the hash table or the list of
2086 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2087 * FIX : wrapping python for TagHeaderEntryHT
2089 2004-02-04 Benoit Regrain
2090 * FIX : even length for some strings when writting the dicom dir
2091 * FIX : sort the images in the dicom dir
2092 * FIX : Bug fix for python use of dicom dir
2093 * ADD : a python demo
2095 2004-02-04 Jean-Pierre Roux
2096 * FIX : Final solution (?) for icone embedded images
2097 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2098 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2099 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2100 gdcmData/gdcm-MR-SIEMENS-16.acr1
2101 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2102 to make full checking easier
2104 2004-02-04 Benoit Regrain
2105 * FIX : WriteEntries : coding style & logic in parameters
2106 * FIX : Set the elements to create the DicomDir in a dictionary file
2108 2004-02-03 Benoit Regrain
2109 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2110 * gdcmDicomDir : add the load of directory
2111 * Bug fix and print add-on
2113 2004-02-03 Jean-Pierre Roux
2114 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2115 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2116 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2117 * FIX gdcmParser.cxx : 'group length' elements are now considered
2118 as integers, even for shadow groups, when file is Implicit VR
2120 2004-02-02 Jean-Pierre Roux
2121 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2123 of the last synonym :-(
2124 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2126 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2127 * FIX taking into account the possible 7fe0,0010 multiplicity
2128 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2129 to allow removal of references to 7fe0,0010, to deal with
2130 ACR-NEMA images, when 0028,0200 is meaningfull
2132 2004-01-31 Jean-Pierre Roux
2133 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2134 no longer writes 'Un' on disk
2135 * FIX SQ elements with actual length are now dealt with corectly
2136 * FIX gdcmFile::WriteBase make the difference, for color images, between
2137 the length (for Palette expanded images)
2138 and Raw Length (non expanded image + Palette)
2139 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2140 (that broke Write). Replaced by UL.
2141 Aware user will reload the field if he
2142 thinks it's necesssary
2144 2004-01-30 Jean-Pierre Roux
2145 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2146 when 'dirty Acr' is found, to be compliant with the new
2147 IsReadable() methods.
2149 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2150 (no DOUBLE images in kosher DICOM,
2151 but so usefull for people that miss them ;-)
2153 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2154 DICOMDIR related utilities (not checked as Windoze compliant)
2156 2004-01-28 Jean-Pierre Roux
2157 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2159 2004-01-27 Jean-Pierre Roux
2160 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2161 to allow skipping the shadow elements, to save memory space.
2162 The TRUE value for this param has to be used
2163 with a FALSE value for the 'enable_sequence' param.
2164 ('public elements' may be embedded in 'shadow Sequences')
2165 * gdcmHeader methods now deal with 'embedded icones images' in the header
2166 (even when an 'icone image sequence' is announced by the
2167 element (0x0088,0x0200), but there is NO icone at all ...
2169 * gdcmHeader sometimes Image Location value doesn't follow
2170 the supposed processor endianity (see gdcmData/cr172241.dcm).
2173 * gdcmHeader add the method
2174 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2175 to get *all* the Header Entries with the same tag.
2176 GetHeaderEntrySameName is probabely *useless*
2177 (no meaning : Name is *not* an identifier within the Dictionary)
2179 2004-01-26 Benoit Regrain
2180 * Bug fix in the print of hexadecimal representations. Remove long fields
2181 in the print and add a third level of print to print them
2183 2004-01-23 Benoit Regrain
2184 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2185 * Bug fix on test suite after remove the strip made on not string fields
2186 * Split the IsReadable method between gdcmParser which test that the file
2187 is dicom and gdcmHeader which test that it's an image file
2189 2004-01-22 Benoit Regrain
2190 * DicomDir : clean code, add methods, set variables in protected or private
2191 * gdcmUtil : bug fix for the clean string method
2193 2004-01-19 Benoit Regrain
2194 * Add the use of shadow dictionaries
2195 * bug fix and coding style
2197 2004-01-19 Benoit Regrain
2198 * src/gdcmFile.cxx : bug fix concerning the close of file
2199 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2200 * Add the update of header entries using the shadow library
2202 2004-01-19 Benoit Regrain
2203 * removal of file gdcmHeader2.cxx
2204 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2205 inheriting from gdcmParser. This split is to prepare the integration
2206 of dicom dir parsing
2207 * bug fix under python
2209 2004-01-16 Jean-Pierre Roux
2210 * REM removal of class gdcmHeaderEntrySet
2211 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2212 * ADD add file gdcmHeader2.cxx
2213 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2215 2004-01-15 Benoit Regrain
2216 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2217 entries created while parsing the header. Thus, they will be destroyed
2218 when the gdcmDictSet will be destroyed
2219 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2222 2004-01-15 Benoit Regrain
2223 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2224 made a fatal error because of the memory release at the end of program.
2225 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2226 some memory and vtk seems to have some problems with that.
2227 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2229 2004-01-14 Benoit Regrain
2230 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2231 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2232 * src/*.[h|cxx] : make changes due to class name changes
2233 * gdcmPython/demo/*.py : bug fix due to method names
2235 2004-01-13 Benoit Regrain
2236 * src/*.[h|cxx] : coding style
2237 * vtk/*.[h|cxx] : coding style
2239 2004-01-13 Benoit Regrain
2240 * gdcmPython/testSuite.py : test the readable flag of file for tests
2241 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2242 It's lied to the stl compilation by MSVC (windows, always windows...)
2243 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2245 2004-01-12 Benoit Regrain
2246 * src/*.h : add comments
2247 * src/gdcmDictSet.h : set the method BuildDictPath in public
2248 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2249 directly setted in the source code
2250 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2253 2004-01-09 Benoit Regrain
2254 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2255 * setup.py : use a reference to gdcmVERSION
2257 2004-01-07 Benoit Regrain
2258 * Modification to compile with the distutils.
2261 2003-12-10 Benoit Regrain
2262 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2263 can use a gdcmHeaderHelper to load data
2264 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2265 made in the source code
2267 2003-12-10 Benoit Regrain
2268 * Update Windows projects and .cvsignore files
2270 2003-11-12 Jean-Pierre Roux
2271 * ENH gdcmHeader constructor has one more parameter (default value : false)
2272 that allows the user to 'go inside' the SeQuences only
2274 gdcmElValSet:Print takes it into account
2276 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2277 * ENH: Update gdcmPython/CMakeLists
2278 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2279 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2281 2003-11-10 Jean-Pierre Roux
2282 * FIX : gdcmHeader::LoadElements is now based
2283 on the ListTag listElem member,
2284 not longer on the TagElValueHT tagHt member
2285 * ENH : PrintPubElVal shows (temporarily) both results,
2286 with the tagHt member and the listElem member.
2287 (it's easier to 'see' the problems when using Printheader)
2289 * FIX : old private member LgrElem is now splitted into
2290 ReadLength : Length actually found on disk (updated only
2291 if bug fixing is necessary), for internal
2293 UsableLength : Updated by FixFoundLength, to fix a bug
2294 or to allow Parser going on.
2295 Will allow to re-write a kosher header when a SeQuence
2296 with a length (not 0000) is found
2297 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2298 because gdcmElValSet::Add does not update ListElem
2301 2003-11-07 Jean-Pierre Roux
2302 * FIX misstyping in Transfert Syntax name table
2303 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2304 when they have an actual length (not 0000 nor FFFFF)
2305 (Nobody should care of it, but DICOMDIR explorers)
2307 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2308 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2310 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2311 * ENH: vtkGdcmReader now supports LUT !
2312 (vtkgdcmViewer for now is not able to use them though)
2314 2003-11-05 Jean-Pierre Roux
2315 * in testSuite.py : new files names for checking the package
2316 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2317 that returns the pixel area size to the *aware* (vtk) user
2318 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2320 2003-11-05 Benoit Regrain
2321 * in testSuite.py : Modify the rules for checking the paths
2322 : Explicit error messages
2323 * in __init__.py : Related modif
2325 2003-11-03 Jean-Pierre Roux
2326 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2327 to be used by aware (vtk) users that want to manage
2328 LUT (and no to turn the PALETTE image into an RGB pixels one)
2329 * GetPixelType now returns 8U for 24 Bits images
2330 (vtkGdcmReader compliant)
2332 2003-10-31 Jean-Pierre Roux
2333 * Removal of *all* gdcmData images and add them again
2334 in order to loose the 'history' of un-anonymised images
2336 2003-10-31 Jean-Pierre Roux
2337 * RMV : removal of useless jBitsInJsample.h
2338 for both 8 and 12 Bits JPEG Lossy Libraries
2340 2003-10-31 Jean-Pierre Roux
2341 * ENH : Add the functions gdcmFile::GetImageDataRaw
2342 gdcmFile::GetImageDataIntoVectorRaw
2343 that act as GetImageData and GetImageDataIntoVector
2344 except the making of an RGB Plane from Gray Plane + LUT
2345 Intended to aware (vtk) users who know how to manage
2348 GetLUTRGBA return a R,G,B,A LUT if any
2349 lgrTotaleRaw gives the 'Raw' length
2350 GetImageDataRaw returns the gray Plane
2351 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2352 (They stay Grey, just like with other Dicom viewers :-(
2354 2003-10-30 Jean-Pierre Roux
2355 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2357 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2358 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2359 being coherents dicom files.
2361 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2362 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2364 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2365 * ENH: Two steps is necessary to please VC++ compiler...
2366 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2367 * ENH: Add include dir to medcon lib
2368 * FIX: only one function is being exported for now !
2369 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2371 2003-10-29 Jean-Pierre Roux
2372 * adding gdcmHeader::GetLUTRGBA
2373 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2374 --> Mathieu, the modif u're waiting for is not yet committed
2375 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2377 2003-10-27 Jean-Pierre Roux
2378 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2379 00191113.dcm DermaColorLossLess.dcm
2380 MxTwinLossLess.dcm RadBWLossLess.dcm
2381 * ENH: For version prior to vtkImageViewer2 -r 1.19
2382 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2384 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2385 * Removal of ido stuff in CMakeLists.txt
2387 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2388 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2389 * FIX: remove a call to ->Modified ... see comments
2390 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2392 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2393 * FIX: Problem with path for libvtkgdcmPython
2394 * ENH: Try adding a search script for python site-package
2395 * RMV: Remove some file from medcon lib that are not necessary
2396 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2397 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2398 * FIX: More pragma disable fro VC++,
2399 I don't think I break something as it is also disable in VTK/ITK.
2400 But it fasten debug compilation time.
2402 2003-10-23 Jean-Pierre Roux
2403 * gdcm now deals with 16 Bits Run Length Encoded images
2404 (they are compressed as 2 planes images,
2405 one for the high Bytes, the other for low Bytes)
2407 2003-10-22 Jean-Pierre Roux
2408 * Now CheckRead takes into account :
2409 - the bugged 'Leonardo' Siemens images
2410 - the XA images, sent thru the burning VPRO station
2411 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2414 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2415 * FIX: When copying a Makefile.am to CMakeLists.txt
2416 one should remove the '\'
2418 2003-10-22 Jean-Pierre Roux
2419 * in gdcmData adding a bugged 'Leonardo' Siemens image
2420 (wrong lengths in header)
2421 OK with gdcm, KO with the other viewers :-)
2422 * add a GE dlx XA image, thru the VEPRO burning station
2425 2003-10-21 Jean-Pierre Roux
2426 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2427 for a brutal checking of vtkgdcmViewer compliance
2429 2003-10-21 Jean-Pierre Roux
2430 * add the files for 'xmedcon' Jpeg Lossless library
2431 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2433 2003-10-21 Jean-Pierre Roux
2434 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2436 2003-10-21 Jean-Pierre Roux
2437 * garbage Siemens 'Leonardo' images dealt with
2438 (the patch is easy to remove)
2439 * cosmetic changes to avoid warnings
2441 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2442 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2443 no need to press 'r' now.
2445 2003-10-20 Jean-Pierre Roux
2446 * upgrade of checkRead.sh checkWrite.sh according
2447 to new Jpeg Lossless decompressor
2448 * add US.3405.1.dcm, a genuine RGB medical file ...
2449 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2450 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2452 2003-10-15 Jean-Pierre Roux
2453 * general anonymisation in gdcmData
2454 * adding the 'color files' from
2455 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2456 * adding some well knowed bugged-header images
2457 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2458 waiting for their inclusion in Python testsuite
2460 2003-10-15 Jean-Pierre Roux
2461 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2462 no longer seg faults when file is not found
2464 2003-10-14 Jean-Pierre Roux
2465 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2468 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2469 * TODO: *.in file to genereate a UseGDCM later
2471 2003-10-14 Jean-Pierre Roux
2472 * Some supposed-to-be Dicom Images have no preamble.
2473 OpenFile takes it into account
2474 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2475 * Missing elements added in dicomV3.dic
2476 (just to be affraid : have a look at
2477 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2478 and do it again next year ;->
2480 2003-10-13 Jean-Pierre Roux
2481 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2482 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2483 But there are NOT. It's fixed !
2485 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2486 * FIX: "jpeglib.h" was not found on VC++
2487 * FIX: vtkgdcm was not being installed
2489 2003-10-10 Jean-Pierre Roux
2490 * ENH : OpenFile closes the file if it *really* doesn't look like
2491 an ACR-NEMA / DICOM one.
2492 * FIX : testWrite no longer writes an empty file if the source file
2493 is not gdcm Readable
2494 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2497 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2498 * FIX: CMake generate now documentation
2499 * ENH: out of source doc build !
2500 * ENH: Generate both user and dev documentation
2501 * ENH: Should work on windows too
2502 * ENH: Only one doxygen config.in file is needed
2503 * FIX: make install should be ok now on ùnix plateform
2504 * FIX: PATH to dictionary was wrong (missing /)
2505 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2507 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2508 * vtkGdcmReader is now able to read rgb dicom file.
2509 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2510 * added a gdcmViewer to vtk test, use mouse to control
2511 window level & window width
2513 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2514 * CMake-ification of gdcm, we have now two build system
2515 * FIX: on cygwin Wsock32 doesn't exist
2516 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2518 2003-10-06 Emanuel Ollart
2519 * FIX : compilation process wad broken.
2520 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2522 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2523 * change gdcmViewer -> vtkgdcmViewer
2524 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2526 2003-10-06 Jean-Pierre Roux
2527 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2528 ( e.g : well known GE images with a wrong elem length,
2529 : Philips MRI Images with a wrong Huffman table)
2530 * still to be done : allow the reading of bugged LEONARDO Siemens images
2532 2003-10-03 Jean-Pierre Roux
2533 * Odd length strings are padded with '\0' (not with spaces,
2534 to remain compliant with already defined strings,
2535 like Transfert Syntax UID and others)
2537 2003-10-03 Jean-Pierre Roux
2538 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2539 to allow displaying RGB images (not only by affim ;-)
2541 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2542 * vtkGdcmReader is now able to read rgb dicom file.
2543 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2545 2003-10-03 Jean-Pierre Roux
2546 * A few nasty patches to allow the reading of a lot of nasty images
2547 ( e.g : well known GE images with a wrong elem length,
2548 : Philips MRI Images with a wrong Huffman table)
2549 * still to be done : allow the reading of bugged LEONARDO Siemens images
2551 2003-10-03 Jean-Pierre Roux
2552 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2554 2003-10-03 Jean-Pierre Roux
2555 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2556 to allow displaying RGB images (not only by affim ;-)
2558 2003-10-03 Jean-Pierre Roux
2559 * gdcmFile::GetImageDataIntoVector now
2560 - deals with MultiFrames MultiFragments Run Length Encoded files
2561 - deals with YcBcR (YBR_FULL) files
2562 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2563 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2565 (no sample found :-(
2567 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2568 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2569 Two reasons: - clear things
2570 - third parties acces gdcm through header files, so won't
2571 suffer anymore VC++ complains
2573 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2574 * add argv[1] in testvtkGdcmReader.cxx
2577 2003-09-24 Jean-Pierre Roux
2578 * The lines are now eigthy characters long.for
2579 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2581 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2582 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2583 char* to std::string. Thus, the use of strdup becomes useless. (see
2584 previous commis of Malaterre)
2585 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2586 before the last Malaterre's commit.
2588 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2589 * This commit should fix the Debug building under VC++, the problem
2590 was mainly a mixture of debug and release lib being loaded at startup.
2591 * I also remove a depency to a specific C function: strdup. Because I had
2592 to force the link to msvcrtd (whereas strdup is in libc).
2594 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2595 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2596 located in the gdcmCommon.h file. All use of reference of tha has been
2597 changed to now use the variable GDCM_UNFOUND.
2599 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2601 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2602 Dicom dictionary. The test suite can now be run again. Note:
2603 I'm note very happy with the " (RET)" changes. I believe this
2604 RETAINED comment should be dropped when parsing the dictionary.
2605 - PACKAGER corrected
2607 - AUTHORS updated and now in alphabetical order
2608 * Makefile.am now exports gdcm.dsw for Windoze users.
2610 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2611 * cygwin complains about missing std:: in subdir Test/
2613 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2614 * remove some methods that are now in gdcmHeaderHelper
2616 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2617 * vtkGdcmReader set spacing and origin correctly
2619 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2620 * Fix a few delete/delete[] mismatch
2622 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2623 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2624 interpretation to data given by gdcmHeader. For instance there are
2625 heuristics to get informations (look at different places).
2626 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2627 sorting DICOM images based on different strategies.
2628 * modified Makefiles accordingly.
2630 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2631 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2632 when building in debug mode
2633 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2634 src/win32/gdcmdll.dsp
2635 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2637 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2638 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2641 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2642 * src/win32/libgdcmjpeg12.dsp was not dos format
2643 * src/win32/libgdcmjpeg12.dsp :
2644 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2645 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2647 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2648 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2650 * src/gdcmFile.cxx : bug fix in affectation type
2651 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2652 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2653 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2654 symbols... future problem ?
2656 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2657 * src/win32/libgdcmijpeg12.dsp was missing
2658 * modified gdcm.dsw accordingly
2660 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2661 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2663 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2664 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2665 commit of JPR (before his hollidays to facilitate our work).
2666 * setup.py : bug fix in code. Modifications made while the last commit
2667 of JPR. The code hasn't been tested before the commit... it's so
2668 useless to make that (for best programmer that is JPR) !!!
2670 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2671 * tagged the current version as Version0_3 (i.e. version 0.3)
2673 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2674 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2675 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2676 * *.dsp : modifications to use new libgdcmijpeg8 library
2677 * setup.py : bug fix on VTKPATH variable
2678 * PACKAGER : adding all concerning windows
2680 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2681 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2683 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2684 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2685 test suite reported error.
2686 * PACKAGER file added (describes what a packager must do when
2687 packaging a new release).
2688 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2689 * configure.in: upgraded version number to 0.3.0
2690 * fixing build of rpm (through rpm -ta):
2691 - Doc/Makefile.am exports proper doxygen files
2692 - src/jpeg/libijg8/Makefile.am exports the include files.
2694 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2695 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2696 * src/gdcmHeader.h : formatting code
2698 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2699 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2700 We were obtaining error message from vtk. Now, creation of file list
2701 is made in an internal list to prevent this problem.
2702 Bug fix when output is empty.
2703 Bug fix in update of progress value. Previous commit for this was a bad
2705 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2707 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2708 * src/gdcmHeader.h : added method to get the file name
2709 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2710 files. Added method to remove all files on the input
2711 Added FIXME comment concerning the bad parsing of header made by
2712 ExecuteInformation method (in ExecuteData method)
2714 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2715 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2716 when using make instal.
2717 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2718 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2720 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2721 * setup.py : adding include dir of jpeg lib to compile all sources
2722 * */Win32/*.dsp : JPR fix for windows compilation
2724 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2725 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2727 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2728 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2730 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2731 * setup.py is again effective on un*x (takes into account the
2732 addon of the jpeg library)
2733 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2734 * Doc/Doxy* updated (includes above enhancements)
2735 * INSTALL now points to web documentation
2737 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2738 * src/gdcmHeader.h doesn't make unnecessary reference to
2740 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2742 * src/gdcm*.[cxx|h] :
2743 - to allow compilation with gcc 3.x
2744 -- clean up of STL usage (added explicit usage of std::)
2745 -- small fixes on exceptions.
2746 Note: linking not tested !
2747 - clean of doxygen comments to avoid warnings at documentation
2749 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2750 dependent convertion).
2752 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2753 * Clean up of previous JPR garbage commit (not even commented in the
2755 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2756 - moved all jpeg related files from src to src/jpeg/libijg8, with
2757 addition/modification of Makefile.am and configure.in.
2758 - the testSuite is still brain damage (not guilty).
2760 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2761 * WrapVTK.py : modifications to get correctly vtk source files to
2763 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2764 (FileName -> Filename)
2766 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2767 * vtk/vtkGdcmReader.[cxx/h]:
2768 - UpdateProgress method should now be effective
2769 - removed the limitation on having only images loaded (as opposed
2771 - when building a stack of images/volume, a lesser number of
2772 gdcmHeader and gdcmFile instances should be used (hopefully
2773 accelerating things).
2774 - when building a stack of images/volumes, files which are not
2775 loadable (wrong path-filename, wrong permissions on existing file,
2776 or file not parsable by gdcm) are replaced with a black image
2777 in the stack (for the caller to notice the problem).
2779 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2780 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2782 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2783 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2784 between standard library (std) and vtk library (problems are found
2785 under Windows... thanks Windows !)
2787 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2788 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2790 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2792 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2793 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2795 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2796 * When compiling with distutils (see setup.py) the C++ compiler is
2797 called with different flags than the default ones (with automake).
2798 In order to fix all those warning, I compiled gdcm with the command
2799 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2800 and went for warning fixes:
2801 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2802 up from unused variables.
2803 - vtk/vtkGdcmReader.cxx: potential bug fix.
2804 * src/gdcmHeader.h: Doxygen warning cleanup
2806 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2807 * gdcmPython/gdcm.i:
2808 - typemaps correction to take into account the systematic replacement
2809 of "using namespace std" with std:: prefix e.g. std::list,
2810 std::string... (cf changes of 2003-05-21).
2811 - gdcmGlob global variable of type gdcmGlobal (defined in
2812 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2813 exported to Python a as cvar.
2814 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2815 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2816 gdcmDictSet.GetPubDictTagNames() and
2817 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2818 C++ static methods).
2819 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2820 with the above changes.
2822 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2823 * setup.py, manifest.in : bug fix under linux
2825 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2826 * Modification of setup.py to compile vtk part too. Then, we have 2
2827 wrappers which must work with same distutils. For that, we have a
2828 generic distutils in distusiltsWrapping.py ; with :
2829 - build_extWrap class to wrap generically all extensions,
2830 - ExtensionWrap base class for all wrapping extension that contains
2832 - Wrapper interface which wrap sources
2833 + In WrapSwig.py we have extension and wrapper for Swig
2834 + In WrapVTK.py we have extension and wrapper for VTK
2835 * MANIFEST.in : modifications to consider vtk directory and new python
2836 files for compilation
2838 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2839 * Added python wrappers of vtkGdcmReader vtk class (see the
2840 source in vtk/vtkGdcmReader.cxx) :
2841 - vtk/Makefile.am now builds a library
2842 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2843 python library (as opposed to _gdcm.so wich are the python
2844 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2845 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2847 - configure.in has an additional flag --enable-vtk that needs
2848 to be set to enable compilation of vtk related code, that is:
2849 + vtk/vtkGdcmReader.so and
2850 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2851 + gdcmPython/vtkgdcmPython.so (see above)
2852 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2853 be read when compressed or when HighBit + 1 != BitsStored),
2854 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2855 the usage of the python wrapper of vtkGdcmReader vtk class.
2856 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2857 * src/*.[h] all occurences of stl classes are now prefixed with
2858 std::, and all occurences of "using namespace std;" where removed.
2859 This is to avoid pollution of global namespace in included files.
2860 Apparently vtk does not avoid this pitfall: when using both
2861 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2862 collision of various stl members (principally cout...).
2863 * gdcmPython/testSuite.py now cleanly removes temprory generated
2865 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2866 comply with above changes)
2868 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2869 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2870 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2871 vtk data structure (an image Flip was required).
2872 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2873 * cosmetic changes in documentation.
2875 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2876 * src/gdcmHeader.cxx: the constructor no longer exits when an
2877 unexisting file is given as argument.
2878 * The subdirectory Data (containing all the images used for the
2879 test suite) is not part of this repository anymore. A new module
2880 containing those images is now available at
2881 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2882 with the name gdcmData.
2883 All the python scripts (including the package initialisation file
2884 gdcmPython/__init__.py) were adapated to take this change into
2885 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2887 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2888 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2889 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2890 demo of the usage of this class.
2891 Compilation of this vtk part is only done when using the --enable-vtk
2892 at configure (or autogen.sh) stage.
2894 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2895 * More memory link related corrections and documentation fixes.
2897 - maximum info is obtained with a command of the form:
2898 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2899 --show-reachable=yes PrintHeader
2900 - the remaining reachable blocks seem to come from the STL
2901 allocation scheme through the usage of map and list. It looks
2902 like this memory cannot be freed but it is not a memory leak
2903 (in fact further invocation to the STL would recollect the
2904 unused memory allthough it cannot explicitely be freed).
2905 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2906 of displaying an image parsed with gdcm and displayed with VTK.
2907 Note: some images don't seem to work e.g.
2908 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2909 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2910 Allthough this weakens the semantics, it is a ditch attempt to
2911 make gdcm more thread friendly.
2913 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2914 * Memory link hunt (by using valgrind through the command
2915 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2916 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2917 gdcmHeader::_dicom_vr.
2918 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2919 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2921 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2923 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2924 * src/Makefile.am now exports all the necessary include files at
2928 * UpdateGroupLength replaced by new one
2931 * UpdateGroupLength re-written using H-Table
2932 (named UpdateGroupLengthNew untill checks are over)
2934 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2935 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2936 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2938 - gdcmHeader::GetPubElValSet removed.
2939 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2940 UpdateGroupLength, WriteElements, Write.
2941 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2942 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2943 carried the same semantics.
2944 - src/gdcmHeaderIdo.cxx changed accordingly.
2945 - gdcmFile::WriteBase now regroups all the codes from previous
2946 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2947 - enum FileType moved to gdcmCommon.h
2948 * src/gdcmHeader.cxx AddDefault trashed
2949 * gdcmGetXSize added
2950 * getimageDataSize now calls gdcmGetXSize
2951 * Test/*.cxx changed to agree with above changes
2953 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2954 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2955 (to avoid double call by end user).
2956 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2957 by end user, since gdcmHeader::gdcmHeader now handles it.
2959 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2960 * gdcm/Doc many doxygen changes:
2961 - Doxyfile now has two different versions, DoxyfileUsers that generates
2962 the html.users end users oriented documentation and
2963 DoxyfileDeveloppers that generates the html.developper developper
2964 oriented documentation.
2965 - README changed accordingly
2966 - requirement.txt removed (old design info moved to TODO).
2967 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2968 DoxyMainPage.txt, DoxyPython.txt provide more information.
2969 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2970 be updated by simply regenerating the docs with doxygen and copying
2971 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2972 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2973 all the tests in the form "if (<map>.count() >1)" were removed.
2974 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2975 ill-formed documentation sections.
2976 * src/gdcmHeader.cxx: ditto
2978 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2979 * setup.py fixed for un*x (needed macro for stdint.h)
2980 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2981 un*ces with sh-utils test utility.
2982 * gdcmPython/demo/test.py renamed to PrintHeader.py
2983 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2984 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2985 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2986 * src/gdcm*.cxx JPR's bad inclusion fixed.
2988 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2989 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2990 * gdcmPython/demo/test.py changed accordingly.
2992 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2993 * gdcmPython/Makefile.am fixed linking against libstdc++
2994 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2995 * Swig subdir (historical tests of swig version 1.3.17++) removed
2996 * Test/testChangeEntete.cxx some lines commented out in order to make
2998 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2999 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3001 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3002 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3003 hence the user doesn't need this explicit call.
3004 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3005 i.e. LoadElements() call removed.
3006 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3007 - src/Makefile.am declares the proper flag for g++.
3008 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3009 for adding user defined new tags.
3010 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3011 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3012 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3014 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3015 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3016 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3017 src/Makefile.am : the project should properly compile and install
3018 with the autotools, included the python wrappers part.
3019 * gdcm.spec.in : added a spec file for RPM packaging.
3021 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3022 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3024 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3025 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3026 to exported to the environement (see gdcmPython/testSuite.py
3028 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3029 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3030 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3031 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3032 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3034 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3035 * gdcmPython/__init__.py doesn't crash anymore when running in
3036 in InstallMode or PreInstallMode but with an environment given
3037 value of GDCM_DICT_PATH.
3038 * src/gdcmDictSet.[cxx/h] coding style.
3040 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3041 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3042 * src/gdcm.h general comments moved to TODO, and README
3043 * src/gdcm.h should now be seen as a user commodity (including it
3044 should suffice to fully use gdcm). It is nowhere including within
3045 any of the kernel files src/*.cxx and src/*.h.
3047 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3049 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3051 * src/gdcm*.cxx only include their corresponding include file
3052 (as opposed to gdcm.h)
3053 * gdcmPython/gdcm.i changed accordingly
3054 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3055 the autogen.sh generated "make snapshot" command to work.
3056 * autogen.sh removed history related references to crea package.
3058 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3059 * distutilsSwigCPlusPlus.py work around some swig portability
3062 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3063 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3064 was done in a last ditch attempt to get setup.py _really_
3065 operationnal. The python/gdcmPython layaout add the advantage
3066 of hidding away the python related distutils specific files
3067 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3068 Alas, the src directory was out of scope (i.e. it's relative
3069 position to setup.py was ../src) which made things impossible to
3070 handle (see previous version of python/setup.py). Crossing fingers...
3072 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3073 * python/setup.py now works on Un*x. (harder than I thougth)
3074 * python/distutilsSwigCPlusPlus.py can now have include files
3075 among the list of sources.
3077 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3078 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3079 * modifications in MSVC projects
3081 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3082 * As stated by the first lines of Test/ExceptionAndPython/README, it
3083 looks like we can move back to original usage of exception within
3084 src/gdcm* and hence remove the errno stuff that was introduced
3085 as a quick and dirty fixture of this problem (added to the TODO).
3086 * Doc/Doxyfile configuration file for Doxygen and corresponding
3087 README file for usage added.
3088 * Test/testWrite.cxx added. This new test comes from a split of
3089 test.cxx that is now reverted to its original purpous i.e.
3090 testing the proper parsing of a Dicom related file.
3091 testWrite.cxx concentrates on testing the IO part of gdcm.
3092 * Test/bug1.cxx (containing a bug on WIn32) added.
3093 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3094 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3095 whose purpose is to publish the content of the TagNames of the
3096 Dicom public dictionary were not accessible without an
3097 instance of class gdcmHeader.
3098 - those methods are now static methods of gdcmDictSet and hence
3099 require no instances at all to be invocated.
3100 - within gdcmDictSet this change required to change some method
3101 to class methods (i.e. are now static) among which SetDictPath
3102 (renamed to BuildDictPath) and LoadDefaultPubDict.
3103 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3104 the above changes by calling the new method classes of gdcmDictSet.
3105 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3106 the above to be effective.
3107 * python/gdcmPython: in order to wrap properly the above changes
3108 for Python, swig version now needs to be > 1.3.17.
3109 * python/gdcmPython/Makefile fixed to adapt itself to new
3110 configure/make shema introduced by Johan Montagnat (thanks for the
3111 contribution). Alas this Makefile cannot be turned into a proper
3112 Makefile.am without some heavy changes in the configure.in
3113 (for python dectection).
3114 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3115 now avoids publishing the empty entries.
3117 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3118 * python/setup.py : bug fix concerning install under windows
3119 ExtraPath reused :-P
3120 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3122 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3123 * Dicts/dicomV3.dic : remove double spaces !!!
3124 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3125 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3128 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3129 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3130 method. Doxygenation.
3131 * src/gdcm.h clean up of JPR spurious comments.
3133 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3134 * python/distutilsSwigCPlusPlus.py now properly collects the
3135 shadow classes generated by "swig -c++" (gdcm.py in our case)
3136 when using "python setup.py install".
3137 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3138 reexports the working classes.
3139 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3140 by the classical C errno scheme. This is to prevent an obscure
3141 behavior of the python wrappers when importing wxPython.wx prior
3142 to gdcmPython (which ended up in an abort call). An illustration
3143 of this oddity can be found in the Test/ExceptionAndPython
3144 subdir (see the README file). This problem probably due to
3145 an combination of g++ and dynamic loading.
3146 * added Test/ExceptionAndPython (see above)
3148 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3149 * Changed the layout of the python part to avoid bloating main
3150 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3151 i.e. the distutils arsenal. All the python related stuff is
3152 again in a python subdir, but the package itself is now in
3154 * setup.py was cleaned up:
3155 - pythonIncludePath removed
3156 - python setup.py bdist target is now functional.
3157 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3158 collision with other packages). gdcmPython/demo/*.py changed
3161 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3162 * python subdir moved to gdcmPython (preparation of distutils packaging).
3163 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3164 distutils installer is operational.
3165 * - gdcmPython/__init__.py now properly loads the swig generated
3166 shadow classes (from gdcm.py).
3167 - gdcmPython/demo/*.py changed to import the package gdcmPython
3168 instead of gdcmPython/demo/load.py.
3169 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3171 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3172 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3173 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3174 entries within the associated public Dicom dictionary resp. the same
3175 information but sorted by the fourth field (PAT, IMG, DIR) of the
3177 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3178 are now in the "???" group.
3179 - python/gdcm.i changed accordingly,
3180 - python/demo/printGroupedPublicDict.py added, that gives an example
3181 of the above new functionalities in Python.
3183 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3184 * src/gdcm.h, gdcmHeader.cxx:
3185 - historic references to glib's g_malloc and g_free (#defined)
3186 were definitively removed.
3187 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3188 * src/gdcmElValSet.cxx:
3189 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3190 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3191 - GetElValue(string) renamed to GetElValueByName.
3192 - Added GetElementByName(string).
3193 * src/gdcmHeader.cxx: added
3194 - GetPubElValRepByNumber(guint16, guint16)
3195 - GetPubElValRepByName(string)
3196 - GetShaElValRepByNumber(guint16, guint16)
3197 - GetShaElValRepByName(string)
3198 - GetShaElValByNumber(guint16, guint16)
3199 - GetShaElValRepByName(string)
3200 - GetElValRepByNumber(guint16, guint16)
3201 - GetElValRepByName(string)
3202 - GetElValByNumber(guint16, guint16)
3203 - GetElValRepByName(string)
3204 * Doc/requirements.txt added.
3206 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3207 * Test/Makefile building now depends on the one of libgdcm.so
3208 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3209 pixel data) aware which enables finding the address (offset) of
3210 the pixel data of JPEG encoded DICOM files. This leaves only a single
3211 file in the testSuite whose pixel data address (offset) is unknown.
3212 * python/testSuite.py changed accordingly.
3214 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3215 * VC++ has some strong limitations when working with the STL, as stated
3216 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3217 "Also note that some STL containers (map, set, queue, list, deque)
3218 cannot be exported. [...]
3219 Some STL classes contain nested classes. These classes can not
3221 This is caused by a designed limitation that once a template
3222 class is instantiated, it can not be re-instantiated and
3224 Since our usage of map<> is ubiquitous in gdcm, this "designed
3225 limitation" of VC++ is a pitfall.
3226 Hence the Python wrappers of gdcm cannot be incrementally linked
3227 against the c++ dynamic library. The dirty but only workaround is
3228 to forget about incremental link of dynamic libraries and to generate
3229 the Python wrappers library with the inclusions of the underlying C++
3231 The following modifications concern this matter on Win32/VC++:
3232 - wrapping python correct with standalone wrapped dll (don't use separate
3233 dll under windows !!!!)
3234 - python21_d debug mode enabled (ask Frog how to use it :-)
3235 - NO problem with having an STL member of class for example string in C++
3236 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3237 - Python test of dcmlib in Python is ok under windows on a large set
3239 * removed glib references
3240 * typedef's inserted in gdcm.i for correct swig type management
3242 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3243 * python/demo/*.py load.py extracted from test.py. Added explore.py
3244 that only displays required tags and testAll.py that parses all
3245 the files of the testsuite without using unittest.
3246 * python/testSuite.py other additional test on new files added.
3247 * Data/* new test files added accordingly to the testSuite.
3248 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3249 the vr in the file differs from the one of the dictionary.
3251 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3252 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3253 values, but limits itself to values which are below a user specified
3254 size (by default 1024 bytes).
3255 * python/gdcm.i : elements not loaded (because their size is above the
3256 user specified treshold) are exported with their TagKey as key of the
3257 python dictionary. This enables the testsuite to make some checks
3258 on the unloaded elements (since we have their offset and size).
3259 * python/testSuite.py
3260 - now tests for the existence and proper value of the pixel data
3261 - two new examples added.
3262 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3264 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3265 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3266 aware. See the strategy comments in gdcmHeader::FindLength().
3267 * Test/test.cxx now accepts a filename as first argument.
3268 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3269 * python/testSuite.py changed to integrate test on above files.
3271 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3272 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3273 the vr was also RET.
3274 * python/testSuite.py more tests added.
3276 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3277 * python/testSuite.py unittest test suite added (uses Data)
3278 * Data/* dcm and acr files for the test suite.
3279 * glib dependance removed from un*x version. We now use ISO C99
3280 7.18 Integer types (see stdint.h)
3281 - python/Makefile, src/Makefile src/gdcm.h
3282 * src/ when an explicit vr (like dicom files) suddenly poped an
3283 implicit element we use to mark the underlying DictEntry of the
3284 concerned ElValue with "Implicit". This strategy was damageable
3285 too the public or provite dictionaries, since some of their vr
3286 would be changed. Since Header::FindLength heavily relies on the
3287 detection by Header::FindVR of falsely explicit elements, I
3288 added an extra ImplicitVr member to ElValue (boolean).
3289 The rest of the changes we the necessary adaptations.
3291 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3292 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3294 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3296 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3297 * Adaptation for porting to VC++:
3299 o forced to use std namespace (for string to be known)
3300 o all class use __declspec export style on WIN32
3301 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3302 (in stdlib.h on Win32 but in std:: for gcc)
3303 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3304 variable GDCM_DICT_PATH.
3305 * src/gdcmHeader.cxx verbose comments made discrete.
3307 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3308 * python/gdcm.i: added a typemap that converts a C++ hashing table
3309 to native Python dictionary.
3310 * python/demo/test.py:
3311 - now uses the native dictionary for exploration of gdcmHeader.
3312 - takes an optional filename argument (the file to parse).
3313 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3314 PubElVals hashing table.
3315 * Dicts/dicomV3.dic removed error prone trailing spaces.
3317 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3318 * Python wrapping process moved away from src/Makefile to
3319 newly created python/Makefile (as well as gdcm.i)
3320 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3321 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3322 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3323 from the environement variable GDCM_DICT_PATH (when existing).
3324 * src/gdcmDict::GetTag bug fix.
3326 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3327 * Straightforward temporary fixes for swig to build the python wrappers.
3328 src/Makefile now has a python working entry [by working we mean
3329 that we can import the shadow classes without errors].
3331 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3332 * hashtest.cxx removed (since already in Test)
3333 * src/gdcmlib.h renamed to src/gdcm.h
3334 * src/dcm.i renamed to src/gdcm.i
3335 * src/Makefile prepared for python wrapping
3337 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3338 * src/gdcmHeader.cxx :
3339 - Parsing of header is now separated from loading of element values
3340 (see gdcmHeader::LoadElements).
3341 - general clean up of hopefully all file access (creation of
3342 ReadInt16 and ReadInt32)
3344 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3345 * src/gdcmHeader.cxx :
3346 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3348 - SetLgrElem renamed to SetLength
3349 - GetLgrElem renamed to GetLength
3350 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3351 * src/gdcmElValSet.cxx fixed both GetElValue methods
3352 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3353 due to IdoDude was cleaned out.
3355 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3356 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3357 concentrates on finding the value representation (when it exists).
3358 RecupLgr now only finds the element value length, and it avoids
3359 returning the unecessary skL (skipped length).
3360 Also, offsetCourant was simply removed (with taille_fich) since
3361 it was redundant with the File position internals (by using
3362 ftell and fseek). This also made skL (see above in RecupLgr) usage
3364 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3365 on the libido specificities which are handled through class
3367 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3370 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3371 * Truckload of changes. Parsing of header is barely functional
3372 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3374 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3375 * src/gdcmHeader.cxx many addons of low level methods
3377 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3378 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3379 and _IdDcmSWAP_LONG.
3381 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3382 * This corresponds to all the changes decided at the meeting of
3383 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob