1 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
2 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
3 related methods, in order not to expose internal mechanisms
6 * REM methods that exposed internal mechanisms :
7 DicomDir::GetDicomDirPatients()
8 DicomDirPatient::GetDicomDirStudies()
9 DicomDirStudy::GetDicomDirSeries()
10 DicomDirSerie::GetDicomDirImages()
21 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
22 * Removed the Print/indent/default parameter mess. There is absolutely no
23 reason to have to methods, moreover with the second takeing the ostream as
24 *SECOND* parameter. This was clearly a bad hack to get things compile.
26 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
27 * Complete rewrite of the GetMacAddress code. Now the code is *much*
28 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
29 Unfortunately the main code does not work on SunOS, thus provide a specific
30 code for this platform only (and Win32 of course). Since this seems to be
31 working, change CreateUniqueUID to use GetMACAddress instead of the
32 problematic getIPAddress
34 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
35 * Unfortunately to be able to test gdcmDirList I had to break the API
36 a little. Now the class is not a std::list anymore but has a member
37 std::vector (more ITK compatible). Allow unit testing on Win32 and
40 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
41 * Update SerieHeader to take into account a Serie Instance UID to properly
44 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
45 * ENH - Comment out Mathieu's (dangerous) Super Hack
46 for dealing with BIGENDIAN processors
47 - Move equivalent stuff to BinEntry::WriteContent
48 When necessary, 16 Bits Pixels are swapped in a small buffer
49 and then written. This avoid allocating a huge buffer, in
50 PixelWriteConveror, and avoid modifying the Pixel Area.
52 Probabely, the same operation will have to be done when we want
53 to write image with Big Endian Transfert Syntax,
54 and we are working onj Little Endian Processor
56 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
59 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
60 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
62 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
64 * Test/TestDict.cxx : add a new test for the dict classes
66 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
67 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
68 file. Debug is yanked if compiled with NDEBUG
70 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * src/gdcmDictSet.h : set the default output to the os variable
72 * src/gdcmDictEntry.[h|cxx] : add the Print method
73 * gdcmPython/demo/ : add a new test
75 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
76 * merging of Test/PrintDicomDir and Test/TestDicomDir
77 * removal of now redundant Test/PrintDicomDir
78 * enhancement of Example/PrintDicomDir
80 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * Now, python test might work on systems
82 * Add the PrintDicomDir test
84 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
85 * FIX : First entry following group 0002 was lost for
86 Explicit Big Endian Transfer Syntax files
87 (group and elem not swaped)
89 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
90 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
91 Big Endian Transfer Syntax supposed the group following 0002
92 begins always by element 0000 (element 0000 is *optional*)
93 To avoid further troubles, let's be pessimistic, and use
94 Document::HandleOutOfGroup0002() method
95 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
96 (related pb not yet solved)
98 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * Bug fix for the python part use
100 * Now, PrintHeader.py pass... but outside the ctest use. shit !
102 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
105 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
106 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
107 a string and should ask the global TS dict what are the propreties of
110 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
111 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
112 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
113 to swap the Swap Code, at parsing time, when we come out of group 0002
114 and Transfer Syntax is Big Endian
115 We should be able to read now 'true DICOM" Big Endian coded images
116 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
117 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
119 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
120 * Hopefully fix the bug on MacOSX and static global initialization.
121 This is the only -minor- patch I found that both please MacOSX and VS6.
122 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
123 but this would require a lot of change. Another approach would be that Global
124 create those string and GDCM_UNFOUND becomes a pointer to a string (which
125 gdcm::Global would destroy at exit).
127 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
128 * Fix bug on MacOSX with static initialization in a multy threaded
129 environment. static const string in a header file used to be ill
130 initialized provoquing the freeze of any tests. patch should solve this
133 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
134 * According to Benoit's suggestion, and without any objection from anybody
135 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
136 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
137 - method gdcmDicomDirObject::GetEntry() renamed as
138 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
140 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
141 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
142 you debug/warning message just as c++ streams which make them very convinient
143 to use. Once this is stabilize I will change the ostringstrem to be
144 redirected to a file (ofstream).
145 * Properly support C99 extension: __FUNCTION__ which allow us to display
146 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
148 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
149 * Removal of useless and dangerous methods :
150 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
151 GetDocEntryByName, GetEntryByName, GetDictEntryByName
152 * Removal of usless methods :
153 Dict::PrintByName, Dict::GetDictEntryByName
154 * Commenting out of probabely useless methods :
155 Dict::GetDictEntryNames()
156 Dict::GetDictEntryNamesByCategory()
157 DictSet::GetPubDictEntryNames()
158 DictSet::GetPubDictEntryNamesByCategory()
159 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
160 * ENH : Use dicomTS.dic as described in 2004 version
161 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
162 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
163 Add Accessors on VM (Value Multiplicity), and VM related methods
164 * ADD : Add a list of 'Dicom Attribute types', as found in
165 http://medical.nema.org/dicom/2004/04_15PU.PDF
167 * ADD : Add dicomGroupNameAbbreviations.dic
168 should be used to write a method to replace the former
169 Dict::GetDictEntryNamesByCategory()
171 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
173 to read in the file... and only it ! Length is the efective length of the
174 data in the DocEntry structure
176 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
177 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
178 And now use a static function call instead, with a global variable. i
179 This is much closer to the VTK approach. Hopefully should be bulletproof
180 and easier to use...hopefully
182 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
183 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
185 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
188 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
190 ValEntry, BinEntry, SeqEntry creation or replace
192 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
194 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
196 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
197 when specifying the VR
198 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
199 * src/gdcmDocEntry.cxx : amelioration of print
201 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
202 * ADD : Add the method Util::IsCurrentProcessorBigEndian
203 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
204 * ADD Method Document::ComputeGroupLength
205 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
206 in order to allow further VR modification by user
207 * REM : removal of once-called method File::WriteBase
208 integration of its code in formerly one-line method File::Write
210 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
211 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
212 replace the different values "??", "Unkn", "Unknown".
213 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
214 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
215 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
216 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
218 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
219 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
221 * Set the gdcm::Base class to some Printable classes
223 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
224 * src/gdcmFile.[h|cxx] : add the Print method
225 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
226 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
227 * src/gdcmDocument.h : remove the PrintLevel informations
228 * Example/PrintFile.cxx : use the new gdcm::File::Print
230 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
232 problems when compiling with the python wrapping
234 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
235 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
236 writting in ImplicitVR
238 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
239 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
240 JPEG decompression, especially when dicom frames are split into several
241 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
242 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
244 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * src/gdcmHeader.cxx : change the initialisation of default header.
246 Now, this header is readable by gdm, e-film, DicomWorks
248 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
250 Rename Decompressed to Raw
251 * Use the API changes in gdcm::File.
252 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
255 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
257 each added entry in the header. Replace the 'Planes' field by the 'Number
260 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
261 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
262 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
264 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
265 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
266 At this time, this image isn't readable by e-film... waiting JPR help to
269 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
271 DocEntry. Now use methods of the Document !
273 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
274 * Test/ShowDicomSeq.cxx : bug fix
276 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
277 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
278 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
279 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
280 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
282 * Test/TestCopyRescaleDicom.cxx : remove unused variable
283 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
284 containing found sequences
286 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
287 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
289 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
290 Some fields in BinEntry must be copied to not seg fault when making the :
291 gdcm::File *copy = new gdcm::File( copyH );
292 and tests are now made on good variables
294 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
296 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
298 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
299 * Add vtkGdcmWriter example and test
301 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
302 * Test/TestUtil.cxx : reformat the source code
303 * vtk/vtkGdcmReader.cxx : remove and change prints
304 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
306 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
307 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
309 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
310 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
311 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
313 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
314 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
315 by an eof to prevent all bad read of the file... and in this case, the
318 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
319 * Example/Volume2Dicom.cxx : comment unused variables
320 * Test/PrintDicomDir.cxx : comment unused variables
321 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
322 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
323 method that is redondant with AddEntry.
324 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
327 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
328 * Bug fix due my last commit (compilation under Windows).
329 * Example/Volume2Dicom : bug fix in the file and reformatting source code
330 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
332 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
334 - Remove printf / sprintf
335 - include iostream AFTER gdcm so we don't get warnings
336 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
338 - Also remove tons of include from header files, hopefully this should
339 speeup the compilation time, since it was becoming a dog slow.
340 - Remove gdcm.h as it include way too many files and slow down compilation
341 (plus it is not up to date)
342 - remove 'using namespace std' this is BAD !
344 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
345 * Remove memory leaks on the DicomDir
346 * Remove some useless data in DicomDirObject
347 * Add usefull methods in SQItem, to be complient withe the ElementSet
349 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
350 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
352 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
353 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
354 future, with convertion)
355 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
356 and ImageDataSize values. Remove the method to get the PixelReadConverter
357 from the output of the class
359 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
360 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
362 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
364 and vtkErrorMacro use.
365 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
367 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
368 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
370 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
371 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
372 The string leaves only in the fonction. So when we make a .c_str(), we
373 get the pointeur on the first element, element that will be destroyed
374 immediately after thee instruction.
375 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
376 file has been opened : the test must be made on the content of the
377 pointer and not directly on the pointer !
380 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
381 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
382 the python part recompiles
384 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
385 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
386 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
387 X session is killed (for my computer... it seems to not be identic on
390 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
391 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
392 avoid problems (otherwise, the difference test between the visible image
393 and the reference is incorrect. If the reference is greater than the
394 screen resolution, it's produce errors).
395 Can be used for only one image. Can be used with a visible flag.
396 * vtk/vtkGdcmReader.cxx : remove commented codes.
397 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
398 under windows at compilation
399 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
401 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
403 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
404 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
405 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
406 tests on the image size X, Y, Z
408 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
410 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
411 between the class name and the file name
413 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
414 * src/ : fix compilation warnings for the Write method (2 different
415 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
416 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
417 variable... create a static method in gdcm::Document to access to
418 this variable content.
420 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
421 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
422 file, to be accessed by other files (like gdcmFile). Remove commented
423 code. Move the change of the header to the gdcmFile, using the
425 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
426 To be sure of that (and simplify calls), the Write of the header now
427 gets a file name and not a file pointer (std::ifstream).
428 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
429 DocEntryArchive. Remove all open of the written file
431 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
432 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
434 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
435 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
436 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
438 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
439 some corresponding methods. Write correctly the file and check before
441 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
442 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
443 is now on RGB data (as before my last commit
444 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
446 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
447 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
448 Add a print information of the type of the entry
449 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
450 It was in the gdcmFile, and all write have been regrouped
451 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
452 Write correctly all dicom files (in decompressed mode only at this time)
453 * Test/ : test on files are now made using Raw data and not color data if
455 * Example/PrintFile.cxx : add more printings
457 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
458 * Amelioration of code, remove some code copy. For the loading of
459 BinEntry (in gdcmDocument), add the test to verify if the file is already
462 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
463 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
464 remove a DocEntry in the header (push an empty DocEntry)
465 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
466 lines. Bug fix in the initialization of the PixelConvert and the
468 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
469 use in TestCopyDicom (now this test can run under windows... but fails)
470 * Test/TestCopyDicom.cxx : amelioration of the test :
471 - test the pixels written
472 - add test points to quickly find where is the error
473 - can set a file name input and output in arguments
474 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
475 amelioration of the test output
477 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
478 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
479 all replaced DocEntry's
480 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
481 Now, each needed DocEntry to modify is duplicated, modified and inserted
482 to the header using DocEntryArchive. Thus, after save, we can restore the
483 header initial state.
485 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
486 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
488 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
489 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
490 correct to copy it. The DictEntry is specified at the DocEntry creation,
491 then, it musn't change in the time.
492 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
493 header correctly. At this time, the change is only made for the first
494 level of the Document. In the future, it might consider sequences.
495 The change is made by replacing a DocEntry by an other that is created
496 outside the class. The old value is kept. When we restore the header
497 status, the added DocEntry is deleted and replaced by the old value.
498 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
499 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
500 set the write type to explicit VR, implicit VR or ACR. Add methods to set
501 the write mode to native, decompressed or RGB (but not used at this time)
503 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
504 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
505 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
507 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
509 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
511 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
512 set because already copied when copying the BinEntry's of the header
513 * Test/TestAllReadCompareDicom.cxx : remove warnings
515 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
516 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
517 Two problems appear when doing it :
518 - with the gdcmFile : when the GetImageData method is called, the pixels
519 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
520 data (pixels). And each structure destruct the data when it's
521 destructed. So we have two destructions for the same data. To solve it,
522 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
523 data or not. If it doesn't own data, then they will not destroyed by
525 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
526 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
527 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
528 create a double destruction of the same DocEntry's. So, to solve it,
529 the TagHT is simply cleared and the DicomDir* elements are destroyed.
530 * TODO : add an entry concerning memory leaks in the DicomDir
532 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
534 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
537 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
538 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
539 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
540 after it have been deleted
542 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
543 * FIX: src/* fix the doxygen warnings.
544 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
545 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
546 was erroneously defined with a size of 15 instead of 16. [many thanks
547 to Jean Michel Rouet for pointing out this bug].
549 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
550 1. Finish merging JMR patch for writting DICOM from scratch
551 2. Fix -hopefully- bug with MONOCHROME and space vs null character
552 3. Use const ref when possible
553 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
554 5. A few more comments
555 6. CreateUniqueUID can now be called without parameter"
557 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
558 * ENH: Slightly bigger patch:
559 1. Getting toward full integration of JMR patch for writting dicom from scratch
560 2. Update Test to test part of this patch: CreateUniqueUID
561 3. File was not close properly in gdcmDict
562 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
563 5. Use of const ref instead of copy (speed issue)
564 6. Remove temporary (duplicate) string in TranslateToKey
565 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
566 8. Do not repeat virtual in subclasses
567 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
569 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
570 * Apply first patch toward better string comparison when dealing with broken
571 DICOM files. Essentially the string could be padded with a space instead
572 of a null character as defined by standard
574 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
576 because never used... and in the same time, that's remove some memory leaks
578 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
579 * src/gdcmFile.cxx : now delete the PixelConvert instance.
580 * In examples and tests : change the type of image data variables from void*
581 to uint8_t*. Remmove all delete on image data variables
583 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
584 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
585 Verify the file pointer value before open the file, and if it's not null,
586 a verbose message is generated.
587 Close correctly the file when the file isn't considered dicom-like. The
588 correctly close is a call to CloseFile.
589 When closing the file pointer, test if its not null to close the file.
590 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
591 file. For an uncompressed image, the copied data correspond in the least
592 case to the image size (calculated) or the image size specified in the
593 header. A verbose is generated if these two size mismatch
595 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
596 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
597 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
598 break under windows (with msvc6 compilation).
600 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
602 compiling with MSVC6)
604 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
605 * Bugs fix for the Windows build with VC6
606 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
607 needed (only for projects required VTK). If the VTK is included in all
608 projects, there is conflicts with the jpeg lib of vtk when compiling the
609 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
610 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
611 when compiling the gdcm_wrap.cxx file (created by the compilation of the
613 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
614 (like it's already made for the cout use). Otherwise, conflict with the
617 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
618 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
620 - comments on the DicomDir::Method related usage added.
621 - now that we use the namespace gdcm, a lot of internal classes do
622 NOT need to be wrapped anymore.
623 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
624 DicomDir::Method) new example added.
626 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
627 * Improve string manipulation. I now inforce the notion of 'DicomString'
628 A DicomString can contain as many \0 as they want
629 and it is *always* of even length.
630 We only support odd length for very rare case.
631 And in the near future this should be removed.
633 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
634 * /binary_write/ gdcm source. Now even on big endian we are writting
635 little endian. This should -heopfully- fix some tests
637 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
638 * Now the dictionary is compiled into gdcm lib. This is a default
639 behavior, thus any dic file specified is picked before failback to
640 the one comiled into lib
642 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
643 * Change internals for gdcmDict. Don't use any 'new' any more.
644 This should definitely solve any leak problem, and we should be
645 as fast as before, as long as don't modify too much the dictionary.
647 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
648 * STYLE: ivars should start with a capital letter.
649 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
650 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
652 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
653 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
654 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
655 new 2004 dictionaries added (thanks to JPR).
656 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
657 * CLEANUP_ROUND (15) for gdcmPixelConvert
658 - RLEFrame::NumberFragments is now of type unsigned int
659 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
660 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
663 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
664 * Initial work in gathering all transfer syntax accessors. clearly
665 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
666 ivars, but only one transfersyntax (class) ivar with equivalent method on
669 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
670 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
671 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
672 discussed (plus I didn't like having a 2000 lines patch not commited)
674 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
675 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
676 * CLEANUP_ROUND (14) for gdcmPixelConvert
677 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
678 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
679 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
681 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
682 anymore and hence avoids storing a copy of PixelConvert::Decompressed
683 into File::Pixel_Data.
685 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
686 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
687 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
688 * CLEANUP_ROUND (13) for gdcmPixelConvert
689 Substituted File::ParsePixelData() with PixelConvert::Print() new
691 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
692 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
693 method to those classes.
694 - src/gdcmFile.[cxx|h]:
695 -- Added a ::Print() method.
696 -- PixelConverter is now a reference instead of a member.
697 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
698 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
700 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
701 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
702 collaboration diagram and inheritance diagram should be generated with
704 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
705 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
706 pointlessly wrapped (see
707 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
708 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
709 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
710 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
711 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
712 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
713 -- File::Initialise: PixelConverter setup moved away to
714 PixelConverter::GrabInformationsFromHeader()
715 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
716 interpretation moved away to PixelConverter::BuildRGBImage()
718 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
719 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
720 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
722 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
723 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
724 displayed on Win32 when a brutal abort() occurs (because of uncatched
725 exception). See TODO new entry of this commit for more on this.
726 * TODO added new entry.
727 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
728 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
729 - HandleColor is no longer called from gdcmFile.cxx
730 - gdcmPixelConvert.cxx clean up on method arguments and internal
731 variable names for semantical coherence.
733 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
734 * Finished lossless transition, not only do we now read all lossless jpeg
735 images, without the need of the Cornwell lib, but we do read them properly now
736 * To reduce code (well to avoid code duplication), I defined a common place
737 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
738 redefine symbols. This is not perfect but this the best solution I found for a
739 compilation time jpeg option.
741 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
742 * Update jpeg ijg lib to support lossless jpeg implementation
743 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
745 * Also added a special copyright for dcmtk since we use their bugfixes.
748 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
749 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
750 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
751 matters, as stated in warning note at begining of %include section).
752 * src/gdcmDicomDir*.[cxx|h]: coding style
753 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
754 * src/gdcmJpeg8.cxx: doxygen fix.
755 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
756 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
757 from File:: to PixelConvert::.
759 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
760 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
761 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
762 - more code moved away from File:: to PixelConvert::
763 - fat setup of PixelConverter set in place in File::Initialise.
765 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
766 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
767 namespace at the file system level. So now you should convert your examples
769 gdcmHeader -> gdcm::Header
770 It would be nice if people keep in mind to no open the namespace, since it
771 allows compilation on broken plateform which were defining common symbol in
772 the standart namespace (like LP, Unknown ...)
774 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
775 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
776 The JPEG fragments are now parsed at the same stage than the RLE
777 information. All code related to JPEG is now in gdcmPixelConvert:
778 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
779 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
780 export a gdcmFile:: method. Those are simply global functions
781 (for the time being this is better than having them attach to
782 either gdcmFile:: or gdcmPixelConvert::).
783 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
784 and stores the result in a gdcmJPEGFragmentsInfo.
785 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
786 code (among other stuff) moved away from gdcmFile:; to
789 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
790 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
791 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
792 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
793 clean up of RLE related code.
794 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
795 - src/gdcmRLE.cxx removed
796 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
797 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
798 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
799 * CLEANUP_ROUND (9) for gdcmPixelConvert
800 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
801 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
802 away from gdcmFile:: to gdcmPixelConvert::.
804 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
805 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
806 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
807 This is because Parse7Fe0 used to parse the pixels to compute the
808 length. This task was passed over to FindDocEntryLengthOB() a long
809 time ago, EXCEPT I had forgotten the OW case...
810 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
811 we just recylce the code for parsing RLE fragments and computing
813 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
814 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
815 with the retired Parse7Fe0().
816 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
817 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
819 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
820 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
821 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
822 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
823 - src/CMakeLists.txt: alphabetic order reodering + new entries.
824 * CLEANUP_ROUND (4) for gdcmPixelConvert
825 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
826 to return an unused length.
828 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
829 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
830 this should be cleanner from the plane view. The iostream are erally a pain
831 to use to do simple stuff.
833 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
834 * Redo the compilation of the ijg jpeg library. Now only one source is
835 necesseray. No need to rename file by hand what so ever. CMake handle the
836 copying of the file within different directory, configure header file to
837 modify some symbol. The only addition made to ijg wasd a mangle table so
838 that symbol are different whether we are within 8bits or 12bits.
840 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
841 * Added documentation of vtkgdcmReader on Website:
842 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
843 with it's binary name).
844 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
845 the Website to be more complete.
846 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
847 doxygenated documentation.
848 - Doc/DoxyVtkGdcmReaderExamples.txt added
849 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
850 DoxyVtkGdmReaderExamples.html )
851 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
852 * CLEANUP_ROUND (3) for gdcmPixelConvert
853 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
855 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * CLEANUP_ROUND (2) for gdcmPixelConvert
857 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
859 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
860 * CLEANUP_ROUND for gdcmPixelConvert:
861 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
862 - src/gdcmPixelStuff[h|cxx] removed
863 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
864 - src/CMakeLists.txt changed accordingly
866 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
867 gdcmVersion.py moved to newly created ATTIC related
868 gdcmPython/SetupOldies/ directory.
869 * Autotools clean up:
870 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
871 - autogen.sh configure.in acinclude.m4 python.m4 removed
873 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
874 * src/*.cxx *.h Reference to License.htm fixed to License.html.
875 * Doc/CMakeLists.txt, doxygen.config.in: fix.
876 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
878 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
879 * TODO updated with Mathieu suggestions. I proposed a template for
880 describing TODO entries and used it for new entries.
881 * Added Doc/Website/CodingStyle.html, Developpers.html,
882 DeveloppersPython.html, GdcmDataCvs.html and
883 DownloadVersion0_1.html, DownloadVersion0_3.html.
884 * Some Doc/*.txt Doxygen files (which do not really concern the
885 documentation itself, but the website) moved to html and
886 placed in directory Doc/Website:
887 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
888 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
889 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
890 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
891 * CMakeLists.txt changed accordingly.
892 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
893 DeveloppersPython.html
894 * INSTALL nows refers to Doc/Website/Installation.html
896 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
897 * Added Doc/Website directory, that contains a first raw version
900 2004-09-23 Jean-Pierre Roux
901 * FIX In order not to be poluted any longer by casting problems,
902 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
903 we can now delete[] it safely
904 * VoidArea is now called BinArea (less confusing name),
905 and all the methods called ...VoidArea... are now ... BinArea...
906 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
908 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
909 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
910 clear) TagHT, which is an inherited member of gdcmElementSet. It is
911 up to the destructor of gdcmElementSet to clean up TagHt and it's
914 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
915 * Test/CMakeLists.txt: update to follow gdcmData renamings.
916 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
918 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
919 * ENH: added some utility method that builds a flat dictionary
920 holding all the Dicom entries contained in the recursive structure
921 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
923 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
924 BuildFlatHashTable() that build a flat dictionary.
925 - src/gdcmElementSet.h: added a new private GetTag() accessor.
926 gdcmDocument is now a friend of gdcmElementSet.
927 - src/gdcmElementSet.cxx: clean up.
928 - Example/FlatHashTablePrint.cxx added.
929 - Example/CmakeLists.txt changed accordingly
931 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
932 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
933 moved away from gdcmDocEntrySet (since this class is an abstract class
934 acting like an interface). SQDepthLevel and BaseTagKey are now
936 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
937 and associated accessors. Doxygenation of the class.
938 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
940 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
941 Use SQDepthLevel accessor instead. ::Print() adapted.
942 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
943 - src/gdcmDocument.cxx changed accordingly.
945 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
946 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
947 - The following is the doxygen comment of the typedef declaration
948 of gdcmTagKey in src/gdcmCommon.h:
949 gdcmTagKey is made to old an "universal" (as in URL, Universal
950 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
951 A dicom tag always has a group and an element, but a set of tags
952 embeded in various (optionally nested) sequences and sharing
953 the same group and element all share the same (group, element)
954 "identifier". Hence the (group, element) cannot be used as an
955 identifier (in gdcm we shall refer to a "TagKey") of a tag.
956 In order to construct a proper tag identifier (i.e. a key) we
957 consider the following definition of a TagKey:
958 - let Group, Element be the string representation of the
959 group and element dicom tag members,
960 - let ItemNumber be the string representation of the integer
961 index of the considered item number of a sequence,
962 Let the key of a tag embeded in a sequence, noted SeqTag, be
964 /ItemNumber#Group|Element
965 where "/", "#" and "|" are characters acting as separators.
966 Then the general form of a gdcmTagKey is given by:
967 Group|Element<SeqTag>
968 where <SeqTag> means NO or many instances of SeqTag.
969 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
972 but the gdcmTagKey of a tag "embeded" is the first item of
973 a sequence, itself nested in the third item of a sequence is the
975 0004|1220/2#0008|0082/0#0008|0090
976 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
977 order to hold the new sequence compatible key. Previously, the
978 GetKey() method would look in the underlying gdcmDictEntry.
979 - src/gdcmDocEntry.cxx:
980 -- constructor now copies the underlying DictEntry key, in the local
982 -- ::Print: displays the member Key, instead of the (group, element).
983 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
984 - src/gdcmDocEntrySet.h:xi
985 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
986 -- now has a new BaseTagKey member.
988 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
989 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
991 This poses the problem with the semantics of the following lines
992 LoadEntryVoidArea(0x0028,0x1201); // R LUT
993 LoadEntryVoidArea(0x0028,0x1202); // G LUT
994 LoadEntryVoidArea(0x0028,0x1203); // B LUT
995 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
996 to the long FIXME note for what the problem is. Nevertheless in
997 order to get things working the dicom dictionary was altered !
998 Please fix things urgently...
999 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1000 information), see above note on moving the member VoidArea. Nevertheless
1001 the following entries previously correctly set as US are now inproperly
1003 0028 1201 OW IMG Red Palette Color Lookup Table Data
1004 0028 1202 OW IMG Green Palette Color Lookup Table Data
1005 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1006 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1007 of gdcmDocEntry moved to gdcmSeqEntry.
1008 * src/gdcmSeqEntry.cxx: STYLE.
1010 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1011 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1013 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1014 * gdcmPython/testSuite.py: all the test suite in python is now moved
1015 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1016 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1017 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1019 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1020 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1021 to avoid inclusion recursion until STL is reached.
1022 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1023 mecanism. errno.h is not included in gdcm anymore.
1024 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1025 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1027 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1028 gdcmData/TestAllEntryVerifyReference.txt
1029 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1030 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1031 exception_on_error parameter.
1032 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1033 - vtk/vtkGdcmReader.cxx changed accordingly,
1034 - Example/*.cxx and Test/*.cxx changed accordingly.
1036 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1038 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1039 enable_sequences removed from gdcmHeader constructor and dependencies.
1040 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1041 * gdcmPython/demo/PrintHeader.py: dummy fix.
1042 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1043 skip_shadow removed from gdcmHeader constructor and dependencies.
1044 * Example/*.cxx and Test/*.cxx changed accordingly.
1046 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1047 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1048 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1050 2004-07-21 Jean-Pierre Roux
1051 * FIX Now, Parsing and Printing a DICOMDIR do work!
1052 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1054 2004-07-20 Jean-Pierre Roux
1055 * FIX Some brain damaged headers have Zero-Lenght fields
1056 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1058 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1059 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1060 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1061 variable (instance of gdcmDebug) by a definition macro, and the instance
1062 is now in static in the gdcmDebug class
1063 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1064 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1066 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1067 * WARNING: ctest now depends more tightly on gdcmData. You should
1068 check out gdcmData properly for things to run smoothly...
1069 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1070 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1071 we need the pixels not be loaded in order to use the ValEntry
1072 that displays position and size).
1073 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1074 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1075 be deprecated. If you have any doubts about the advantages of a
1076 modern scripting language (read Python) versus grass root C++ (i.e.
1077 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1078 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1079 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1080 Anyhow, consider documenting the gdcmData images in
1081 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1083 * Test/CMakeLists.txt:
1084 - now uses TestAllEntryVerify.cxx
1085 - specific comments on oldACR00001.ima (now renamed in gdcmData
1086 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1087 gdcmData/TestAllEntryVerifyReference.txt
1090 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1091 * src/*.[h|cxx] : typedef clean up
1092 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1093 - TagKey renamed to gdcmTagKey (for external usage)
1094 - VRKey renamed to gdcmVRKey (for external usage)
1095 - removal of typedef duplication.
1096 - Removed all unecessary inline keyword from class inline definitions.
1097 - Some method|function(void) declarations replaced with method|function().
1098 * src/jpeg/libijg12/jdhuff12.c:
1099 - printf polluting ctest removed.
1100 - TAB removal for comminting
1102 - TestAllReadCompareDicom.cxx: added a test that compares all the
1103 images in gdcmDataImages.h with corresponding images in
1104 gdcmData/BaselineDicom/. When baseline images are not present
1105 this test creates them.
1106 Note: we need to validate each reference image, but before that
1107 I'd like to rename them with a more explicit name...
1108 - CMakeLists.txt: changed accordingly.
1109 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1110 including each header needed).
1112 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1113 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1114 test suite to the Example directory. Are concerned:
1119 - TestWriteSimple.cxx
1120 * Test/CMakeLists.txt: added some comments on reasons for black listing
1121 image gdcmData/oldACR00001.ima
1123 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1124 * Test/CmakeList.txt: removed the following from black list (to be coherent
1125 with removal from gdcmData):
1126 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1127 - gdcm-MR-PHILIPS-16.dcm
1129 Added the following because after last cvs update, they cause
1130 ctest -R TestReadWriteReadCompare
1132 - gdcm-MR-SIEMENS-16-1.acr
1134 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1135 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1136 new comments in this file) we temporarily (sigh) move to a weaker
1138 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1139 we don't need to black list the following images anymore:
1140 - 8BitsUncompressedColor.dcm
1142 - US-PAL-8-10x-echo.dcm
1143 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1144 fixes and the beautified code ;-)
1145 This fixes the bug introduced in version 1.42 (when beautifying)
1146 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1147 Note: ctest was blind to this bug (this means we need to still
1148 improve the test suite). The bug could be detected by using
1149 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1151 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1152 and by displaying the (garbage) produced file temp.XDCM...
1154 2004-06-29 Jean-Pierre Roux
1155 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1156 - replace by uggly but working old code :-(
1157 A lot of things should be OK again.
1158 It's really urgent to have a test suite that *tests*,
1159 to prevent Frog's beautifying sessions to break all the stuff
1160 (twice, withing a fortnigh ...)
1162 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1163 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1164 redundancy) to added Test/TestReadWriteReadCompare.cxx
1165 * Test/CmakeList.txt: because the compare test of
1166 Test/TestReadWriteReadCompare.cxx fails, the following images are
1167 black listed: - 8BitsUncompressedColor.dcm
1169 - US-PAL-8-10x-echo.dcm
1170 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1171 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1172 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1173 and ad-hoc kludge. This kludge is now removed, and on encountering
1174 such an image (OB field brain damaged) we set errno. Then in
1175 ::FindDocLength() we "fix" the length as being ALL what remains
1176 in the file (until EOF). We then proceed, hoping for the best...
1177 This fixes a SegFault in ShowDicom when trying to write such an
1179 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1180 (because TestWriteRead breaks on it, after a non conformal commit?).
1181 ctest now runs properly, except for MakeDicomDir (which was always
1182 broken) and the Python related stuff (still not fixed).
1184 2004-06-24 Jean-Pierre Roux
1185 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1186 FIX : Test/TestReadWrite now iterates on all the file names
1187 (instead of infinite loop)
1188 ENH : Test/TestWriteRead now iterates on all the file names
1190 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1191 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1193 2004-06-24 Jean-Pierre Roux
1194 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1195 when SamplesPerPixel =3
1196 - now Write is no longer confused by
1197 'BitsAllocated = 12" and 'BitsStored=12"
1198 - "UN" value representation Elements are now written correctly
1199 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1200 ENH : - now gdcmHeader has its own Write methods
1201 (in order to split the job that has not to be done
1204 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1205 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1206 loop on the same image until memory went out.
1207 Note: this means we still have gobs of memory loss in PrintDocument
1208 * src/gdcmDocument.cxx: fixes problem on parsing on file
1209 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1211 2004-06-24 Jean-Pierre Roux
1212 FIX : Write - All the Sequences and Sequence Item are now written
1213 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1214 is added a the end, when necessary.
1215 - A lot of brain-damaged images, that were read correctly are
1216 now written correctly
1217 - length compatible BinEntry are now loaded correctly
1218 (even for odd groups)
1219 Note : only Explicit Value Representation was checked.
1220 (question : is implicit VR really necessary for gdcm ?)
1222 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1223 * DEVELOPPER: added a proposition of coding style.
1224 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1227 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1228 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1229 Use the gdcmDocEntry::Print() and Write() instead.
1230 * src/gdcmDocument.cxx: bug fix.
1232 2004-06-22 Jean-Pierre Roux
1233 FIX : gdcmDocument.cxx
1234 - Now we do recognize the JpegLossLess format (there was a misstyping in
1235 code 'beautyfication' :-(
1236 - Now we automaticaticaly load the Luts, if any
1238 2004-06-22 Jean-Pierre Roux
1239 In order : to write Sequences, whatever their imbrication level,
1240 : to allow user to create his own Sequences
1241 a lot of modif where necessary (adding, moving, or virtualising methods)
1243 WARNING : save your own sources *before* cvs up !
1246 ADD virtual void Write(FILE *fp, FileType filetype);
1249 ADD virtual void Write(FILE *fp, FileType filetype);
1250 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1253 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1254 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1255 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1256 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1257 ADD std::string GetEntryByName(TagName name);
1258 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1260 std::string vr = "unkn",
1261 std::string fourth = "unkn",
1262 std::string name = "unkn");
1263 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1264 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1265 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1266 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1267 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1268 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1269 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1270 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1273 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1274 ADD virtual std::string GetEntryByName (TagName tagName);
1275 ADD virtual std::string GetEntryVRByName (TagName tagName);
1276 REM virtual bool Write(FILE *, FileType);
1277 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1278 FILE *_fp, FileType type);
1279 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1280 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1281 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1282 REM virtual std::string GetEntryByName (std::string tagName);
1283 REM virtual std::string GetEntryVRByName (std::string tagName);
1284 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1285 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1286 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1288 std::string vr = "unkn",
1289 std::string fourth = "unkn",
1290 std::string name = "unkn");
1291 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1292 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1293 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1294 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1297 ADD virtual void Write(FILE *fp, FileType filetype);
1300 ADD virtual void Write(FILE *fp,FileType filetype);
1303 ADD virtual void Write(FILE *fp, FileType filetype);
1304 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1305 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1306 REM std::string GetEntryByName(TagName name);
1309 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1311 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1312 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1313 The default constructor invoked by the line
1314 gdcmHeader *f1 = new gdcmHeader( header );
1315 was gdcmHeader::gdcmHeader(bool) instead of the expected
1316 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1317 Hence the parsing wasn't executed... See also below.
1318 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1319 as explicit constructor didn't do the trick to fix the above problem.
1320 Could anyone explain why ?
1321 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1322 properly calls gdcmValEntry::Print() (that was weed out from
1323 code related to gdcmBinEntry).
1325 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1326 * In order to fix memory leaks:
1327 - Test/TestWriteSimple.cxx: added cleaning of free store through
1329 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1330 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1331 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1332 (through the call to ::AddDicomDirMeta()) or the destructor
1333 would crash when deleting uninitialized ::metaElems].
1334 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1335 - src/gdcmDocument.cxx:
1336 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1337 from dynamic stores.
1338 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1339 was causing memory leaks.
1340 - src/gdcmSQItem.cxx:
1341 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1342 cleanly handled with polymophism: sorry but my milage is low).
1343 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1344 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1345 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1346 This avoids SegFaulting.
1347 - src/gdcmSQItem.h: coding style.
1349 - Test/TestWriteSimple still severely sucks. The output image content
1350 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1351 damaged when displayed with vtkgdcmViewer.
1352 - on memory leaks: TestWriteSimple leaks really less (see entry
1353 of 2004-06-18 in Changelog file for the call to valgrind).
1354 - on segfaults: ctest now passes all the tests but one (no more
1356 * Erroneous leading white fix:
1357 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1358 white[s] (as opposed to from >> xxx, that removes it [them].
1359 - src/gdcmTS.cxx: ditto.
1360 - gdcmPython/testSuite.py: dirty related kludge removed.
1361 * src/*: remaining references to gdcmParser removed.
1362 * src/*[cxx|h]: added copy[way]left header.
1365 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1366 * In order to fix writing of dicom files:
1367 - Test/TestWriteSimple.cxx: a simpler example of writing.
1368 - Test/CMakeLists.txt changed accordingly.
1369 - src/gdcmDocument.cxx:
1370 -- The destructor now recursilvely removes potential sequences.
1371 -- Bug fix in ::IsJPEG2000()
1372 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1373 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1375 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1376 to only declared) and build on top of
1377 ::GetDocEntryByNumber(guint16, guint16).
1378 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1379 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1380 for usage in destructor and treatement of promotion in
1381 ::ReplaceOrCreateByNumber().
1382 - src/gdcmSQItem.cxx: destructor should better handle his job.
1383 Test/TestWriteSimple now runs (or at least it DOES something).
1384 * We can now start hutting memory links. A good starting point is:
1385 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1386 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1387 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1389 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1390 * Valgrind note: after Mathieu Malaterre teached me how to read
1391 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1393 Using gcc, you can force the STL to use malloc and to free memory as
1394 soon as possible by globally disabling memory caching.
1395 With 3.2.2 and later, you should export the environment variable
1396 GLIBCPP_FORCE_NEW before running your program.
1397 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1398 simply vanish (it is still not clear to me, whether this means that
1399 STL std::string leaks or if valgrind believes it leaks...).
1400 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1401 running bin/gdcmTests makeDicomDir):
1402 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1403 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1405 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1406 SegFaulting (I drowned in DicomDir related code when trying to
1407 understand why the list is empty...).
1408 * src/gdcmDocument.h: first BSD license header try.
1409 * Doc/License.txt added.
1411 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1412 * src/gdcmDocument.[h|cxx]:
1413 - Clean up of the Transfer related predicates. They are now all based
1414 on new method isGivenTransferSyntax, that (should) handle properly
1415 the padding problem.
1416 - general clean up, simplification, and coding style.
1417 - Specific clean up of Parse7FE0() (umproperly named actually).
1418 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1420 2004-06-14 Jean-Pierre Roux
1422 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1423 - fix the display of SQItem ordinal number
1424 - add the GetSQItemByOrdinalNumber method
1425 - remove some useless never written private methods
1427 2004-06-14 Jean-Pierre Roux
1429 - adding a constructor taking a gdcmDocEntry as an input param
1430 - ReplaceOrCreateByNumber now returns :
1431 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1432 a gdcmValEntry * if a string value is passed as a param
1434 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1435 according to the param type (no longer sets a gdcmDocEntry)
1436 - GetValEntryByNumber, GetBinEntryByNumber added
1437 - NewValEntryByNumber and NewBinEntryByNumber added
1439 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1441 - GetSQItemNumber and SetSQItemNumber added, to provide
1442 a (relative) Item identier inside a given Sequence
1443 \warning : some pb remaining around this number
1445 - AddEntry now takes the Item Number as a param
1447 - adding a constructor taking a gdcmDocEntry as an input param
1449 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1450 * Memory leak hunt with the following command:
1451 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1452 --show-reachable=yes gdcmTests PrintDocument
1453 It looks like many (all?) leaks are due to the STL (or a bad usage
1454 of the STL. The lines producing the leaks now have a comment with
1455 a "MEMORY LEAK" tag: you can retrieve them with
1456 grep "MEMORY LEAK" src/*
1457 Here are two typical examples which I can't help fixing:
1462 char * test = "babo";
1463 name = test; //// <--- valgrind detects 960 bytes lost in
1464 //// call to std::string::operator=(char const*)
1465 name.clear(); //// Doesn't help !
1473 std::cout << "Type a bunch of characters followed by RETURN: ";
1474 getline(std::cin, line); //// <--- valgrind dectects a loss
1475 //// of 1320 bytes in call to
1476 /// std::basic_istream<>& std::getline<>
1482 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1483 * src/gdcmHeader.[cxx|h]:
1484 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1485 and related, moved away to gdcmDocument.
1486 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1487 the corresponding protected accessors of inherited class
1488 gdcmDocument, removed ! As a consequence gdcmFile had to be
1489 declared friend of class gdcmDocument (see below).
1490 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1491 - Clean up of undefined or unused methods.
1492 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1493 account the changes to gdcmHeader.h).
1494 * src/gdcmDocument.h:
1495 - gdcmFile is now a friend class (in order to take into account the
1496 changes to gdcmHeader.h).
1497 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1498 (see changes to gdcmHeader.h).
1499 - Accessors (reading on the form GetEntry*) are now public.
1500 - Clean up of undefined or unused methods.
1501 * src/gdcmDocument.cxx:
1502 - adaptation to changes to gdcmDocument.h
1503 - ::OpenFile now writes a verbose message when file cannot be opened.
1504 - some std::string properly set to VRKey
1505 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1506 references to gdcmDocument.
1507 * Test/TestFindTags.cxx: changed accordingly to above changes.
1508 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1509 cvs repository gdcmData.
1511 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1512 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1513 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1514 conflicts with gdcmValEntry::voidArea.
1515 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1516 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1517 Value representation between StringRepresentable and BinaryRepresentable.
1518 * src/gdcmDocument.cxx:
1519 - method ParseDES: proper indentation restored and usage of
1520 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1521 - method LoadDocEntry: the fingerprint left in the SetValue() of
1522 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1523 removed. Reverting to previous code segment with the proper
1524 dynamic_cast< gdcmValEntry* >.
1525 Note: this was (partially) breaking the python test suite
1526 (gdcmPython/testSuite.py) that made usage of the above
1527 fingerprint to check presence of "Pixel Data".
1528 * src/gdcmDocEntry.h: coding style.
1529 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1530 now taken into account.
1531 * gdcmPython/gdcm.i: adaptation to the new internal representation
1532 of gdcm (exit gdcmParser, hello gdcmDocument).
1533 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1535 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1536 anymore, but instead prints the loaded Python dictionary.
1537 * .... alas, the python testSuite is still broken.
1539 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1540 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1542 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1543 * src/gdcmUtil.h : export methods
1545 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1546 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1548 * Initial addition of automatic python testing
1549 * Initial addition of automatic image comparison
1551 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1552 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1553 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1555 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1556 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1557 * Test/ShowDicom.cxx : bug fix for msvc compilation
1558 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1560 2004-05-04 Jean-Pierre Roux
1561 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1562 new concepts (and new classes) :
1563 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1564 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1565 - Sequence Doc Entries (gdcmSeqEntries)
1566 a Sequence is composed of Items.
1567 Each item is a set of Doc Entries (this is recursive)
1568 The non uniqueness of the 'Dicom tag' is due to this recursivity
1569 (never taken into account)
1570 Our unability to add a new 'entry' in the header
1571 at the proper location (neither in the H-Table (map or multimap),
1572 nor in the Chained List is also due to this recursivity.
1573 Don't try, right now, to use/modify/compile these new sources :
1574 nothing is finished.
1575 We just commit all the stuff, 'as is', in order not to loose it.
1577 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1578 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1580 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1581 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1582 file prefix (SetFilePrefix)
1584 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1585 * Add a new test: ShowDicom, for now this is just the c++ version of
1586 checkRead.sh, later it will be able to compare the image read against a
1588 * Replace the DEBUG on the stack with a global entry in cmake interface:
1589 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1591 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1592 * Add an example subdir, with a real example on how to read + write a
1595 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1596 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1597 * Doc/CMakeLists.txt: the main page is now properly differentiated
1598 between the developper and user version.
1599 * Doc/doxygen.config.in: dropped search related obsolete flags
1600 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1602 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1603 * DEVELOPPER: added some helpfull comments for compile/test/install
1606 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1607 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1608 src directory, now generated in the build dir.
1609 2. Tests as mentionned smarter
1611 4. Add a new method in gdcmDict that return the PubDict by name
1612 this is interesting for 3rd party lib like ITK,
1613 where we could set the institution name / patient name...
1615 * ENH: 1. Now the test suite is working for real
1616 2. All binaries are now output in the gdcm-bin directory
1617 (this was not true before)
1619 2004-04-28 Jean-Pierre Roux
1620 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1621 SeQuence indented printing of Dicom Header.
1622 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1623 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1624 Computation of SQDepthLevel is now part of gdcmHeader constructor
1625 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1626 tree-like structure of a Dicom Header.
1627 * FIX Test code cleaning
1629 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1630 * ENH: Adding automatic testing
1631 1. Need a DartConfig.cmake to submit to public
1632 2. Add a test driver gdcmTest.cxx
1633 3. gdcmTestMain, an helper for the main test driver gdcmTest
1634 4. Files in Test don't have a main anymore, this becomes interesting
1635 when we add more and more tests, thus dsw don't have to load
1637 * ENH: Adding a GDCM_DATA_ROOT for testing
1638 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1639 one file instead of seven + some small cleanup
1641 2004-04-22 Jean-Pierre Roux
1642 * ENH Minor changes to the Print() methods.
1643 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1644 Header printing. Example given with :
1645 > PrintHeader fileName 2 new
1646 (SQ based tree-like structure still to be done for the Header ...)
1648 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1649 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1650 1. I have added some unsigned where needed
1651 2. Some function parameter not used -> (void)
1652 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1653 4. g++ don't like character '\' in comment
1654 5. #define jpeg_create_decompress jCreaDecompress
1655 this really need to be fixed
1656 6. virtualize destructor of gdcmObject ... leakage
1657 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1658 this also really need to be fixed
1659 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1660 remove compression file
1661 (as we only do decompression, right ?)
1662 * ENH: Change malloc/calloc/free with c++ equivalent
1664 2004-04-21 Jean-Pierre Roux
1665 * FIX gdcmHeaderHelper::GetXSpacing
1666 when a single value is found (bug ?), xpacing is now
1667 defaulted to yspacing
1669 2004-04-19 Jean-Pierre Roux
1670 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1671 * ENH add parameters :
1672 bool exception_on_error = false,
1673 bool enable_sequences = false,
1674 bool ignore_shadow = false
1675 to the gdcmFile constructors to be full gdcmParser compliant
1676 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1677 to allow reading of PAPYRUS 3.0 files
1679 2004-04-06 Jean-Pierre Roux
1680 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1682 2004-04-02 Jean-Pierre Roux
1683 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1684 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1685 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1687 2004-03-30 Jean-Pierre Roux
1688 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1689 for ACR file, written out as DICOM files (hope so...)
1691 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1692 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1693 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1694 moved to base class gdcmParser and only the specialisation is kept
1696 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1697 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1698 already does the job.
1699 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1700 (to be consistent with gdcmParser::WriteEntries).
1702 2004-03-30 Benoit Regrain
1703 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1704 upate of the object's instance. It's passed to 2 in the unfavorable
1705 case : one in the ExecuteInformation, one in the ExecuteData
1707 2004-03-29 Jean-Pierre Roux
1708 * ENH : Check on file type to be written moved
1709 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1710 * FIX : gdcmObject::ResetBoundaries now stops properly
1711 when end-of-list is reached
1712 : gdcmVersion modified (as Benoit Regrain asked)
1714 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1715 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1716 * src/gdcmUtil.cxx: added forgotten iostream include.
1717 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1718 equivalent to ExplicitVR in existing code).
1720 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1721 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1722 now contains all the gdcmGlobal related code.
1723 * minor coding style and doxygenation changes.
1725 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1726 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1727 now contains all the Debug related code.
1728 * minor clean-up of includes in src/*.cxx
1729 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1730 CreateCleanString) removed.
1731 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1732 * Doc/DoxyMainPageUser.txt added.
1733 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1734 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1735 src/gdcmDirList.cxx)
1737 2004-03-24 Jean-Pierre Roux
1738 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1740 2004-03-23 Jean-Pierre Roux
1741 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1742 big endian made volumes
1743 * ENH Now gdcmParser constructor and destructor are protected to forbid
1744 end user to instanciate class gdcmParser
1745 (only gdcmHeader and gdcmDicomDir are meaningfull)
1747 2004-03-22 Benoit Regrain
1748 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1749 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1750 gdcmSerie to gdcmDicomDirSerie
1752 2004-03-19 Jean-Pierre Roux
1753 * ENH Now the tree-like structure describing a DICOMDIR comming from
1754 an already existing DICOMDIR file is consistent with
1755 the home-made tree-like structure build ex-nihilo
1756 or build from the files held (recursively) in a Directory
1757 functions gdcmDicomDir::CheckBoundaries()
1758 gdcmObject::SetBoundaries() added
1760 2004-03-17 Jean-Pierre Roux
1761 * REM (Eric Boix bug) : removal of meaningless
1762 gdcmDicomDirImage::NewImage function.
1763 * FIX now file names and directory name are written properly in the
1765 * FIX now gdcmDicomDir constructor may be call without any trick
1768 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1769 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1770 of gdcmDicomDirImage::NewImage as empty function.
1772 2004-02-28 Jean-Pierre Roux
1773 * ENH add gdcmDicomDir:NewPatient
1774 add gdcmDicomDirPatient:NewStudy
1775 add gdcmDicomDirStudy:NewSerie
1776 add gdcmDicomDirSerie:NewImage
1777 to allow making gdcDicomDir object.
1778 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1779 (as opposite to the gdcmHeader chained list)
1781 2004-02-11 Benoit Regrain
1782 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1783 when using from python
1785 2004-02-10 Benoit Regrain
1786 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1787 * FIX : in gdcmDicomDir when the directory is empty
1788 * ENH : add callback and methods to get the progression of dicomDir
1791 2004-02-06 Jean-Pierre Roux
1792 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1793 - GDCM_META added to gdcmDicomDirType
1794 - class gdcmMeta created
1795 * ENH : - A brief summary is now displayed at the beginning of
1796 'testDicomDir' to help disaster magnitude estimation
1797 * REM : Now useless Test/explDICOMDIR.cxx
1799 2004-02-05 Benoit Regrain
1800 * ENH : add methods in gdcmObject to get the hash table or the list of
1802 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1803 * FIX : wrapping python for TagHeaderEntryHT
1805 2004-02-04 Benoit Regrain
1806 * FIX : even length for some strings when writting the dicom dir
1807 * FIX : sort the images in the dicom dir
1808 * FIX : Bug fix for python use of dicom dir
1809 * ADD : a python demo
1811 2004-02-04 Jean-Pierre Roux
1812 * FIX : Final solution (?) for icone embedded images
1813 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1814 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1815 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1816 gdcmData/gdcm-MR-SIEMENS-16.acr1
1817 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1818 to make full checking easier
1820 2004-02-04 Benoit Regrain
1821 * FIX : WriteEntries : coding style & logic in parameters
1822 * FIX : Set the elements to create the DicomDir in a dictionary file
1824 2004-02-03 Benoit Regrain
1825 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1826 * gdcmDicomDir : add the load of directory
1827 * Bug fix and print add-on
1829 2004-02-03 Jean-Pierre Roux
1830 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1831 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1832 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1833 * FIX gdcmParser.cxx : 'group length' elements are now considered
1834 as integers, even for shadow groups, when file is Implicit VR
1836 2004-02-02 Jean-Pierre Roux
1837 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1839 of the last synonym :-(
1840 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1842 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1843 * FIX taking into account the possible 7fe0,0010 multiplicity
1844 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1845 to allow removal of references to 7fe0,0010, to deal with
1846 ACR-NEMA images, when 0028,0200 is meaningfull
1848 2004-01-31 Jean-Pierre Roux
1849 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1850 no longer writes 'Un' on disk
1851 * FIX SQ elements with actual length are now dealt with corectly
1852 * FIX gdcmFile::WriteBase make the difference, for color images, between
1853 the length (for Palette expanded images)
1854 and Raw Length (non expanded image + Palette)
1855 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1856 (that broke Write). Replaced by UL.
1857 Aware user will reload the field if he
1858 thinks it's necesssary
1860 2004-01-30 Jean-Pierre Roux
1861 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1862 when 'dirty Acr' is found, to be compliant with the new
1863 IsReadable() methods.
1865 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1866 (no DOUBLE images in kosher DICOM,
1867 but so usefull for people that miss them ;-)
1869 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1870 DICOMDIR related utilities (not checked as Windoze compliant)
1872 2004-01-28 Jean-Pierre Roux
1873 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1875 2004-01-27 Jean-Pierre Roux
1876 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1877 to allow skipping the shadow elements, to save memory space.
1878 The TRUE value for this param has to be used
1879 with a FALSE value for the 'enable_sequence' param.
1880 ('public elements' may be embedded in 'shadow Sequences')
1881 * gdcmHeader methods now deal with 'embedded icones images' in the header
1882 (even when an 'icone image sequence' is announced by the
1883 element (0x0088,0x0200), but there is NO icone at all ...
1885 * gdcmHeader sometimes Image Location value doesn't follow
1886 the supposed processor endianity (see gdcmData/cr172241.dcm).
1889 * gdcmHeader add the method
1890 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1891 to get *all* the Header Entries with the same tag.
1892 GetHeaderEntrySameName is probabely *useless*
1893 (no meaning : Name is *not* an identifier within the Dictionary)
1895 2004-01-26 Benoit Regrain
1896 * Bug fix in the print of hexadecimal representations. Remove long fields
1897 in the print and add a third level of print to print them
1899 2004-01-23 Benoit Regrain
1900 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1901 * Bug fix on test suite after remove the strip made on not string fields
1902 * Split the IsReadable method between gdcmParser which test that the file
1903 is dicom and gdcmHeader which test that it's an image file
1905 2004-01-22 Benoit Regrain
1906 * DicomDir : clean code, add methods, set variables in protected or private
1907 * gdcmUtil : bug fix for the clean string method
1909 2004-01-19 Benoit Regrain
1910 * Add the use of shadow dictionaries
1911 * bug fix and coding style
1913 2004-01-19 Benoit Regrain
1914 * src/gdcmFile.cxx : bug fix concerning the close of file
1915 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1916 * Add the update of header entries using the shadow library
1918 2004-01-19 Benoit Regrain
1919 * removal of file gdcmHeader2.cxx
1920 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1921 inheriting from gdcmParser. This split is to prepare the integration
1922 of dicom dir parsing
1923 * bug fix under python
1925 2004-01-16 Jean-Pierre Roux
1926 * REM removal of class gdcmHeaderEntrySet
1927 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1928 * ADD add file gdcmHeader2.cxx
1929 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1931 2004-01-15 Benoit Regrain
1932 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1933 entries created while parsing the header. Thus, they will be destroyed
1934 when the gdcmDictSet will be destroyed
1935 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1938 2004-01-15 Benoit Regrain
1939 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1940 made a fatal error because of the memory release at the end of program.
1941 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1942 some memory and vtk seems to have some problems with that.
1943 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1945 2004-01-14 Benoit Regrain
1946 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1947 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1948 * src/*.[h|cxx] : make changes due to class name changes
1949 * gdcmPython/demo/*.py : bug fix due to method names
1951 2004-01-13 Benoit Regrain
1952 * src/*.[h|cxx] : coding style
1953 * vtk/*.[h|cxx] : coding style
1955 2004-01-13 Benoit Regrain
1956 * gdcmPython/testSuite.py : test the readable flag of file for tests
1957 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1958 It's lied to the stl compilation by MSVC (windows, always windows...)
1959 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1961 2004-01-12 Benoit Regrain
1962 * src/*.h : add comments
1963 * src/gdcmDictSet.h : set the method BuildDictPath in public
1964 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
1965 directly setted in the source code
1966 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
1969 2004-01-09 Benoit Regrain
1970 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1971 * setup.py : use a reference to gdcmVERSION
1973 2004-01-07 Benoit Regrain
1974 * Modification to compile with the distutils.
1977 2003-12-10 Benoit Regrain
1978 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1979 can use a gdcmHeaderHelper to load data
1980 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1981 made in the source code
1983 2003-12-10 Benoit Regrain
1984 * Update Windows projects and .cvsignore files
1986 2003-11-12 Jean-Pierre Roux
1987 * ENH gdcmHeader constructor has one more parameter (default value : false)
1988 that allows the user to 'go inside' the SeQuences only
1990 gdcmElValSet:Print takes it into account
1992 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1993 * ENH: Update gdcmPython/CMakeLists
1994 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1995 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1997 2003-11-10 Jean-Pierre Roux
1998 * FIX : gdcmHeader::LoadElements is now based
1999 on the ListTag listElem member,
2000 not longer on the TagElValueHT tagHt member
2001 * ENH : PrintPubElVal shows (temporarily) both results,
2002 with the tagHt member and the listElem member.
2003 (it's easier to 'see' the problems when using Printheader)
2005 * FIX : old private member LgrElem is now splitted into
2006 ReadLength : Length actually found on disk (updated only
2007 if bug fixing is necessary), for internal
2009 UsableLength : Updated by FixFoundLength, to fix a bug
2010 or to allow Parser going on.
2011 Will allow to re-write a kosher header when a SeQuence
2012 with a length (not 0000) is found
2013 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2014 because gdcmElValSet::Add does not update ListElem
2017 2003-11-07 Jean-Pierre Roux
2018 * FIX misstyping in Transfert Syntax name table
2019 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2020 when they have an actual length (not 0000 nor FFFFF)
2021 (Nobody should care of it, but DICOMDIR explorers)
2023 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2024 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2026 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2027 * ENH: vtkGdcmReader now supports LUT !
2028 (vtkgdcmViewer for now is not able to use them though)
2030 2003-11-05 Jean-Pierre Roux
2031 * in testSuite.py : new files names for checking the package
2032 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2033 that returns the pixel area size to the *aware* (vtk) user
2034 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2036 2003-11-05 Benoit Regrain
2037 * in testSuite.py : Modify the rules for checking the paths
2038 : Explicit error messages
2039 * in __init__.py : Related modif
2041 2003-11-03 Jean-Pierre Roux
2042 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2043 to be used by aware (vtk) users that want to manage
2044 LUT (and no to turn the PALETTE image into an RGB pixels one)
2045 * GetPixelType now returns 8U for 24 Bits images
2046 (vtkGdcmReader compliant)
2048 2003-10-31 Jean-Pierre Roux
2049 * Removal of *all* gdcmData images and add them again
2050 in order to loose the 'history' of un-anonymised images
2052 2003-10-31 Jean-Pierre Roux
2053 * RMV : removal of useless jBitsInJsample.h
2054 for both 8 and 12 Bits JPEG Lossy Libraries
2056 2003-10-31 Jean-Pierre Roux
2057 * ENH : Add the functions gdcmFile::GetImageDataRaw
2058 gdcmFile::GetImageDataIntoVectorRaw
2059 that act as GetImageData and GetImageDataIntoVector
2060 except the making of an RGB Plane from Gray Plane + LUT
2061 Intended to aware (vtk) users who know how to manage
2064 GetLUTRGBA return a R,G,B,A LUT if any
2065 lgrTotaleRaw gives the 'Raw' length
2066 GetImageDataRaw returns the gray Plane
2067 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2068 (They stay Grey, just like with other Dicom viewers :-(
2070 2003-10-30 Jean-Pierre Roux
2071 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2073 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2074 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2075 being coherents dicom files.
2077 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2078 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2080 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2081 * ENH: Two steps is necessary to please VC++ compiler...
2082 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2083 * ENH: Add include dir to medcon lib
2084 * FIX: only one function is being exported for now !
2085 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2087 2003-10-29 Jean-Pierre Roux
2088 * adding gdcmHeader::GetLUTRGBA
2089 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2090 --> Mathieu, the modif u're waiting for is not yet committed
2091 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2093 2003-10-27 Jean-Pierre Roux
2094 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2095 00191113.dcm DermaColorLossLess.dcm
2096 MxTwinLossLess.dcm RadBWLossLess.dcm
2097 * ENH: For version prior to vtkImageViewer2 -r 1.19
2098 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2100 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2101 * Removal of ido stuff in CMakeLists.txt
2103 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2104 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2105 * FIX: remove a call to ->Modified ... see comments
2106 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2108 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2109 * FIX: Problem with path for libvtkgdcmPython
2110 * ENH: Try adding a search script for python site-package
2111 * RMV: Remove some file from medcon lib that are not necessary
2112 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2113 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2114 * FIX: More pragma disable fro VC++,
2115 I don't think I break something as it is also disable in VTK/ITK.
2116 But it fasten debug compilation time.
2118 2003-10-23 Jean-Pierre Roux
2119 * gdcm now deals with 16 Bits Run Length Encoded images
2120 (they are compressed as 2 planes images,
2121 one for the high Bytes, the other for low Bytes)
2123 2003-10-22 Jean-Pierre Roux
2124 * Now CheckRead takes into account :
2125 - the bugged 'Leonardo' Siemens images
2126 - the XA images, sent thru the burning VPRO station
2127 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2130 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2131 * FIX: When copying a Makefile.am to CMakeLists.txt
2132 one should remove the '\'
2134 2003-10-22 Jean-Pierre Roux
2135 * in gdcmData adding a bugged 'Leonardo' Siemens image
2136 (wrong lengths in header)
2137 OK with gdcm, KO with the other viewers :-)
2138 * add a GE dlx XA image, thru the VEPRO burning station
2141 2003-10-21 Jean-Pierre Roux
2142 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2143 for a brutal checking of vtkgdcmViewer compliance
2145 2003-10-21 Jean-Pierre Roux
2146 * add the files for 'xmedcon' Jpeg Lossless library
2147 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2149 2003-10-21 Jean-Pierre Roux
2150 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2152 2003-10-21 Jean-Pierre Roux
2153 * garbage Siemens 'Leonardo' images dealt with
2154 (the patch is easy to remove)
2155 * cosmetic changes to avoid warnings
2157 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2158 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2159 no need to press 'r' now.
2161 2003-10-20 Jean-Pierre Roux
2162 * upgrade of checkRead.sh checkWrite.sh according
2163 to new Jpeg Lossless decompressor
2164 * add US.3405.1.dcm, a genuine RGB medical file ...
2165 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2166 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2168 2003-10-15 Jean-Pierre Roux
2169 * general anonymisation in gdcmData
2170 * adding the 'color files' from
2171 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2172 * adding some well knowed bugged-header images
2173 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2174 waiting for their inclusion in Python testsuite
2176 2003-10-15 Jean-Pierre Roux
2177 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2178 no longer seg faults when file is not found
2180 2003-10-14 Jean-Pierre Roux
2181 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2184 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2185 * TODO: *.in file to genereate a UseGDCM later
2187 2003-10-14 Jean-Pierre Roux
2188 * Some supposed-to-be Dicom Images have no preamble.
2189 OpenFile takes it into account
2190 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2191 * Missing elements added in dicomV3.dic
2192 (just to be affraid : have a look at
2193 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2194 and do it again next year ;->
2196 2003-10-13 Jean-Pierre Roux
2197 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2198 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2199 But there are NOT. It's fixed !
2201 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2202 * FIX: "jpeglib.h" was not found on VC++
2203 * FIX: vtkgdcm was not being installed
2205 2003-10-10 Jean-Pierre Roux
2206 * ENH : OpenFile closes the file if it *really* doesn't look like
2207 an ACR-NEMA / DICOM one.
2208 * FIX : testWrite no longer writes an empty file if the source file
2209 is not gdcm Readable
2210 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2213 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2214 * FIX: CMake generate now documentation
2215 * ENH: out of source doc build !
2216 * ENH: Generate both user and dev documentation
2217 * ENH: Should work on windows too
2218 * ENH: Only one doxygen config.in file is needed
2219 * FIX: make install should be ok now on ùnix plateform
2220 * FIX: PATH to dictionary was wrong (missing /)
2221 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2223 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2224 * vtkGdcmReader is now able to read rgb dicom file.
2225 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2226 * added a gdcmViewer to vtk test, use mouse to control
2227 window level & window width
2229 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2230 * CMake-ification of gdcm, we have now two build system
2231 * FIX: on cygwin Wsock32 doesn't exist
2232 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2234 2003-10-06 Emanuel Ollart
2235 * FIX : compilation process wad broken.
2236 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2238 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2239 * change gdcmViewer -> vtkgdcmViewer
2240 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2242 2003-10-06 Jean-Pierre Roux
2243 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2244 ( e.g : well known GE images with a wrong elem length,
2245 : Philips MRI Images with a wrong Huffman table)
2246 * still to be done : allow the reading of bugged LEONARDO Siemens images
2248 2003-10-03 Jean-Pierre Roux
2249 * Odd length strings are padded with '\0' (not with spaces,
2250 to remain compliant with already defined strings,
2251 like Transfert Syntax UID and others)
2253 2003-10-03 Jean-Pierre Roux
2254 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2255 to allow displaying RGB images (not only by affim ;-)
2257 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2258 * vtkGdcmReader is now able to read rgb dicom file.
2259 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2261 2003-10-03 Jean-Pierre Roux
2262 * A few nasty patches to allow the reading of a lot of nasty images
2263 ( e.g : well known GE images with a wrong elem length,
2264 : Philips MRI Images with a wrong Huffman table)
2265 * still to be done : allow the reading of bugged LEONARDO Siemens images
2267 2003-10-03 Jean-Pierre Roux
2268 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2270 2003-10-03 Jean-Pierre Roux
2271 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2272 to allow displaying RGB images (not only by affim ;-)
2274 2003-10-03 Jean-Pierre Roux
2275 * gdcmFile::GetImageDataIntoVector now
2276 - deals with MultiFrames MultiFragments Run Length Encoded files
2277 - deals with YcBcR (YBR_FULL) files
2278 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2279 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2281 (no sample found :-(
2283 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2284 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2285 Two reasons: - clear things
2286 - third parties acces gdcm through header files, so won't
2287 suffer anymore VC++ complains
2289 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2290 * add argv[1] in testvtkGdcmReader.cxx
2293 2003-09-24 Jean-Pierre Roux
2294 * The lines are now eigthy characters long.for
2295 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2297 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2298 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2299 char* to std::string. Thus, the use of strdup becomes useless. (see
2300 previous commis of Malaterre)
2301 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2302 before the last Malaterre's commit.
2304 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2305 * This commit should fix the Debug building under VC++, the problem
2306 was mainly a mixture of debug and release lib being loaded at startup.
2307 * I also remove a depency to a specific C function: strdup. Because I had
2308 to force the link to msvcrtd (whereas strdup is in libc).
2310 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2311 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2312 located in the gdcmCommon.h file. All use of reference of tha has been
2313 changed to now use the variable GDCM_UNFOUND.
2315 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2317 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2318 Dicom dictionary. The test suite can now be run again. Note:
2319 I'm note very happy with the " (RET)" changes. I believe this
2320 RETAINED comment should be dropped when parsing the dictionary.
2321 - PACKAGER corrected
2323 - AUTHORS updated and now in alphabetical order
2324 * Makefile.am now exports gdcm.dsw for Windoze users.
2326 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2327 * cygwin complains about missing std:: in subdir Test/
2329 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2330 * remove some methods that are now in gdcmHeaderHelper
2332 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2333 * vtkGdcmReader set spacing and origin correctly
2335 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2336 * Fix a few delete/delete[] mismatch
2338 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2339 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2340 interpretation to data given by gdcmHeader. For instance there are
2341 heuristics to get informations (look at different places).
2342 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2343 sorting DICOM images based on different strategies.
2344 * modified Makefiles accordingly.
2346 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2347 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2348 when building in debug mode
2349 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2350 src/win32/gdcmdll.dsp
2351 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2353 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2354 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2357 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2358 * src/win32/libgdcmjpeg12.dsp was not dos format
2359 * src/win32/libgdcmjpeg12.dsp :
2360 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2361 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2363 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2364 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2366 * src/gdcmFile.cxx : bug fix in affectation type
2367 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2368 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2369 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2370 symbols... future problem ?
2372 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2373 * src/win32/libgdcmijpeg12.dsp was missing
2374 * modified gdcm.dsw accordingly
2376 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2377 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2379 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2380 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2381 commit of JPR (before his hollidays to facilitate our work).
2382 * setup.py : bug fix in code. Modifications made while the last commit
2383 of JPR. The code hasn't been tested before the commit... it's so
2384 useless to make that (for best programmer that is JPR) !!!
2386 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2387 * tagged the current version as Version0_3 (i.e. version 0.3)
2389 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2390 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2391 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2392 * *.dsp : modifications to use new libgdcmijpeg8 library
2393 * setup.py : bug fix on VTKPATH variable
2394 * PACKAGER : adding all concerning windows
2396 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2397 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2399 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2400 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2401 test suite reported error.
2402 * PACKAGER file added (describes what a packager must do when
2403 packaging a new release).
2404 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2405 * configure.in: upgraded version number to 0.3.0
2406 * fixing build of rpm (through rpm -ta):
2407 - Doc/Makefile.am exports proper doxygen files
2408 - src/jpeg/libijg8/Makefile.am exports the include files.
2410 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2411 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2412 * src/gdcmHeader.h : formatting code
2414 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2415 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2416 We were obtaining error message from vtk. Now, creation of file list
2417 is made in an internal list to prevent this problem.
2418 Bug fix when output is empty.
2419 Bug fix in update of progress value. Previous commit for this was a bad
2421 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2423 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2424 * src/gdcmHeader.h : added method to get the file name
2425 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2426 files. Added method to remove all files on the input
2427 Added FIXME comment concerning the bad parsing of header made by
2428 ExecuteInformation method (in ExecuteData method)
2430 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2431 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2432 when using make instal.
2433 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2434 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2436 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2437 * setup.py : adding include dir of jpeg lib to compile all sources
2438 * */Win32/*.dsp : JPR fix for windows compilation
2440 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2441 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2443 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2444 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2446 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2447 * setup.py is again effective on un*x (takes into account the
2448 addon of the jpeg library)
2449 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2450 * Doc/Doxy* updated (includes above enhancements)
2451 * INSTALL now points to web documentation
2453 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2454 * src/gdcmHeader.h doesn't make unnecessary reference to
2456 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2458 * src/gdcm*.[cxx|h] :
2459 - to allow compilation with gcc 3.x
2460 -- clean up of STL usage (added explicit usage of std::)
2461 -- small fixes on exceptions.
2462 Note: linking not tested !
2463 - clean of doxygen comments to avoid warnings at documentation
2465 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2466 dependent convertion).
2468 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2469 * Clean up of previous JPR garbage commit (not even commented in the
2471 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2472 - moved all jpeg related files from src to src/jpeg/libijg8, with
2473 addition/modification of Makefile.am and configure.in.
2474 - the testSuite is still brain damage (not guilty).
2476 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2477 * WrapVTK.py : modifications to get correctly vtk source files to
2479 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2480 (FileName -> Filename)
2482 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2483 * vtk/vtkGdcmReader.[cxx/h]:
2484 - UpdateProgress method should now be effective
2485 - removed the limitation on having only images loaded (as opposed
2487 - when building a stack of images/volume, a lesser number of
2488 gdcmHeader and gdcmFile instances should be used (hopefully
2489 accelerating things).
2490 - when building a stack of images/volumes, files which are not
2491 loadable (wrong path-filename, wrong permissions on existing file,
2492 or file not parsable by gdcm) are replaced with a black image
2493 in the stack (for the caller to notice the problem).
2495 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2496 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2498 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2499 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2500 between standard library (std) and vtk library (problems are found
2501 under Windows... thanks Windows !)
2503 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2506 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2508 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2509 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2511 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2512 * When compiling with distutils (see setup.py) the C++ compiler is
2513 called with different flags than the default ones (with automake).
2514 In order to fix all those warning, I compiled gdcm with the command
2515 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2516 and went for warning fixes:
2517 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2518 up from unused variables.
2519 - vtk/vtkGdcmReader.cxx: potential bug fix.
2520 * src/gdcmHeader.h: Doxygen warning cleanup
2522 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2523 * gdcmPython/gdcm.i:
2524 - typemaps correction to take into account the systematic replacement
2525 of "using namespace std" with std:: prefix e.g. std::list,
2526 std::string... (cf changes of 2003-05-21).
2527 - gdcmGlob global variable of type gdcmGlobal (defined in
2528 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2529 exported to Python a as cvar.
2530 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2531 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2532 gdcmDictSet.GetPubDictTagNames() and
2533 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2534 C++ static methods).
2535 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2536 with the above changes.
2538 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2539 * setup.py, manifest.in : bug fix under linux
2541 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2542 * Modification of setup.py to compile vtk part too. Then, we have 2
2543 wrappers which must work with same distutils. For that, we have a
2544 generic distutils in distusiltsWrapping.py ; with :
2545 - build_extWrap class to wrap generically all extensions,
2546 - ExtensionWrap base class for all wrapping extension that contains
2548 - Wrapper interface which wrap sources
2549 + In WrapSwig.py we have extension and wrapper for Swig
2550 + In WrapVTK.py we have extension and wrapper for VTK
2551 * MANIFEST.in : modifications to consider vtk directory and new python
2552 files for compilation
2554 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2555 * Added python wrappers of vtkGdcmReader vtk class (see the
2556 source in vtk/vtkGdcmReader.cxx) :
2557 - vtk/Makefile.am now builds a library
2558 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2559 python library (as opposed to _gdcm.so wich are the python
2560 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2561 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2563 - configure.in has an additional flag --enable-vtk that needs
2564 to be set to enable compilation of vtk related code, that is:
2565 + vtk/vtkGdcmReader.so and
2566 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2567 + gdcmPython/vtkgdcmPython.so (see above)
2568 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2569 be read when compressed or when HighBit + 1 != BitsStored),
2570 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2571 the usage of the python wrapper of vtkGdcmReader vtk class.
2572 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2573 * src/*.[h] all occurences of stl classes are now prefixed with
2574 std::, and all occurences of "using namespace std;" where removed.
2575 This is to avoid pollution of global namespace in included files.
2576 Apparently vtk does not avoid this pitfall: when using both
2577 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2578 collision of various stl members (principally cout...).
2579 * gdcmPython/testSuite.py now cleanly removes temprory generated
2581 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2582 comply with above changes)
2584 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2585 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2586 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2587 vtk data structure (an image Flip was required).
2588 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2589 * cosmetic changes in documentation.
2591 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2592 * src/gdcmHeader.cxx: the constructor no longer exits when an
2593 unexisting file is given as argument.
2594 * The subdirectory Data (containing all the images used for the
2595 test suite) is not part of this repository anymore. A new module
2596 containing those images is now available at
2597 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2598 with the name gdcmData.
2599 All the python scripts (including the package initialisation file
2600 gdcmPython/__init__.py) were adapated to take this change into
2601 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2603 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2604 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2605 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2606 demo of the usage of this class.
2607 Compilation of this vtk part is only done when using the --enable-vtk
2608 at configure (or autogen.sh) stage.
2610 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2611 * More memory link related corrections and documentation fixes.
2613 - maximum info is obtained with a command of the form:
2614 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2615 --show-reachable=yes PrintHeader
2616 - the remaining reachable blocks seem to come from the STL
2617 allocation scheme through the usage of map and list. It looks
2618 like this memory cannot be freed but it is not a memory leak
2619 (in fact further invocation to the STL would recollect the
2620 unused memory allthough it cannot explicitely be freed).
2621 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2622 of displaying an image parsed with gdcm and displayed with VTK.
2623 Note: some images don't seem to work e.g.
2624 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2625 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2626 Allthough this weakens the semantics, it is a ditch attempt to
2627 make gdcm more thread friendly.
2629 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2630 * Memory link hunt (by using valgrind through the command
2631 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2632 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2633 gdcmHeader::_dicom_vr.
2634 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2635 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2637 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2639 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2640 * src/Makefile.am now exports all the necessary include files at
2644 * UpdateGroupLength replaced by new one
2647 * UpdateGroupLength re-written using H-Table
2648 (named UpdateGroupLengthNew untill checks are over)
2650 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2651 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2652 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2654 - gdcmHeader::GetPubElValSet removed.
2655 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2656 UpdateGroupLength, WriteElements, Write.
2657 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2658 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2659 carried the same semantics.
2660 - src/gdcmHeaderIdo.cxx changed accordingly.
2661 - gdcmFile::WriteBase now regroups all the codes from previous
2662 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2663 - enum FileType moved to gdcmCommon.h
2664 * src/gdcmHeader.cxx AddDefault trashed
2665 * gdcmGetXSize added
2666 * getimageDataSize now calls gdcmGetXSize
2667 * Test/*.cxx changed to agree with above changes
2669 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2670 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2671 (to avoid double call by end user).
2672 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2673 by end user, since gdcmHeader::gdcmHeader now handles it.
2675 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2676 * gdcm/Doc many doxygen changes:
2677 - Doxyfile now has two different versions, DoxyfileUsers that generates
2678 the html.users end users oriented documentation and
2679 DoxyfileDeveloppers that generates the html.developper developper
2680 oriented documentation.
2681 - README changed accordingly
2682 - requirement.txt removed (old design info moved to TODO).
2683 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2684 DoxyMainPage.txt, DoxyPython.txt provide more information.
2685 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2686 be updated by simply regenerating the docs with doxygen and copying
2687 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2688 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2689 all the tests in the form "if (<map>.count() >1)" were removed.
2690 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2691 ill-formed documentation sections.
2692 * src/gdcmHeader.cxx: ditto
2694 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2695 * setup.py fixed for un*x (needed macro for stdint.h)
2696 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2697 un*ces with sh-utils test utility.
2698 * gdcmPython/demo/test.py renamed to PrintHeader.py
2699 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2700 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2701 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2702 * src/gdcm*.cxx JPR's bad inclusion fixed.
2704 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2705 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2706 * gdcmPython/demo/test.py changed accordingly.
2708 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2709 * gdcmPython/Makefile.am fixed linking against libstdc++
2710 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2711 * Swig subdir (historical tests of swig version 1.3.17++) removed
2712 * Test/testChangeEntete.cxx some lines commented out in order to make
2714 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2715 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2717 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2718 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2719 hence the user doesn't need this explicit call.
2720 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2721 i.e. LoadElements() call removed.
2722 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2723 - src/Makefile.am declares the proper flag for g++.
2724 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2725 for adding user defined new tags.
2726 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2727 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2728 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2730 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2731 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2732 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2733 src/Makefile.am : the project should properly compile and install
2734 with the autotools, included the python wrappers part.
2735 * gdcm.spec.in : added a spec file for RPM packaging.
2737 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2738 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2740 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2741 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2742 to exported to the environement (see gdcmPython/testSuite.py
2744 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2745 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2746 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2747 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2748 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2750 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2751 * gdcmPython/__init__.py doesn't crash anymore when running in
2752 in InstallMode or PreInstallMode but with an environement given
2753 value of GDCM_DICT_PATH.
2754 * src/gdcmDictSet.[cxx/h] coding style.
2756 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2757 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2758 * src/gdcm.h general comments moved to TODO, and README
2759 * src/gdcm.h should now be seen as a user commodity (including it
2760 should suffice to fully use gdcm). It is nowhere including within
2761 any of the kernel files src/*.cxx and src/*.h.
2763 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2764 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2765 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2767 * src/gdcm*.cxx only include their corresponding include file
2768 (as opposed to gdcm.h)
2769 * gdcmPython/gdcm.i changed accordingly
2770 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2771 the autogen.sh generated "make snapshot" command to work.
2772 * autogen.sh removed history related references to crea package.
2774 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2775 * distutilsSwigCPlusPlus.py work around some swig portability
2778 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2779 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2780 was done in a last ditch attempt to get setup.py _really_
2781 operationnal. The python/gdcmPython layaout add the advantage
2782 of hidding away the python related distutils specific files
2783 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2784 Alas, the src directory was out of scope (i.e. it's relative
2785 position to setup.py was ../src) which made things impossible to
2786 handle (see previous version of python/setup.py). Crossing fingers...
2788 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2789 * python/setup.py now works on Un*x. (harder than I thougth)
2790 * python/distutilsSwigCPlusPlus.py can now have include files
2791 among the list of sources.
2793 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2794 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2795 * modifications in MSVC projects
2797 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2798 * As stated by the first lines of Test/ExceptionAndPython/README, it
2799 looks like we can move back to original usage of exception within
2800 src/gdcm* and hence remove the errno stuff that was introduced
2801 as a quick and dirty fixture of this problem (added to the TODO).
2802 * Doc/Doxyfile configuration file for Doxygen and corresponding
2803 README file for usage added.
2804 * Test/testWrite.cxx added. This new test comes from a split of
2805 test.cxx that is now reverted to its original purpous i.e.
2806 testing the proper parsing of a Dicom related file.
2807 testWrite.cxx concentrates on testing the IO part of gdcm.
2808 * Test/bug1.cxx (containing a bug on WIn32) added.
2809 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2810 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2811 whose purpose is to publish the content of the TagNames of the
2812 Dicom public dictionary were not accessible without an
2813 instance of class gdcmHeader.
2814 - those methods are now static methods of gdcmDictSet and hence
2815 require no instances at all to be invocated.
2816 - within gdcmDictSet this change required to change some method
2817 to class methods (i.e. are now static) among which SetDictPath
2818 (renamed to BuildDictPath) and LoadDefaultPubDict.
2819 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2820 the above changes by calling the new method classes of gdcmDictSet.
2821 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2822 the above to be effective.
2823 * python/gdcmPython: in order to wrap properly the above changes
2824 for Python, swig version now needs to be > 1.3.17.
2825 * python/gdcmPython/Makefile fixed to adapt itself to new
2826 configure/make shema introduced by Johan Montagnat (thanks for the
2827 contribution). Alas this Makefile cannot be turned into a proper
2828 Makefile.am without some heavy changes in the configure.in
2829 (for python dectection).
2830 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2831 now avoids publishing the empty entries.
2833 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2834 * python/setup.py : bug fix concerning install under windows
2835 ExtraPath reused :-P
2836 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2838 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2839 * Dicts/dicomV3.dic : remove double spaces !!!
2840 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2841 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2844 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2845 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2846 method. Doxygenation.
2847 * src/gdcm.h clean up of JPR spurious comments.
2849 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2850 * python/distutilsSwigCPlusPlus.py now properly collects the
2851 shadow classes generated by "swig -c++" (gdcm.py in our case)
2852 when using "python setup.py install".
2853 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2854 reexports the working classes.
2855 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2856 by the classical C errno scheme. This is to prevent an obscure
2857 behavior of the python wrappers when importing wxPython.wx prior
2858 to gdcmPython (which ended up in an abort call). An illustration
2859 of this oddity can be found in the Test/ExceptionAndPython
2860 subdir (see the README file). This problem probably due to
2861 an combination of g++ and dynamic loading.
2862 * added Test/ExceptionAndPython (see above)
2864 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2865 * Changed the layout of the python part to avoid bloating main
2866 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2867 i.e. the distutils arsenal. All the python related stuff is
2868 again in a python subdir, but the package itself is now in
2870 * setup.py was cleaned up:
2871 - pythonIncludePath removed
2872 - python setup.py bdist target is now functional.
2873 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2874 collision with other packages). gdcmPython/demo/*.py changed
2877 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2878 * python subdir moved to gdcmPython (preparation of distutils packaging).
2879 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2880 distutils installer is operational.
2881 * - gdcmPython/__init__.py now properly loads the swig generated
2882 shadow classes (from gdcm.py).
2883 - gdcmPython/demo/*.py changed to import the package gdcmPython
2884 instead of gdcmPython/demo/load.py.
2885 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2887 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2888 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2889 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2890 entries within the associated public Dicom dictionary resp. the same
2891 information but sorted by the fourth field (PAT, IMG, DIR) of the
2893 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2894 are now in the "???" group.
2895 - python/gdcm.i changed accordingly,
2896 - python/demo/printGroupedPublicDict.py added, that gives an example
2897 of the above new functionalities in Python.
2899 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2900 * src/gdcm.h, gdcmHeader.cxx:
2901 - historic references to glib's g_malloc and g_free (#defined)
2902 were definitively removed.
2903 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2904 * src/gdcmElValSet.cxx:
2905 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2906 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2907 - GetElValue(string) renamed to GetElValueByName.
2908 - Added GetElementByName(string).
2909 * src/gdcmHeader.cxx: added
2910 - GetPubElValRepByNumber(guint16, guint16)
2911 - GetPubElValRepByName(string)
2912 - GetShaElValRepByNumber(guint16, guint16)
2913 - GetShaElValRepByName(string)
2914 - GetShaElValByNumber(guint16, guint16)
2915 - GetShaElValRepByName(string)
2916 - GetElValRepByNumber(guint16, guint16)
2917 - GetElValRepByName(string)
2918 - GetElValByNumber(guint16, guint16)
2919 - GetElValRepByName(string)
2920 * Doc/requirements.txt added.
2922 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2923 * Test/Makefile building now depends on the one of libgdcm.so
2924 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2925 pixel data) aware which enables finding the address (offset) of
2926 the pixel data of JPEG encoded DICOM files. This leaves only a single
2927 file in the testSuite whose pixel data address (offset) is unknown.
2928 * python/testSuite.py changed accordingly.
2930 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2931 * VC++ has some strong limitations when working with the STL, as stated
2932 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2933 "Also note that some STL containers (map, set, queue, list, deque)
2934 cannot be exported. [...]
2935 Some STL classes contain nested classes. These classes can not
2937 This is caused by a designed limitation that once a template
2938 class is instantiated, it can not be re-instantiated and
2940 Since our usage of map<> is ubiquitous in gdcm, this "designed
2941 limitation" of VC++ is a pitfall.
2942 Hence the Python wrappers of gdcm cannot be incrementally linked
2943 against the c++ dynamic library. The dirty but only workaround is
2944 to forget about incremental link of dynamic libraries and to generate
2945 the Python wrappers library with the inclusions of the underlying C++
2947 The following modifications concern this matter on Win32/VC++:
2948 - wrapping python correct with standalone wrapped dll (don't use separate
2949 dll under windows !!!!)
2950 - python21_d debug mode enabled (ask Frog how to use it :-)
2951 - NO problem with having an STL member of class for example string in C++
2952 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2953 - Python test of dcmlib in Python is ok under windows on a large set
2955 * removed glib references
2956 * typedef's inserted in gdcm.i for correct swig type management
2958 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2959 * python/demo/*.py load.py extracted from test.py. Added explore.py
2960 that only displays required tags and testAll.py that parses all
2961 the files of the testsuite without using unittest.
2962 * python/testSuite.py other additional test on new files added.
2963 * Data/* new test files added accordingly to the testSuite.
2964 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2965 the vr in the file differs from the one of the dictionary.
2967 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2968 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2969 values, but limits itself to values which are below a user specified
2970 size (by default 1024 bytes).
2971 * python/gdcm.i : elements not loaded (because their size is above the
2972 user specified treshold) are exported with their TagKey as key of the
2973 python dictionary. This enables the testsuite to make some checks
2974 on the unloaded elements (since we have their offset and size).
2975 * python/testSuite.py
2976 - now tests for the existence and proper value of the pixel data
2977 - two new examples added.
2978 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2980 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2981 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2982 aware. See the strategy comments in gdcmHeader::FindeLength().
2983 * Test/test.cxx now accepts a filename as first argument.
2984 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2985 * python/testSuite.py changed to integrate test on above files.
2987 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2988 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2989 the vr was also RET.
2990 * python/testSuite.py more tests added.
2992 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2993 * python/testSuite.py unittest test suite added (uses Data)
2994 * Data/* dcm and acr files for the test suite.
2995 * glib dependance removed from un*x version. We now use ISO C99
2996 7.18 Integer types (see stdint.h)
2997 - python/Makefile, src/Makefile src/gdcm.h
2998 * src/ when an explicit vr (like dicom files) suddenly poped an
2999 implicit element we use to mark the underlying DictEntry of the
3000 concerned ElValue with "Implicit". This strategy was damageable
3001 too the public or provite dictionaries, since some of their vr
3002 would be changed. Since Header::FindLength heavily relies on the
3003 detection by Header::FindVR of falsely explicit elements, I
3004 added an extra ImplicitVr member to ElValue (boolean).
3005 The rest of the changes we the necessary adaptations.
3007 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3008 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3010 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3012 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3013 * Adaptation for porting to VC++:
3015 o forced to use std namespace (for string to be known)
3016 o all class use __declspec export style on WIN32
3017 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3018 (in stdlib.h on Win32 but in std:: for gcc)
3019 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3020 variable GDCM_DICT_PATH.
3021 * src/gdcmHeader.cxx verbose comments made discrete.
3023 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3024 * python/gdcm.i: added a typemap that converts a C++ hashing table
3025 to native Python dictionary.
3026 * python/demo/test.py:
3027 - now uses the native dictionary for exploration of gdcmHeader.
3028 - takes an optional filename argument (the file to parse).
3029 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3030 PubElVals hashing table.
3031 * Dicts/dicomV3.dic removed error prone trailing spaces.
3033 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3034 * Python wrapping process moved away from src/Makefile to
3035 newly created python/Makefile (as well as gdcm.i)
3036 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3037 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3038 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3039 from the environement variable GDCM_DICT_PATH (when existing).
3040 * src/gdcmDict::GetTag bug fix.
3042 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3043 * Straightforward temporary fixes for swig to build the python wrappers.
3044 src/Makefile now has a python working entry [by working we mean
3045 that we can import de shadow classes without errors].
3047 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * hashtest.cxx removed (since already in Test)
3049 * src/gdcmlib.h renamed to src/gdcm.h
3050 * src/dcm.i renamed to src/gdcm.i
3051 * src/Makefile prepared for python wrapping
3053 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3054 * src/gdcmHeader.cxx :
3055 - Parsing of header is now separated from loading of element values
3056 (see gdcmHeader::LoadElements).
3057 - general clean up of hopefully all file access (creation of
3058 ReadInt16 and ReadInt32)
3060 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3061 * src/gdcmHeader.cxx :
3062 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3064 - SetLgrElem renamed to SetLength
3065 - GetLgrElem renamed to GetLength
3066 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3067 * src/gdcmElValSet.cxx fixed both GetElValue methods
3068 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3069 due to IdoDude was cleaned out.
3071 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3072 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3073 concentrates on finding the value representation (when it exists).
3074 RecupLgr now only finds the element value length, and it avoids
3075 returning the unecessary skL (skipped length).
3076 Also, offsetCourant was simply removed (with taille_fich) since
3077 it was redundant with the File position internals (by using
3078 ftell and fseek). This also made skL (see above in RecupLgr) usage
3080 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3081 on the libido specificities which are handled through class
3083 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3086 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3087 * Truckload of changes. Parsing of header is barely functional
3088 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3090 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3091 * src/gdcmHeader.cxx many addons of low level methods
3093 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3094 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3095 and _IdDcmSWAP_LONG.
3097 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3098 * This corresponds to all the changes decided at the meeting of
3099 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob