1 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDictSet.h : set the default output to the os variable
3 * src/gdcmDictEntry.[h|cxx] : add the Print method
4 * gdcmPython/demo/ : add a new test
6 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
7 * merging of Test/PrintDicomDir and Test/TestDicomDir
8 * removal of now redundant Test/PrintDicomDir
9 * enhancement of Example/PrintDicomDir
11 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * Now, python test might work on systems
13 * Add the PrintDicomDir test
15 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
16 * FIX : First entry following group 0002 was lost for
17 Explicit Big Endian Transfer Syntax files
18 (group and elem not swaped)
20 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
21 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
22 Big Endian Transfer Syntax supposed the group following 0002
23 begins always by element 0000 (element 0000 is *optional*)
24 To avoid further troubles, let's be pessimistic, and use
25 Document::HandleOutOfGroup0002() method
26 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
27 (related pb not yet solved)
29 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * Bug fix for the python part use
31 * Now, PrintHeader.py pass... but outside the ctest use. shit !
33 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
36 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
37 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
38 a string and should ask the global TS dict what are the propreties of
41 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
42 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
43 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
44 to swap the Swap Code, at parsing time, when we come out of group 0002
45 and Transfer Syntax is Big Endian
46 We should be able to read now 'true DICOM" Big Endian coded images
47 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
48 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
50 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
51 * Hopefully fix the bug on MacOSX and static global initialization.
52 This is the only -minor- patch I found that both please MacOSX and VS6.
53 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
54 but this would require a lot of change. Another approach would be that Global
55 create those string and GDCM_UNFOUND becomes a pointer to a string (which
56 gdcm::Global would destroy at exit).
58 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
59 * Fix bug on MacOSX with static initialization in a multy threaded
60 environment. static const string in a header file used to be ill
61 initialized provoquing the freeze of any tests. patch should solve this
64 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
65 * According to Benoit's suggestion, and without any objection from anybody
66 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
67 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
68 - method gdcmDicomDirObject::GetEntry() renamed as
69 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
71 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
72 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
73 you debug/warning message just as c++ streams which make them very convinient
74 to use. Once this is stabilize I will change the ostringstrem to be
75 redirected to a file (ofstream).
76 * Properly support C99 extension: __FUNCTION__ which allow us to display
77 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
79 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
80 * Removal of useless and dangerous methods :
81 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
82 GetDocEntryByName, GetEntryByName, GetDictEntryByName
83 * Removal of usless methods :
84 Dict::PrintByName, Dict::GetDictEntryByName
85 * Commenting out of probabely useless methods :
86 Dict::GetDictEntryNames()
87 Dict::GetDictEntryNamesByCategory()
88 DictSet::GetPubDictEntryNames()
89 DictSet::GetPubDictEntryNamesByCategory()
90 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
91 * ENH : Use dicomTS.dic as described in 2004 version
92 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
93 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
94 Add Accessors on VM (Value Multiplicity), and VM related methods
95 * ADD : Add a list of 'Dicom Attribute types', as found in
96 http://medical.nema.org/dicom/2004/04_15PU.PDF
98 * ADD : Add dicomGroupNameAbbreviations.dic
99 should be used to write a method to replace the former
100 Dict::GetDictEntryNamesByCategory()
102 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
104 to read in the file... and only it ! Length is the efective length of the
105 data in the DocEntry structure
107 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
108 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
109 And now use a static function call instead, with a global variable. i
110 This is much closer to the VTK approach. Hopefully should be bulletproof
111 and easier to use...hopefully
113 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
114 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
116 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
117 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
119 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
121 ValEntry, BinEntry, SeqEntry creation or replace
123 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
125 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
127 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
128 when specifying the VR
129 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
130 * src/gdcmDocEntry.cxx : amelioration of print
132 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
133 * ADD : Add the method Util::IsCurrentProcessorBigEndian
134 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
135 * ADD Method Document::ComputeGroupLength
136 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
137 in order to allow further VR modification by user
138 * REM : removal of once-called method File::WriteBase
139 integration of its code in formerly one-line method File::Write
141 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
143 replace the different values "??", "Unkn", "Unknown".
144 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
145 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
146 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
147 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
149 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
152 * Set the gdcm::Base class to some Printable classes
154 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * src/gdcmFile.[h|cxx] : add the Print method
156 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
157 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
158 * src/gdcmDocument.h : remove the PrintLevel informations
159 * Example/PrintFile.cxx : use the new gdcm::File::Print
161 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
163 problems when compiling with the python wrapping
165 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
166 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
167 writting in ImplicitVR
169 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
170 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
171 JPEG decompression, especially when dicom frames are split into several
172 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
173 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
175 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * src/gdcmHeader.cxx : change the initialisation of default header.
177 Now, this header is readable by gdm, e-film, DicomWorks
179 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
181 Rename Decompressed to Raw
182 * Use the API changes in gdcm::File.
183 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
186 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
187 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
188 each added entry in the header. Replace the 'Planes' field by the 'Number
191 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
193 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
195 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
196 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
197 At this time, this image isn't readable by e-film... waiting JPR help to
200 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
201 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
202 DocEntry. Now use methods of the Document !
204 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
205 * Test/ShowDicomSeq.cxx : bug fix
207 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
208 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
209 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
210 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
211 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
213 * Test/TestCopyRescaleDicom.cxx : remove unused variable
214 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
215 containing found sequences
217 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
218 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
220 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
221 Some fields in BinEntry must be copied to not seg fault when making the :
222 gdcm::File *copy = new gdcm::File( copyH );
223 and tests are now made on good variables
225 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
227 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
229 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
230 * Add vtkGdcmWriter example and test
232 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
233 * Test/TestUtil.cxx : reformat the source code
234 * vtk/vtkGdcmReader.cxx : remove and change prints
235 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
237 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
238 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
240 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
242 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
244 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
246 by an eof to prevent all bad read of the file... and in this case, the
249 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * Example/Volume2Dicom.cxx : comment unused variables
251 * Test/PrintDicomDir.cxx : comment unused variables
252 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
253 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
254 method that is redondant with AddEntry.
255 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
258 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * Bug fix due my last commit (compilation under Windows).
260 * Example/Volume2Dicom : bug fix in the file and reformatting source code
261 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
263 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
265 - Remove printf / sprintf
266 - include iostream AFTER gdcm so we don't get warnings
267 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
269 - Also remove tons of include from header files, hopefully this should
270 speeup the compilation time, since it was becoming a dog slow.
271 - Remove gdcm.h as it include way too many files and slow down compilation
272 (plus it is not up to date)
273 - remove 'using namespace std' this is BAD !
275 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
276 * Remove memory leaks on the DicomDir
277 * Remove some useless data in DicomDirObject
278 * Add usefull methods in SQItem, to be complient withe the ElementSet
280 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
281 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
283 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
285 future, with convertion)
286 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
287 and ImageDataSize values. Remove the method to get the PixelReadConverter
288 from the output of the class
290 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
291 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
293 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
294 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
295 and vtkErrorMacro use.
296 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
298 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
299 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
301 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
302 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
303 The string leaves only in the fonction. So when we make a .c_str(), we
304 get the pointeur on the first element, element that will be destroyed
305 immediately after thee instruction.
306 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
307 file has been opened : the test must be made on the content of the
308 pointer and not directly on the pointer !
311 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
313 the python part recompiles
315 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
317 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
318 X session is killed (for my computer... it seems to not be identic on
321 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
322 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
323 avoid problems (otherwise, the difference test between the visible image
324 and the reference is incorrect. If the reference is greater than the
325 screen resolution, it's produce errors).
326 Can be used for only one image. Can be used with a visible flag.
327 * vtk/vtkGdcmReader.cxx : remove commented codes.
328 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
329 under windows at compilation
330 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
332 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
334 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
335 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
336 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
337 tests on the image size X, Y, Z
339 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
340 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
341 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
342 between the class name and the file name
344 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
345 * src/ : fix compilation warnings for the Write method (2 different
346 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
347 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
348 variable... create a static method in gdcm::Document to access to
349 this variable content.
351 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
352 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
353 file, to be accessed by other files (like gdcmFile). Remove commented
354 code. Move the change of the header to the gdcmFile, using the
356 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
357 To be sure of that (and simplify calls), the Write of the header now
358 gets a file name and not a file pointer (std::ifstream).
359 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
360 DocEntryArchive. Remove all open of the written file
362 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
365 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
366 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
367 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
369 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
370 some corresponding methods. Write correctly the file and check before
372 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
373 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
374 is now on RGB data (as before my last commit
375 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
377 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
378 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
379 Add a print information of the type of the entry
380 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
381 It was in the gdcmFile, and all write have been regrouped
382 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
383 Write correctly all dicom files (in decompressed mode only at this time)
384 * Test/ : test on files are now made using Raw data and not color data if
386 * Example/PrintFile.cxx : add more printings
388 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
389 * Amelioration of code, remove some code copy. For the loading of
390 BinEntry (in gdcmDocument), add the test to verify if the file is already
393 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
394 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
395 remove a DocEntry in the header (push an empty DocEntry)
396 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
397 lines. Bug fix in the initialization of the PixelConvert and the
399 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
400 use in TestCopyDicom (now this test can run under windows... but fails)
401 * Test/TestCopyDicom.cxx : amelioration of the test :
402 - test the pixels written
403 - add test points to quickly find where is the error
404 - can set a file name input and output in arguments
405 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
406 amelioration of the test output
408 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
410 all replaced DocEntry's
411 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
412 Now, each needed DocEntry to modify is duplicated, modified and inserted
413 to the header using DocEntryArchive. Thus, after save, we can restore the
414 header initial state.
416 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
417 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
419 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
420 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
421 correct to copy it. The DictEntry is specified at the DocEntry creation,
422 then, it musn't change in the time.
423 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
424 header correctly. At this time, the change is only made for the first
425 level of the Document. In the future, it might consider sequences.
426 The change is made by replacing a DocEntry by an other that is created
427 outside the class. The old value is kept. When we restore the header
428 status, the added DocEntry is deleted and replaced by the old value.
429 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
430 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
431 set the write type to explicit VR, implicit VR or ACR. Add methods to set
432 the write mode to native, decompressed or RGB (but not used at this time)
434 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
435 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
436 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
438 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
440 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
442 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
443 set because already copied when copying the BinEntry's of the header
444 * Test/TestAllReadCompareDicom.cxx : remove warnings
446 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
447 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
448 Two problems appear when doing it :
449 - with the gdcmFile : when the GetImageData method is called, the pixels
450 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
451 data (pixels). And each structure destruct the data when it's
452 destructed. So we have two destructions for the same data. To solve it,
453 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
454 data or not. If it doesn't own data, then they will not destroyed by
456 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
457 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
458 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
459 create a double destruction of the same DocEntry's. So, to solve it,
460 the TagHT is simply cleared and the DicomDir* elements are destroyed.
461 * TODO : add an entry concerning memory leaks in the DicomDir
463 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
464 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
465 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
468 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
470 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
471 after it have been deleted
473 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
474 * FIX: src/* fix the doxygen warnings.
475 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
476 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
477 was erroneously defined with a size of 15 instead of 16. [many thanks
478 to Jean Michel Rouet for pointing out this bug].
480 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
481 1. Finish merging JMR patch for writting DICOM from scratch
482 2. Fix -hopefully- bug with MONOCHROME and space vs null character
483 3. Use const ref when possible
484 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
485 5. A few more comments
486 6. CreateUniqueUID can now be called without parameter"
488 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
489 * ENH: Slightly bigger patch:
490 1. Getting toward full integration of JMR patch for writting dicom from scratch
491 2. Update Test to test part of this patch: CreateUniqueUID
492 3. File was not close properly in gdcmDict
493 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
494 5. Use of const ref instead of copy (speed issue)
495 6. Remove temporary (duplicate) string in TranslateToKey
496 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
497 8. Do not repeat virtual in subclasses
498 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
500 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
501 * Apply first patch toward better string comparison when dealing with broken
502 DICOM files. Essentially the string could be padded with a space instead
503 of a null character as defined by standard
505 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
506 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
507 because never used... and in the same time, that's remove some memory leaks
509 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
510 * src/gdcmFile.cxx : now delete the PixelConvert instance.
511 * In examples and tests : change the type of image data variables from void*
512 to uint8_t*. Remmove all delete on image data variables
514 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
515 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
516 Verify the file pointer value before open the file, and if it's not null,
517 a verbose message is generated.
518 Close correctly the file when the file isn't considered dicom-like. The
519 correctly close is a call to CloseFile.
520 When closing the file pointer, test if its not null to close the file.
521 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
522 file. For an uncompressed image, the copied data correspond in the least
523 case to the image size (calculated) or the image size specified in the
524 header. A verbose is generated if these two size mismatch
526 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
527 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
528 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
529 break under windows (with msvc6 compilation).
531 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
532 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
533 compiling with MSVC6)
535 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
536 * Bugs fix for the Windows build with VC6
537 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
538 needed (only for projects required VTK). If the VTK is included in all
539 projects, there is conflicts with the jpeg lib of vtk when compiling the
540 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
541 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
542 when compiling the gdcm_wrap.cxx file (created by the compilation of the
544 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
545 (like it's already made for the cout use). Otherwise, conflict with the
548 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
549 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
551 - comments on the DicomDir::Method related usage added.
552 - now that we use the namespace gdcm, a lot of internal classes do
553 NOT need to be wrapped anymore.
554 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
555 DicomDir::Method) new example added.
557 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
558 * Improve string manipulation. I now inforce the notion of 'DicomString'
559 A DicomString can contain as many \0 as they want
560 and it is *always* of even length.
561 We only support odd length for very rare case.
562 And in the near future this should be removed.
564 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
565 * /binary_write/ gdcm source. Now even on big endian we are writting
566 little endian. This should -heopfully- fix some tests
568 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
569 * Now the dictionary is compiled into gdcm lib. This is a default
570 behavior, thus any dic file specified is picked before failback to
571 the one comiled into lib
573 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
574 * Change internals for gdcmDict. Don't use any 'new' any more.
575 This should definitely solve any leak problem, and we should be
576 as fast as before, as long as don't modify too much the dictionary.
578 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
579 * STYLE: ivars should start with a capital letter.
580 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
581 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
583 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
584 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
585 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
586 new 2004 dictionaries added (thanks to JPR).
587 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
588 * CLEANUP_ROUND (15) for gdcmPixelConvert
589 - RLEFrame::NumberFragments is now of type unsigned int
590 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
591 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
594 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
595 * Initial work in gathering all transfer syntax accessors. clearly
596 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
597 ivars, but only one transfersyntax (class) ivar with equivalent method on
600 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
601 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
602 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
603 discussed (plus I didn't like having a 2000 lines patch not commited)
605 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
606 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
607 * CLEANUP_ROUND (14) for gdcmPixelConvert
608 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
609 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
610 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
612 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
613 anymore and hence avoids storing a copy of PixelConvert::Decompressed
614 into File::Pixel_Data.
616 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
617 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
618 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
619 * CLEANUP_ROUND (13) for gdcmPixelConvert
620 Substituted File::ParsePixelData() with PixelConvert::Print() new
622 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
623 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
624 method to those classes.
625 - src/gdcmFile.[cxx|h]:
626 -- Added a ::Print() method.
627 -- PixelConverter is now a reference instead of a member.
628 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
629 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
631 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
632 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
633 collaboration diagram and inheritance diagram should be generated with
635 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
636 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
637 pointlessly wrapped (see
638 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
639 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
640 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
641 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
642 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
643 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
644 -- File::Initialise: PixelConverter setup moved away to
645 PixelConverter::GrabInformationsFromHeader()
646 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
647 interpretation moved away to PixelConverter::BuildRGBImage()
649 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
650 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
651 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
653 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
654 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
655 displayed on Win32 when a brutal abort() occurs (because of uncatched
656 exception). See TODO new entry of this commit for more on this.
657 * TODO added new entry.
658 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
659 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
660 - HandleColor is no longer called from gdcmFile.cxx
661 - gdcmPixelConvert.cxx clean up on method arguments and internal
662 variable names for semantical coherence.
664 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
665 * Finished lossless transition, not only do we now read all lossless jpeg
666 images, without the need of the Cornwell lib, but we do read them properly now
667 * To reduce code (well to avoid code duplication), I defined a common place
668 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
669 redefine symbols. This is not perfect but this the best solution I found for a
670 compilation time jpeg option.
672 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
673 * Update jpeg ijg lib to support lossless jpeg implementation
674 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
676 * Also added a special copyright for dcmtk since we use their bugfixes.
679 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
680 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
681 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
682 matters, as stated in warning note at begining of %include section).
683 * src/gdcmDicomDir*.[cxx|h]: coding style
684 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
685 * src/gdcmJpeg8.cxx: doxygen fix.
686 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
687 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
688 from File:: to PixelConvert::.
690 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
691 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
692 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
693 - more code moved away from File:: to PixelConvert::
694 - fat setup of PixelConverter set in place in File::Initialise.
696 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
697 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
698 namespace at the file system level. So now you should convert your examples
700 gdcmHeader -> gdcm::Header
701 It would be nice if people keep in mind to no open the namespace, since it
702 allows compilation on broken plateform which were defining common symbol in
703 the standart namespace (like LP, Unknown ...)
705 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
706 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
707 The JPEG fragments are now parsed at the same stage than the RLE
708 information. All code related to JPEG is now in gdcmPixelConvert:
709 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
710 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
711 export a gdcmFile:: method. Those are simply global functions
712 (for the time being this is better than having them attach to
713 either gdcmFile:: or gdcmPixelConvert::).
714 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
715 and stores the result in a gdcmJPEGFragmentsInfo.
716 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
717 code (among other stuff) moved away from gdcmFile:; to
720 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
721 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
722 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
723 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
724 clean up of RLE related code.
725 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
726 - src/gdcmRLE.cxx removed
727 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
728 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
729 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
730 * CLEANUP_ROUND (9) for gdcmPixelConvert
731 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
732 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
733 away from gdcmFile:: to gdcmPixelConvert::.
735 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
736 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
737 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
738 This is because Parse7Fe0 used to parse the pixels to compute the
739 length. This task was passed over to FindDocEntryLengthOB() a long
740 time ago, EXCEPT I had forgotten the OW case...
741 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
742 we just recylce the code for parsing RLE fragments and computing
744 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
745 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
746 with the retired Parse7Fe0().
747 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
748 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
750 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
751 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
752 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
753 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
754 - src/CMakeLists.txt: alphabetic order reodering + new entries.
755 * CLEANUP_ROUND (4) for gdcmPixelConvert
756 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
757 to return an unused length.
759 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
760 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
761 this should be cleanner from the plane view. The iostream are erally a pain
762 to use to do simple stuff.
764 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
765 * Redo the compilation of the ijg jpeg library. Now only one source is
766 necesseray. No need to rename file by hand what so ever. CMake handle the
767 copying of the file within different directory, configure header file to
768 modify some symbol. The only addition made to ijg wasd a mangle table so
769 that symbol are different wether we are within 8bits or 12bits.
771 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
772 * Added documentation of vtkgdcmReader on Website:
773 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
774 with it's binary name).
775 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
776 the Website to be more complete.
777 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
778 doxygenated documentation.
779 - Doc/DoxyVtkGdcmReaderExamples.txt added
780 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
781 DoxyVtkGdmReaderExamples.html )
782 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
783 * CLEANUP_ROUND (3) for gdcmPixelConvert
784 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
786 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
787 * CLEANUP_ROUND (2) for gdcmPixelConvert
788 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
790 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
791 * CLEANUP_ROUND for gdcmPixelConvert:
792 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
793 - src/gdcmPixelStuff[h|cxx] removed
794 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
795 - src/CMakeLists.txt changed accordingly
797 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
798 gdcmVersion.py moved to newly created ATTIC related
799 gdcmPython/SetupOldies/ directory.
800 * Autotools clean up:
801 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
802 - autogen.sh configure.in acinclude.m4 python.m4 removed
804 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
805 * src/*.cxx *.h Reference to License.htm fixed to License.html.
806 * Doc/CMakeLists.txt, doxygen.config.in: fix.
807 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
809 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
810 * TODO updated with Mathieu suggestions. I proposed a template for
811 describing TODO entries and used it for new entries.
812 * Added Doc/Website/CodingStyle.html, Developpers.html,
813 DeveloppersPython.html, GdcmDataCvs.html and
814 DownloadVersion0_1.html, DownloadVersion0_3.html.
815 * Some Doc/*.txt Doxygen files (which do not really concern the
816 documentation itself, but the website) moved to html and
817 placed in directory Doc/Website:
818 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
819 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
820 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
821 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
822 * CMakeLists.txt changed accordingly.
823 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
824 DeveloppersPython.html
825 * INSTALL nows refers to Doc/Website/Installation.html
827 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
828 * Added Doc/Website directory, that contains a first raw version
831 2004-09-23 Jean-Pierre Roux
832 * FIX In order not to be poluted any longer by casting problems,
833 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
834 we can now delete[] it safely
835 * VoidArea is now called BinArea (less confusing name),
836 and all the methods called ...VoidArea... are now ... BinArea...
837 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
839 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
840 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
841 clear) TagHT, which is an inherited member of gdcmElementSet. It is
842 up to the destructor of gdcmElementSet to clean up TagHt and it's
845 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
846 * Test/CMakeLists.txt: update to follow gdcmData renamings.
847 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
849 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
850 * ENH: added some utility method that builds a flat dictionnary
851 holding all the Dicom entries contained in the recursive structure
852 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
854 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
855 BuildFlatHashTable() that build a flat dictionary.
856 - src/gdcmElementSet.h: added a new private GetTag() accessor.
857 gdcmDocument is now a friend of gdcmElementSet.
858 - src/gdcmElementSet.cxx: clean up.
859 - Example/FlatHashTablePrint.cxx added.
860 - Example/CmakeLists.txt changed accordingly
862 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
863 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
864 moved away from gdcmDocEntrySet (since this class is an abstract class
865 acting like an interface). SQDepthLevel and BaseTagKey are now
867 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
868 and associated accessors. Doxygenation of the class.
869 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
871 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
872 Use SQDepthLevel accessor instead. ::Print() adapted.
873 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
874 - src/gdcmDocument.cxx changed accordingly.
876 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
877 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
878 - The following is the doxygen comment of the typedef declaration
879 of gdcmTagKey in src/gdcmCommon.h:
880 gdcmTagKey is made to old an "universal" (as in URL, Universal
881 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
882 A dicom tag always has a group and an element, but a set of tags
883 embeded in various (optionally nested) sequences and sharing
884 the same group and element all share the same (group, element)
885 "identifier". Hence the (group, element) cannot be used as an
886 identifier (in gdcm we shall refer to a "TagKey") of a tag.
887 In order to construct a proper tag identifier (i.e. a key) we
888 consider the following definition of a TagKey:
889 - let Group, Element be the string representation of the
890 group and element dicom tag members,
891 - let ItemNumber be the string representation of the integer
892 index of the considered item number of a sequence,
893 Let the key of a tag embeded in a sequence, noted SeqTag, be
895 /ItemNumber#Group|Element
896 where "/", "#" and "|" are characters acting as separators.
897 Then the general form of a gdcmTagKey is given by:
898 Group|Element<SeqTag>
899 where <SeqTag> means NO or many instances of SeqTag.
900 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
903 but the gdcmTagKey of a tag "embeded" is the first item of
904 a sequence, itself nested in the third item of a sequence is the
906 0004|1220/2#0008|0082/0#0008|0090
907 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
908 order to hold the new sequence compatible key. Previously, the
909 GetKey() method would look in the underlying gdcmDictEntry.
910 - src/gdcmDocEntry.cxx:
911 -- constructor now copies the underlying DictEntry key, in the local
913 -- ::Print: displays the member Key, instead of the (group, element).
914 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
915 - src/gdcmDocEntrySet.h:xi
916 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
917 -- now has a new BaseTagKey member.
919 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
920 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
922 This poses the problem with the semantics of the following lines
923 LoadEntryVoidArea(0x0028,0x1201); // R LUT
924 LoadEntryVoidArea(0x0028,0x1202); // G LUT
925 LoadEntryVoidArea(0x0028,0x1203); // B LUT
926 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
927 to the long FIXME note for what the problem is. Nevertheless in
928 order to get things working the dicom dictionary was altered !
929 Please fix things urgently...
930 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
931 information), see above note on moving the member VoidArea. Nevertheless
932 the following entries previously correctly set as US are now inproperly
934 0028 1201 OW IMG Red Palette Color Lookup Table Data
935 0028 1202 OW IMG Green Palette Color Lookup Table Data
936 0028 1203 OW IMG Blue Palette Color Lookup Table Data
937 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
938 of gdcmDocEntry moved to gdcmSeqEntry.
939 * src/gdcmSeqEntry.cxx: STYLE.
941 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
942 * Test/TestAllEntryVerify.cxx minor fix and added comments.
944 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
945 * gdcmPython/testSuite.py: all the test suite in python is now moved
946 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
947 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
948 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
950 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
951 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
952 to avoid inclusion recursion until STL is reached.
953 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
954 mecanism. errno.h is not included in gdcm anymore.
955 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
956 (gdcmFormatError now inherits from gdcmFormatUnexpected).
958 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
959 gdcmData/TestAllEntryVerifyReference.txt
960 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
961 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
962 exception_on_error parameter.
963 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
964 - vtk/vtkGdcmReader.cxx changed accordingly,
965 - Example/*.cxx and Test/*.cxx changed accordingly.
967 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
968 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
969 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
970 enable_sequences removed from gdcmHeader constructor and dependencies.
971 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
972 * gdcmPython/demo/PrintHeader.py: dummy fix.
973 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
974 skip_shadow removed from gdcmHeader constructor and dependencies.
975 * Example/*.cxx and Test/*.cxx changed accordingly.
977 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
978 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
979 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
981 2004-07-21 Jean-Pierre Roux
982 * FIX Now, Parsing and Printing a DICOMDIR do work!
983 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
985 2004-07-20 Jean-Pierre Roux
986 * FIX Some brain damaged headers have Zero-Lenght fields
987 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
989 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
990 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
991 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
992 variable (instance of gdcmDebug) by a definition macro, and the instance
993 is now in static in the gdcmDebug class
994 * src/gdcmSQItem.h : (FIXME) remove an undefined method
995 * Test/PrintAllDocument.cxx : bug fix in the result of the test
997 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
998 * WARNING: ctest now depends more tightly on gdcmData. You should
999 check out gdcmData properly for things to run smoothly...
1000 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1001 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1002 we need the pixels not be loaded in order to use the ValEntry
1003 that displays position and size).
1004 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1005 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1006 be deprecated. If you have any doubts about the advantages of a
1007 modern scripting language (read Python) versus grass root C++ (i.e.
1008 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1009 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1010 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1011 Anyhow, consider documenting the gdcmData images in
1012 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1014 * Test/CMakeLists.txt:
1015 - now uses TestAllEntryVerify.cxx
1016 - specific comments on oldACR00001.ima (now renamed in gdcmData
1017 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1018 gdcmData/TestAllEntryVerifyReference.txt
1021 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1022 * src/*.[h|cxx] : typedef clean up
1023 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1024 - TagKey renamed to gdcmTagKey (for external usage)
1025 - VRKey renamed to gdcmVRKey (for external usage)
1026 - removal of typedef duplication.
1027 - Removed all unecessary inline keyword from class inline definitions.
1028 - Some method|function(void) declarations replaced with method|function().
1029 * src/jpeg/libijg12/jdhuff12.c:
1030 - printf polluting ctest removed.
1031 - TAB removal for comminting
1033 - TestAllReadCompareDicom.cxx: added a test that compares all the
1034 images in gdcmDataImages.h with corresponding images in
1035 gdcmData/BaselineDicom/. When baseline images are not present
1036 this test creates them.
1037 Note: we need to validate each reference image, but before that
1038 I'd like to rename them with a more explicit name...
1039 - CMakeLists.txt: changed accordingly.
1040 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1041 including each header needed).
1043 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1044 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1045 test suite to the Example directory. Are concerned:
1050 - TestWriteSimple.cxx
1051 * Test/CMakeLists.txt: added some comments on reasons for black listing
1052 image gdcmData/oldACR00001.ima
1054 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1055 * Test/CmakeList.txt: removed the following from black list (to be coherent
1056 with removal from gdcmData):
1057 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1058 - gdcm-MR-PHILIPS-16.dcm
1060 Added the following because after last cvs update, they cause
1061 ctest -R TestReadWriteReadCompare
1063 - gdcm-MR-SIEMENS-16-1.acr
1065 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1066 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1067 new comments in this file) we temporarily (sigh) move to a weaker
1069 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1070 we don't need to black list the following images anymore:
1071 - 8BitsUncompressedColor.dcm
1073 - US-PAL-8-10x-echo.dcm
1074 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1075 fixes and the beautified code ;-)
1076 This fixes the bug introduced in version 1.42 (when beautifying)
1077 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1078 Note: ctest was blind to this bug (this means we need to still
1079 improve the test suite). The bug could be detected by using
1080 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1082 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1083 and by displaying the (garbage) produced file temp.XDCM...
1085 2004-06-29 Jean-Pierre Roux
1086 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1087 - replace by uggly but working old code :-(
1088 A lot of things should be OK again.
1089 It's really urgent to have a test suite that *tests*,
1090 to prevent Frog's beautifying sessions to break all the stuff
1091 (twice, withing a fortnigh ...)
1093 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1094 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1095 redundancy) to added Test/TestReadWriteReadCompare.cxx
1096 * Test/CmakeList.txt: because the compare test of
1097 Test/TestReadWriteReadCompare.cxx fails, the following images are
1098 black listed: - 8BitsUncompressedColor.dcm
1100 - US-PAL-8-10x-echo.dcm
1101 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1102 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1103 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1104 and ad-hoc kludge. This kludge is now removed, and on encountering
1105 such an image (OB field brain damaged) we set errno. Then in
1106 ::FindDocLength() we "fix" the length as being ALL what remains
1107 in the file (until EOF). We then proceed, hoping for the best...
1108 This fixes a SegFault in ShowDicom when trying to write such an
1110 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1111 (because TestWriteRead breaks on it, after a non conformal commit?).
1112 ctest now runs properly, except for MakeDicomDir (which was always
1113 broken) and the Python related stuff (still not fixed).
1115 2004-06-24 Jean-Pierre Roux
1116 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1117 FIX : Test/TestReadWrite now iterates on all the file names
1118 (instead of infinite loop)
1119 ENH : Test/TestWriteRead now iterates on all the file names
1121 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1122 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1124 2004-06-24 Jean-Pierre Roux
1125 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1126 when SamplesPerPixel =3
1127 - now Write is no longer confused by
1128 'BitsAllocated = 12" and 'BitsStored=12"
1129 - "UN" value representation Elements are now written correctly
1130 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1131 ENH : - now gdcmHeader has its own Write methods
1132 (in order to split the job that has not to be done
1135 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1136 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1137 loop on the same image until memory went out.
1138 Note: this means we still have gobs of memory loss in PrintDocument
1139 * src/gdcmDocument.cxx: fixes problem on parsing on file
1140 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1142 2004-06-24 Jean-Pierre Roux
1143 FIX : Write - All the Sequences and Sequence Item are now written
1144 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1145 is added a the end, when necessary.
1146 - A lot of brain-damaged images, that were read correctly are
1147 now written correctly
1148 - length compatible BinEntry are now loaded correctly
1149 (even for odd groups)
1150 Note : only Explicit Value Representation was checked.
1151 (question : is implicit VR really necessary for gdcm ?)
1153 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1154 * DEVELOPPER: added a proposition of coding style.
1155 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1158 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1159 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1160 Use the gdcmDocEntry::Print() and Write() instead.
1161 * src/gdcmDocument.cxx: bug fix.
1163 2004-06-22 Jean-Pierre Roux
1164 FIX : gdcmDocument.cxx
1165 - Now we do recognize the JpegLossLess format (there was a misstyping in
1166 code 'beautyfication' :-(
1167 - Now we automaticaticaly load the Luts, if any
1169 2004-06-22 Jean-Pierre Roux
1170 In order : to write Sequences, whatever their imbrication level,
1171 : to allow user to create his own Sequences
1172 a lot of modif where necessary (adding, moving, or virtualising methods)
1174 WARNING : save your own sources *before* cvs up !
1177 ADD virtual void Write(FILE *fp, FileType filetype);
1180 ADD virtual void Write(FILE *fp, FileType filetype);
1181 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1184 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1185 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1186 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1187 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1188 ADD std::string GetEntryByName(TagName name);
1189 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1191 std::string vr = "unkn",
1192 std::string fourth = "unkn",
1193 std::string name = "unkn");
1194 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1195 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1196 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1197 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1198 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1199 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1200 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1201 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1204 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1205 ADD virtual std::string GetEntryByName (TagName tagName);
1206 ADD virtual std::string GetEntryVRByName (TagName tagName);
1207 REM virtual bool Write(FILE *, FileType);
1208 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1209 FILE *_fp, FileType type);
1210 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1211 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1212 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1213 REM virtual std::string GetEntryByName (std::string tagName);
1214 REM virtual std::string GetEntryVRByName (std::string tagName);
1215 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1216 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1217 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1219 std::string vr = "unkn",
1220 std::string fourth = "unkn",
1221 std::string name = "unkn");
1222 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1223 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1224 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1225 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1228 ADD virtual void Write(FILE *fp, FileType filetype);
1231 ADD virtual void Write(FILE *fp,FileType filetype);
1234 ADD virtual void Write(FILE *fp, FileType filetype);
1235 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1236 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1237 REM std::string GetEntryByName(TagName name);
1240 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1242 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1243 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1244 The default constructor invoked by the line
1245 gdcmHeader *f1 = new gdcmHeader( header );
1246 was gdcmHeader::gdcmHeader(bool) instead of the expected
1247 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1248 Hence the parsing wasn't executed... See also below.
1249 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1250 as explicit constructor didn't do the trick to fix the above problem.
1251 Could anyone explain why ?
1252 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1253 properly calls gdcmValEntry::Print() (that was weed out from
1254 code related to gdcmBinEntry).
1256 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1257 * In order to fix memory leaks:
1258 - Test/TestWriteSimple.cxx: added cleaning of free store through
1260 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1261 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1262 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1263 (through the call to ::AddDicomDirMeta()) or the destructor
1264 would crash when deleting uninitialized ::metaElems].
1265 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1266 - src/gdcmDocument.cxx:
1267 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1268 from dynamic stores.
1269 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1270 was causing memory leaks.
1271 - src/gdcmSQItem.cxx:
1272 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1273 cleanly handled with polymophism: sorry but my milage is low).
1274 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1275 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1276 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1277 This avoids SegFaulting.
1278 - src/gdcmSQItem.h: coding style.
1280 - Test/TestWriteSimple still severely sucks. The output image content
1281 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1282 damaged when displayed with vtkgdcmViewer.
1283 - on memory leaks: TestWriteSimple leaks really less (see entry
1284 of 2004-06-18 in Changelog file for the call to valgrind).
1285 - on segfaults: ctest now passes all the tests but one (no more
1287 * Erroneous leading white fix:
1288 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1289 white[s] (as opposed to from >> xxx, that removes it [them].
1290 - src/gdcmTS.cxx: ditto.
1291 - gdcmPython/testSuite.py: dirty related kludge removed.
1292 * src/*: remaining references to gdcmParser removed.
1293 * src/*[cxx|h]: added copy[way]left header.
1296 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1297 * In order to fix writing of dicom files:
1298 - Test/TestWriteSimple.cxx: a simpler example of writing.
1299 - Test/CMakeLists.txt changed accordingly.
1300 - src/gdcmDocument.cxx:
1301 -- The destructor now recursilvely removes potential sequences.
1302 -- Bug fix in ::IsJPEG2000()
1303 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1304 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1306 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1307 to only declared) and build on top of
1308 ::GetDocEntryByNumber(guint16, guint16).
1309 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1310 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1311 for usage in destructor and treatement of promotion in
1312 ::ReplaceOrCreateByNumber().
1313 - src/gdcmSQItem.cxx: destructor should better handle his job.
1314 Test/TestWriteSimple now runs (or at least it DOES something).
1315 * We can now start hutting memory links. A good starting point is:
1316 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1317 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1318 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1320 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1321 * Valgrind note: after Mathieu Malaterre teached me how to read
1322 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1324 Using gcc, you can force the STL to use malloc and to free memory as
1325 soon as possible by globally disabling memory caching.
1326 With 3.2.2 and later, you should export the environment variable
1327 GLIBCPP_FORCE_NEW before running your program.
1328 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1329 simply vanish (it is still not clear to me, whether this means that
1330 STL std::string leaks or if valgrind believes it leaks...).
1331 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1332 running bin/gdcmTests makeDicomDir):
1333 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1334 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1336 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1337 SegFaulting (I drowned in DicomDir related code when trying to
1338 understand why the list is empty...).
1339 * src/gdcmDocument.h: first BSD license header try.
1340 * Doc/License.txt added.
1342 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1343 * src/gdcmDocument.[h|cxx]:
1344 - Clean up of the Transfer related predicates. They are now all based
1345 on new method isGivenTransferSyntax, that (should) handle properly
1346 the padding problem.
1347 - general clean up, simplification, and coding style.
1348 - Specific clean up of Parse7FE0() (umproperly named actually).
1349 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1351 2004-06-14 Jean-Pierre Roux
1353 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1354 - fix the display of SQItem ordinal number
1355 - add the GetSQItemByOrdinalNumber method
1356 - remove some useless never written private methods
1358 2004-06-14 Jean-Pierre Roux
1360 - adding a constructor taking a gdcmDocEntry as an input param
1361 - ReplaceOrCreateByNumber now returns :
1362 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1363 a gdcmValEntry * if a string value is passed as a param
1365 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1366 according to the param type (no longer sets a gdcmDocEntry)
1367 - GetValEntryByNumber, GetBinEntryByNumber added
1368 - NewValEntryByNumber and NewBinEntryByNumber added
1370 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1372 - GetSQItemNumber and SetSQItemNumber added, to provide
1373 a (relative) Item identier inside a given Sequence
1374 \warning : some pb remaining around this number
1376 - AddEntry now takes the Item Number as a param
1378 - adding a constructor taking a gdcmDocEntry as an input param
1380 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1381 * Memory leak hunt with the following command:
1382 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1383 --show-reachable=yes gdcmTests PrintDocument
1384 It looks like many (all?) leaks are due to the STL (or a bad usage
1385 of the STL. The lines producing the leaks now have a comment with
1386 a "MEMORY LEAK" tag: you can retrieve them with
1387 grep "MEMORY LEAK" src/*
1388 Here are two typical examples which I can't help fixing:
1393 char * test = "babo";
1394 name = test; //// <--- valgrind detects 960 bytes lost in
1395 //// call to std::string::operator=(char const*)
1396 name.clear(); //// Doesn't help !
1404 std::cout << "Type a bunch of characters followed by RETURN: ";
1405 getline(std::cin, line); //// <--- valgrind dectects a loss
1406 //// of 1320 bytes in call to
1407 /// std::basic_istream<>& std::getline<>
1413 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1414 * src/gdcmHeader.[cxx|h]:
1415 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1416 and related, moved away to gdcmDocument.
1417 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1418 the corresponding protected accessors of inherited class
1419 gdcmDocument, removed ! As a consequence gdcmFile had to be
1420 declared friend of class gdcmDocument (see below).
1421 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1422 - Clean up of undefined or unused methods.
1423 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1424 account the changes to gdcmHeader.h).
1425 * src/gdcmDocument.h:
1426 - gdcmFile is now a friend class (in order to take into account the
1427 changes to gdcmHeader.h).
1428 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1429 (see changes to gdcmHeader.h).
1430 - Accessors (reading on the form GetEntry*) are now public.
1431 - Clean up of undefined or unused methods.
1432 * src/gdcmDocument.cxx:
1433 - adaptation to changes to gdcmDocument.h
1434 - ::OpenFile now writes a verbose message when file cannot be opened.
1435 - some std::string properly set to VRKey
1436 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1437 references to gdcmDocument.
1438 * Test/TestFindTags.cxx: changed accordingly to above changes.
1439 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1440 cvs repository gdcmData.
1442 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1443 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1444 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1445 conflicts with gdcmValEntry::voidArea.
1446 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1447 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1448 Value representation between StringRepresentable and BinaryRepresentable.
1449 * src/gdcmDocument.cxx:
1450 - method ParseDES: proper indentation restored and usage of
1451 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1452 - method LoadDocEntry: the fingerprint left in the SetValue() of
1453 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1454 removed. Reverting to previous code segment with the proper
1455 dynamic_cast< gdcmValEntry* >.
1456 Note: this was (partially) breaking the python test suite
1457 (gdcmPython/testSuite.py) that made usage of the above
1458 fingerprint to check presence of "Pixel Data".
1459 * src/gdcmDocEntry.h: coding style.
1460 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1461 now taken into account.
1462 * gdcmPython/gdcm.i: adaptation to the new internal representation
1463 of gdcm (exit gdcmParser, hello gdcmDocument).
1464 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1466 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1467 anymore, but instead prints the loaded Python dictionary.
1468 * .... alas, the python testSuite is still broken.
1470 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1471 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1473 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1474 * src/gdcmUtil.h : export methods
1476 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1477 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1479 * Initial addition of automatic python testing
1480 * Initial addition of automatic image comparison
1482 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1483 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1484 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1486 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1487 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1488 * Test/ShowDicom.cxx : bug fix for msvc compilation
1489 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1491 2004-05-04 Jean-Pierre Roux
1492 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1493 new concepts (and new classes) :
1494 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1495 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1496 - Sequence Doc Entries (gdcmSeqEntries)
1497 a Sequence is composed of Items.
1498 Each item is a set of Doc Entries (this is recursive)
1499 The non uniqueness of the 'Dicom tag' is due to this recursivity
1500 (never taken into account)
1501 Our unability to add a new 'entry' in the header
1502 at the proper location (neither in the H-Table (map or multimap),
1503 nor in the Chained List is also due to this recursivity.
1504 Don't try, right now, to use/modify/compile these new sources :
1505 nothing is finished.
1506 We just commit all the stuff, 'as is', in order not to loose it.
1508 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1509 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1511 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1512 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1513 file prefix (SetFilePrefix)
1515 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1516 * Add a new test: ShowDicom, for now this is just the c++ version of
1517 checkRead.sh, later it will be able to compare the image read against a
1519 * Replace the DEBUG on the stack with a global entry in cmake interface:
1520 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1522 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1523 * Add an example subdir, with a real example on how to read + write a
1526 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1527 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1528 * Doc/CMakeLists.txt: the main page is now properly differentiated
1529 between the developper and user version.
1530 * Doc/doxygen.config.in: dropped search related obsolete flags
1531 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1533 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1534 * DEVELOPPER: added some helpfull comments for compile/test/install
1537 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1538 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1539 src directory, now generated in the build dir.
1540 2. Tests as mentionned smarter
1542 4. Add a new method in gdcmDict that return the PubDict by name
1543 this is interesting for 3rd party lib like ITK,
1544 where we could set the institution name / patient name...
1546 * ENH: 1. Now the test suite is working for real
1547 2. All binaries are now output in the gdcm-bin directory
1548 (this was not true before)
1550 2004-04-28 Jean-Pierre Roux
1551 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1552 SeQuence indented printing of Dicom Header.
1553 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1554 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1555 Computation of SQDepthLevel is now part of gdcmHeader constructor
1556 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1557 tree-like structure of a Dicom Header.
1558 * FIX Test code cleaning
1560 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1561 * ENH: Adding automatic testing
1562 1. Need a DartConfig.cmake to submit to public
1563 2. Add a test driver gdcmTest.cxx
1564 3. gdcmTestMain, an helper for the main test driver gdcmTest
1565 4. Files in Test don't have a main anymore, this becomes interesting
1566 when we add more and more tests, thus dsw don't have to load
1568 * ENH: Adding a GDCM_DATA_ROOT for testing
1569 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1570 one file instead of seven + some small cleanup
1572 2004-04-22 Jean-Pierre Roux
1573 * ENH Minor changes to the Print() methods.
1574 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1575 Header printing. Example given with :
1576 > PrintHeader fileName 2 new
1577 (SQ based tree-like structure still to be done for the Header ...)
1579 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1580 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1581 1. I have added some unsigned where needed
1582 2. Some function parameter not used -> (void)
1583 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1584 4. g++ don't like character '\' in comment
1585 5. #define jpeg_create_decompress jCreaDecompress
1586 this really need to be fixed
1587 6. virtualize destructor of gdcmObject ... leakage
1588 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1589 this also really need to be fixed
1590 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1591 remove compression file
1592 (as we only do decompression, right ?)
1593 * ENH: Change malloc/calloc/free with c++ equivalent
1595 2004-04-21 Jean-Pierre Roux
1596 * FIX gdcmHeaderHelper::GetXSpacing
1597 when a single value is found (bug ?), xpacing is now
1598 defaulted to yspacing
1600 2004-04-19 Jean-Pierre Roux
1601 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1602 * ENH add parameters :
1603 bool exception_on_error = false,
1604 bool enable_sequences = false,
1605 bool ignore_shadow = false
1606 to the gdcmFile constructors to be full gdcmParser compliant
1607 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1608 to allow reading of PAPYRUS 3.0 files
1610 2004-04-06 Jean-Pierre Roux
1611 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1613 2004-04-02 Jean-Pierre Roux
1614 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1615 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1616 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1618 2004-03-30 Jean-Pierre Roux
1619 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1620 for ACR file, written out as DICOM files (hope so...)
1622 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1623 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1624 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1625 moved to base class gdcmParser and only the specialisation is kept
1627 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1628 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1629 already does the job.
1630 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1631 (to be consistent with gdcmParser::WriteEntries).
1633 2004-03-30 Benoit Regrain
1634 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1635 upate of the object's instance. It's passed to 2 in the unfavorable
1636 case : one in the ExecuteInformation, one in the ExecuteData
1638 2004-03-29 Jean-Pierre Roux
1639 * ENH : Check on file type to be written moved
1640 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1641 * FIX : gdcmObject::ResetBoundaries now stops properly
1642 when end-of-list is reached
1643 : gdcmVersion modified (as Benoit Regrain asked)
1645 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1646 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1647 * src/gdcmUtil.cxx: added forgotten iostream include.
1648 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1649 equivalent to ExplicitVR in existing code).
1651 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1652 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1653 now contains all the gdcmGlobal related code.
1654 * minor coding style and doxygenation changes.
1656 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1657 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1658 now contains all the Debug related code.
1659 * minor clean-up of includes in src/*.cxx
1660 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1661 CreateCleanString) removed.
1662 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1663 * Doc/DoxyMainPageUser.txt added.
1664 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1665 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1666 src/gdcmDirList.cxx)
1668 2004-03-24 Jean-Pierre Roux
1669 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1671 2004-03-23 Jean-Pierre Roux
1672 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1673 big endian made volumes
1674 * ENH Now gdcmParser constructor and destructor are protected to forbid
1675 end user to instanciate class gdcmParser
1676 (only gdcmHeader and gdcmDicomDir are meaningfull)
1678 2004-03-22 Benoit Regrain
1679 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1680 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1681 gdcmSerie to gdcmDicomDirSerie
1683 2004-03-19 Jean-Pierre Roux
1684 * ENH Now the tree-like structure describing a DICOMDIR comming from
1685 an already existing DICOMDIR file is consistent with
1686 the home-made tree-like structure build ex-nihilo
1687 or build from the files held (recursively) in a Directory
1688 functions gdcmDicomDir::CheckBoundaries()
1689 gdcmObject::SetBoundaries() added
1691 2004-03-17 Jean-Pierre Roux
1692 * REM (Eric Boix bug) : removal of meaningless
1693 gdcmDicomDirImage::NewImage function.
1694 * FIX now file names and directory name are written properly in the
1696 * FIX now gdcmDicomDir constructor may be call without any trick
1699 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1700 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1701 of gdcmDicomDirImage::NewImage as empty function.
1703 2004-02-28 Jean-Pierre Roux
1704 * ENH add gdcmDicomDir:NewPatient
1705 add gdcmDicomDirPatient:NewStudy
1706 add gdcmDicomDirStudy:NewSerie
1707 add gdcmDicomDirSerie:NewImage
1708 to allow making gdcDicomDir object.
1709 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1710 (as opposite to the gdcmHeader chained list)
1712 2004-02-11 Benoit Regrain
1713 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1714 when using from python
1716 2004-02-10 Benoit Regrain
1717 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1718 * FIX : in gdcmDicomDir when the directory is empty
1719 * ENH : add callback and methods to get the progression of dicomDir
1722 2004-02-06 Jean-Pierre Roux
1723 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1724 - GDCM_META added to gdcmDicomDirType
1725 - class gdcmMeta created
1726 * ENH : - A brief summary is now displayed at the beginning of
1727 'testDicomDir' to help disaster magnitude estimation
1728 * REM : Now useless Test/explDICOMDIR.cxx
1730 2004-02-05 Benoit Regrain
1731 * ENH : add methods in gdcmObject to get the hash table or the list of
1733 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1734 * FIX : wrapping python for TagHeaderEntryHT
1736 2004-02-04 Benoit Regrain
1737 * FIX : even length for some strings when writting the dicom dir
1738 * FIX : sort the images in the dicom dir
1739 * FIX : Bug fix for python use of dicom dir
1740 * ADD : a python demo
1742 2004-02-04 Jean-Pierre Roux
1743 * FIX : Final solution (?) for icone embedded images
1744 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1745 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1746 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1747 gdcmData/gdcm-MR-SIEMENS-16.acr1
1748 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1749 to make full checking easier
1751 2004-02-04 Benoit Regrain
1752 * FIX : WriteEntries : coding style & logic in parameters
1753 * FIX : Set the elements to create the DicomDir in a dictionary file
1755 2004-02-03 Benoit Regrain
1756 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1757 * gdcmDicomDir : add the load of directory
1758 * Bug fix and print add-on
1760 2004-02-03 Jean-Pierre Roux
1761 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1762 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1763 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1764 * FIX gdcmParser.cxx : 'group length' elements are now considered
1765 as integers, even for shadow groups, when file is Implicit VR
1767 2004-02-02 Jean-Pierre Roux
1768 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1770 of the last synonym :-(
1771 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1773 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1774 * FIX taking into account the possible 7fe0,0010 multiplicity
1775 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1776 to allow removal of references to 7fe0,0010, to deal with
1777 ACR-NEMA images, when 0028,0200 is meaningfull
1779 2004-01-31 Jean-Pierre Roux
1780 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1781 no longer writes 'Un' on disk
1782 * FIX SQ elements with actual length are now dealt with corectly
1783 * FIX gdcmFile::WriteBase make the difference, for color images, between
1784 the length (for Palette expanded images)
1785 and Raw Length (non expanded image + Palette)
1786 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1787 (that broke Write). Replaced by UL.
1788 Aware user will reload the field if he
1789 thinks it's necesssary
1791 2004-01-30 Jean-Pierre Roux
1792 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1793 when 'dirty Acr' is found, to be compliant with the new
1794 IsReadable() methods.
1796 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1797 (no DOUBLE images in kosher DICOM,
1798 but so usefull for people that miss them ;-)
1800 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1801 DICOMDIR related utilities (not checked as Windoze compliant)
1803 2004-01-28 Jean-Pierre Roux
1804 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1806 2004-01-27 Jean-Pierre Roux
1807 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1808 to allow skipping the shadow elements, to save memory space.
1809 The TRUE value for this param has to be used
1810 with a FALSE value for the 'enable_sequence' param.
1811 ('public elements' may be embedded in 'shadow Sequences')
1812 * gdcmHeader methods now deal with 'embedded icones images' in the header
1813 (even when an 'icone image sequence' is announced by the
1814 element (0x0088,0x0200), but there is NO icone at all ...
1816 * gdcmHeader sometimes Image Location value doesn't follow
1817 the supposed processor endianity (see gdcmData/cr172241.dcm).
1820 * gdcmHeader add the method
1821 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1822 to get *all* the Header Entries with the same tag.
1823 GetHeaderEntrySameName is probabely *useless*
1824 (no meaning : Name is *not* an identifier within the Dictionnary)
1826 2004-01-26 Benoit Regrain
1827 * Bug fix in the print of hexadecimal representations. Remove long fields
1828 in the print and add a third level of print to print them
1830 2004-01-23 Benoit Regrain
1831 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1832 * Bug fix on test suite after remove the strip made on not string fields
1833 * Split the IsReadable method between gdcmParser which test that the file
1834 is dicom and gdcmHeader which test that it's an image file
1836 2004-01-22 Benoit Regrain
1837 * DicomDir : clean code, add methods, set variables in protected or private
1838 * gdcmUtil : bug fix for the clean string method
1840 2004-01-19 Benoit Regrain
1841 * Add the use of shadow dictionaries
1842 * bug fix and coding style
1844 2004-01-19 Benoit Regrain
1845 * src/gdcmFile.cxx : bug fix concerning the close of file
1846 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1847 * Add the update of header entries using the shadow library
1849 2004-01-19 Benoit Regrain
1850 * removal of file gdcmHeader2.cxx
1851 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1852 inheriting from gdcmParser. This split is to prepare the integration
1853 of dicom dir parsing
1854 * bug fix under python
1856 2004-01-16 Jean-Pierre Roux
1857 * REM removal of class gdcmHeaderEntrySet
1858 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1859 * ADD add file gdcmHeader2.cxx
1860 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1862 2004-01-15 Benoit Regrain
1863 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1864 entries created while parsing the header. Thus, they will be destroyed
1865 when the gdcmDictSet will be destroyed
1866 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1869 2004-01-15 Benoit Regrain
1870 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1871 made a fatal error because of the memory release at the end of program.
1872 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1873 some memory and vtk seems to have some problems with that.
1874 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1876 2004-01-14 Benoit Regrain
1877 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1878 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1879 * src/*.[h|cxx] : make changes due to class name changes
1880 * gdcmPython/demo/*.py : bug fix due to method names
1882 2004-01-13 Benoit Regrain
1883 * src/*.[h|cxx] : coding style
1884 * vtk/*.[h|cxx] : coding style
1886 2004-01-13 Benoit Regrain
1887 * gdcmPython/testSuite.py : test the readable flag of file for tests
1888 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1889 It's lied to the stl compilation by MSVC (windows, always windows...)
1890 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1892 2004-01-12 Benoit Regrain
1893 * src/*.h : add comments
1894 * src/gdcmDictSet.h : set the method BuildDictPath in public
1895 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1896 directly setted in the source code
1897 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1900 2004-01-09 Benoit Regrain
1901 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1902 * setup.py : use a reference to gdcmVERSION
1904 2004-01-07 Benoit Regrain
1905 * Modification to compile with the distutils.
1908 2003-12-10 Benoit Regrain
1909 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1910 can use a gdcmHeaderHelper to load data
1911 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1912 made in the source code
1914 2003-12-10 Benoit Regrain
1915 * Update Windows projects and .cvsignore files
1917 2003-11-12 Jean-Pierre Roux
1918 * ENH gdcmHeader constructor has one more parameter (default value : false)
1919 that allows the user to 'go inside' the SeQuences only
1921 gdcmElValSet:Print takes it into account
1923 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1924 * ENH: Update gdcmPython/CMakeLists
1925 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1926 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1928 2003-11-10 Jean-Pierre Roux
1929 * FIX : gdcmHeader::LoadElements is now based
1930 on the ListTag listElem member,
1931 not longer on the TagElValueHT tagHt member
1932 * ENH : PrintPubElVal shows (temporarily) both results,
1933 with the tagHt member and the listElem member.
1934 (it's easier to 'see' the problems when using Printheader)
1936 * FIX : old private member LgrElem is now splitted into
1937 ReadLength : Length actually found on disk (updated only
1938 if bug fixing is necessary), for internal
1940 UsableLength : Updated by FixFoundLength, to fix a bug
1941 or to allow Parser going on.
1942 Will allow to re-write a kosher header when a SeQuence
1943 with a length (not 0000) is found
1944 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1945 because gdcmElValSet::Add does not update ListElem
1948 2003-11-07 Jean-Pierre Roux
1949 * FIX misstyping in Transfert Syntax name table
1950 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1951 when they have an actual length (not 0000 nor FFFFF)
1952 (Nobody should care of it, but DICOMDIR explorers)
1954 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1955 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1957 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1958 * ENH: vtkGdcmReader now supports LUT !
1959 (vtkgdcmViewer for now is not able to use them though)
1961 2003-11-05 Jean-Pierre Roux
1962 * in testSuite.py : new files names for checking the package
1963 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1964 that returns the pixel area size to the *aware* (vtk) user
1965 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1967 2003-11-05 Benoit Regrain
1968 * in testSuite.py : Modify the rules for checking the paths
1969 : Explicit error messages
1970 * in __init__.py : Related modif
1972 2003-11-03 Jean-Pierre Roux
1973 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1974 to be used by aware (vtk) users that want to manage
1975 LUT (and no to turn the PALETTE image into an RGB pixels one)
1976 * GetPixelType now returns 8U for 24 Bits images
1977 (vtkGdcmReader compliant)
1979 2003-10-31 Jean-Pierre Roux
1980 * Removal of *all* gdcmData images and add them again
1981 in order to loose the 'history' of un-anonymised images
1983 2003-10-31 Jean-Pierre Roux
1984 * RMV : removal of useless jBitsInJsample.h
1985 for both 8 and 12 Bits JPEG Lossy Libraries
1987 2003-10-31 Jean-Pierre Roux
1988 * ENH : Add the functions gdcmFile::GetImageDataRaw
1989 gdcmFile::GetImageDataIntoVectorRaw
1990 that act as GetImageData and GetImageDataIntoVector
1991 except the making of an RGB Plane from Gray Plane + LUT
1992 Intended to aware (vtk) users who know how to manage
1995 GetLUTRGBA return a R,G,B,A LUT if any
1996 lgrTotaleRaw gives the 'Raw' length
1997 GetImageDataRaw returns the gray Plane
1998 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1999 (They stay Grey, just like with other Dicom viewers :-(
2001 2003-10-30 Jean-Pierre Roux
2002 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2004 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2005 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2006 being coherents dicom files.
2008 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2009 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2011 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2012 * ENH: Two steps is necessary to please VC++ compiler...
2013 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2014 * ENH: Add include dir to medcon lib
2015 * FIX: only one function is being exported for now !
2016 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2018 2003-10-29 Jean-Pierre Roux
2019 * adding gdcmHeader::GetLUTRGBA
2020 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2021 --> Mathieu, the modif u're waiting for is not yet committed
2022 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2024 2003-10-27 Jean-Pierre Roux
2025 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2026 00191113.dcm DermaColorLossLess.dcm
2027 MxTwinLossLess.dcm RadBWLossLess.dcm
2028 * ENH: For version prior to vtkImageViewer2 -r 1.19
2029 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2031 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2032 * Removal of ido stuff in CMakeLists.txt
2034 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2035 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2036 * FIX: remove a call to ->Modified ... see comments
2037 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2039 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2040 * FIX: Problem with path for libvtkgdcmPython
2041 * ENH: Try adding a search script for python site-package
2042 * RMV: Remove some file from medcon lib that are not necessary
2043 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2044 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2045 * FIX: More pragma disable fro VC++,
2046 I don't think I break something as it is also disable in VTK/ITK.
2047 But it fasten debug compilation time.
2049 2003-10-23 Jean-Pierre Roux
2050 * gdcm now deals with 16 Bits Run Length Encoded images
2051 (they are compressed as 2 planes images,
2052 one for the high Bytes, the other for low Bytes)
2054 2003-10-22 Jean-Pierre Roux
2055 * Now CheckRead takes into account :
2056 - the bugged 'Leonardo' Siemens images
2057 - the XA images, sent thru the burning VPRO station
2058 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2061 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2062 * FIX: When copying a Makefile.am to CMakeLists.txt
2063 one should remove the '\'
2065 2003-10-22 Jean-Pierre Roux
2066 * in gdcmData adding a bugged 'Leonardo' Siemens image
2067 (wrong lengths in header)
2068 OK with gdcm, KO with the other viewers :-)
2069 * add a GE dlx XA image, thru the VEPRO burning station
2072 2003-10-21 Jean-Pierre Roux
2073 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2074 for a brutal checking of vtkgdcmViewer compliance
2076 2003-10-21 Jean-Pierre Roux
2077 * add the files for 'xmedcon' Jpeg Lossless library
2078 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2080 2003-10-21 Jean-Pierre Roux
2081 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2083 2003-10-21 Jean-Pierre Roux
2084 * garbage Siemens 'Leonardo' images dealt with
2085 (the patch is easy to remove)
2086 * cosmetic changes to avoid warnings
2088 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2089 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2090 no need to press 'r' now.
2092 2003-10-20 Jean-Pierre Roux
2093 * upgrade of checkRead.sh checkWrite.sh according
2094 to new Jpeg Lossless decompressor
2095 * add US.3405.1.dcm, a genuine RGB medical file ...
2096 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2097 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2099 2003-10-15 Jean-Pierre Roux
2100 * general anonymisation in gdcmData
2101 * adding the 'color files' from
2102 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2103 * adding some well knowed bugged-header images
2104 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2105 waiting for their inclusion in Python testsuite
2107 2003-10-15 Jean-Pierre Roux
2108 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2109 no longer seg faults when file is not found
2111 2003-10-14 Jean-Pierre Roux
2112 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2115 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2116 * TODO: *.in file to genereate a UseGDCM later
2118 2003-10-14 Jean-Pierre Roux
2119 * Some supposed-to-be Dicom Images have no preamble.
2120 OpenFile takes it into account
2121 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2122 * Missing elements added in dicomV3.dic
2123 (just to be affraid : have a look at
2124 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2125 and do it again next year ;->
2127 2003-10-13 Jean-Pierre Roux
2128 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2129 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2130 But there are NOT. It's fixed !
2132 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2133 * FIX: "jpeglib.h" was not found on VC++
2134 * FIX: vtkgdcm was not being installed
2136 2003-10-10 Jean-Pierre Roux
2137 * ENH : OpenFile closes the file if it *really* doesn't look like
2138 an ACR-NEMA / DICOM one.
2139 * FIX : testWrite no longer writes an empty file if the source file
2140 is not gdcm Readable
2141 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2144 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2145 * FIX: CMake generate now documentation
2146 * ENH: out of source doc build !
2147 * ENH: Generate both user and dev documentation
2148 * ENH: Should work on windows too
2149 * ENH: Only one doxygen config.in file is needed
2150 * FIX: make install should be ok now on ùnix plateform
2151 * FIX: PATH to dictionary was wrong (missing /)
2152 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2154 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2155 * vtkGdcmReader is now able to read rgb dicom file.
2156 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2157 * added a gdcmViewer to vtk test, use mouse to control
2158 window level & window width
2160 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2161 * CMake-ification of gdcm, we have now two build system
2162 * FIX: on cygwin Wsock32 doesn't exist
2163 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2165 2003-10-06 Emanuel Ollart
2166 * FIX : compilation process wad broken.
2167 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2169 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2170 * change gdcmViewer -> vtkgdcmViewer
2171 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2173 2003-10-06 Jean-Pierre Roux
2174 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2175 ( e.g : well known GE images with a wrong elem length,
2176 : Philips MRI Images with a wrong Huffman table)
2177 * still to be done : allow the reading of bugged LEONARDO Siemens images
2179 2003-10-03 Jean-Pierre Roux
2180 * Odd length strings are padded with '\0' (not with spaces,
2181 to remain compliant with already defined strings,
2182 like Transfert Syntax UID and others)
2184 2003-10-03 Jean-Pierre Roux
2185 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2186 to allow displaying RGB images (not only by affim ;-)
2188 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2189 * vtkGdcmReader is now able to read rgb dicom file.
2190 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2192 2003-10-03 Jean-Pierre Roux
2193 * A few nasty patches to allow the reading of a lot of nasty images
2194 ( e.g : well known GE images with a wrong elem length,
2195 : Philips MRI Images with a wrong Huffman table)
2196 * still to be done : allow the reading of bugged LEONARDO Siemens images
2198 2003-10-03 Jean-Pierre Roux
2199 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2201 2003-10-03 Jean-Pierre Roux
2202 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2203 to allow displaying RGB images (not only by affim ;-)
2205 2003-10-03 Jean-Pierre Roux
2206 * gdcmFile::GetImageDataIntoVector now
2207 - deals with MultiFrames MultiFragments Run Length Encoded files
2208 - deals with YcBcR (YBR_FULL) files
2209 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2210 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2212 (no sample found :-(
2214 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2215 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2216 Two reasons: - clear things
2217 - third parties acces gdcm through header files, so won't
2218 suffer anymore VC++ complains
2220 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2221 * add argv[1] in testvtkGdcmReader.cxx
2224 2003-09-24 Jean-Pierre Roux
2225 * The lines are now eigthy characters long.for
2226 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2228 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2229 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2230 char* to std::string. Thus, the use of strdup becomes useless. (see
2231 previous commis of Malaterre)
2232 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2233 before the last Malaterre's commit.
2235 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2236 * This commit should fix the Debug building under VC++, the problem
2237 was mainly a mixture of debug and release lib being loaded at startup.
2238 * I also remove a depency to a specific C function: strdup. Because I had
2239 to force the link to msvcrtd (whereas strdup is in libc).
2241 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2242 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2243 located in the gdcmCommon.h file. All use of reference of tha has been
2244 changed to now use the variable GDCM_UNFOUND.
2246 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2248 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2249 Dicom dictionary. The test suite can now be run again. Note:
2250 I'm note very happy with the " (RET)" changes. I believe this
2251 RETAINED comment should be dropped when parsing the dictionary.
2252 - PACKAGER corrected
2254 - AUTHORS updated and now in alphabetical order
2255 * Makefile.am now exports gdcm.dsw for Windoze users.
2257 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2258 * cygwin complains about missing std:: in subdir Test/
2260 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2261 * remove some methods that are now in gdcmHeaderHelper
2263 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2264 * vtkGdcmReader set spacing and origin correctly
2266 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2267 * Fix a few delete/delete[] mismatch
2269 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2270 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2271 interpretation to data given by gdcmHeader. For instance there are
2272 heuristics to get informations (look at different places).
2273 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2274 sorting DICOM images based on different strategies.
2275 * modified Makefiles accordingly.
2277 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2278 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2279 when building in debug mode
2280 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2281 src/win32/gdcmdll.dsp
2282 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2284 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2285 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2288 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2289 * src/win32/libgdcmjpeg12.dsp was not dos format
2290 * src/win32/libgdcmjpeg12.dsp :
2291 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2292 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2294 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2295 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2297 * src/gdcmFile.cxx : bug fix in affectation type
2298 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2299 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2300 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2301 symbols... future problem ?
2303 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2304 * src/win32/libgdcmijpeg12.dsp was missing
2305 * modified gdcm.dsw accordingly
2307 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2308 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2310 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2311 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2312 commit of JPR (before his hollidays to facilitate our work).
2313 * setup.py : bug fix in code. Modifications made while the last commit
2314 of JPR. The code hasn't been tested before the commit... it's so
2315 useless to make that (for best programmer that is JPR) !!!
2317 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2318 * tagged the current version as Version0_3 (i.e. version 0.3)
2320 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2321 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2322 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2323 * *.dsp : modifications to use new libgdcmijpeg8 library
2324 * setup.py : bug fix on VTKPATH variable
2325 * PACKAGER : adding all concerning windows
2327 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2328 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2330 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2331 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2332 test suite reported error.
2333 * PACKAGER file added (describes what a packager must do when
2334 packaging a new release).
2335 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2336 * configure.in: upgraded version number to 0.3.0
2337 * fixing build of rpm (through rpm -ta):
2338 - Doc/Makefile.am exports proper doxygen files
2339 - src/jpeg/libijg8/Makefile.am exports the include files.
2341 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2342 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2343 * src/gdcmHeader.h : formatting code
2345 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2346 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2347 We were obtaining error message from vtk. Now, creation of file list
2348 is made in an internal list to prevent this problem.
2349 Bug fix when output is empty.
2350 Bug fix in update of progress value. Previous commit for this was a bad
2352 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2354 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2355 * src/gdcmHeader.h : added method to get the file name
2356 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2357 files. Added method to remove all files on the input
2358 Added FIXME comment concerning the bad parsing of header made by
2359 ExecuteInformation method (in ExecuteData method)
2361 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2362 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2363 when using make instal.
2364 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2365 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2367 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2368 * setup.py : adding include dir of jpeg lib to compile all sources
2369 * */Win32/*.dsp : JPR fix for windows compilation
2371 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2372 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2374 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2375 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2377 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2378 * setup.py is again effective on un*x (takes into account the
2379 addon of the jpeg library)
2380 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2381 * Doc/Doxy* updated (includes above enhancements)
2382 * INSTALL now points to web documentation
2384 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2385 * src/gdcmHeader.h doesn't make unnecessary reference to
2387 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2389 * src/gdcm*.[cxx|h] :
2390 - to allow compilation with gcc 3.x
2391 -- clean up of STL usage (added explicit usage of std::)
2392 -- small fixes on exceptions.
2393 Note: linking not tested !
2394 - clean of doxygen comments to avoid warnings at documentation
2396 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2397 dependent convertion).
2399 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2400 * Clean up of previous JPR garbage commit (not even commented in the
2402 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2403 - moved all jpeg related files from src to src/jpeg/libijg8, with
2404 addition/modification of Makefile.am and configure.in.
2405 - the testSuite is still brain damage (not guilty).
2407 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2408 * WrapVTK.py : modifications to get correctly vtk source files to
2410 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2411 (FileName -> Filename)
2413 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2414 * vtk/vtkGdcmReader.[cxx/h]:
2415 - UpdateProgress method should now be effective
2416 - removed the limitation on having only images loaded (as opposed
2418 - when building a stack of images/volume, a lesser number of
2419 gdcmHeader and gdcmFile instances should be used (hopefully
2420 accelerating things).
2421 - when building a stack of images/volumes, files which are not
2422 loadable (wrong path-filename, wrong permissions on existing file,
2423 or file not parsable by gdcm) are replaced with a black image
2424 in the stack (for the caller to notice the problem).
2426 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2427 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2429 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2430 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2431 between standard library (std) and vtk library (problems are found
2432 under Windows... thanks Windows !)
2434 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2435 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2437 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2439 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2440 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2442 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2443 * When compiling with distutils (see setup.py) the C++ compiler is
2444 called with different flags than the default ones (with automake).
2445 In order to fix all those warning, I compiled gdcm with the command
2446 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2447 and went for warning fixes:
2448 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2449 up from unused variables.
2450 - vtk/vtkGdcmReader.cxx: potential bug fix.
2451 * src/gdcmHeader.h: Doxygen warning cleanup
2453 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2454 * gdcmPython/gdcm.i:
2455 - typemaps correction to take into account the systematic replacement
2456 of "using namespace std" with std:: prefix e.g. std::list,
2457 std::string... (cf changes of 2003-05-21).
2458 - gdcmGlob global variable of type gdcmGlobal (defined in
2459 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2460 exported to Python a as cvar.
2461 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2462 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2463 gdcmDictSet.GetPubDictTagNames() and
2464 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2465 C++ static methods).
2466 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2467 with the above changes.
2469 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2470 * setup.py, manifest.in : bug fix under linux
2472 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2473 * Modification of setup.py to compile vtk part too. Then, we have 2
2474 wrappers which must work with same distutils. For that, we have a
2475 generic distutils in distusiltsWrapping.py ; with :
2476 - build_extWrap class to wrap generically all extensions,
2477 - ExtensionWrap base class for all wrapping extension that contains
2479 - Wrapper interface which wrap sources
2480 + In WrapSwig.py we have extension and wrapper for Swig
2481 + In WrapVTK.py we have extension and wrapper for VTK
2482 * MANIFEST.in : modifications to consider vtk directory and new python
2483 files for compilation
2485 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2486 * Added python wrappers of vtkGdcmReader vtk class (see the
2487 source in vtk/vtkGdcmReader.cxx) :
2488 - vtk/Makefile.am now builds a library
2489 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2490 python library (as opposed to _gdcm.so wich are the python
2491 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2492 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2494 - configure.in has an additional flag --enable-vtk that needs
2495 to be set to enable compilation of vtk related code, that is:
2496 + vtk/vtkGdcmReader.so and
2497 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2498 + gdcmPython/vtkgdcmPython.so (see above)
2499 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2500 be read when compressed or when HighBit + 1 != BitsStored),
2501 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2502 the usage of the python wrapper of vtkGdcmReader vtk class.
2503 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2504 * src/*.[h] all occurences of stl classes are now prefixed with
2505 std::, and all occurences of "using namespace std;" where removed.
2506 This is to avoid pollution of global namespace in included files.
2507 Apparently vtk does not avoid this pitfall: when using both
2508 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2509 collision of various stl members (principally cout...).
2510 * gdcmPython/testSuite.py now cleanly removes temprory generated
2512 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2513 comply with above changes)
2515 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2516 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2517 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2518 vtk data structure (an image Flip was required).
2519 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2520 * cosmetic changes in documentation.
2522 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2523 * src/gdcmHeader.cxx: the constructor no longer exits when an
2524 unexisting file is given as argument.
2525 * The subdirectory Data (containing all the images used for the
2526 test suite) is not part of this repository anymore. A new module
2527 containing those images is now available at
2528 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2529 with the name gdcmData.
2530 All the python scripts (including the package initialisation file
2531 gdcmPython/__init__.py) were adapated to take this change into
2532 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2534 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2535 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2536 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2537 demo of the usage of this class.
2538 Compilation of this vtk part is only done when using the --enable-vtk
2539 at configure (or autogen.sh) stage.
2541 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2542 * More memory link related corrections and documentation fixes.
2544 - maximum info is obtained with a command of the form:
2545 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2546 --show-reachable=yes PrintHeader
2547 - the remaining reachable blocks seem to come from the STL
2548 allocation scheme through the usage of map and list. It looks
2549 like this memory cannot be freed but it is not a memory leak
2550 (in fact further invocation to the STL would recollect the
2551 unused memory allthough it cannot explicitely be freed).
2552 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2553 of displaying an image parsed with gdcm and displayed with VTK.
2554 Note: some images don't seem to work e.g.
2555 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2556 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2557 Allthough this weakens the semantics, it is a ditch attempt to
2558 make gdcm more thread friendly.
2560 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2561 * Memory link hunt (by using valgrind through the command
2562 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2563 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2564 gdcmHeader::_dicom_vr.
2565 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2566 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2568 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2570 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2571 * src/Makefile.am now exports all the necessary include files at
2575 * UpdateGroupLength replaced by new one
2578 * UpdateGroupLength re-written using H-Table
2579 (named UpdateGroupLengthNew untill checks are over)
2581 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2582 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2583 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2585 - gdcmHeader::GetPubElValSet removed.
2586 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2587 UpdateGroupLength, WriteElements, Write.
2588 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2589 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2590 carried the same semantics.
2591 - src/gdcmHeaderIdo.cxx changed accordingly.
2592 - gdcmFile::WriteBase now regroups all the codes from previous
2593 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2594 - enum FileType moved to gdcmCommon.h
2595 * src/gdcmHeader.cxx AddDefault trashed
2596 * gdcmGetXSize added
2597 * getimageDataSize now calls gdcmGetXSize
2598 * Test/*.cxx changed to agree with above changes
2600 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2601 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2602 (to avoid double call by end user).
2603 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2604 by end user, since gdcmHeader::gdcmHeader now handles it.
2606 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2607 * gdcm/Doc many doxygen changes:
2608 - Doxyfile now has two different versions, DoxyfileUsers that generates
2609 the html.users end users oriented documentation and
2610 DoxyfileDeveloppers that generates the html.developper developper
2611 oriented documentation.
2612 - README changed accordingly
2613 - requirement.txt removed (old design info moved to TODO).
2614 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2615 DoxyMainPage.txt, DoxyPython.txt provide more information.
2616 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2617 be updated by simply regenerating the docs with doxygen and copying
2618 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2619 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2620 all the tests in the form "if (<map>.count() >1)" were removed.
2621 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2622 ill-formed documentation sections.
2623 * src/gdcmHeader.cxx: ditto
2625 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2626 * setup.py fixed for un*x (needed macro for stdint.h)
2627 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2628 un*ces with sh-utils test utility.
2629 * gdcmPython/demo/test.py renamed to PrintHeader.py
2630 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2631 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2632 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2633 * src/gdcm*.cxx JPR's bad inclusion fixed.
2635 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2636 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2637 * gdcmPython/demo/test.py changed accordingly.
2639 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2640 * gdcmPython/Makefile.am fixed linking against libstdc++
2641 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2642 * Swig subdir (historical tests of swig version 1.3.17++) removed
2643 * Test/testChangeEntete.cxx some lines commented out in order to make
2645 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2646 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2648 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2649 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2650 hence the user doesn't need this explicit call.
2651 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2652 i.e. LoadElements() call removed.
2653 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2654 - src/Makefile.am declares the proper flag for g++.
2655 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2656 for adding user defined new tags.
2657 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2658 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2659 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2661 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2662 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2663 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2664 src/Makefile.am : the project should properly compile and install
2665 with the autotools, included the python wrappers part.
2666 * gdcm.spec.in : added a spec file for RPM packaging.
2668 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2669 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2671 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2672 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2673 to exported to the environement (see gdcmPython/testSuite.py
2675 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2676 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2677 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2678 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2679 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2681 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2682 * gdcmPython/__init__.py doesn't crash anymore when running in
2683 in InstallMode or PreInstallMode but with an environement given
2684 value of GDCM_DICT_PATH.
2685 * src/gdcmDictSet.[cxx/h] coding style.
2687 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2688 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2689 * src/gdcm.h general comments moved to TODO, and README
2690 * src/gdcm.h should now be seen as a user commodity (including it
2691 should suffice to fully use gdcm). It is nowhere including within
2692 any of the kernel files src/*.cxx and src/*.h.
2694 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2695 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2696 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2698 * src/gdcm*.cxx only include their corresponding include file
2699 (as opposed to gdcm.h)
2700 * gdcmPython/gdcm.i changed accordingly
2701 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2702 the autogen.sh generated "make snapshot" command to work.
2703 * autogen.sh removed history related references to crea package.
2705 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2706 * distutilsSwigCPlusPlus.py work around some swig portability
2709 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2710 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2711 was done in a last ditch attempt to get setup.py _really_
2712 operationnal. The python/gdcmPython layaout add the advantage
2713 of hidding away the python related distutils specific files
2714 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2715 Alas, the src directory was out of scope (i.e. it's relative
2716 position to setup.py was ../src) which made things impossible to
2717 handle (see previous version of python/setup.py). Crossing fingers...
2719 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2720 * python/setup.py now works on Un*x. (harder than I thougth)
2721 * python/distutilsSwigCPlusPlus.py can now have include files
2722 among the list of sources.
2724 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2725 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2726 * modifications in MSVC projects
2728 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2729 * As stated by the first lines of Test/ExceptionAndPython/README, it
2730 looks like we can move back to original usage of exception within
2731 src/gdcm* and hence remove the errno stuff that was introduced
2732 as a quick and dirty fixture of this problem (added to the TODO).
2733 * Doc/Doxyfile configuration file for Doxygen and corresponding
2734 README file for usage added.
2735 * Test/testWrite.cxx added. This new test comes from a split of
2736 test.cxx that is now reverted to its original purpous i.e.
2737 testing the proper parsing of a Dicom related file.
2738 testWrite.cxx concentrates on testing the IO part of gdcm.
2739 * Test/bug1.cxx (containing a bug on WIn32) added.
2740 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2741 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2742 whose purpose is to publish the content of the TagNames of the
2743 Dicom public dictionnary were not accessible without an
2744 instance of class gdcmHeader.
2745 - those methods are now static methods of gdcmDictSet and hence
2746 require no instances at all to be invocated.
2747 - within gdcmDictSet this change required to change some method
2748 to class methods (i.e. are now static) among which SetDictPath
2749 (renamed to BuildDictPath) and LoadDefaultPubDict.
2750 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2751 the above changes by calling the new method classes of gdcmDictSet.
2752 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2753 the above to be effective.
2754 * python/gdcmPython: in order to wrap properly the above changes
2755 for Python, swig version now needs to be > 1.3.17.
2756 * python/gdcmPython/Makefile fixed to adapt itself to new
2757 configure/make shema introduced by Johan Montagnat (thanks for the
2758 contribution). Alas this Makefile cannot be turned into a proper
2759 Makefile.am without some heavy changes in the configure.in
2760 (for python dectection).
2761 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2762 now avoids publishing the empty entries.
2764 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2765 * python/setup.py : bug fix concerning install under windows
2766 ExtraPath reused :-P
2767 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2769 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2770 * Dicts/dicomV3.dic : remove double spaces !!!
2771 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2772 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2775 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2776 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2777 method. Doxygenation.
2778 * src/gdcm.h clean up of JPR spurious comments.
2780 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2781 * python/distutilsSwigCPlusPlus.py now properly collects the
2782 shadow classes generated by "swig -c++" (gdcm.py in our case)
2783 when using "python setup.py install".
2784 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2785 reexports the working classes.
2786 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2787 by the classical C errno scheme. This is to prevent an obscure
2788 behavior of the python wrappers when importing wxPython.wx prior
2789 to gdcmPython (which ended up in an abort call). An illustration
2790 of this oddity can be found in the Test/ExceptionAndPython
2791 subdir (see the README file). This problem probably due to
2792 an combination of g++ and dynamic loading.
2793 * added Test/ExceptionAndPython (see above)
2795 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2796 * Changed the layout of the python part to avoid bloating main
2797 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2798 i.e. the distutils arsenal. All the python related stuff is
2799 again in a python subdir, but the package itself is now in
2801 * setup.py was cleaned up:
2802 - pythonIncludePath removed
2803 - python setup.py bdist target is now functional.
2804 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2805 collision with other packages). gdcmPython/demo/*.py changed
2808 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2809 * python subdir moved to gdcmPython (preparation of distutils packaging).
2810 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2811 distutils installer is operational.
2812 * - gdcmPython/__init__.py now properly loads the swig generated
2813 shadow classes (from gdcm.py).
2814 - gdcmPython/demo/*.py changed to import the package gdcmPython
2815 instead of gdcmPython/demo/load.py.
2816 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2818 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2819 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2820 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2821 entries within the associated public Dicom dictionary resp. the same
2822 information but sorted by the fourth field (PAT, IMG, DIR) of the
2824 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2825 are now in the "???" group.
2826 - python/gdcm.i changed accordingly,
2827 - python/demo/printGroupedPublicDict.py added, that gives an example
2828 of the above new functionalities in Python.
2830 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2831 * src/gdcm.h, gdcmHeader.cxx:
2832 - historic references to glib's g_malloc and g_free (#defined)
2833 were definitively removed.
2834 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2835 * src/gdcmElValSet.cxx:
2836 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2837 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2838 - GetElValue(string) renamed to GetElValueByName.
2839 - Added GetElementByName(string).
2840 * src/gdcmHeader.cxx: added
2841 - GetPubElValRepByNumber(guint16, guint16)
2842 - GetPubElValRepByName(string)
2843 - GetShaElValRepByNumber(guint16, guint16)
2844 - GetShaElValRepByName(string)
2845 - GetShaElValByNumber(guint16, guint16)
2846 - GetShaElValRepByName(string)
2847 - GetElValRepByNumber(guint16, guint16)
2848 - GetElValRepByName(string)
2849 - GetElValByNumber(guint16, guint16)
2850 - GetElValRepByName(string)
2851 * Doc/requirements.txt added.
2853 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2854 * Test/Makefile building now depends on the one of libgdcm.so
2855 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2856 pixel data) aware which enables finding the address (offset) of
2857 the pixel data of JPEG encoded DICOM files. This leaves only a single
2858 file in the testSuite whose pixel data address (offset) is unknown.
2859 * python/testSuite.py changed accordingly.
2861 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2862 * VC++ has some strong limitations when working with the STL, as stated
2863 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2864 "Also note that some STL containers (map, set, queue, list, deque)
2865 cannot be exported. [...]
2866 Some STL classes contain nested classes. These classes can not
2868 This is caused by a designed limitation that once a template
2869 class is instantiated, it can not be re-instantiated and
2871 Since our usage of map<> is ubiquitous in gdcm, this "designed
2872 limitation" of VC++ is a pitfall.
2873 Hence the Python wrappers of gdcm cannot be incrementally linked
2874 against the c++ dynamic library. The dirty but only workaround is
2875 to forget about incremental link of dynamic libraries and to generate
2876 the Python wrappers library with the inclusions of the underlying C++
2878 The following modifications concern this matter on Win32/VC++:
2879 - wrapping python correct with standalone wrapped dll (don't use separate
2880 dll under windows !!!!)
2881 - python21_d debug mode enabled (ask Frog how to use it :-)
2882 - NO problem with having an STL member of class for example string in C++
2883 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2884 - Python test of dcmlib in Python is ok under windows on a large set
2886 * removed glib references
2887 * typedef's inserted in gdcm.i for correct swig type management
2889 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2890 * python/demo/*.py load.py extracted from test.py. Added explore.py
2891 that only displays required tags and testAll.py that parses all
2892 the files of the testsuite without using unittest.
2893 * python/testSuite.py other additional test on new files added.
2894 * Data/* new test files added accordingly to the testSuite.
2895 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2896 the vr in the file differs from the one of the dictionary.
2898 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2899 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2900 values, but limits itself to values which are below a user specified
2901 size (by default 1024 bytes).
2902 * python/gdcm.i : elements not loaded (because their size is above the
2903 user specified treshold) are exported with their TagKey as key of the
2904 python dictionary. This enables the testsuite to make some checks
2905 on the unloaded elements (since we have their offset and size).
2906 * python/testSuite.py
2907 - now tests for the existence and proper value of the pixel data
2908 - two new examples added.
2909 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2911 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2912 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2913 aware. See the strategy comments in gdcmHeader::FindeLength().
2914 * Test/test.cxx now accepts a filename as first argument.
2915 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2916 * python/testSuite.py changed to integrate test on above files.
2918 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2919 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2920 the vr was also RET.
2921 * python/testSuite.py more tests added.
2923 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2924 * python/testSuite.py unittest test suite added (uses Data)
2925 * Data/* dcm and acr files for the test suite.
2926 * glib dependance removed from un*x version. We now use ISO C99
2927 7.18 Integer types (see stdint.h)
2928 - python/Makefile, src/Makefile src/gdcm.h
2929 * src/ when an explicit vr (like dicom files) suddenly poped an
2930 implicit element we use to mark the underlying DictEntry of the
2931 concerned ElValue with "Implicit". This strategy was damageable
2932 too the public or provite dictionaries, since some of their vr
2933 would be changed. Since Header::FindLength heavily relies on the
2934 detection by Header::FindVR of falsely explicit elements, I
2935 added an extra ImplicitVr member to ElValue (boolean).
2936 The rest of the changes we the necessary adaptations.
2938 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2939 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2941 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2943 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2944 * Adaptation for porting to VC++:
2946 o forced to use std namespace (for string to be known)
2947 o all class use __declspec export style on WIN32
2948 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2949 (in stdlib.h on Win32 but in std:: for gcc)
2950 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2951 variable GDCM_DICT_PATH.
2952 * src/gdcmHeader.cxx verbose comments made discrete.
2954 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2955 * python/gdcm.i: added a typemap that converts a C++ hashing table
2956 to native Python dictionary.
2957 * python/demo/test.py:
2958 - now uses the native dictionary for exploration of gdcmHeader.
2959 - takes an optional filename argument (the file to parse).
2960 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2961 PubElVals hashing table.
2962 * Dicts/dicomV3.dic removed error prone trailing spaces.
2964 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2965 * Python wrapping process moved away from src/Makefile to
2966 newly created python/Makefile (as well as gdcm.i)
2967 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2968 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2969 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2970 from the environement variable GDCM_DICT_PATH (when existing).
2971 * src/gdcmDict::GetTag bug fix.
2973 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2974 * Straightforward temporary fixes for swig to build the python wrappers.
2975 src/Makefile now has a python working entry [by working we mean
2976 that we can import de shadow classes without errors].
2978 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2979 * hashtest.cxx removed (since already in Test)
2980 * src/gdcmlib.h renamed to src/gdcm.h
2981 * src/dcm.i renamed to src/gdcm.i
2982 * src/Makefile prepared for python wrapping
2984 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2985 * src/gdcmHeader.cxx :
2986 - Parsing of header is now separated from loading of element values
2987 (see gdcmHeader::LoadElements).
2988 - general clean up of hopefully all file access (creation of
2989 ReadInt16 and ReadInt32)
2991 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2992 * src/gdcmHeader.cxx :
2993 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2995 - SetLgrElem renamed to SetLength
2996 - GetLgrElem renamed to GetLength
2997 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2998 * src/gdcmElValSet.cxx fixed both GetElValue methods
2999 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3000 due to IdoDude was cleaned out.
3002 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3003 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3004 concentrates on finding the value representation (when it exists).
3005 RecupLgr now only finds the element value length, and it avoids
3006 returning the unecessary skL (skipped length).
3007 Also, offsetCourant was simply removed (with taille_fich) since
3008 it was redundant with the File position internals (by using
3009 ftell and fseek). This also made skL (see above in RecupLgr) usage
3011 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3012 on the libido specificities which are handled through class
3014 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3017 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3018 * Truckload of changes. Parsing of header is barely functional
3019 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3021 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3022 * src/gdcmHeader.cxx many addons of low level methods
3024 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3025 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3026 and _IdDcmSWAP_LONG.
3028 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3029 * This corresponds to all the changes decided at the meeting of
3030 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob