1 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
2 In ordrer to avoid missbehaviour :
3 . gdcm::DocEntry is now specialized in
4 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
5 - gdcm::ContentEntry (Dicom entry with a 'content')
6 . gdcm::ContentEntry is specialized in
7 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
8 characters value, or integers)
9 - gdcm::BinEntry (Dicom entry with a non strig representable value
10 (user hasn't any longer to thing about the precedence of his dynamic_casts)
12 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * Test/VTKTest*.cxx : bug fix under linux
15 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
17 use with python. Some methods are moved from Document to ElementSet or
18 DocEntrySet. The equivalent methods to ElementSet have been added to
19 SQItem and are virtual in DocEntrySet. Methods that may have the same code
20 in SQItem and ElementSet is directly placed in DocEntrySet
22 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * Test/VTKTest*.cxx : remove the show variable in each test method because
24 it's useless (the viewer variable replace this variable)
26 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * src/gdcmDocument.cxx : bug fix on potential memory leak
28 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
29 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
30 Add ClearXxx methods to remove all the content of the list or map
31 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
33 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
34 * methods ReplaceOrCreate renamed as Insert
35 (nobody will be any longer confused by 'CreateOrReplace')
37 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
38 * Grealty simplify the JPEg decompression, no need to differenciate based on
39 the JPEG possible type (with/without fragment, with/without multiple frame).
40 Everything is done throught the JPEG IO Suspension mechanism in IJG
42 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
43 * Stage 3 of normalization :
44 in order to avoid any missunderstanding while reading method names :
45 - All the methods xxxEntry now deal with dicom Entries
46 - Methods GetEntry splitted into
49 - Method SetEntry renamed as SetEntryValue
50 - Method SetEntryBinArea let as it was
52 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
53 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
54 - Position correctly the entry points for JPEG2000 and JPEG-LS
55 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
57 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
59 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
60 with other method names
61 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
62 * Test/TestDicomDirElement.cxx : add new test
64 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
65 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
66 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
67 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
68 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
69 So can't you use __int64 in ostream at all.
71 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
72 * bug fix for compilation on MSVC6
73 * gdcmPython/gdcm.i : rename of classes missed
75 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
76 * Stage 2 of names normalization :
77 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
78 (easy to understand ...)
79 - gdcm::FileHelper replaces old class gdcm::File
81 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
83 type and not a string. So, there remove problems on the format of the
86 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
87 * Add Example/TestPapyrus.cxx
88 - reads a Papyrus file (gdcm::Header compliant),
89 - gets the pixels of all the images, using low level iterators
90 - writes an multiframes Dicom image.
91 (Just to show it's *possible* to do that)
92 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
95 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
97 Thus, DicomDirXXX are created with a flad that indicates if the created
98 object is empty or not (when not empty, the DicomDirElement is used to
101 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
103 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
105 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
108 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
110 Remove all access to the hash-tables or lists in the objects.
112 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
114 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
115 be complient with all the gdcm source code
117 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
121 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
125 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * Test/ : rename VTK tests to have a best name for the tests
127 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
128 GetFirstEntry/GetNextEntry use
130 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
131 * In SerieHeader::ImagePositionPatientOrdering()
132 // a Dicom 'Serie' may contain scout views
133 // and images may have differents directions.
134 // -> More than one may have the same 'pos'
135 // Sorting has then NO meaning !
136 Thx to Eduardo Davila for reporting bug.
138 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
139 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
140 test. Now it's on image content and not on the resulting visualisation...
141 might solve the problem on linux when using the OpenGL drivers
143 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
144 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
145 DicomDirSerie, DicomDirImage
146 Dict, DictSet classes :
147 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
148 -remove InitTraversal method.
149 * UPD Test programs + Example programs
151 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
152 * remove useless and never updated keyword \ingroup
153 * Solve pb when structure (list, map, ...) is empty.
154 Thx to Benoit for reporting bug
156 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
157 * Taking into account of 'Transfer Syntax' value
158 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
161 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
163 is no memory access violation
164 * gdcmPython/demo : add python demos using VTK
166 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
167 * FIX 'Dictionnary' is now spelt 'Dictionary'
168 'wether' is now spelt 'whether'
169 'archieve' is now spelt 'archive' ;-)
171 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
172 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
173 related methods, in order not to expose internal mechanisms
176 * REM methods that exposed internal mechanisms :
177 DicomDir::GetDicomDirPatients()
178 DicomDirPatient::GetDicomDirStudies()
179 DicomDirStudy::GetDicomDirSeries()
180 DicomDirSerie::GetDicomDirImages()
181 * UPD Test programs :
185 * UPD Example program
187 * ADD DictSet methods
191 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
192 * Removed the Print/indent/default parameter mess. There is absolutely no
193 reason to have to methods, moreover with the second taking the ostream as
194 *SECOND* parameter. This was clearly a bad hack to get things compile.
196 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
197 * Complete rewrite of the GetMacAddress code. Now the code is *much*
198 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
199 Unfortunately the main code does not work on SunOS, thus provide a specific
200 code for this platform only (and Win32 of course). Since this seems to be
201 working, change CreateUniqueUID to use GetMACAddress instead of the
202 problematic GctestetIPAddress
204 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
205 * Unfortunately to be able to test gdcmDirList I had to break the API
206 a little. Now the class is not a std::list anymore but has a member
207 std::vector (more ITK compatible). Allow unit testing on Win32 and
210 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
211 * Update SerieHeader to take into account a Serie Instance UID to properly
214 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
215 * ENH - Comment out Mathieu's (dangerous) Super Hack
216 for dealing with BIGENDIAN processors
217 - Move equivalent stuff to BinEntry::WriteContent
218 When necessary, 16 Bits Pixels are swapped in a small buffer
219 and then written. This avoid allocating a huge buffer, in
220 PixelWriteConvertor, and avoid modifying the Pixel Area.
222 Probabely, the same operation will have to be done when we want
223 to write image with Big Endian Transfert Syntax,
224 and we are working on Little Endian Processor
226 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
229 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
230 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
231 all the dict content.
232 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
234 * Test/TestDict.cxx : add a new test for the dict classes
236 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
237 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
238 file. Debug is yanked if compiled with NDEBUG
240 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * src/gdcmDictSet.h : set the default output to the os variable
242 * src/gdcmDictEntry.[h|cxx] : add the Print method
243 * gdcmPython/demo/ : add a new test
245 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
246 * merging of Test/PrintDicomDir and Test/TestDicomDir
247 * removal of now redundant Test/PrintDicomDir
248 * enhancement of Example/PrintDicomDir
250 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
251 * Now, python test might work on systems
252 * Add the PrintDicomDir test
254 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
255 * FIX : First entry following group 0002 was lost for
256 Explicit Big Endian Transfer Syntax files
257 (group and elem not swaped)
259 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
260 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
261 Big Endian Transfer Syntax supposed the group following 0002
262 begins always by element 0000 (element 0000 is *optional*)
263 To avoid further troubles, let's be pessimistic, and use
264 Document::HandleOutOfGroup0002() method
265 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
266 (related pb not yet solved)
268 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
269 * Bug fix for the python part use
270 * Now, PrintHeader.py pass... but outside the ctest use. shit !
272 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
273 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
275 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
276 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
277 a string and should ask the global TS dict what are the propreties of
280 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
281 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
282 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
283 to swap the Swap Code, at parsing time, when we come out of group 0002
284 and Transfer Syntax is Big Endian
285 We should be able to read now 'true DICOM" Big Endian coded images
286 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
287 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
289 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
290 * Hopefully fix the bug on MacOSX and static global initialization.
291 This is the only -minor- patch I found that both please MacOSX and VS6.
292 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
293 but this would require a lot of change. Another approach would be that Global
294 create those string and GDCM_UNFOUND becomes a pointer to a string (which
295 gdcm::Global would destroy at exit).
297 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
298 * Fix bug on MacOSX with static initialization in a multy threaded
299 environment. static const string in a header file used to be ill
300 initialized provoquing the freeze of any tests. patch should solve this
303 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
304 * According to Benoit's suggestion, and without any objection from anybody
305 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
306 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
307 - method gdcmDicomDirObject::GetEntry() renamed as
308 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
310 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
311 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
312 you debug/warning message just as c++ streams which make them very convinient
313 to use. Once this is stabilize I will change the ostringstrem to be
314 redirected to a file (ofstream).
315 * Properly support C99 extension: __FUNCTION__ which allow us to display
316 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
318 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
319 * Removal of useless and dangerous methods :
320 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
321 GetDocEntryByName, GetEntryByName, GetDictEntryByName
322 * Removal of usless methods :
323 Dict::PrintByName, Dict::GetDictEntryByName
324 * Commenting out of probabely useless methods :
325 Dict::GetDictEntryNames()
326 Dict::GetDictEntryNamesByCategory()
327 DictSet::GetPubDictEntryNames()
328 DictSet::GetPubDictEntryNamesByCategory()
329 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
330 * ENH : Use dicomTS.dic as described in 2004 version
331 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
332 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
333 Add Accessors on VM (Value Multiplicity), and VM related methods
334 * ADD : Add a list of 'Dicom Attribute types', as found in
335 http://medical.nema.org/dicom/2004/04_15PU.PDF
337 * ADD : Add dicomGroupNameAbbreviations.dic
338 should be used to write a method to replace the former
339 Dict::GetDictEntryNamesByCategory()
341 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
343 to read in the file... and only it ! Length is the efective length of the
344 data in the DocEntry structure
346 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
347 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
348 And now use a static function call instead, with a global variable. i
349 This is much closer to the VTK approach. Hopefully should be bulletproof
350 and easier to use...hopefully
352 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
353 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
355 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
356 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
358 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
359 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
360 ValEntry, BinEntry, SeqEntry creation or replace
362 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
364 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
366 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
367 when specifying the VR
368 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
369 * src/gdcmDocEntry.cxx : amelioration of print
371 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
372 * ADD : Add the method Util::IsCurrentProcessorBigEndian
373 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
374 * ADD Method Document::ComputeGroupLength
375 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
376 in order to allow further VR modification by user
377 * REM : removal of once-called method File::WriteBase
378 integration of its code in formerly one-line method File::Write
380 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
381 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
382 replace the different values "??", "Unkn", "Unknown".
383 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
384 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
385 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
386 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
388 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
389 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
391 * Set the gdcm::Base class to some Printable classes
393 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
394 * src/gdcmFile.[h|cxx] : add the Print method
395 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
396 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
397 * src/gdcmDocument.h : remove the PrintLevel informations
398 * Example/PrintFile.cxx : use the new gdcm::File::Print
400 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
401 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
402 problems when compiling with the python wrapping
404 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
405 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
406 writting in ImplicitVR
408 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
409 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
410 JPEG decompression, especially when dicom frames are split into several
411 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
412 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
414 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
415 * src/gdcmHeader.cxx : change the initialisation of default header.
416 Now, this header is readable by gdm, e-film, DicomWorks
418 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
419 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
420 Rename Decompressed to Raw
421 * Use the API changes in gdcm::File.
422 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
425 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
426 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
427 each added entry in the header. Replace the 'Planes' field by the 'Number
430 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
431 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
432 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
434 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
435 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
436 At this time, this image isn't readable by e-film... waiting JPR help to
439 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
440 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
441 DocEntry. Now use methods of the Document !
443 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
444 * Test/ShowDicomSeq.cxx : bug fix
446 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
447 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
448 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
449 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
450 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
452 * Test/TestCopyRescaleDicom.cxx : remove unused variable
453 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
454 containing found sequences
456 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
457 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
459 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
460 Some fields in BinEntry must be copied to not seg fault when making the :
461 gdcm::File *copy = new gdcm::File( copyH );
462 and tests are now made on good variables
464 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
465 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
466 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
468 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
469 * Add vtkGdcmWriter example and test
471 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
472 * Test/TestUtil.cxx : reformat the source code
473 * vtk/vtkGdcmReader.cxx : remove and change prints
474 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
476 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
477 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
479 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
480 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
481 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
483 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
484 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
485 by an eof to prevent all bad read of the file... and in this case, the
488 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
489 * Example/Volume2Dicom.cxx : comment unused variables
490 * Test/PrintDicomDir.cxx : comment unused variables
491 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
492 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
493 method that is redondant with AddEntry.
494 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
497 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
498 * Bug fix due my last commit (compilation under Windows).
499 * Example/Volume2Dicom : bug fix in the file and reformatting source code
500 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
502 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
504 - Remove printf / sprintf
505 - include iostream AFTER gdcm so we don't get warnings
506 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
508 - Also remove tons of include from header files, hopefully this should
509 speeup the compilation time, since it was becoming a dog slow.
510 - Remove gdcm.h as it include way too many files and slow down compilation
511 (plus it is not up to date)
512 - remove 'using namespace std' this is BAD !
514 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
515 * Remove memory leaks on the DicomDir
516 * Remove some useless data in DicomDirObject
517 * Add usefull methods in SQItem, to be complient withe the ElementSet
519 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
520 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
522 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
523 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
524 future, with convertion)
525 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
526 and ImageDataSize values. Remove the method to get the PixelReadConverter
527 from the output of the class
529 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
530 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
532 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
534 and vtkErrorMacro use.
535 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
537 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
538 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
540 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
541 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
542 The string leaves only in the fonction. So when we make a .c_str(), we
543 get the pointeur on the first element, element that will be destroyed
544 immediately after thee instruction.
545 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
546 file has been opened : the test must be made on the content of the
547 pointer and not directly on the pointer !
550 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
551 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
552 the python part recompiles
554 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
556 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
557 X session is killed (for my computer... it seems to not be identic on
560 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
561 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
562 avoid problems (otherwise, the difference test between the visible image
563 and the reference is incorrect. If the reference is greater than the
564 screen resolution, it's produce errors).
565 Can be used for only one image. Can be used with a visible flag.
566 * vtk/vtkGdcmReader.cxx : remove commented codes.
567 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
568 under windows at compilation
569 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
571 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
573 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
574 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
575 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
576 tests on the image size X, Y, Z
578 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
579 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
580 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
581 between the class name and the file name
583 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
584 * src/ : fix compilation warnings for the Write method (2 different
585 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
586 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
587 variable... create a static method in gdcm::Document to access to
588 this variable content.
590 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
591 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
592 file, to be accessed by other files (like gdcmFile). Remove commented
593 code. Move the change of the header to the gdcmFile, using the
595 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
596 To be sure of that (and simplify calls), the Write of the header now
597 gets a file name and not a file pointer (std::ifstream).
598 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
599 DocEntryArchive. Remove all open of the written file
601 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
602 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
604 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
605 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
606 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
608 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
609 some corresponding methods. Write correctly the file and check before
611 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
612 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
613 is now on RGB data (as before my last commit
614 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
616 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
617 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
618 Add a print information of the type of the entry
619 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
620 It was in the gdcmFile, and all write have been regrouped
621 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
622 Write correctly all dicom files (in decompressed mode only at this time)
623 * Test/ : test on files are now made using Raw data and not color data if
625 * Example/PrintFile.cxx : add more printings
627 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
628 * Amelioration of code, remove some code copy. For the loading of
629 BinEntry (in gdcmDocument), add the test to verify if the file is already
632 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
634 remove a DocEntry in the header (push an empty DocEntry)
635 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
636 lines. Bug fix in the initialization of the PixelConvert and the
638 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
639 use in TestCopyDicom (now this test can run under windows... but fails)
640 * Test/TestCopyDicom.cxx : amelioration of the test :
641 - test the pixels written
642 - add test points to quickly find where is the error
643 - can set a file name input and output in arguments
644 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
645 amelioration of the test output
647 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
648 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
649 all replaced DocEntry's
650 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
651 Now, each needed DocEntry to modify is duplicated, modified and inserted
652 to the header using DocEntryArchive. Thus, after save, we can restore the
653 header initial state.
655 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
656 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
658 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
659 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
660 correct to copy it. The DictEntry is specified at the DocEntry creation,
661 then, it musn't change in the time.
662 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
663 header correctly. At this time, the change is only made for the first
664 level of the Document. In the future, it might consider sequences.
665 The change is made by replacing a DocEntry by an other that is created
666 outside the class. The old value is kept. When we restore the header
667 status, the added DocEntry is deleted and replaced by the old value.
668 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
669 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
670 set the write type to explicit VR, implicit VR or ACR. Add methods to set
671 the write mode to native, decompressed or RGB (but not used at this time)
673 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
674 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
675 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
677 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
678 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
679 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
681 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
682 set because already copied when copying the BinEntry's of the header
683 * Test/TestAllReadCompareDicom.cxx : remove warnings
685 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
686 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
687 Two problems appear when doing it :
688 - with the gdcmFile : when the GetImageData method is called, the pixels
689 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
690 data (pixels). And each structure destruct the data when it's
691 destructed. So we have two destructions for the same data. To solve it,
692 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
693 data or not. If it doesn't own data, then they will not destroyed by
695 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
696 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
697 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
698 create a double destruction of the same DocEntry's. So, to solve it,
699 the TagHT is simply cleared and the DicomDir* elements are destroyed.
700 * TODO : add an entry concerning memory leaks in the DicomDir
702 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
703 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
704 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
707 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
708 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
709 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
710 after it have been deleted
712 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
713 * FIX: src/* fix the doxygen warnings.
714 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
715 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
716 was erroneously defined with a size of 15 instead of 16. [many thanks
717 to Jean Michel Rouet for pointing out this bug].
719 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
720 1. Finish merging JMR patch for writting DICOM from scratch
721 2. Fix -hopefully- bug with MONOCHROME and space vs null character
722 3. Use const ref when possible
723 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
724 5. A few more comments
725 6. CreateUniqueUID can now be called without parameter"
727 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
728 * ENH: Slightly bigger patch:
729 1. Getting toward full integration of JMR patch for writting dicom from scratch
730 2. Update Test to test part of this patch: CreateUniqueUID
731 3. File was not close properly in gdcmDict
732 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
733 5. Use of const ref instead of copy (speed issue)
734 6. Remove temporary (duplicate) string in TranslateToKey
735 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
736 8. Do not repeat virtual in subclasses
737 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
739 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
740 * Apply first patch toward better string comparison when dealing with broken
741 DICOM files. Essentially the string could be padded with a space instead
742 of a null character as defined by standard
744 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
745 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
746 because never used... and in the same time, that's remove some memory leaks
748 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
749 * src/gdcmFile.cxx : now delete the PixelConvert instance.
750 * In examples and tests : change the type of image data variables from void*
751 to uint8_t*. Remmove all delete on image data variables
753 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
754 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
755 Verify the file pointer value before open the file, and if it's not null,
756 a verbose message is generated.
757 Close correctly the file when the file isn't considered dicom-like. The
758 correctly close is a call to CloseFile.
759 When closing the file pointer, test if its not null to close the file.
760 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
761 file. For an uncompressed image, the copied data correspond in the least
762 case to the image size (calculated) or the image size specified in the
763 header. A verbose is generated if these two size mismatch
765 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
766 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
767 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
768 break under windows (with msvc6 compilation).
770 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
771 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
772 compiling with MSVC6)
774 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
775 * Bugs fix for the Windows build with VC6
776 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
777 needed (only for projects required VTK). If the VTK is included in all
778 projects, there is conflicts with the jpeg lib of vtk when compiling the
779 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
780 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
781 when compiling the gdcm_wrap.cxx file (created by the compilation of the
783 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
784 (like it's already made for the cout use). Otherwise, conflict with the
787 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
788 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
790 - comments on the DicomDir::Method related usage added.
791 - now that we use the namespace gdcm, a lot of internal classes do
792 NOT need to be wrapped anymore.
793 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
794 DicomDir::Method) new example added.
796 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
797 * Improve string manipulation. I now inforce the notion of 'DicomString'
798 A DicomString can contain as many \0 as they want
799 and it is *always* of even length.
800 We only support odd length for very rare case.
801 And in the near future this should be removed.
803 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
804 * /binary_write/ gdcm source. Now even on big endian we are writting
805 little endian. This should -heopfully- fix some tests
807 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
808 * Now the dictionary is compiled into gdcm lib. This is a default
809 behavior, thus any dic file specified is picked before failback to
810 the one comiled into lib
812 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
813 * Change internals for gdcmDict. Don't use any 'new' any more.
814 This should definitely solve any leak problem, and we should be
815 as fast as before, as long as don't modify too much the dictionary.
817 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
818 * STYLE: ivars should start with a capital letter.
819 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
820 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
822 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
823 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
824 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
825 new 2004 dictionaries added (thanks to JPR).
826 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
827 * CLEANUP_ROUND (15) for gdcmPixelConvert
828 - RLEFrame::NumberFragments is now of type unsigned int
829 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
830 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
833 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
834 * Initial work in gathering all transfer syntax accessors. clearly
835 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
836 ivars, but only one transfersyntax (class) ivar with equivalent method on
839 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
840 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
841 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
842 discussed (plus I didn't like having a 2000 lines patch not commited)
844 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
845 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
846 * CLEANUP_ROUND (14) for gdcmPixelConvert
847 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
848 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
849 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
851 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
852 anymore and hence avoids storing a copy of PixelConvert::Decompressed
853 into File::Pixel_Data.
855 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
857 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
858 * CLEANUP_ROUND (13) for gdcmPixelConvert
859 Substituted File::ParsePixelData() with PixelConvert::Print() new
861 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
862 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
863 method to those classes.
864 - src/gdcmFile.[cxx|h]:
865 -- Added a ::Print() method.
866 -- PixelConverter is now a reference instead of a member.
867 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
868 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
870 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
871 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
872 collaboration diagram and inheritance diagram should be generated with
874 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
875 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
876 pointlessly wrapped (see
877 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
878 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
879 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
880 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
881 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
882 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
883 -- File::Initialise: PixelConverter setup moved away to
884 PixelConverter::GrabInformationsFromHeader()
885 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
886 interpretation moved away to PixelConverter::BuildRGBImage()
888 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
889 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
890 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
892 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
893 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
894 displayed on Win32 when a brutal abort() occurs (because of uncatched
895 exception). See TODO new entry of this commit for more on this.
896 * TODO added new entry.
897 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
898 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
899 - HandleColor is no longer called from gdcmFile.cxx
900 - gdcmPixelConvert.cxx clean up on method arguments and internal
901 variable names for semantical coherence.
903 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
904 * Finished lossless transition, not only do we now read all lossless jpeg
905 images, without the need of the Cornwell lib, but we do read them properly now
906 * To reduce code (well to avoid code duplication), I defined a common place
907 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
908 redefine symbols. This is not perfect but this the best solution I found for a
909 compilation time jpeg option.
911 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
912 * Update jpeg ijg lib to support lossless jpeg implementation
913 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
915 * Also added a special copyright for dcmtk since we use their bugfixes.
918 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
919 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
920 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
921 matters, as stated in warning note at begining of %include section).
922 * src/gdcmDicomDir*.[cxx|h]: coding style
923 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
924 * src/gdcmJpeg8.cxx: doxygen fix.
925 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
926 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
927 from File:: to PixelConvert::.
929 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
930 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
931 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
932 - more code moved away from File:: to PixelConvert::
933 - fat setup of PixelConverter set in place in File::Initialise.
935 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
936 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
937 namespace at the file system level. So now you should convert your examples
939 gdcmHeader -> gdcm::Header
940 It would be nice if people keep in mind to no open the namespace, since it
941 allows compilation on broken plateform which were defining common symbol in
942 the standart namespace (like LP, Unknown ...)
944 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
945 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
946 The JPEG fragments are now parsed at the same stage than the RLE
947 information. All code related to JPEG is now in gdcmPixelConvert:
948 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
949 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
950 export a gdcmFile:: method. Those are simply global functions
951 (for the time being this is better than having them attach to
952 either gdcmFile:: or gdcmPixelConvert::).
953 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
954 and stores the result in a gdcmJPEGFragmentsInfo.
955 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
956 code (among other stuff) moved away from gdcmFile:; to
959 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
960 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
961 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
962 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
963 clean up of RLE related code.
964 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
965 - src/gdcmRLE.cxx removed
966 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
967 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
968 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
969 * CLEANUP_ROUND (9) for gdcmPixelConvert
970 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
971 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
972 away from gdcmFile:: to gdcmPixelConvert::.
974 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
975 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
976 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
977 This is because Parse7Fe0 used to parse the pixels to compute the
978 length. This task was passed over to FindDocEntryLengthOB() a long
979 time ago, EXCEPT I had forgotten the OW case...
980 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
981 we just recylce the code for parsing RLE fragments and computing
983 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
984 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
985 with the retired Parse7Fe0().
986 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
987 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
989 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
990 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
991 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
992 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
993 - src/CMakeLists.txt: alphabetic order reodering + new entries.
994 * CLEANUP_ROUND (4) for gdcmPixelConvert
995 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
996 to return an unused length.
998 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
999 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1000 this should be cleanner from the plane view. The iostream are erally a pain
1001 to use to do simple stuff.
1003 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1004 * Redo the compilation of the ijg jpeg library. Now only one source is
1005 necesseray. No need to rename file by hand what so ever. CMake handle the
1006 copying of the file within different directory, configure header file to
1007 modify some symbol. The only addition made to ijg wasd a mangle table so
1008 that symbol are different whether we are within 8bits or 12bits.
1010 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1011 * Added documentation of vtkgdcmReader on Website:
1012 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1013 with it's binary name).
1014 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1015 the Website to be more complete.
1016 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1017 doxygenated documentation.
1018 - Doc/DoxyVtkGdcmReaderExamples.txt added
1019 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1020 DoxyVtkGdmReaderExamples.html )
1021 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1022 * CLEANUP_ROUND (3) for gdcmPixelConvert
1023 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1025 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1026 * CLEANUP_ROUND (2) for gdcmPixelConvert
1027 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1029 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1030 * CLEANUP_ROUND for gdcmPixelConvert:
1031 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1032 - src/gdcmPixelStuff[h|cxx] removed
1033 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1034 - src/CMakeLists.txt changed accordingly
1035 * GDCMHOME clean up:
1036 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1037 gdcmVersion.py moved to newly created ATTIC related
1038 gdcmPython/SetupOldies/ directory.
1039 * Autotools clean up:
1040 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1041 - autogen.sh configure.in acinclude.m4 python.m4 removed
1043 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1044 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1045 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1046 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1048 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1049 * TODO updated with Mathieu suggestions. I proposed a template for
1050 describing TODO entries and used it for new entries.
1051 * Added Doc/Website/CodingStyle.html, Developpers.html,
1052 DeveloppersPython.html, GdcmDataCvs.html and
1053 DownloadVersion0_1.html, DownloadVersion0_3.html.
1054 * Some Doc/*.txt Doxygen files (which do not really concern the
1055 documentation itself, but the website) moved to html and
1056 placed in directory Doc/Website:
1057 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1058 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1059 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1060 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1061 * CMakeLists.txt changed accordingly.
1062 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1063 DeveloppersPython.html
1064 * INSTALL nows refers to Doc/Website/Installation.html
1066 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1067 * Added Doc/Website directory, that contains a first raw version
1070 2004-09-23 Jean-Pierre Roux
1071 * FIX In order not to be poluted any longer by casting problems,
1072 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1073 we can now delete[] it safely
1074 * VoidArea is now called BinArea (less confusing name),
1075 and all the methods called ...VoidArea... are now ... BinArea...
1076 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1078 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1079 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1080 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1081 up to the destructor of gdcmElementSet to clean up TagHt and it's
1084 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1085 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1086 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1088 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * ENH: added some utility method that builds a flat dictionary
1090 holding all the Dicom entries contained in the recursive structure
1091 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1092 an example of usage.
1093 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1094 BuildFlatHashTable() that build a flat dictionary.
1095 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1096 gdcmDocument is now a friend of gdcmElementSet.
1097 - src/gdcmElementSet.cxx: clean up.
1098 - Example/FlatHashTablePrint.cxx added.
1099 - Example/CmakeLists.txt changed accordingly
1101 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1102 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1103 moved away from gdcmDocEntrySet (since this class is an abstract class
1104 acting like an interface). SQDepthLevel and BaseTagKey are now
1106 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1107 and associated accessors. Doxygenation of the class.
1108 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1110 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1111 Use SQDepthLevel accessor instead. ::Print() adapted.
1112 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1113 - src/gdcmDocument.cxx changed accordingly.
1115 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1116 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1117 - The following is the doxygen comment of the typedef declaration
1118 of gdcmTagKey in src/gdcmCommon.h:
1119 gdcmTagKey is made to old an "universal" (as in URL, Universal
1120 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1121 A dicom tag always has a group and an element, but a set of tags
1122 embeded in various (optionally nested) sequences and sharing
1123 the same group and element all share the same (group, element)
1124 "identifier". Hence the (group, element) cannot be used as an
1125 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1126 In order to construct a proper tag identifier (i.e. a key) we
1127 consider the following definition of a TagKey:
1128 - let Group, Element be the string representation of the
1129 group and element dicom tag members,
1130 - let ItemNumber be the string representation of the integer
1131 index of the considered item number of a sequence,
1132 Let the key of a tag embeded in a sequence, noted SeqTag, be
1134 /ItemNumber#Group|Element
1135 where "/", "#" and "|" are characters acting as separators.
1136 Then the general form of a gdcmTagKey is given by:
1137 Group|Element<SeqTag>
1138 where <SeqTag> means NO or many instances of SeqTag.
1139 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1142 but the gdcmTagKey of a tag "embeded" is the first item of
1143 a sequence, itself nested in the third item of a sequence is the
1145 0004|1220/2#0008|0082/0#0008|0090
1146 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1147 order to hold the new sequence compatible key. Previously, the
1148 GetKey() method would look in the underlying gdcmDictEntry.
1149 - src/gdcmDocEntry.cxx:
1150 -- constructor now copies the underlying DictEntry key, in the local
1152 -- ::Print: displays the member Key, instead of the (group, element).
1153 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1154 - src/gdcmDocEntrySet.h:xi
1155 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1156 -- now has a new BaseTagKey member.
1158 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1159 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1161 This poses the problem with the semantics of the following lines
1162 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1163 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1164 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1165 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1166 to the long FIXME note for what the problem is. Nevertheless in
1167 order to get things working the dicom dictionary was altered !
1168 Please fix things urgently...
1169 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1170 information), see above note on moving the member VoidArea. Nevertheless
1171 the following entries previously correctly set as US are now inproperly
1173 0028 1201 OW IMG Red Palette Color Lookup Table Data
1174 0028 1202 OW IMG Green Palette Color Lookup Table Data
1175 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1176 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1177 of gdcmDocEntry moved to gdcmSeqEntry.
1178 * src/gdcmSeqEntry.cxx: STYLE.
1180 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1181 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1183 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1184 * gdcmPython/testSuite.py: all the test suite in python is now moved
1185 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1186 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1187 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1189 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1190 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1191 to avoid inclusion recursion until STL is reached.
1192 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1193 mecanism. errno.h is not included in gdcm anymore.
1194 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1195 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1197 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1198 gdcmData/TestAllEntryVerifyReference.txt
1199 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1200 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1201 exception_on_error parameter.
1202 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1203 - vtk/vtkGdcmReader.cxx changed accordingly,
1204 - Example/*.cxx and Test/*.cxx changed accordingly.
1206 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1207 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1208 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1209 enable_sequences removed from gdcmHeader constructor and dependencies.
1210 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1211 * gdcmPython/demo/PrintHeader.py: dummy fix.
1212 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1213 skip_shadow removed from gdcmHeader constructor and dependencies.
1214 * Example/*.cxx and Test/*.cxx changed accordingly.
1216 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1217 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1218 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1220 2004-07-21 Jean-Pierre Roux
1221 * FIX Now, Parsing and Printing a DICOMDIR do work!
1222 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1224 2004-07-20 Jean-Pierre Roux
1225 * FIX Some brain damaged headers have Zero-Lenght fields
1226 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1228 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1229 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1230 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1231 variable (instance of gdcmDebug) by a definition macro, and the instance
1232 is now in static in the gdcmDebug class
1233 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1234 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1236 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1237 * WARNING: ctest now depends more tightly on gdcmData. You should
1238 check out gdcmData properly for things to run smoothly...
1239 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1240 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1241 we need the pixels not be loaded in order to use the ValEntry
1242 that displays position and size).
1243 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1244 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1245 be deprecated. If you have any doubts about the advantages of a
1246 modern scripting language (read Python) versus grass root C++ (i.e.
1247 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1248 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1249 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1250 Anyhow, consider documenting the gdcmData images in
1251 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1253 * Test/CMakeLists.txt:
1254 - now uses TestAllEntryVerify.cxx
1255 - specific comments on oldACR00001.ima (now renamed in gdcmData
1256 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1257 gdcmData/TestAllEntryVerifyReference.txt
1260 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1261 * src/*.[h|cxx] : typedef clean up
1262 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1263 - TagKey renamed to gdcmTagKey (for external usage)
1264 - VRKey renamed to gdcmVRKey (for external usage)
1265 - removal of typedef duplication.
1266 - Removed all unecessary inline keyword from class inline definitions.
1267 - Some method|function(void) declarations replaced with method|function().
1268 * src/jpeg/libijg12/jdhuff12.c:
1269 - printf polluting ctest removed.
1270 - TAB removal for comminting
1272 - TestAllReadCompareDicom.cxx: added a test that compares all the
1273 images in gdcmDataImages.h with corresponding images in
1274 gdcmData/BaselineDicom/. When baseline images are not present
1275 this test creates them.
1276 Note: we need to validate each reference image, but before that
1277 I'd like to rename them with a more explicit name...
1278 - CMakeLists.txt: changed accordingly.
1279 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1280 including each header needed).
1282 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1283 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1284 test suite to the Example directory. Are concerned:
1289 - TestWriteSimple.cxx
1290 * Test/CMakeLists.txt: added some comments on reasons for black listing
1291 image gdcmData/oldACR00001.ima
1293 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1294 * Test/CmakeList.txt: removed the following from black list (to be coherent
1295 with removal from gdcmData):
1296 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1297 - gdcm-MR-PHILIPS-16.dcm
1299 Added the following because after last cvs update, they cause
1300 ctest -R TestReadWriteReadCompare
1302 - gdcm-MR-SIEMENS-16-1.acr
1304 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1305 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1306 new comments in this file) we temporarily (sigh) move to a weaker
1308 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1309 we don't need to black list the following images anymore:
1310 - 8BitsUncompressedColor.dcm
1312 - US-PAL-8-10x-echo.dcm
1313 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1314 fixes and the beautified code ;-)
1315 This fixes the bug introduced in version 1.42 (when beautifying)
1316 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1317 Note: ctest was blind to this bug (this means we need to still
1318 improve the test suite). The bug could be detected by using
1319 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1321 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1322 and by displaying the (garbage) produced file temp.XDCM...
1324 2004-06-29 Jean-Pierre Roux
1325 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1326 - replace by uggly but working old code :-(
1327 A lot of things should be OK again.
1328 It's really urgent to have a test suite that *tests*,
1329 to prevent Frog's beautifying sessions to break all the stuff
1330 (twice, withing a fortnigh ...)
1332 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1333 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1334 redundancy) to added Test/TestReadWriteReadCompare.cxx
1335 * Test/CmakeList.txt: because the compare test of
1336 Test/TestReadWriteReadCompare.cxx fails, the following images are
1337 black listed: - 8BitsUncompressedColor.dcm
1339 - US-PAL-8-10x-echo.dcm
1340 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1341 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1342 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1343 and ad-hoc kludge. This kludge is now removed, and on encountering
1344 such an image (OB field brain damaged) we set errno. Then in
1345 ::FindDocLength() we "fix" the length as being ALL what remains
1346 in the file (until EOF). We then proceed, hoping for the best...
1347 This fixes a SegFault in ShowDicom when trying to write such an
1349 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1350 (because TestWriteRead breaks on it, after a non conformal commit?).
1351 ctest now runs properly, except for MakeDicomDir (which was always
1352 broken) and the Python related stuff (still not fixed).
1354 2004-06-24 Jean-Pierre Roux
1355 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1356 FIX : Test/TestReadWrite now iterates on all the file names
1357 (instead of infinite loop)
1358 ENH : Test/TestWriteRead now iterates on all the file names
1360 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1361 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1363 2004-06-24 Jean-Pierre Roux
1364 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1365 when SamplesPerPixel =3
1366 - now Write is no longer confused by
1367 'BitsAllocated = 12" and 'BitsStored=12"
1368 - "UN" value representation Elements are now written correctly
1369 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1370 ENH : - now gdcmHeader has its own Write methods
1371 (in order to split the job that has not to be done
1374 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1375 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1376 loop on the same image until memory went out.
1377 Note: this means we still have gobs of memory loss in PrintDocument
1378 * src/gdcmDocument.cxx: fixes problem on parsing on file
1379 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1381 2004-06-24 Jean-Pierre Roux
1382 FIX : Write - All the Sequences and Sequence Item are now written
1383 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1384 is added a the end, when necessary.
1385 - A lot of brain-damaged images, that were read correctly are
1386 now written correctly
1387 - length compatible BinEntry are now loaded correctly
1388 (even for odd groups)
1389 Note : only Explicit Value Representation was checked.
1390 (question : is implicit VR really necessary for gdcm ?)
1392 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1393 * DEVELOPPER: added a proposition of coding style.
1394 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1397 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1398 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1399 Use the gdcmDocEntry::Print() and Write() instead.
1400 * src/gdcmDocument.cxx: bug fix.
1402 2004-06-22 Jean-Pierre Roux
1403 FIX : gdcmDocument.cxx
1404 - Now we do recognize the JpegLossLess format (there was a misstyping in
1405 code 'beautyfication' :-(
1406 - Now we automaticaticaly load the Luts, if any
1408 2004-06-22 Jean-Pierre Roux
1409 In order : to write Sequences, whatever their imbrication level,
1410 : to allow user to create his own Sequences
1411 a lot of modif where necessary (adding, moving, or virtualising methods)
1413 WARNING : save your own sources *before* cvs up !
1416 ADD virtual void Write(FILE *fp, FileType filetype);
1419 ADD virtual void Write(FILE *fp, FileType filetype);
1420 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1423 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1424 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1425 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1426 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1427 ADD std::string GetEntryByName(TagName name);
1428 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1430 std::string vr = "unkn",
1431 std::string fourth = "unkn",
1432 std::string name = "unkn");
1433 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1434 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1435 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1436 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1437 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1438 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1439 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1440 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1443 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1444 ADD virtual std::string GetEntryByName (TagName tagName);
1445 ADD virtual std::string GetEntryVRByName (TagName tagName);
1446 REM virtual bool Write(FILE *, FileType);
1447 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1448 FILE *_fp, FileType type);
1449 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1450 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1451 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1452 REM virtual std::string GetEntryByName (std::string tagName);
1453 REM virtual std::string GetEntryVRByName (std::string tagName);
1454 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1455 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1456 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1458 std::string vr = "unkn",
1459 std::string fourth = "unkn",
1460 std::string name = "unkn");
1461 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1462 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1463 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1464 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1467 ADD virtual void Write(FILE *fp, FileType filetype);
1470 ADD virtual void Write(FILE *fp,FileType filetype);
1473 ADD virtual void Write(FILE *fp, FileType filetype);
1474 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1475 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1476 REM std::string GetEntryByName(TagName name);
1479 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1481 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1482 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1483 The default constructor invoked by the line
1484 gdcmHeader *f1 = new gdcmHeader( header );
1485 was gdcmHeader::gdcmHeader(bool) instead of the expected
1486 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1487 Hence the parsing wasn't executed... See also below.
1488 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1489 as explicit constructor didn't do the trick to fix the above problem.
1490 Could anyone explain why ?
1491 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1492 properly calls gdcmValEntry::Print() (that was weed out from
1493 code related to gdcmBinEntry).
1495 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1496 * In order to fix memory leaks:
1497 - Test/TestWriteSimple.cxx: added cleaning of free store through
1499 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1500 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1501 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1502 (through the call to ::AddDicomDirMeta()) or the destructor
1503 would crash when deleting uninitialized ::metaElems].
1504 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1505 - src/gdcmDocument.cxx:
1506 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1507 from dynamic stores.
1508 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1509 was causing memory leaks.
1510 - src/gdcmSQItem.cxx:
1511 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1512 cleanly handled with polymophism: sorry but my milage is low).
1513 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1514 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1515 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1516 This avoids SegFaulting.
1517 - src/gdcmSQItem.h: coding style.
1519 - Test/TestWriteSimple still severely sucks. The output image content
1520 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1521 damaged when displayed with vtkgdcmViewer.
1522 - on memory leaks: TestWriteSimple leaks really less (see entry
1523 of 2004-06-18 in Changelog file for the call to valgrind).
1524 - on segfaults: ctest now passes all the tests but one (no more
1526 * Erroneous leading white fix:
1527 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1528 white[s] (as opposed to from >> xxx, that removes it [them].
1529 - src/gdcmTS.cxx: ditto.
1530 - gdcmPython/testSuite.py: dirty related kludge removed.
1531 * src/*: remaining references to gdcmParser removed.
1532 * src/*[cxx|h]: added copy[way]left header.
1535 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1536 * In order to fix writing of dicom files:
1537 - Test/TestWriteSimple.cxx: a simpler example of writing.
1538 - Test/CMakeLists.txt changed accordingly.
1539 - src/gdcmDocument.cxx:
1540 -- The destructor now recursilvely removes potential sequences.
1541 -- Bug fix in ::IsJPEG2000()
1542 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1543 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1545 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1546 to only declared) and build on top of
1547 ::GetDocEntryByNumber(guint16, guint16).
1548 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1549 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1550 for usage in destructor and treatement of promotion in
1551 ::ReplaceOrCreateByNumber().
1552 - src/gdcmSQItem.cxx: destructor should better handle his job.
1553 Test/TestWriteSimple now runs (or at least it DOES something).
1554 * We can now start hutting memory links. A good starting point is:
1555 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1556 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1557 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1559 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1560 * Valgrind note: after Mathieu Malaterre teached me how to read
1561 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1563 Using gcc, you can force the STL to use malloc and to free memory as
1564 soon as possible by globally disabling memory caching.
1565 With 3.2.2 and later, you should export the environment variable
1566 GLIBCPP_FORCE_NEW before running your program.
1567 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1568 simply vanish (it is still not clear to me, whether this means that
1569 STL std::string leaks or if valgrind believes it leaks...).
1570 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1571 running bin/gdcmTests makeDicomDir):
1572 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1573 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1575 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1576 SegFaulting (I drowned in DicomDir related code when trying to
1577 understand why the list is empty...).
1578 * src/gdcmDocument.h: first BSD license header try.
1579 * Doc/License.txt added.
1581 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1582 * src/gdcmDocument.[h|cxx]:
1583 - Clean up of the Transfer related predicates. They are now all based
1584 on new method isGivenTransferSyntax, that (should) handle properly
1585 the padding problem.
1586 - general clean up, simplification, and coding style.
1587 - Specific clean up of Parse7FE0() (umproperly named actually).
1588 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1590 2004-06-14 Jean-Pierre Roux
1592 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1593 - fix the display of SQItem ordinal number
1594 - add the GetSQItemByOrdinalNumber method
1595 - remove some useless never written private methods
1597 2004-06-14 Jean-Pierre Roux
1599 - adding a constructor taking a gdcmDocEntry as an input param
1600 - ReplaceOrCreateByNumber now returns :
1601 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1602 a gdcmValEntry * if a string value is passed as a param
1604 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1605 according to the param type (no longer sets a gdcmDocEntry)
1606 - GetValEntryByNumber, GetBinEntryByNumber added
1607 - NewValEntryByNumber and NewBinEntryByNumber added
1609 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1611 - GetSQItemNumber and SetSQItemNumber added, to provide
1612 a (relative) Item identier inside a given Sequence
1613 \warning : some pb remaining around this number
1615 - AddEntry now takes the Item Number as a param
1617 - adding a constructor taking a gdcmDocEntry as an input param
1619 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1620 * Memory leak hunt with the following command:
1621 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1622 --show-reachable=yes gdcmTests PrintDocument
1623 It looks like many (all?) leaks are due to the STL (or a bad usage
1624 of the STL. The lines producing the leaks now have a comment with
1625 a "MEMORY LEAK" tag: you can retrieve them with
1626 grep "MEMORY LEAK" src/*
1627 Here are two typical examples which I can't help fixing:
1632 char * test = "babo";
1633 name = test; //// <--- valgrind detects 960 bytes lost in
1634 //// call to std::string::operator=(char const*)
1635 name.clear(); //// Doesn't help !
1643 std::cout << "Type a bunch of characters followed by RETURN: ";
1644 getline(std::cin, line); //// <--- valgrind dectects a loss
1645 //// of 1320 bytes in call to
1646 /// std::basic_istream<>& std::getline<>
1652 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1653 * src/gdcmHeader.[cxx|h]:
1654 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1655 and related, moved away to gdcmDocument.
1656 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1657 the corresponding protected accessors of inherited class
1658 gdcmDocument, removed ! As a consequence gdcmFile had to be
1659 declared friend of class gdcmDocument (see below).
1660 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1661 - Clean up of undefined or unused methods.
1662 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1663 account the changes to gdcmHeader.h).
1664 * src/gdcmDocument.h:
1665 - gdcmFile is now a friend class (in order to take into account the
1666 changes to gdcmHeader.h).
1667 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1668 (see changes to gdcmHeader.h).
1669 - Accessors (reading on the form GetEntry*) are now public.
1670 - Clean up of undefined or unused methods.
1671 * src/gdcmDocument.cxx:
1672 - adaptation to changes to gdcmDocument.h
1673 - ::OpenFile now writes a verbose message when file cannot be opened.
1674 - some std::string properly set to VRKey
1675 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1676 references to gdcmDocument.
1677 * Test/TestFindTags.cxx: changed accordingly to above changes.
1678 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1679 cvs repository gdcmData.
1681 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1682 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1683 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1684 conflicts with gdcmValEntry::voidArea.
1685 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1686 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1687 Value representation between StringRepresentable and BinaryRepresentable.
1688 * src/gdcmDocument.cxx:
1689 - method ParseDES: proper indentation restored and usage of
1690 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1691 - method LoadDocEntry: the fingerprint left in the SetValue() of
1692 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1693 removed. Reverting to previous code segment with the proper
1694 dynamic_cast< gdcmValEntry* >.
1695 Note: this was (partially) breaking the python test suite
1696 (gdcmPython/testSuite.py) that made usage of the above
1697 fingerprint to check presence of "Pixel Data".
1698 * src/gdcmDocEntry.h: coding style.
1699 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1700 now taken into account.
1701 * gdcmPython/gdcm.i: adaptation to the new internal representation
1702 of gdcm (exit gdcmParser, hello gdcmDocument).
1703 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1705 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1706 anymore, but instead prints the loaded Python dictionary.
1707 * .... alas, the python testSuite is still broken.
1709 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1710 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1712 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1713 * src/gdcmUtil.h : export methods
1715 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1716 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1718 * Initial addition of automatic python testing
1719 * Initial addition of automatic image comparison
1721 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1722 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1723 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1725 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1726 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1727 * Test/ShowDicom.cxx : bug fix for msvc compilation
1728 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1730 2004-05-04 Jean-Pierre Roux
1731 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1732 new concepts (and new classes) :
1733 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1734 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1735 - Sequence Doc Entries (gdcmSeqEntries)
1736 a Sequence is composed of Items.
1737 Each item is a set of Doc Entries (this is recursive)
1738 The non uniqueness of the 'Dicom tag' is due to this recursivity
1739 (never taken into account)
1740 Our unability to add a new 'entry' in the header
1741 at the proper location (neither in the H-Table (map or multimap),
1742 nor in the Chained List is also due to this recursivity.
1743 Don't try, right now, to use/modify/compile these new sources :
1744 nothing is finished.
1745 We just commit all the stuff, 'as is', in order not to loose it.
1747 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1748 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1750 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1751 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1752 file prefix (SetFilePrefix)
1754 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1755 * Add a new test: ShowDicom, for now this is just the c++ version of
1756 checkRead.sh, later it will be able to compare the image read against a
1758 * Replace the DEBUG on the stack with a global entry in cmake interface:
1759 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1761 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1762 * Add an example subdir, with a real example on how to read + write a
1765 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1766 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1767 * Doc/CMakeLists.txt: the main page is now properly differentiated
1768 between the developper and user version.
1769 * Doc/doxygen.config.in: dropped search related obsolete flags
1770 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1772 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1773 * DEVELOPPER: added some helpfull comments for compile/test/install
1776 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1777 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1778 src directory, now generated in the build dir.
1779 2. Tests as mentionned smarter
1781 4. Add a new method in gdcmDict that return the PubDict by name
1782 this is interesting for 3rd party lib like ITK,
1783 where we could set the institution name / patient name...
1785 * ENH: 1. Now the test suite is working for real
1786 2. All binaries are now output in the gdcm-bin directory
1787 (this was not true before)
1789 2004-04-28 Jean-Pierre Roux
1790 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1791 SeQuence indented printing of Dicom Header.
1792 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1793 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1794 Computation of SQDepthLevel is now part of gdcmHeader constructor
1795 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1796 tree-like structure of a Dicom Header.
1797 * FIX Test code cleaning
1799 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1800 * ENH: Adding automatic testing
1801 1. Need a DartConfig.cmake to submit to public
1802 2. Add a test driver gdcmTest.cxx
1803 3. gdcmTestMain, an helper for the main test driver gdcmTest
1804 4. Files in Test don't have a main anymore, this becomes interesting
1805 when we add more and more tests, thus dsw don't have to load
1807 * ENH: Adding a GDCM_DATA_ROOT for testing
1808 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1809 one file instead of seven + some small cleanup
1811 2004-04-22 Jean-Pierre Roux
1812 * ENH Minor changes to the Print() methods.
1813 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1814 Header printing. Example given with :
1815 > PrintHeader fileName 2 new
1816 (SQ based tree-like structure still to be done for the Header ...)
1818 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1819 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1820 1. I have added some unsigned where needed
1821 2. Some function parameter not used -> (void)
1822 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1823 4. g++ don't like character '\' in comment
1824 5. #define jpeg_create_decompress jCreaDecompress
1825 this really need to be fixed
1826 6. virtualize destructor of gdcmObject ... leakage
1827 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1828 this also really need to be fixed
1829 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1830 remove compression file
1831 (as we only do decompression, right ?)
1832 * ENH: Change malloc/calloc/free with c++ equivalent
1834 2004-04-21 Jean-Pierre Roux
1835 * FIX gdcmHeaderHelper::GetXSpacing
1836 when a single value is found (bug ?), xpacing is now
1837 defaulted to yspacing
1839 2004-04-19 Jean-Pierre Roux
1840 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1841 * ENH add parameters :
1842 bool exception_on_error = false,
1843 bool enable_sequences = false,
1844 bool ignore_shadow = false
1845 to the gdcmFile constructors to be full gdcmParser compliant
1846 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1847 to allow reading of PAPYRUS 3.0 files
1849 2004-04-06 Jean-Pierre Roux
1850 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1852 2004-04-02 Jean-Pierre Roux
1853 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1854 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1855 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1857 2004-03-30 Jean-Pierre Roux
1858 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1859 for ACR file, written out as DICOM files (hope so...)
1861 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1862 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1863 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1864 moved to base class gdcmParser and only the specialisation is kept
1866 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1867 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1868 already does the job.
1869 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1870 (to be consistent with gdcmParser::WriteEntries).
1872 2004-03-30 Benoit Regrain
1873 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1874 upate of the object's instance. It's passed to 2 in the unfavorable
1875 case : one in the ExecuteInformation, one in the ExecuteData
1877 2004-03-29 Jean-Pierre Roux
1878 * ENH : Check on file type to be written moved
1879 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1880 * FIX : gdcmObject::ResetBoundaries now stops properly
1881 when end-of-list is reached
1882 : gdcmVersion modified (as Benoit Regrain asked)
1884 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1885 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1886 * src/gdcmUtil.cxx: added forgotten iostream include.
1887 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1888 equivalent to ExplicitVR in existing code).
1890 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1891 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1892 now contains all the gdcmGlobal related code.
1893 * minor coding style and doxygenation changes.
1895 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1896 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1897 now contains all the Debug related code.
1898 * minor clean-up of includes in src/*.cxx
1899 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1900 CreateCleanString) removed.
1901 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1902 * Doc/DoxyMainPageUser.txt added.
1903 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1904 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1905 src/gdcmDirList.cxx)
1907 2004-03-24 Jean-Pierre Roux
1908 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1910 2004-03-23 Jean-Pierre Roux
1911 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1912 big endian made volumes
1913 * ENH Now gdcmParser constructor and destructor are protected to forbid
1914 end user to instanciate class gdcmParser
1915 (only gdcmHeader and gdcmDicomDir are meaningfull)
1917 2004-03-22 Benoit Regrain
1918 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1919 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1920 gdcmSerie to gdcmDicomDirSerie
1922 2004-03-19 Jean-Pierre Roux
1923 * ENH Now the tree-like structure describing a DICOMDIR comming from
1924 an already existing DICOMDIR file is consistent with
1925 the home-made tree-like structure build ex-nihilo
1926 or build from the files held (recursively) in a Directory
1927 functions gdcmDicomDir::CheckBoundaries()
1928 gdcmObject::SetBoundaries() added
1930 2004-03-17 Jean-Pierre Roux
1931 * REM (Eric Boix bug) : removal of meaningless
1932 gdcmDicomDirImage::NewImage function.
1933 * FIX now file names and directory name are written properly in the
1935 * FIX now gdcmDicomDir constructor may be call without any trick
1938 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1939 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1940 of gdcmDicomDirImage::NewImage as empty function.
1942 2004-02-28 Jean-Pierre Roux
1943 * ENH add gdcmDicomDir:NewPatient
1944 add gdcmDicomDirPatient:NewStudy
1945 add gdcmDicomDirStudy:NewSerie
1946 add gdcmDicomDirSerie:NewImage
1947 to allow making gdcDicomDir object.
1948 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1949 (as opposite to the gdcmHeader chained list)
1951 2004-02-11 Benoit Regrain
1952 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1953 when using from python
1955 2004-02-10 Benoit Regrain
1956 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1957 * FIX : in gdcmDicomDir when the directory is empty
1958 * ENH : add callback and methods to get the progression of dicomDir
1961 2004-02-06 Jean-Pierre Roux
1962 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1963 - GDCM_META added to gdcmDicomDirType
1964 - class gdcmMeta created
1965 * ENH : - A brief summary is now displayed at the beginning of
1966 'testDicomDir' to help disaster magnitude estimation
1967 * REM : Now useless Test/explDICOMDIR.cxx
1969 2004-02-05 Benoit Regrain
1970 * ENH : add methods in gdcmObject to get the hash table or the list of
1972 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1973 * FIX : wrapping python for TagHeaderEntryHT
1975 2004-02-04 Benoit Regrain
1976 * FIX : even length for some strings when writting the dicom dir
1977 * FIX : sort the images in the dicom dir
1978 * FIX : Bug fix for python use of dicom dir
1979 * ADD : a python demo
1981 2004-02-04 Jean-Pierre Roux
1982 * FIX : Final solution (?) for icone embedded images
1983 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1984 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1985 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1986 gdcmData/gdcm-MR-SIEMENS-16.acr1
1987 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1988 to make full checking easier
1990 2004-02-04 Benoit Regrain
1991 * FIX : WriteEntries : coding style & logic in parameters
1992 * FIX : Set the elements to create the DicomDir in a dictionary file
1994 2004-02-03 Benoit Regrain
1995 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1996 * gdcmDicomDir : add the load of directory
1997 * Bug fix and print add-on
1999 2004-02-03 Jean-Pierre Roux
2000 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2001 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2002 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2003 * FIX gdcmParser.cxx : 'group length' elements are now considered
2004 as integers, even for shadow groups, when file is Implicit VR
2006 2004-02-02 Jean-Pierre Roux
2007 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2009 of the last synonym :-(
2010 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2012 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2013 * FIX taking into account the possible 7fe0,0010 multiplicity
2014 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2015 to allow removal of references to 7fe0,0010, to deal with
2016 ACR-NEMA images, when 0028,0200 is meaningfull
2018 2004-01-31 Jean-Pierre Roux
2019 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2020 no longer writes 'Un' on disk
2021 * FIX SQ elements with actual length are now dealt with corectly
2022 * FIX gdcmFile::WriteBase make the difference, for color images, between
2023 the length (for Palette expanded images)
2024 and Raw Length (non expanded image + Palette)
2025 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2026 (that broke Write). Replaced by UL.
2027 Aware user will reload the field if he
2028 thinks it's necesssary
2030 2004-01-30 Jean-Pierre Roux
2031 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2032 when 'dirty Acr' is found, to be compliant with the new
2033 IsReadable() methods.
2035 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2036 (no DOUBLE images in kosher DICOM,
2037 but so usefull for people that miss them ;-)
2039 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2040 DICOMDIR related utilities (not checked as Windoze compliant)
2042 2004-01-28 Jean-Pierre Roux
2043 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2045 2004-01-27 Jean-Pierre Roux
2046 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2047 to allow skipping the shadow elements, to save memory space.
2048 The TRUE value for this param has to be used
2049 with a FALSE value for the 'enable_sequence' param.
2050 ('public elements' may be embedded in 'shadow Sequences')
2051 * gdcmHeader methods now deal with 'embedded icones images' in the header
2052 (even when an 'icone image sequence' is announced by the
2053 element (0x0088,0x0200), but there is NO icone at all ...
2055 * gdcmHeader sometimes Image Location value doesn't follow
2056 the supposed processor endianity (see gdcmData/cr172241.dcm).
2059 * gdcmHeader add the method
2060 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2061 to get *all* the Header Entries with the same tag.
2062 GetHeaderEntrySameName is probabely *useless*
2063 (no meaning : Name is *not* an identifier within the Dictionary)
2065 2004-01-26 Benoit Regrain
2066 * Bug fix in the print of hexadecimal representations. Remove long fields
2067 in the print and add a third level of print to print them
2069 2004-01-23 Benoit Regrain
2070 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2071 * Bug fix on test suite after remove the strip made on not string fields
2072 * Split the IsReadable method between gdcmParser which test that the file
2073 is dicom and gdcmHeader which test that it's an image file
2075 2004-01-22 Benoit Regrain
2076 * DicomDir : clean code, add methods, set variables in protected or private
2077 * gdcmUtil : bug fix for the clean string method
2079 2004-01-19 Benoit Regrain
2080 * Add the use of shadow dictionaries
2081 * bug fix and coding style
2083 2004-01-19 Benoit Regrain
2084 * src/gdcmFile.cxx : bug fix concerning the close of file
2085 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2086 * Add the update of header entries using the shadow library
2088 2004-01-19 Benoit Regrain
2089 * removal of file gdcmHeader2.cxx
2090 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2091 inheriting from gdcmParser. This split is to prepare the integration
2092 of dicom dir parsing
2093 * bug fix under python
2095 2004-01-16 Jean-Pierre Roux
2096 * REM removal of class gdcmHeaderEntrySet
2097 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2098 * ADD add file gdcmHeader2.cxx
2099 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2101 2004-01-15 Benoit Regrain
2102 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2103 entries created while parsing the header. Thus, they will be destroyed
2104 when the gdcmDictSet will be destroyed
2105 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2108 2004-01-15 Benoit Regrain
2109 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2110 made a fatal error because of the memory release at the end of program.
2111 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2112 some memory and vtk seems to have some problems with that.
2113 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2115 2004-01-14 Benoit Regrain
2116 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2117 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2118 * src/*.[h|cxx] : make changes due to class name changes
2119 * gdcmPython/demo/*.py : bug fix due to method names
2121 2004-01-13 Benoit Regrain
2122 * src/*.[h|cxx] : coding style
2123 * vtk/*.[h|cxx] : coding style
2125 2004-01-13 Benoit Regrain
2126 * gdcmPython/testSuite.py : test the readable flag of file for tests
2127 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2128 It's lied to the stl compilation by MSVC (windows, always windows...)
2129 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2131 2004-01-12 Benoit Regrain
2132 * src/*.h : add comments
2133 * src/gdcmDictSet.h : set the method BuildDictPath in public
2134 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2135 directly setted in the source code
2136 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2139 2004-01-09 Benoit Regrain
2140 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2141 * setup.py : use a reference to gdcmVERSION
2143 2004-01-07 Benoit Regrain
2144 * Modification to compile with the distutils.
2147 2003-12-10 Benoit Regrain
2148 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2149 can use a gdcmHeaderHelper to load data
2150 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2151 made in the source code
2153 2003-12-10 Benoit Regrain
2154 * Update Windows projects and .cvsignore files
2156 2003-11-12 Jean-Pierre Roux
2157 * ENH gdcmHeader constructor has one more parameter (default value : false)
2158 that allows the user to 'go inside' the SeQuences only
2160 gdcmElValSet:Print takes it into account
2162 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2163 * ENH: Update gdcmPython/CMakeLists
2164 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2165 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2167 2003-11-10 Jean-Pierre Roux
2168 * FIX : gdcmHeader::LoadElements is now based
2169 on the ListTag listElem member,
2170 not longer on the TagElValueHT tagHt member
2171 * ENH : PrintPubElVal shows (temporarily) both results,
2172 with the tagHt member and the listElem member.
2173 (it's easier to 'see' the problems when using Printheader)
2175 * FIX : old private member LgrElem is now splitted into
2176 ReadLength : Length actually found on disk (updated only
2177 if bug fixing is necessary), for internal
2179 UsableLength : Updated by FixFoundLength, to fix a bug
2180 or to allow Parser going on.
2181 Will allow to re-write a kosher header when a SeQuence
2182 with a length (not 0000) is found
2183 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2184 because gdcmElValSet::Add does not update ListElem
2187 2003-11-07 Jean-Pierre Roux
2188 * FIX misstyping in Transfert Syntax name table
2189 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2190 when they have an actual length (not 0000 nor FFFFF)
2191 (Nobody should care of it, but DICOMDIR explorers)
2193 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2194 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2196 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2197 * ENH: vtkGdcmReader now supports LUT !
2198 (vtkgdcmViewer for now is not able to use them though)
2200 2003-11-05 Jean-Pierre Roux
2201 * in testSuite.py : new files names for checking the package
2202 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2203 that returns the pixel area size to the *aware* (vtk) user
2204 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2206 2003-11-05 Benoit Regrain
2207 * in testSuite.py : Modify the rules for checking the paths
2208 : Explicit error messages
2209 * in __init__.py : Related modif
2211 2003-11-03 Jean-Pierre Roux
2212 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2213 to be used by aware (vtk) users that want to manage
2214 LUT (and no to turn the PALETTE image into an RGB pixels one)
2215 * GetPixelType now returns 8U for 24 Bits images
2216 (vtkGdcmReader compliant)
2218 2003-10-31 Jean-Pierre Roux
2219 * Removal of *all* gdcmData images and add them again
2220 in order to loose the 'history' of un-anonymised images
2222 2003-10-31 Jean-Pierre Roux
2223 * RMV : removal of useless jBitsInJsample.h
2224 for both 8 and 12 Bits JPEG Lossy Libraries
2226 2003-10-31 Jean-Pierre Roux
2227 * ENH : Add the functions gdcmFile::GetImageDataRaw
2228 gdcmFile::GetImageDataIntoVectorRaw
2229 that act as GetImageData and GetImageDataIntoVector
2230 except the making of an RGB Plane from Gray Plane + LUT
2231 Intended to aware (vtk) users who know how to manage
2234 GetLUTRGBA return a R,G,B,A LUT if any
2235 lgrTotaleRaw gives the 'Raw' length
2236 GetImageDataRaw returns the gray Plane
2237 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2238 (They stay Grey, just like with other Dicom viewers :-(
2240 2003-10-30 Jean-Pierre Roux
2241 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2243 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2244 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2245 being coherents dicom files.
2247 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2248 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2250 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2251 * ENH: Two steps is necessary to please VC++ compiler...
2252 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2253 * ENH: Add include dir to medcon lib
2254 * FIX: only one function is being exported for now !
2255 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2257 2003-10-29 Jean-Pierre Roux
2258 * adding gdcmHeader::GetLUTRGBA
2259 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2260 --> Mathieu, the modif u're waiting for is not yet committed
2261 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2263 2003-10-27 Jean-Pierre Roux
2264 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2265 00191113.dcm DermaColorLossLess.dcm
2266 MxTwinLossLess.dcm RadBWLossLess.dcm
2267 * ENH: For version prior to vtkImageViewer2 -r 1.19
2268 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2270 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2271 * Removal of ido stuff in CMakeLists.txt
2273 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2274 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2275 * FIX: remove a call to ->Modified ... see comments
2276 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2278 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2279 * FIX: Problem with path for libvtkgdcmPython
2280 * ENH: Try adding a search script for python site-package
2281 * RMV: Remove some file from medcon lib that are not necessary
2282 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2283 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2284 * FIX: More pragma disable fro VC++,
2285 I don't think I break something as it is also disable in VTK/ITK.
2286 But it fasten debug compilation time.
2288 2003-10-23 Jean-Pierre Roux
2289 * gdcm now deals with 16 Bits Run Length Encoded images
2290 (they are compressed as 2 planes images,
2291 one for the high Bytes, the other for low Bytes)
2293 2003-10-22 Jean-Pierre Roux
2294 * Now CheckRead takes into account :
2295 - the bugged 'Leonardo' Siemens images
2296 - the XA images, sent thru the burning VPRO station
2297 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2300 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2301 * FIX: When copying a Makefile.am to CMakeLists.txt
2302 one should remove the '\'
2304 2003-10-22 Jean-Pierre Roux
2305 * in gdcmData adding a bugged 'Leonardo' Siemens image
2306 (wrong lengths in header)
2307 OK with gdcm, KO with the other viewers :-)
2308 * add a GE dlx XA image, thru the VEPRO burning station
2311 2003-10-21 Jean-Pierre Roux
2312 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2313 for a brutal checking of vtkgdcmViewer compliance
2315 2003-10-21 Jean-Pierre Roux
2316 * add the files for 'xmedcon' Jpeg Lossless library
2317 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2319 2003-10-21 Jean-Pierre Roux
2320 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2322 2003-10-21 Jean-Pierre Roux
2323 * garbage Siemens 'Leonardo' images dealt with
2324 (the patch is easy to remove)
2325 * cosmetic changes to avoid warnings
2327 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2328 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2329 no need to press 'r' now.
2331 2003-10-20 Jean-Pierre Roux
2332 * upgrade of checkRead.sh checkWrite.sh according
2333 to new Jpeg Lossless decompressor
2334 * add US.3405.1.dcm, a genuine RGB medical file ...
2335 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2336 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2338 2003-10-15 Jean-Pierre Roux
2339 * general anonymisation in gdcmData
2340 * adding the 'color files' from
2341 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2342 * adding some well knowed bugged-header images
2343 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2344 waiting for their inclusion in Python testsuite
2346 2003-10-15 Jean-Pierre Roux
2347 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2348 no longer seg faults when file is not found
2350 2003-10-14 Jean-Pierre Roux
2351 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2354 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2355 * TODO: *.in file to genereate a UseGDCM later
2357 2003-10-14 Jean-Pierre Roux
2358 * Some supposed-to-be Dicom Images have no preamble.
2359 OpenFile takes it into account
2360 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2361 * Missing elements added in dicomV3.dic
2362 (just to be affraid : have a look at
2363 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2364 and do it again next year ;->
2366 2003-10-13 Jean-Pierre Roux
2367 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2368 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2369 But there are NOT. It's fixed !
2371 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2372 * FIX: "jpeglib.h" was not found on VC++
2373 * FIX: vtkgdcm was not being installed
2375 2003-10-10 Jean-Pierre Roux
2376 * ENH : OpenFile closes the file if it *really* doesn't look like
2377 an ACR-NEMA / DICOM one.
2378 * FIX : testWrite no longer writes an empty file if the source file
2379 is not gdcm Readable
2380 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2383 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2384 * FIX: CMake generate now documentation
2385 * ENH: out of source doc build !
2386 * ENH: Generate both user and dev documentation
2387 * ENH: Should work on windows too
2388 * ENH: Only one doxygen config.in file is needed
2389 * FIX: make install should be ok now on ùnix plateform
2390 * FIX: PATH to dictionary was wrong (missing /)
2391 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2393 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2394 * vtkGdcmReader is now able to read rgb dicom file.
2395 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2396 * added a gdcmViewer to vtk test, use mouse to control
2397 window level & window width
2399 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2400 * CMake-ification of gdcm, we have now two build system
2401 * FIX: on cygwin Wsock32 doesn't exist
2402 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2404 2003-10-06 Emanuel Ollart
2405 * FIX : compilation process wad broken.
2406 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2408 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2409 * change gdcmViewer -> vtkgdcmViewer
2410 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2412 2003-10-06 Jean-Pierre Roux
2413 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2414 ( e.g : well known GE images with a wrong elem length,
2415 : Philips MRI Images with a wrong Huffman table)
2416 * still to be done : allow the reading of bugged LEONARDO Siemens images
2418 2003-10-03 Jean-Pierre Roux
2419 * Odd length strings are padded with '\0' (not with spaces,
2420 to remain compliant with already defined strings,
2421 like Transfert Syntax UID and others)
2423 2003-10-03 Jean-Pierre Roux
2424 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2425 to allow displaying RGB images (not only by affim ;-)
2427 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2428 * vtkGdcmReader is now able to read rgb dicom file.
2429 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2431 2003-10-03 Jean-Pierre Roux
2432 * A few nasty patches to allow the reading of a lot of nasty images
2433 ( e.g : well known GE images with a wrong elem length,
2434 : Philips MRI Images with a wrong Huffman table)
2435 * still to be done : allow the reading of bugged LEONARDO Siemens images
2437 2003-10-03 Jean-Pierre Roux
2438 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2440 2003-10-03 Jean-Pierre Roux
2441 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2442 to allow displaying RGB images (not only by affim ;-)
2444 2003-10-03 Jean-Pierre Roux
2445 * gdcmFile::GetImageDataIntoVector now
2446 - deals with MultiFrames MultiFragments Run Length Encoded files
2447 - deals with YcBcR (YBR_FULL) files
2448 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2449 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2451 (no sample found :-(
2453 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2454 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2455 Two reasons: - clear things
2456 - third parties acces gdcm through header files, so won't
2457 suffer anymore VC++ complains
2459 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2460 * add argv[1] in testvtkGdcmReader.cxx
2463 2003-09-24 Jean-Pierre Roux
2464 * The lines are now eigthy characters long.for
2465 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2467 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2468 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2469 char* to std::string. Thus, the use of strdup becomes useless. (see
2470 previous commis of Malaterre)
2471 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2472 before the last Malaterre's commit.
2474 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2475 * This commit should fix the Debug building under VC++, the problem
2476 was mainly a mixture of debug and release lib being loaded at startup.
2477 * I also remove a depency to a specific C function: strdup. Because I had
2478 to force the link to msvcrtd (whereas strdup is in libc).
2480 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2481 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2482 located in the gdcmCommon.h file. All use of reference of tha has been
2483 changed to now use the variable GDCM_UNFOUND.
2485 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2487 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2488 Dicom dictionary. The test suite can now be run again. Note:
2489 I'm note very happy with the " (RET)" changes. I believe this
2490 RETAINED comment should be dropped when parsing the dictionary.
2491 - PACKAGER corrected
2493 - AUTHORS updated and now in alphabetical order
2494 * Makefile.am now exports gdcm.dsw for Windoze users.
2496 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2497 * cygwin complains about missing std:: in subdir Test/
2499 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2500 * remove some methods that are now in gdcmHeaderHelper
2502 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2503 * vtkGdcmReader set spacing and origin correctly
2505 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2506 * Fix a few delete/delete[] mismatch
2508 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2509 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2510 interpretation to data given by gdcmHeader. For instance there are
2511 heuristics to get informations (look at different places).
2512 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2513 sorting DICOM images based on different strategies.
2514 * modified Makefiles accordingly.
2516 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2517 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2518 when building in debug mode
2519 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2520 src/win32/gdcmdll.dsp
2521 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2523 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2524 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2527 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2528 * src/win32/libgdcmjpeg12.dsp was not dos format
2529 * src/win32/libgdcmjpeg12.dsp :
2530 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2531 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2533 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2534 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2536 * src/gdcmFile.cxx : bug fix in affectation type
2537 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2538 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2539 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2540 symbols... future problem ?
2542 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2543 * src/win32/libgdcmijpeg12.dsp was missing
2544 * modified gdcm.dsw accordingly
2546 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2547 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2549 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2550 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2551 commit of JPR (before his hollidays to facilitate our work).
2552 * setup.py : bug fix in code. Modifications made while the last commit
2553 of JPR. The code hasn't been tested before the commit... it's so
2554 useless to make that (for best programmer that is JPR) !!!
2556 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2557 * tagged the current version as Version0_3 (i.e. version 0.3)
2559 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2560 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2561 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2562 * *.dsp : modifications to use new libgdcmijpeg8 library
2563 * setup.py : bug fix on VTKPATH variable
2564 * PACKAGER : adding all concerning windows
2566 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2567 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2569 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2570 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2571 test suite reported error.
2572 * PACKAGER file added (describes what a packager must do when
2573 packaging a new release).
2574 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2575 * configure.in: upgraded version number to 0.3.0
2576 * fixing build of rpm (through rpm -ta):
2577 - Doc/Makefile.am exports proper doxygen files
2578 - src/jpeg/libijg8/Makefile.am exports the include files.
2580 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2581 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2582 * src/gdcmHeader.h : formatting code
2584 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2585 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2586 We were obtaining error message from vtk. Now, creation of file list
2587 is made in an internal list to prevent this problem.
2588 Bug fix when output is empty.
2589 Bug fix in update of progress value. Previous commit for this was a bad
2591 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2593 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2594 * src/gdcmHeader.h : added method to get the file name
2595 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2596 files. Added method to remove all files on the input
2597 Added FIXME comment concerning the bad parsing of header made by
2598 ExecuteInformation method (in ExecuteData method)
2600 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2601 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2602 when using make instal.
2603 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2604 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2606 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2607 * setup.py : adding include dir of jpeg lib to compile all sources
2608 * */Win32/*.dsp : JPR fix for windows compilation
2610 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2611 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2613 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2614 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2616 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2617 * setup.py is again effective on un*x (takes into account the
2618 addon of the jpeg library)
2619 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2620 * Doc/Doxy* updated (includes above enhancements)
2621 * INSTALL now points to web documentation
2623 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2624 * src/gdcmHeader.h doesn't make unnecessary reference to
2626 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2628 * src/gdcm*.[cxx|h] :
2629 - to allow compilation with gcc 3.x
2630 -- clean up of STL usage (added explicit usage of std::)
2631 -- small fixes on exceptions.
2632 Note: linking not tested !
2633 - clean of doxygen comments to avoid warnings at documentation
2635 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2636 dependent convertion).
2638 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2639 * Clean up of previous JPR garbage commit (not even commented in the
2641 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2642 - moved all jpeg related files from src to src/jpeg/libijg8, with
2643 addition/modification of Makefile.am and configure.in.
2644 - the testSuite is still brain damage (not guilty).
2646 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2647 * WrapVTK.py : modifications to get correctly vtk source files to
2649 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2650 (FileName -> Filename)
2652 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2653 * vtk/vtkGdcmReader.[cxx/h]:
2654 - UpdateProgress method should now be effective
2655 - removed the limitation on having only images loaded (as opposed
2657 - when building a stack of images/volume, a lesser number of
2658 gdcmHeader and gdcmFile instances should be used (hopefully
2659 accelerating things).
2660 - when building a stack of images/volumes, files which are not
2661 loadable (wrong path-filename, wrong permissions on existing file,
2662 or file not parsable by gdcm) are replaced with a black image
2663 in the stack (for the caller to notice the problem).
2665 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2666 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2668 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2669 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2670 between standard library (std) and vtk library (problems are found
2671 under Windows... thanks Windows !)
2673 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2674 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2676 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2678 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2679 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2681 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2682 * When compiling with distutils (see setup.py) the C++ compiler is
2683 called with different flags than the default ones (with automake).
2684 In order to fix all those warning, I compiled gdcm with the command
2685 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2686 and went for warning fixes:
2687 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2688 up from unused variables.
2689 - vtk/vtkGdcmReader.cxx: potential bug fix.
2690 * src/gdcmHeader.h: Doxygen warning cleanup
2692 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2693 * gdcmPython/gdcm.i:
2694 - typemaps correction to take into account the systematic replacement
2695 of "using namespace std" with std:: prefix e.g. std::list,
2696 std::string... (cf changes of 2003-05-21).
2697 - gdcmGlob global variable of type gdcmGlobal (defined in
2698 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2699 exported to Python a as cvar.
2700 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2701 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2702 gdcmDictSet.GetPubDictTagNames() and
2703 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2704 C++ static methods).
2705 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2706 with the above changes.
2708 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2709 * setup.py, manifest.in : bug fix under linux
2711 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2712 * Modification of setup.py to compile vtk part too. Then, we have 2
2713 wrappers which must work with same distutils. For that, we have a
2714 generic distutils in distusiltsWrapping.py ; with :
2715 - build_extWrap class to wrap generically all extensions,
2716 - ExtensionWrap base class for all wrapping extension that contains
2718 - Wrapper interface which wrap sources
2719 + In WrapSwig.py we have extension and wrapper for Swig
2720 + In WrapVTK.py we have extension and wrapper for VTK
2721 * MANIFEST.in : modifications to consider vtk directory and new python
2722 files for compilation
2724 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2725 * Added python wrappers of vtkGdcmReader vtk class (see the
2726 source in vtk/vtkGdcmReader.cxx) :
2727 - vtk/Makefile.am now builds a library
2728 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2729 python library (as opposed to _gdcm.so wich are the python
2730 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2731 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2733 - configure.in has an additional flag --enable-vtk that needs
2734 to be set to enable compilation of vtk related code, that is:
2735 + vtk/vtkGdcmReader.so and
2736 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2737 + gdcmPython/vtkgdcmPython.so (see above)
2738 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2739 be read when compressed or when HighBit + 1 != BitsStored),
2740 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2741 the usage of the python wrapper of vtkGdcmReader vtk class.
2742 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2743 * src/*.[h] all occurences of stl classes are now prefixed with
2744 std::, and all occurences of "using namespace std;" where removed.
2745 This is to avoid pollution of global namespace in included files.
2746 Apparently vtk does not avoid this pitfall: when using both
2747 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2748 collision of various stl members (principally cout...).
2749 * gdcmPython/testSuite.py now cleanly removes temprory generated
2751 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2752 comply with above changes)
2754 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2755 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2756 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2757 vtk data structure (an image Flip was required).
2758 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2759 * cosmetic changes in documentation.
2761 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2762 * src/gdcmHeader.cxx: the constructor no longer exits when an
2763 unexisting file is given as argument.
2764 * The subdirectory Data (containing all the images used for the
2765 test suite) is not part of this repository anymore. A new module
2766 containing those images is now available at
2767 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2768 with the name gdcmData.
2769 All the python scripts (including the package initialisation file
2770 gdcmPython/__init__.py) were adapated to take this change into
2771 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2773 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2774 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2775 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2776 demo of the usage of this class.
2777 Compilation of this vtk part is only done when using the --enable-vtk
2778 at configure (or autogen.sh) stage.
2780 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2781 * More memory link related corrections and documentation fixes.
2783 - maximum info is obtained with a command of the form:
2784 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2785 --show-reachable=yes PrintHeader
2786 - the remaining reachable blocks seem to come from the STL
2787 allocation scheme through the usage of map and list. It looks
2788 like this memory cannot be freed but it is not a memory leak
2789 (in fact further invocation to the STL would recollect the
2790 unused memory allthough it cannot explicitely be freed).
2791 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2792 of displaying an image parsed with gdcm and displayed with VTK.
2793 Note: some images don't seem to work e.g.
2794 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2795 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2796 Allthough this weakens the semantics, it is a ditch attempt to
2797 make gdcm more thread friendly.
2799 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2800 * Memory link hunt (by using valgrind through the command
2801 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2802 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2803 gdcmHeader::_dicom_vr.
2804 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2805 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2807 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2809 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2810 * src/Makefile.am now exports all the necessary include files at
2814 * UpdateGroupLength replaced by new one
2817 * UpdateGroupLength re-written using H-Table
2818 (named UpdateGroupLengthNew untill checks are over)
2820 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2821 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2822 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2824 - gdcmHeader::GetPubElValSet removed.
2825 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2826 UpdateGroupLength, WriteElements, Write.
2827 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2828 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2829 carried the same semantics.
2830 - src/gdcmHeaderIdo.cxx changed accordingly.
2831 - gdcmFile::WriteBase now regroups all the codes from previous
2832 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2833 - enum FileType moved to gdcmCommon.h
2834 * src/gdcmHeader.cxx AddDefault trashed
2835 * gdcmGetXSize added
2836 * getimageDataSize now calls gdcmGetXSize
2837 * Test/*.cxx changed to agree with above changes
2839 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2840 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2841 (to avoid double call by end user).
2842 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2843 by end user, since gdcmHeader::gdcmHeader now handles it.
2845 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2846 * gdcm/Doc many doxygen changes:
2847 - Doxyfile now has two different versions, DoxyfileUsers that generates
2848 the html.users end users oriented documentation and
2849 DoxyfileDeveloppers that generates the html.developper developper
2850 oriented documentation.
2851 - README changed accordingly
2852 - requirement.txt removed (old design info moved to TODO).
2853 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2854 DoxyMainPage.txt, DoxyPython.txt provide more information.
2855 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2856 be updated by simply regenerating the docs with doxygen and copying
2857 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2858 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2859 all the tests in the form "if (<map>.count() >1)" were removed.
2860 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2861 ill-formed documentation sections.
2862 * src/gdcmHeader.cxx: ditto
2864 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2865 * setup.py fixed for un*x (needed macro for stdint.h)
2866 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2867 un*ces with sh-utils test utility.
2868 * gdcmPython/demo/test.py renamed to PrintHeader.py
2869 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2870 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2871 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2872 * src/gdcm*.cxx JPR's bad inclusion fixed.
2874 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2875 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2876 * gdcmPython/demo/test.py changed accordingly.
2878 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2879 * gdcmPython/Makefile.am fixed linking against libstdc++
2880 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2881 * Swig subdir (historical tests of swig version 1.3.17++) removed
2882 * Test/testChangeEntete.cxx some lines commented out in order to make
2884 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2885 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2887 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2888 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2889 hence the user doesn't need this explicit call.
2890 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2891 i.e. LoadElements() call removed.
2892 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2893 - src/Makefile.am declares the proper flag for g++.
2894 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2895 for adding user defined new tags.
2896 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2897 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2898 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2900 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2901 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2902 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2903 src/Makefile.am : the project should properly compile and install
2904 with the autotools, included the python wrappers part.
2905 * gdcm.spec.in : added a spec file for RPM packaging.
2907 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2908 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2910 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2911 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2912 to exported to the environement (see gdcmPython/testSuite.py
2914 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2915 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2916 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2917 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2918 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2920 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2921 * gdcmPython/__init__.py doesn't crash anymore when running in
2922 in InstallMode or PreInstallMode but with an environment given
2923 value of GDCM_DICT_PATH.
2924 * src/gdcmDictSet.[cxx/h] coding style.
2926 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2927 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2928 * src/gdcm.h general comments moved to TODO, and README
2929 * src/gdcm.h should now be seen as a user commodity (including it
2930 should suffice to fully use gdcm). It is nowhere including within
2931 any of the kernel files src/*.cxx and src/*.h.
2933 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2934 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2935 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2937 * src/gdcm*.cxx only include their corresponding include file
2938 (as opposed to gdcm.h)
2939 * gdcmPython/gdcm.i changed accordingly
2940 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2941 the autogen.sh generated "make snapshot" command to work.
2942 * autogen.sh removed history related references to crea package.
2944 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2945 * distutilsSwigCPlusPlus.py work around some swig portability
2948 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2949 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2950 was done in a last ditch attempt to get setup.py _really_
2951 operationnal. The python/gdcmPython layaout add the advantage
2952 of hidding away the python related distutils specific files
2953 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2954 Alas, the src directory was out of scope (i.e. it's relative
2955 position to setup.py was ../src) which made things impossible to
2956 handle (see previous version of python/setup.py). Crossing fingers...
2958 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2959 * python/setup.py now works on Un*x. (harder than I thougth)
2960 * python/distutilsSwigCPlusPlus.py can now have include files
2961 among the list of sources.
2963 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2964 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2965 * modifications in MSVC projects
2967 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2968 * As stated by the first lines of Test/ExceptionAndPython/README, it
2969 looks like we can move back to original usage of exception within
2970 src/gdcm* and hence remove the errno stuff that was introduced
2971 as a quick and dirty fixture of this problem (added to the TODO).
2972 * Doc/Doxyfile configuration file for Doxygen and corresponding
2973 README file for usage added.
2974 * Test/testWrite.cxx added. This new test comes from a split of
2975 test.cxx that is now reverted to its original purpous i.e.
2976 testing the proper parsing of a Dicom related file.
2977 testWrite.cxx concentrates on testing the IO part of gdcm.
2978 * Test/bug1.cxx (containing a bug on WIn32) added.
2979 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2980 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2981 whose purpose is to publish the content of the TagNames of the
2982 Dicom public dictionary were not accessible without an
2983 instance of class gdcmHeader.
2984 - those methods are now static methods of gdcmDictSet and hence
2985 require no instances at all to be invocated.
2986 - within gdcmDictSet this change required to change some method
2987 to class methods (i.e. are now static) among which SetDictPath
2988 (renamed to BuildDictPath) and LoadDefaultPubDict.
2989 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2990 the above changes by calling the new method classes of gdcmDictSet.
2991 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2992 the above to be effective.
2993 * python/gdcmPython: in order to wrap properly the above changes
2994 for Python, swig version now needs to be > 1.3.17.
2995 * python/gdcmPython/Makefile fixed to adapt itself to new
2996 configure/make shema introduced by Johan Montagnat (thanks for the
2997 contribution). Alas this Makefile cannot be turned into a proper
2998 Makefile.am without some heavy changes in the configure.in
2999 (for python dectection).
3000 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3001 now avoids publishing the empty entries.
3003 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3004 * python/setup.py : bug fix concerning install under windows
3005 ExtraPath reused :-P
3006 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3008 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3009 * Dicts/dicomV3.dic : remove double spaces !!!
3010 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3011 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3014 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3015 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3016 method. Doxygenation.
3017 * src/gdcm.h clean up of JPR spurious comments.
3019 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3020 * python/distutilsSwigCPlusPlus.py now properly collects the
3021 shadow classes generated by "swig -c++" (gdcm.py in our case)
3022 when using "python setup.py install".
3023 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3024 reexports the working classes.
3025 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3026 by the classical C errno scheme. This is to prevent an obscure
3027 behavior of the python wrappers when importing wxPython.wx prior
3028 to gdcmPython (which ended up in an abort call). An illustration
3029 of this oddity can be found in the Test/ExceptionAndPython
3030 subdir (see the README file). This problem probably due to
3031 an combination of g++ and dynamic loading.
3032 * added Test/ExceptionAndPython (see above)
3034 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3035 * Changed the layout of the python part to avoid bloating main
3036 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3037 i.e. the distutils arsenal. All the python related stuff is
3038 again in a python subdir, but the package itself is now in
3040 * setup.py was cleaned up:
3041 - pythonIncludePath removed
3042 - python setup.py bdist target is now functional.
3043 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3044 collision with other packages). gdcmPython/demo/*.py changed
3047 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * python subdir moved to gdcmPython (preparation of distutils packaging).
3049 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3050 distutils installer is operational.
3051 * - gdcmPython/__init__.py now properly loads the swig generated
3052 shadow classes (from gdcm.py).
3053 - gdcmPython/demo/*.py changed to import the package gdcmPython
3054 instead of gdcmPython/demo/load.py.
3055 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3057 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3058 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3059 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3060 entries within the associated public Dicom dictionary resp. the same
3061 information but sorted by the fourth field (PAT, IMG, DIR) of the
3063 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3064 are now in the "???" group.
3065 - python/gdcm.i changed accordingly,
3066 - python/demo/printGroupedPublicDict.py added, that gives an example
3067 of the above new functionalities in Python.
3069 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3070 * src/gdcm.h, gdcmHeader.cxx:
3071 - historic references to glib's g_malloc and g_free (#defined)
3072 were definitively removed.
3073 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3074 * src/gdcmElValSet.cxx:
3075 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3076 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3077 - GetElValue(string) renamed to GetElValueByName.
3078 - Added GetElementByName(string).
3079 * src/gdcmHeader.cxx: added
3080 - GetPubElValRepByNumber(guint16, guint16)
3081 - GetPubElValRepByName(string)
3082 - GetShaElValRepByNumber(guint16, guint16)
3083 - GetShaElValRepByName(string)
3084 - GetShaElValByNumber(guint16, guint16)
3085 - GetShaElValRepByName(string)
3086 - GetElValRepByNumber(guint16, guint16)
3087 - GetElValRepByName(string)
3088 - GetElValByNumber(guint16, guint16)
3089 - GetElValRepByName(string)
3090 * Doc/requirements.txt added.
3092 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3093 * Test/Makefile building now depends on the one of libgdcm.so
3094 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3095 pixel data) aware which enables finding the address (offset) of
3096 the pixel data of JPEG encoded DICOM files. This leaves only a single
3097 file in the testSuite whose pixel data address (offset) is unknown.
3098 * python/testSuite.py changed accordingly.
3100 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3101 * VC++ has some strong limitations when working with the STL, as stated
3102 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3103 "Also note that some STL containers (map, set, queue, list, deque)
3104 cannot be exported. [...]
3105 Some STL classes contain nested classes. These classes can not
3107 This is caused by a designed limitation that once a template
3108 class is instantiated, it can not be re-instantiated and
3110 Since our usage of map<> is ubiquitous in gdcm, this "designed
3111 limitation" of VC++ is a pitfall.
3112 Hence the Python wrappers of gdcm cannot be incrementally linked
3113 against the c++ dynamic library. The dirty but only workaround is
3114 to forget about incremental link of dynamic libraries and to generate
3115 the Python wrappers library with the inclusions of the underlying C++
3117 The following modifications concern this matter on Win32/VC++:
3118 - wrapping python correct with standalone wrapped dll (don't use separate
3119 dll under windows !!!!)
3120 - python21_d debug mode enabled (ask Frog how to use it :-)
3121 - NO problem with having an STL member of class for example string in C++
3122 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3123 - Python test of dcmlib in Python is ok under windows on a large set
3125 * removed glib references
3126 * typedef's inserted in gdcm.i for correct swig type management
3128 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3129 * python/demo/*.py load.py extracted from test.py. Added explore.py
3130 that only displays required tags and testAll.py that parses all
3131 the files of the testsuite without using unittest.
3132 * python/testSuite.py other additional test on new files added.
3133 * Data/* new test files added accordingly to the testSuite.
3134 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3135 the vr in the file differs from the one of the dictionary.
3137 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3139 values, but limits itself to values which are below a user specified
3140 size (by default 1024 bytes).
3141 * python/gdcm.i : elements not loaded (because their size is above the
3142 user specified treshold) are exported with their TagKey as key of the
3143 python dictionary. This enables the testsuite to make some checks
3144 on the unloaded elements (since we have their offset and size).
3145 * python/testSuite.py
3146 - now tests for the existence and proper value of the pixel data
3147 - two new examples added.
3148 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3150 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3151 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3152 aware. See the strategy comments in gdcmHeader::FindeLength().
3153 * Test/test.cxx now accepts a filename as first argument.
3154 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3155 * python/testSuite.py changed to integrate test on above files.
3157 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3158 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3159 the vr was also RET.
3160 * python/testSuite.py more tests added.
3162 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3163 * python/testSuite.py unittest test suite added (uses Data)
3164 * Data/* dcm and acr files for the test suite.
3165 * glib dependance removed from un*x version. We now use ISO C99
3166 7.18 Integer types (see stdint.h)
3167 - python/Makefile, src/Makefile src/gdcm.h
3168 * src/ when an explicit vr (like dicom files) suddenly poped an
3169 implicit element we use to mark the underlying DictEntry of the
3170 concerned ElValue with "Implicit". This strategy was damageable
3171 too the public or provite dictionaries, since some of their vr
3172 would be changed. Since Header::FindLength heavily relies on the
3173 detection by Header::FindVR of falsely explicit elements, I
3174 added an extra ImplicitVr member to ElValue (boolean).
3175 The rest of the changes we the necessary adaptations.
3177 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3178 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3180 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3182 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3183 * Adaptation for porting to VC++:
3185 o forced to use std namespace (for string to be known)
3186 o all class use __declspec export style on WIN32
3187 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3188 (in stdlib.h on Win32 but in std:: for gcc)
3189 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3190 variable GDCM_DICT_PATH.
3191 * src/gdcmHeader.cxx verbose comments made discrete.
3193 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3194 * python/gdcm.i: added a typemap that converts a C++ hashing table
3195 to native Python dictionary.
3196 * python/demo/test.py:
3197 - now uses the native dictionary for exploration of gdcmHeader.
3198 - takes an optional filename argument (the file to parse).
3199 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3200 PubElVals hashing table.
3201 * Dicts/dicomV3.dic removed error prone trailing spaces.
3203 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3204 * Python wrapping process moved away from src/Makefile to
3205 newly created python/Makefile (as well as gdcm.i)
3206 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3207 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3208 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3209 from the environement variable GDCM_DICT_PATH (when existing).
3210 * src/gdcmDict::GetTag bug fix.
3212 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3213 * Straightforward temporary fixes for swig to build the python wrappers.
3214 src/Makefile now has a python working entry [by working we mean
3215 that we can import de shadow classes without errors].
3217 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3218 * hashtest.cxx removed (since already in Test)
3219 * src/gdcmlib.h renamed to src/gdcm.h
3220 * src/dcm.i renamed to src/gdcm.i
3221 * src/Makefile prepared for python wrapping
3223 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3224 * src/gdcmHeader.cxx :
3225 - Parsing of header is now separated from loading of element values
3226 (see gdcmHeader::LoadElements).
3227 - general clean up of hopefully all file access (creation of
3228 ReadInt16 and ReadInt32)
3230 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3231 * src/gdcmHeader.cxx :
3232 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3234 - SetLgrElem renamed to SetLength
3235 - GetLgrElem renamed to GetLength
3236 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3237 * src/gdcmElValSet.cxx fixed both GetElValue methods
3238 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3239 due to IdoDude was cleaned out.
3241 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3242 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3243 concentrates on finding the value representation (when it exists).
3244 RecupLgr now only finds the element value length, and it avoids
3245 returning the unecessary skL (skipped length).
3246 Also, offsetCourant was simply removed (with taille_fich) since
3247 it was redundant with the File position internals (by using
3248 ftell and fseek). This also made skL (see above in RecupLgr) usage
3250 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3251 on the libido specificities which are handled through class
3253 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3256 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3257 * Truckload of changes. Parsing of header is barely functional
3258 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3260 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3261 * src/gdcmHeader.cxx many addons of low level methods
3263 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3264 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3265 and _IdDcmSWAP_LONG.
3267 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3268 * This corresponds to all the changes decided at the meeting of
3269 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob